AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

tests: make test_delpay_works deterministic

Public commit record

What the developer wrote

Authored by daywalker90

68/100 · Adequate
tests: make test_delpay_works deterministic

The test relied on force-disconnecting l2 from l3 to make the cheap
route fail. Whether that failure happened depended on timing: the
disable channel_update for l2<->l3 could reach l1 before it computed
the route, in which case l1 never tried the cheap route and only one
payment was recorded. This was seen as a CI flake.

Instead, run l2 with the fail_htlcs plugin so it rejects the forward
on purpose. The first attempt always fails and the retry via l4
always succeeds.

Also rename the variable that holds the successful payment from
`failed` to `success`.

Changelog-None

Signed-off-by: daywalker90 <daywalker990@gmx.de>
✓ Descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
The short version

What changed, and why it matters

This commit only changes a test file to make a flaky test more reliable. It does not modify any production code, so it has no security impact on real users.

Recommended action

No security action needed; this is a test-only reliability improvement.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.