Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit adds a regression test for Core Lightning's database downgrade path. It ensures that when a user downgrades from an upcoming v26.09 release to an older version (v26.06), the new 'impressions' data added by the askrene routing s…
Database downgrade path for new askrene schema (impressions table)Regression test only; no production code changeNo input validation, cryptography, network, or authorization changes
This commit only adds and updates a regression test in the project's test suite. It checks that the hsmtool utility correctly handles both empty and non-empty passphrases when working with BIP39 mnemonic-based wallet secrets. There is no c…
Regression test added for passphrase handling in hsmtoolNo production code changes observedTest-only change to tests/test_wallet.py
This commit updates the bundled libwally library to version 1.5.6. The practical effect is that calling the JSON-RPC `signpsbt` command on a PSBT that is already signed now succeeds as a harmless no-op, instead of returning an error on Bit…
Dependency update to incorporate upstream bug fixBehavior change from error to no-op on re-signing signed PSBTsTaproot keypath handling change in upstream cryptographic library
This commit is a simple variable rename inside a Bitcoin/Lightning wallet file. The old name 'b32script' suggested all change addresses were bech32 format, but the project now uses a newer address type (p2tr) by default. The developer rena…
This change makes Core Lightning register long-lasting 'watches' for all wallet deposit addresses when the node starts up, so the new bwatch plugin can spot incoming payments from the first block it scans. It also removes a now-redundant p…
Change is part of an experimental chain-watcher (bwatch) featureAdds startup registration of scriptPubKey watches for all derived wallet keysRemoves a redundant unconfirmed-change watch, relying on the new blanket coverage
This is a database refactoring commit in Core Lightning. It makes the wallet write UTXO (unspent transaction output) state to a new table called our_outputs in addition to the legacy outputs table, while reads still use the old table. The …
Database schema migration with dual-write mirror patternNo security claim in commit title or messageNo CVE, advisory, or researcher attribution in commit metadata
This commit adds new wallet bookkeeping code for Core Lightning. It records Bitcoin deposits found by a new chain-watcher ('bwatch') into database tables and handles blockchain reorganizations by demoting transactions back to unconfirmed r…
New database write paths for wallet UTXOs and transactionsReorg revert logic demotes rather than deletes rows to preserve metadataOwner-string constructors added to avoid silent unwatch failures from format mismatches
This commit only adds two new empty database tables (our_outputs and our_txs) to Core Lightning's wallet. It is a preparatory schema change for a future feature; no code reads from or writes to these tables yet, and no existing behavior is…
Schema-only migration with no runtime codeNew tables are not yet populated or queried by any code pathDesign note: sentinel 0 replaces NULL for blockheight/txindex/reserved_til, which could reduce NULL-handling bugs in future code
This commit adds a database migration that copies existing wallet data into new tables used by an upcoming 'bwatch' wallet component. It is a data backfill, not a code fix for an active vulnerability. The main risk is that if the migration…
Database migration touching wallet UTXO and transaction tablesPotential for data inconsistency if mapping logic is wrongON CONFLICT DO NOTHING prevents overwrite but could hide duplicate-key anomalies
This change is a behind-the-scenes bookkeeping patch for Core Lightning's wallet database. The project is moving to a new table (`our_outputs`) for tracking spendable coins, but older versions of the software still read from the old table …
Race-condition guard for foreign-key-backed confirmation_height and spend_height when bwatch is ahead of chaintopologyTemporary mirroring to keep legacy outputs table consistent with new our_outputs tableON CONFLICT DO NOTHING used for legacy insert to avoid duplicate-key failures
This commit fixes a bug where Core Lightning's in-memory record of the highest address index could fall out of step with the database. When a user generated a new on-chain address, the code updated the database directly but left the cached…
Cache/database inconsistency in address index trackingPotential for stale lower index to overwrite newer persisted indexFreshly generated addresses invisible to wallet rescan/listing until restart
This commit is a straightforward performance optimization. It caches two address-index values in memory instead of reading them from the database twice for every transaction output in every scanned block. The change fixes a slowdown during…
This change fixes a subtle bug in Core Lightning's tracing code. When running with a special developer-only deterministic randomness override (CLN_DEV_ENTROPY_SEED), trace IDs were being drawn from the same predictable random stream used f…
Deterministic RNG stream contamination by observability codeTransaction output divergence between instrumented and non-instrumented buildsDeveloper-only entropy override affecting reproducibility of transaction generation
This commit is a large documentation-only refresh. It regenerates example outputs in the project's JSON API schema files and test data so that all examples use a newer, more realistic test chain setup called 'newchain'. The values shown in…
This change fixes a test-flakiness bug in a developer-only random-number override used during testing. It makes the random stream depend only on the program name, not the full file path, so tests produce the same results on different compu…
No security-relevant signal: change is in a developer override for deterministic testing RNGNo memory safety, authentication, authorization, or cryptographic weakness introducedNo incident or vulnerability disclosure referenced
This commit only adds a new header include (<common/randbytes.h>) to 24 test files. It does not change any production code, cryptographic operations, or runtime behavior. The change is a test-infrastructure refactor to support deterministi…
This commit is a routine renaming and cleanup of internal Lightning protocol message names and fields to match a newer version of the BOLTs specification. It does not fix a security bug, add a security feature, or change any security-criti…
This commit fixes a bug in Core Lightning's wallet code where, if a prepared Bitcoin transaction failed during signing or broadcast, the coins that had been set aside ('reserved') for that transaction were not released back to the wallet. …
Denial-of-service/availability impact: failed transactions could leave wallet UTXOs permanently reserved, preventing their reuse until manual interventionResource exhaustion pattern: reserved inputs are not spendable, so repeated failed sends could reduce usable wallet balanceError-path resource cleanup (CWE-772, CWE-404): missing release of reserved inputs on failure
This commit fixes a bug in Core Lightning's 'withdraw' command where the transaction shown to the user was returned without valid signatures or witness data, even though the actual network broadcast worked correctly. The returned 'tx' fiel…
API response returned unsigned transaction data to the userRegression introduced by libwally 0.8.8 / PSBTv2 updateWitness and scriptSig data stripped due to WALLY_PSBT_EXTRACT_NON_FINAL flag
This commit only adds two new automated tests that demonstrate an existing bug: the 'withdraw' command returns an unsigned raw transaction in its 'tx' field because an internal helper strips away signatures. The tests are marked as expecte…
Regression tests for issue #8701: withdraw returns unsigned raw transactionRoot cause identified in commit message: psbt_txid() uses WALLY_PSBT_EXTRACT_NON_FINAL which strips signatures/witnessesTests assert all segwit inputs have non-empty witness data in withdraw response
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
Lower-priorityRevert "doc: require Homebrew GNU make and gpatch on macOS"by Sangbida Chaudhuri · 0cfa949f · Aug 5, 2026 · 1 fileMessage 65 · AdequateTriage 0Details
Commit message · Sangbida Chaudhuri
Revert "doc: require Homebrew GNU make and gpatch on macOS"
This reverts commit d3ff147454ea693b3b599d74ce6f3750003cbd0c.
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
documentation-only discount
Lower-priorityRevert "tests: drop obsolete x-prefix in compacter-slow.sh"by Sangbida Chaudhuri · 116fd7cd · Aug 5, 2026 · 1 fileMessage 75 · AdequateTriage 0Details
Commit message · Sangbida Chaudhuri
Revert "tests: drop obsolete x-prefix in compacter-slow.sh"
This reverts commit 474c272a4699e9e98de2eef5f27355e8ed7a250b.
75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Lower-prioritydoc: require Homebrew GNU make and gpatch on macOSby Sangbida Chaudhuri · d3ff1474 · Aug 5, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Sangbida Chaudhuri
doc: require Homebrew GNU make and gpatch on macOS
Apple's make/patch are too old for the build and check-source; install gpatch and put both Homebrew gnubin dirs on PATH.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
documentation-only discount
Lower-prioritytests: drop obsolete x-prefix in compacter-slow.shby Sangbida Chaudhuri · 474c272a · Aug 5, 2026 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · Sangbida Chaudhuri
tests: drop obsolete x-prefix in compacter-slow.sh
Shellcheck 0.11 (SC2268) rejects the old x"$1" comparison idiom.
Prevents: "tests/plugins/compacter-slow.sh:5:6: note: Avoid x-prefix in comparisons as it no longer serves a purpose. [SC2268]"
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-priorityxpay: trim constraints: small optimizationby Lagrang3 · ab9fd89a · Aug 4, 2026 · 1 fileMessage 60 · AdequateTriage 0Details
Commit message · Lagrang3
xpay: trim constraints: small optimization
Use a single realloc to remove old entries.
Changelog-None
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-prioritycommon: implement str_to_u64, make json_to_u64 use it.by Rusty Russell · 529ae2b7 · Aug 4, 2026 · 3 filesMessage 73 · AdequateTriage 0Details
Commit message · Rusty Russell
common: implement str_to_u64, make json_to_u64 use it.
The prior implementation could read past the end of the buffer (we actually pad our JSON so this isn't harmful, but still). Fix up json_to_s64 and json_to_double too, but since they're not used as often, just copy the string there.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritycommon: hoist amount+currency parsing into common code.by Rusty Russell · e0f86c17 · Aug 4, 2026 · 3 filesMessage 65 · AdequateTriage 0Details
Commit message · Rusty Russell
common: hoist amount+currency parsing into common code.
Currently used for offers, we will use it for repeatpay too.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityaskrene: safer iterating over changing htableby Lagrang3 · 2a3feb7e · Aug 4, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · Lagrang3
askrene: safer iterating over changing htable
on trim_constraints: to be sure we don't miss elements we add to the hash table after the loop and not during iteration.
Changelog-None
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritylibplugin: json_id: guard against weird prefixesby Lagrang3 · dd652105 · Aug 4, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · Lagrang3
libplugin: json_id: guard against weird prefixes
Following the recent enforcement of ids being printable strings we put guards on "method" and "prefix" as well.
Changelog-None
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI review queuedlightningd: internal cleanups since all non-command JSON IDs are strings.by Rusty Russell · a70ae963 · Aug 4, 2026 · 8 filesMessage 73 · AdequateTriage 12Details
Commit message · Rusty Russell
lightningd: internal cleanups since all non-command JSON IDs are strings.
In particular, "struct jsonrpc_request"'s id is always a string. cmd->id isn't, though.
We can also remove the now-unused json_get_id.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
Lower-prioritycommon: hoist hash_str helper into its own header.by Rusty Russell · 581bbb1f · Aug 4, 2026 · 6 filesMessage 65 · AdequateTriage 0Details
Commit message · Rusty Russell
common: hoist hash_str helper into its own header.
We have three uses already, about to add a fourth.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Security candidatedowngrade: we need to remove "impressions" from askrene datastore when downgrading to v26.06.by Rusty Russell · 4d926285 · Aug 4, 2026 · 1 fileMessage 65 · AdequateTriage 18Details
Commit message · Rusty Russell
downgrade: we need to remove "impressions" from askrene datastore when downgrading to v26.06.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
channeld_fakenet sudbdaemon purposedly crafted for this test needs updating to account for funds moving after every success payment. I've tried to fix that but in doing so I also triggered an xpay bug not related to this PR. Therefore, for the moment we skip this test.
Changelog-None
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-priorityxpay: actually tell askrene when a payment succeeded.by Rusty Russell · a66fabd4 · Aug 4, 2026 · 2 filesMessage 65 · AdequateTriage 0Details
Commit message · Rusty Russell
xpay: actually tell askrene when a payment succeeded.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityaskrene: correctly order constraints.by Rusty Russell · 4b6fe4a1 · Aug 4, 2026 · 2 filesMessage 58 · ThinTriage 0Details
Commit message · Rusty Russell
askrene: correctly order constraints.
Pure "constraints" don't care about order (they simply clamp max and min), but "impressions" are relative, so they do. Change the hashtable to keep them timestamp sorted.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
On deletion of individual channel intel entries we need to free the pointer inside the structure.
Changelog-None
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityaskrene: give clearer error codes.by Rusty Russell · b0a7a6a9 · Aug 4, 2026 · 8 filesMessage 68 · AdequateTriage 0Details
Commit message · Rusty Russell
askrene: give clearer error codes.
Add PAY_INSUFFICIENT_FUNDS and PAY_ROUTE_NOT_FOUND, and give nice detailed errors for those.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Changed: JSON-RPC: `getroutes` can now return PAY_INSUFFICIENT_FUNDS (215) and PAY_DESTINATION_INSUFFICIENT_CAPACITY (220) error codes.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityxpay: tests should expect the new error messagesby Lagrang3 · 0b67601f · Aug 4, 2026 · 2 filesMessage 70 · AdequateTriage 0Details
Commit message · Lagrang3
xpay: tests should expect the new error messages
Changelog-None
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Consider the case in which payment fails due to not enough "known enabled" liquidity. Notice that we cover the "known" and "enabled" cases already. But: known_enabled <= enabled and known_enabled <= known
Changelog-None
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI review queuedoffers: limit invoices to 10 minutes for recurring offers in other currencies.by Rusty Russell · 446312cf · Aug 4, 2026 · 8 filesMessage 65 · AdequateTriage 7Details
Commit message · Rusty Russell
offers: limit invoices to 10 minutes for recurring offers in other currencies.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
parser or protocol pathsecond-pass: security-sensitive path
Lower-priorityoffers: limit expiry to offer limit, or 10 minutes with currency conversion.by Rusty Russell · a6cf4915 · Aug 4, 2026 · 2 filesMessage 73 · AdequateTriage 0Details
Commit message · Rusty Russell
offers: limit expiry to offer limit, or 10 minutes with currency conversion.
This mirrors the previous commit, where we did it for recurring offers.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: Offers: we set a 10 minute expiry when we create invoices for offers in other currencies.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI review queuedfetchinvoice: don't bother with checking recurrence timing.by Rusty Russell · 3e49d908 · Aug 4, 2026 · 2 filesMessage 73 · AdequateTriage 0Details
Commit message · Rusty Russell
fetchinvoice: don't bother with checking recurrence timing.
We don't actually need to enforce this check here: we can make that the users' responsibility. This simplifies our work quite a lot, since createinvoicerequest won't have to do a lookup any more.
This can be done by the repeatpay plugin itself.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
Lower-prioritylightningd: don't do previous invoice checking in createinvoicerequest.by Rusty Russell · 4348d8ac · Aug 4, 2026 · 4 filesMessage 73 · AdequateTriage 0Details
Commit message · Rusty Russell
lightningd: don't do previous invoice checking in createinvoicerequest.
This is an undocumented interface, so we can just change it.
Rename "recurrence_label" to the more general "label", now we don't require it to find previous payments.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context