test: add flag to test_constant_packet_size
What the developer wrote
Authored by Sangbida Chaudhuri
test: add flag to test_constant_packet_size
What changed, and why it matters
This is a one-line change to a test file. It adds a developer-only flag ('dev-uniform-padding') when creating test nodes so that an existing test for constant TCP packet sizes actually exercises the uniform-padding feature. There is no change to production code, no bug fix, and no security-relevant behavior change.
No action required. This is a benign test-only change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies tests/test_connection.py in test_constant_packet_size. It changes node_factory.get_nodes(4) to node_factory.get_nodes(4, opts={‘dev-uniform-padding’: None}). This opts-in to a developer flag that presumably enables uniform packet padding during the test. The change is purely test-harness configuration and does not alter Core Lightning’s runtime code, protocol handling, or cryptography.
Changed components
tests/test_connection.pyInspect captured patch +1 / −1
diff --git a/tests/test_connection.py b/tests/test_connection.py
index dece3e1a..87ee2b66 100644
--- a/tests/test_connection.py
+++ b/tests/test_connection.py
@@ -4818,7 +4818,7 @@ def test_constant_packet_size(node_factory, tcp_capture):
Test that TCP packets between nodes are constant size. This will be skipped unless
you can run `dumpcap` (usually means you have to be in the `wireshark` group).
"""
- l1, l2, l3, l4 = node_factory.get_nodes(4)
+ l1, l2, l3, l4 = node_factory.get_nodes(4, opts={'dev-uniform-padding': None})
# Encrypted setup BOLT 8 has some short packets.
l1.connect(l2)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.