Revert "test: add flag to test_constant_packet_size"
What the developer wrote
Authored by Sangbida Chaudhuri
Revert "test: add flag to test_constant_packet_size"
This reverts commit c39c5055ee4e2e537424febfd73b73d2f8fe6b91.
What changed, and why it matters
This commit simply reverts a previous test-only change. It removes a special developer flag ('dev-uniform-padding') from a network traffic test, returning the test to its original state. There is no change to production code, no user-facing behavior change, and no security fix or vulnerability introduced by this patch.
No security action needed. Treat as ordinary test maintenance. If the reverted test flag was related to an experimental privacy feature, ensure the feature's production code is reviewed separately, but this commit itself is not a security event.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit reverts c39c5055, which had added the ‘dev-uniform-padding’ option to test_constant_packet_size in tests/test_connection.py. The revert removes that option, so the test again calls node_factory.get_nodes(4) without opts. This is a test configuration rollback; it does not modify Core Lightning’s runtime code, protocol handling, or cryptographic padding logic.
Changed components
tests/test_connection.pytest_constant_packet_size test caseInspect captured patch +1 / −1
diff --git a/tests/test_connection.py b/tests/test_connection.py
index 87ee2b66..dece3e1a 100644
--- a/tests/test_connection.py
+++ b/tests/test_connection.py
@@ -4818,7 +4818,7 @@ def test_constant_packet_size(node_factory, tcp_capture):
Test that TCP packets between nodes are constant size. This will be skipped unless
you can run `dumpcap` (usually means you have to be in the `wireshark` group).
"""
- l1, l2, l3, l4 = node_factory.get_nodes(4, opts={'dev-uniform-padding': None})
+ l1, l2, l3, l4 = node_factory.get_nodes(4)
# Encrypted setup BOLT 8 has some short packets.
l1.connect(l2)
Why this scored 12/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.