splice: Fix typo in test and xfail
What the developer wrote
Authored by Dusty Daemon
splice: Fix typo in test and xfail
This test should be enabled and it was failing because of a typo — this fixes both issues.
Changelog-None
What changed, and why it matters
This commit fixes a typo in a test file and removes a marker that was causing the test to be expected to fail. The change only affects internal testing code, not the actual Core Lightning software that users run. There is no security issue here.
No security action required. This is a routine test maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies tests/test_splice.py. It removes an @pytest.mark.xfail(strict=True) decorator from test_easy_splice_out_into_channel and corrects two RPC calls to use listpeerchannels()[‘channels’] instead of listpeerchannels(). This is a test-only fix that aligns the test with the actual RPC response format; it does not alter node behavior or fix a runtime vulnerability.
Changed components
tests/test_splice.pyInspect captured patch +2 / −3
diff --git a/tests/test_splice.py b/tests/test_splice.py
index 02040807..37fda1f2 100644
--- a/tests/test_splice.py
+++ b/tests/test_splice.py
@@ -686,7 +686,6 @@ def test_easy_splice_out_address(node_factory, bitcoind, chainparams):
assert initial_wallet_balance + Millisatoshi(spliceamt * 1000) == end_wallet_balance
-@pytest.mark.xfail(strict=True)
@pytest.mark.openchannel('v1')
@pytest.mark.openchannel('v2')
@unittest.skipIf(TEST_NETWORK != 'regtest', 'elementsd doesnt yet support PSBT features we need')
@@ -709,8 +708,8 @@ def test_easy_splice_out_into_channel(node_factory, bitcoind, chainparams):
bitcoind.generate_block(6, wait_for_mempool=1)
l2.daemon.wait_for_log(r'lightningd, splice_locked clearing inflights')
- p1 = only_one(l1.rpc.listpeerchannels())
- p2 = only_one(l3.rpc.listpeerchannels())
+ p1 = only_one(l1.rpc.listpeerchannels()['channels'])
+ p2 = only_one(l3.rpc.listpeerchannels()['channels'])
assert 'inflight' not in p1
assert 'inflight' not in p2
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.