Bitcoin Core

This Bitcoin Core change lets users migrate old-style wallets to the newer descriptor format without automatically loading the migrated wallet afterward. The main goal is to support pruned nodes, which previously could not migrate because loading the wallet required full block history. The patch also removes the old wallet from the startup list when migration is done without loading. There is no obvious security bug here; it is a feature/robustness improvement.

This small change reorders two operations in the `importdescriptors` wallet command. Previously, the wallet first waited until it was caught up to the latest block, then tried to reserve a rescan. Now it reserves the rescan first, then waits to catch up. The likely goal is to prevent a race where another process starts a rescan in between those two steps, which could cause the import to proceed without the expected rescan or with conflicting rescan state. The practical security impact is limited and situational.

This commit finishes the Bitcoin Core HTTP server's ability to actually close client connections. Before, several error paths had 'TODO: disconnect' comments, meaning misbehaving or finished clients could stay connected longer than intended. The change adds flags and a periodic cleanup routine so the server drops clients after errors, oversized requests, malformed requests, EOF, non-keep-alive responses, and during shutdown. It is best read as a robustness/cleanup improvement rather than a single critical vulnerability fix, though leaving connections hanging can waste resources and, in some designs, be abused.

This commit only adds a new C++ class definition to a header file. It does not change any existing behavior, fix a bug, or alter how the program handles data. There is nothing here that would allow an attacker to exploit the software.

This commit adds a new helper class for formatting HTTP response headers in Bitcoin Core's internal web server. It does not change any existing behavior or fix any known problem; it is purely new infrastructure code with accompanying tests.

This commit is a documentation-only metadata change. It adds a new 'placeholder' flag to the internal description of several old, ignored RPC parameters so the help system can label them as kept only for backward compatibility. No code behavior changes, no bug fixes, and no security issue is present.

This commit adds small plumbing so that Bitcoin Core's RPC command metadata (descriptions, argument details, result formats) can be inspected by other code. It does not change any user-facing RPC behavior by itself; it merely exposes internal data structures that were already present. There is no obvious security bug in the diff.

This commit changes the internal mining interface so that when a miner submits a solved block through the IPC interface, the caller now receives a specific rejection reason (like 'bad-version', 'duplicate', or 'inconclusive') instead of just a true/false answer. It also keeps the old interface method as a deprecated stub that throws an explicit error telling old clients to update, preventing them from misinterpreting new return values. This is a defensive compatibility and observability improvement, not a fix for an active exploit.

This commit is a code cleanup in Bitcoin Core's RPC help documentation. It restructures how the help text for the getblock command is generated, replacing duplicated inline descriptions with shared helper functions. It does not change what data the software returns, how it processes network data, or any security-sensitive logic.

This commit is a code cleanup that extracts a repeated list of RPC help text fields into a reusable helper function. It only affects how the documentation/help output for the listsinceblock command is generated, not how transactions or wallet data are processed. There is no security issue visible in the change.

This commit is a documentation-only change for the Bitcoin Core wallet's 'getaddressinfo' RPC command. It replaces a vague placeholder in the help text with a detailed, explicit list of fields that can appear inside the 'embedded' object. No wallet logic, validation rules, or network behavior is changed.

This commit is a code cleanup for Bitcoin Core's RPC help documentation. It restructures how the help text for getrawtransaction verbosity=2 is generated, making it more consistent with other RPC documentation. It does not change how transactions are fetched, validated, or returned at runtime. There is no indication this fixes a security bug.

This commit simply moves a header file called btcsignals.h from the top-level src/ directory into src/util/ and updates all the source files that include it. The code inside the file is unchanged. It is a routine code reorganization with no security relevance.

This is a minor code cleanup change that makes a single-argument constructor require explicit syntax. It does not fix a security bug or change runtime behavior; it only prevents accidental automatic type conversions during compilation.

This is a test-only change for Bitcoin Core. It makes an existing unit test stricter by checking that one part of a multi-threaded signal callback counter is deterministic, and by testing connection/disconnection races more frequently. It does not change any production code, runtime behavior, or network protocol.

This commit fixes a brittle signal-handling bug in Bitcoin Core's user-interface code. Previously, when the program asked the user a yes/no question (for example, whether to rebuild the database), the answer could be ignored depending on the order in which internal callbacks were connected. The commit changes the signal system so that a 'yes' answer from any relevant handler is respected, rather than being overwritten by a later handler. The commit message explicitly notes that, before the fix, clicking 'OK' could abort the program instead of performing the requested recovery.

This is a minor code-quality change that tells the compiler to warn when a developer ignores the return value of a specific function call. It does not change how the program behaves, fix a bug, or close a security hole. It is a routine refactoring to help catch future programming mistakes during compilation.

This commit only updates a documentation example in external-signer.md to include a Taproot (BIP86 tr()) descriptor alongside existing address-type examples. It is a documentation-only change with no code modifications, no functional changes, and no security implications.

This commit only updates documentation and code comments for Bitcoin Core's external signer interface. It clarifies which command-line flags are passed to which signer commands and fixes usage examples to match the actual implementation. No code behavior changes, no security bug fix, and no vulnerability is present.

This commit only updates documentation and RPC help text. It explains how Bitcoin Core talks to external hardware wallets: the signer's 'model' field becomes the 'name' shown to users, duplicate fingerprints are skipped, and wallet operations require exactly one connected signer. No code behavior changed, so there is no security issue here.

This commit only adds a new unit test to Bitcoin Core's wallet test suite. It verifies that the wallet's rescan-abort mechanism behaves correctly in two scenarios: an abort requested before any rescan starts should not accidentally cancel a later scan, and an abort requested after a reservation but before the scan begins should cancel the scan. There is no change to production code, no bug fix, and no security-relevant behavior introduced.

This Bitcoin Core wallet patch fixes a small but real timing bug: if a user clicked 'abort rescan' at exactly the wrong moment, the abort signal could be ignored and the rescan would keep running. The fix moves the 'clear any old abort signal' step to the moment the rescan reservation is taken, so a fresh abort request is always honored. It is a reliability/usability bug, not a theft-of-funds vulnerability.

This commit removes a broken move-assignment operator from a small helper class that manages automatic disconnection of signal callbacks. The broken operator could leave an old callback registered after a move, causing unexpected behavior. The commit states the operator is unused in the codebase, so it is deleted rather than fixed. There is no direct evidence this bug was exploitable for security harm.

This commit adds a new automated test to Bitcoin Core. The test checks what happens when a user cancels a wallet rescan while importing descriptors. It does not change any production wallet code; it only adds test coverage. There is no security vulnerability here.

This commit only adds a new test case to Bitcoin Core's test suite. It checks that the wallet's importdescriptors RPC returns a specific error message when used during an in-progress assumeutxo background sync. There is no change to production code, no bug fix, and no security vulnerability being introduced or patched.