BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3175 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

320security candidates668second-pass queue3008AI analyses
151commits · 30 days
331commits · 60 days
1299commits · 180 days
2864commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

71/100 average clarity
1180Strong · 80–100
1206Adequate · 60–79
701Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script2054790389
Antoine Poinsot22422170
Ava Chow19868191069
MarcoFalke41421408074
fanquake23121228058
Lőrinc18121177081
Hennadii Stepanov22516211064
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 44 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36364: tools: Call SHA256AutoDetect in bitcoin-util, bitcoin-tx and bitcoin-wallet

This change makes three Bitcoin command-line tools (bitcoin-tx, bitcoin-util, and bitcoin-wallet) automatically pick the fastest SHA-256 hashing implementation available on the computer, such as hardware-accelerated versions on modern CPUs…

dc2a9987by merge-script+6−03 files
No security note in commit
Informational 23 AI analysisMessage 98 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36321: net: cast vector size to avoid overflow, truncation, sign change

This is a one-line fix in Bitcoin Core's network code. It changes how the size of a list of block headers is converted to a signed integer inside a loop. Previously, if the list was empty, the conversion could trigger undefined-behavior wa…

UndefinedBehaviorSanitizer integer sanitizer warning addressedImplicit signed/unsigned conversion in loop counterUnsigned integer wraparound on empty vector size
ced4c6e6by merge-script+1−11 file
No security note in commit
Low 32 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#34371: wallet: allow importprunedfunds for spending transactions

This change fixes a Bitcoin Core wallet bug where the `importprunedfunds` RPC command could only re-import transactions that sent money to the wallet, not transactions that spent money from it. After this fix, both incoming and outgoing tr…

Logic bug in wallet transaction import scopeIncorrect balance possible after removing and re-importing spending transactionFix routes import through existing involvement check (IsMine + IsFromMe)
ed7dd7cfby Ava Chow+36−203 files
No security note in commit
Low 28 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#29278: Wallet: Add `maxfeerate` wallet startup option

This commit adds a new Bitcoin Core wallet startup option called -maxfeerate. It lets users set a maximum fee rate (fee per unit of transaction size) that the wallet will allow when creating or broadcasting transactions. Previously, the wa…

New wallet startup option -maxfeerate to cap transaction fee rateNew transaction error type MAX_FEE_RATE_EXCEEDEDBroadcastTransaction now checks both max absolute fee and max fee rate
f80aaf4bby Ava Chow+303−7930 files
No security note in commit
Moderate 64 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35984: sign: skip signing SIGHASH_SINGLE inputs with no corresponding output

This Bitcoin Core update fixes a wallet-signing quirk. When a user chose the SIGHASH_SINGLE signature mode, an input that had no matching output index would sign essentially nothing meaningful. That signature could then stay valid even if …

Funds-redirection footgun from SIGHASH_SINGLE signatures with no committed outputInconsistent guard between SignTransaction and SignPSBTInput pathsFix centralizes the guard in the low-level signature creator to cover future signing paths
e19f83e9by Ava Chow+37−82 files
Vendor flagged security relevance
Low 35 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35696: i2p: update leaseset encryption types

This change updates Bitcoin Core's I2P (Invisible Internet Project) privacy network settings to use newer, stronger encryption for the published 'leaseset' that describes how other peers can contact a node. The old setting included ElGamal…

Cryptographic algorithm update (ElGamal to MLKEM-768)Use of I2P 'legacy' encryption type removedConfiguration-only change in network privacy layer
65e075f8by Ava Chow+2−21 file
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35948: init: correct first-run disk space estimate

This change fixes a labeling bug in Bitcoin Core's first-run disk-space warning. The estimate was stored in GiB (binary gigabytes, 1024-based) but displayed as GB (decimal gigabytes, 1000-based), and for pruned nodes it showed the full-cha…

d26f19c7by Ava Chow+5−42 files
No security note in commit
Low 44 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36284: wallet: don't double discard output groups with avoidpartialspends

This is a wallet bug, not a theft or remote-code bug. When a Bitcoin Core user turns on the optional 'avoidpartialspends' or 'avoid_reuse' setting, an output group rejected during coin selection could be counted twice as 'discarded.' That …

Logic error causing double-counting of discarded UTXO groupsCan trigger false 'insufficient funds' failure in coin selectionAffects avoidpartialspends / avoid_reuse wallets only
e8e7e91aby Ava Chow+43−14 files
No security note in commit
Informational 18 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35890: doc: use overwrite (>) instead of append (>>) for one-shot PSBT files in offline-signing-tutorial.md

This is a documentation-only fix in a tutorial file. It changes two shell examples from using '>>' (append to file) to '>' (overwrite file). If a user followed the old instructions and ran the same command twice, the file would contain two…

No security signal: change is limited to documentationNo code changes to Bitcoin Core binaries, RPC, wallet, or consensus logicNo cryptographic, network, or privilege-boundary implications
bfdcd979by merge-script+2−21 file
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35675: mining: add block template manager

This is a large internal code reorganization (refactor) in Bitcoin Core. It creates a new BlockTemplateManager class that takes over block-template creation, block submission, and tip-waiting helpers that were previously spread across seve…

Large refactor touching mining, RPC, interfaces, and test shutdown pathsNew object lifetime dependency: BlockTemplateManager holds references to mempool, chainman, and notifications; explicit reset ordering added in Shutdown/InitAndLoadChainstate/test setupsRemoval of early-init node.mining interface; BlockTemplateManager is now created after chainstate load, with a comment that it must exist before setChainstateLoaded(true) unblocks IPC waiters
5c726f20by Ryan Ofsky+561−44926 files
No security note in commit
Informational 12 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35301: Silent Payments: Implement bip352 (take 2)

This commit adds the first implementation of BIP352 (Silent Payments) to Bitcoin Core. Silent Payments are a new type of privacy-preserving Bitcoin address that lets someone receive payments without publicly revealing a fixed address. The …

New cryptographic feature implementation (BIP352 Silent Payments)Extensive use of secp256k1 silentpayments moduleInput public key extraction from P2PKH, P2WPKH, P2SH-P2WPKH, and P2TR inputs
be5d0b55by Ava Chow+6951−010 files
No security note in commit
Low 45 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35440: wallet: check descriptor cache xpub length before decoding

This update fixes a wallet database loading bug where a damaged or tampered Bitcoin wallet file could cause the program to read past the end of a stored extended public key (xpub). The patch makes the loader check the stored xpub length be…

Out-of-bounds read in wallet descriptor cache deserializationASan container-overflow triggered by malformed on-disk recordMissing length validation between record size prefix and fixed-size decoder
b3f846ecby Ava Chow+225−8511 files
Vendor flagged security relevance
Informational 20 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35813: wallet, rpc: Add listrawtransactions RPC

This commit adds a new wallet RPC called listrawtransactions to Bitcoin Core. It is a feature addition that lets users list every transaction their wallet knows about, including internal transfers and consolidations that the existing listt…

No security-relevant bug fix or vulnerability patch is present in the diff.New RPC exposes additional wallet transaction metadata, but only to callers already authorized for wallet RPCs.Code is a refactor of existing gettransaction logic into shared helpers; no new cryptographic, network, or consensus code.
2b95b45aby Ava Chow+334−276 files
No security note in commit
Moderate 68 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35752: wallet: make encryption state updates atomic

This Bitcoin Core update fixes several wallet bugs where a failed database write could leave a wallet in an inconsistent state. For example, encrypting a wallet or changing its passphrase could appear to succeed in memory while the change …

Atomicity fix for encryption state and descriptor key persistenceFailure to persist master key during encryption previously reported success in memoryPassphrase change could activate new passphrase only in memory
7ee3d622by Ava Chow+379−16418 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35619: test: ExtendedPrivateKey follow-ups

This commit only changes Bitcoin Core's internal functional test code. It replaces hard-coded test keys and addresses with ones generated from a new test helper class, and unifies how tests tell nodes not to create a default wallet. There …

248ce46fby merge-script+18−244 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36261: test: cover PSBT unknown field merging

This commit only adds a new automated test to Bitcoin Core. It checks that when two partially-signed Bitcoin transactions (PSBTs) are combined, any custom 'unknown' data fields attached to them are preserved correctly. There is no change t…

bbc40edeby merge-script+130−01 file
No security note in commit
Informational 18 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36230: wallet: Improve `HasWalletDescriptor` performance and other canonical descriptor string followups

This is a Bitcoin Core wallet maintenance patch. It speeds up a wallet function that checks whether a descriptor already exists by caching a hash of the descriptor's canonical text, instead of rebuilding that text every time. It also tidie…

No security-relevant signal in commit message or diffChange is described as performance improvement and code cleanupBackwards-compatibility test notes a known miniscript wallet loading incompatibility between v31.0/v31.1 and other versions, but this is a documented compatibility quirk, not a vulnerability
4a583f38by merge-script+97−429 files
No security note in commit
Informational 21 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36297: rpc: Correct invalid OpenRPC defaults

This is a documentation-only fix for Bitcoin Core's machine-readable RPC help data. It changes several default values from literal strings to 'hint' labels (because the real default depends on context) and corrects one boolean default from…

OpenRPC schema/default mismatch correctionRPC help metadata type correction (string 'false' to boolean false)No executable code path changes
5f05d8c5by merge-script+6−63 files
No security note in commit
Informational 20 AI analysisMessage 68 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

rpc: Correct OpenRPC default metadata

This commit fixes documentation metadata for six Bitcoin Core RPC arguments. It changes how default values are described so that automatically generated API docs and schemas are accurate. The actual behavior of the software when running is…

No runtime code changesOnly RPC help/schema metadata modifiedVendor explicitly states runtime behavior is unchanged
b7f740c5by will+6−63 files
No security note in commit
Informational 24 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36286: crypto: Fix MuHash3072 division by itself

This commit fixes a bug in Bitcoin Core's MuHash3072 cryptographic code where dividing a MuHash object by itself (x /= x) produced the wrong mathematical result. The fix is straightforward: the code now saves the divisor's numerator before…

Cryptographic correctness bug in MuHash3072 division operatorSelf-aliasing in operator/= produces incorrect 1/D result instead of empty setNo production code path identified that triggers self-division
d48e76e6by merge-script+11−13 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-prioritytest: clean up and modernize interface_httpby Matthew Zipkin · f06de5c1 · Apr 6, 2026 · 1 fileMessage 67 · AdequateInformational 15Details
Commit message · Matthew Zipkin

test: clean up and modernize interface_http

67/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a routine cleanup of a single test file in Bitcoin Core. It rewrites the functional test that checks HTTP server behavior, wrapping raw HTTP client code into a helper class and adding a few extra sanity checks. There is no change to the actual Bitcoin node software, no bug fix, and no security-relevant behavior change.

Lower-prioritytest: enable `feature_bind_extra` on macOS and BSDby Lőrinc · 7236a055 · Apr 6, 2026 · 2 filesMessage 100 · StrongInformational 15Details
Commit message · Lőrinc

test: enable `feature_bind_extra` on macOS and BSD

`feature_bind_extra` checks `-bind` and `-whitebind` by comparing the node's listening sockets with the expected addresses.
Add `get_bind_addrs` support for macOS, FreeBSD, NetBSD, and OpenBSD using `lsof`, and switch the test to the POSIX platform guard so it runs there too.
On FreeBSD, pass `-Di` to avoid device-cache warnings on stderr that the functional test runner treats as failures.

Co-authored-by: willcl-ark <will8clark@gmail.com>
Co-authored-by: fanquake <fanquake@gmail.com>

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only expands a Bitcoin Core test so it also runs on macOS and BSD systems, not just Linux. It adds a helper that uses the lsof command to find which network addresses a test node is listening on. There is no change to the actual Bitcoin node software that users run, and no security bug is being fixed or introduced.

Lower-prioritytest: enable `rpc_bind` on macOS and BSDby Lőrinc · 1950da94 · Apr 6, 2026 · 2 filesMessage 90 · StrongInformational 15Details
Commit message · Lőrinc

test: enable `rpc_bind` on macOS and BSD

`rpc_bind` uses `all_interfaces` to find a non-loopback IPv4 address and `get_bind_addrs` to verify the node's listening sockets.
Add `all_interfaces` support for macOS, FreeBSD, NetBSD, and OpenBSD using `ifconfig -au`, switch the test to the POSIX platform guard so it runs there too, and fail early if no IPv4 interfaces are returned.

Co-authored-by: Sjors Provoost <sjors@sprovoost.nl>

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only changes Bitcoin Core's internal test code. It expands an existing test so it can run on macOS and BSD systems, and adds a helper function that reads network interface information from the operating system. There is no change to the actual Bitcoin node software that users run, and nothing in the commit introduces a security vulnerability or fixes one.

Lower-priorityguix: remove riscv exclusion from symbol checkby fanquake · 19e99be0 · Apr 6, 2026 · 1 fileMessage 45 · ThinInformational 16Details
Commit message · fanquake

guix: remove riscv exclusion from symbol check

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 16/100

This commit removes a special exception that previously let RISC-V builds skip a check for unwanted exported symbols. The change makes the build-time symbol check apply equally to RISC-V binaries, slightly tightening release-build quality controls. It is not a fix for an active vulnerability in running Bitcoin software.

AI review queuedguix: binutils 2.46.0by fanquake · 47b7a9f6 · Apr 6, 2026 · 1 fileMessage 38 · OpaqueInformational 11Details
Commit message · fanquake

guix: binutils 2.46.0

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 11/100

This commit updates the version of binutils (a set of tools used to build Bitcoin Core's release binaries inside a reproducible build environment called Guix) from 2.44 to 2.46.0. It is a routine build-system dependency bump. There is no direct evidence in the commit or supplied references that this fixes a security vulnerability, introduces a known exploit, or changes any runtime code that end users interact with.

Lower-priorityvalidation: Remove stale BlockManager param in ContextualCheckBlockHeaderby ismaelsadeeq · 851152e4 · Apr 4, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · ismaelsadeeq

validation: Remove stale BlockManager param in ContextualCheckBlockHeader

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This is a small code cleanup that removes an unused parameter from an internal function. The function previously received a 'BlockManager' object but did not actually use it. The change only adjusts the function signature and the two places that call it. There is no security fix here.

Lower-prioritytest: Add test for exceeding max line length in torcontrolby Fabian Jahr · 1401011f · Apr 3, 2026 · 1 fileMessage 95 · StrongInformational 15Details
Commit message · Fabian Jahr

test: Add test for exceeding max line length in torcontrol

Also deduplicates the repetitive tor mock setup for each test case a bit.

Co-authored-by: janb84 <githubjanb.drainer976@passmail.net>

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only adds a new automated test for Bitcoin Core's Tor control feature. It checks that the program safely disconnects when a mock Tor server sends an extremely long response line. There are no changes to the actual Bitcoin Core program code, only to the test file.

Lower-priorityfuzz: Improve torcontrol fuzz testby Fabian Jahr · 4117b92e · Apr 3, 2026 · 2 filesMessage 78 · AdequateInformational 18Details
Commit message · Fabian Jahr

fuzz: Improve torcontrol fuzz test

Gets rid of the Dummy class and adds coverage of get_socks_cb.

Also explicitly handles an exception case within Torcontrol rather than
relying on a guard in the fuzz test.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 18/100

This commit improves a fuzz test for Bitcoin Core's Tor control code and adds a small safety check in the real Tor control logic. The production change guards against an empty reply from Tor during the SAFECOOKIE authentication challenge, preventing a potential out-of-bounds read or crash. The rest of the change is test cleanup and expanded fuzzing coverage.

Lower-prioritytest: Add torcontrol coverage for PoW defense enablementby Fabian Jahr · 84c1f320 · Apr 3, 2026 · 1 fileMessage 72 · AdequateInformational 15Details
Commit message · Fabian Jahr

test: Add torcontrol coverage for PoW defense enablement

72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds new automated tests for Bitcoin Core's Tor control feature. It checks that when creating a hidden service, the software requests a modern anti-DoS feature (proof-of-work defenses) and gracefully falls back if the Tor daemon does not support it. No production code is changed, so this cannot introduce a security vulnerability or fix one directly.

Lower-prioritytest: Add simple functional test for torcontrolby Fabian Jahr · 56938335 · Apr 3, 2026 · 2 filesMessage 67 · AdequateInformational 15Details
Commit message · Fabian Jahr

test: Add simple functional test for torcontrol

67/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds a new automated test that simulates a Tor control server and checks that Bitcoin Core talks to it correctly. It does not change any production code, so it cannot introduce a security vulnerability or fix one.

Lower-prioritytest: Add test for partial message handling in torcontrolby Fabian Jahr · 7dff9ec2 · Apr 3, 2026 · 1 fileMessage 72 · AdequateInformational 12Details
Commit message · Fabian Jahr

test: Add test for partial message handling in torcontrol

72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 12/100

This commit only adds a new automated test for Bitcoin Core's Tor control feature. It checks that the software correctly waits for a complete message before acting, rather than reacting to a partial message. There is no change to the actual Bitcoin Core program code that users run.

Lower-prioritytorcontrol: Move tor controller into node contextby Fabian Jahr · b1869e9a · Apr 3, 2026 · 5 filesMessage 60 · AdequateInformational 15Details
Commit message · Fabian Jahr

torcontrol: Move tor controller into node context

Co-authored-by: sedited <seb.kung@gmail.com>

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit is a straightforward internal code cleanup: it moves the Tor controller object from a single global variable into the per-node context structure. There is no change in user-facing behavior, no bug fix, and no security-relevant change visible in the diff.

Lower-prioritytorcontrol: Remove libevent usageby Fabian Jahr · eae193e7 · Apr 3, 2026 · 3 filesMessage 50 · ThinLow 28Details
Commit message · Fabian Jahr

torcontrol: Remove libevent usage

Replace libevent-based approach with using the Sock class and CThreadInterrupt.

50/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body
AI analysis · Low 28/100

This commit rewrites how Bitcoin Core talks to the Tor control port. It replaces the libevent networking library with Bitcoin Core's own simpler socket wrapper and a dedicated control thread. The change is a refactor: it removes one external dependency and makes the code easier to test and reason about, but it also introduces new socket-handling code that must correctly manage reconnects, timeouts, partial reads, and shutdown. There is no direct evidence in the commit or supplied references that this fixes a known security bug, but any rewrite of network code carries a small risk of introducing subtle bugs.

AI review queuedbtcsignals: use a single shared_ptr for liveness and callbackby Cory Fields · 242b0ebb · Apr 3, 2026 · 1 fileMessage 73 · AdequateInformational 13Details
Commit message · Cory Fields

btcsignals: use a single shared_ptr for liveness and callback

This simplifies the implementation and eliminates an unnecessary shared_ptr.

Suggested by Marco Falke.

<Co-authored-by: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 13/100

This is a small internal code cleanup in Bitcoin Core's custom signal/slot system. It merges two separate shared pointers (one tracking whether a callback is still active, and one used as a construction tag) into a single shared pointer. There is no user-facing change, no bug fix, and no security-relevant behavior change visible in the diff.

AI review queuedsignals: Add a simplified boost-compatible implementationby Cory Fields · e60a0b9a · Apr 3, 2026 · 1 fileMessage 73 · AdequateLow 27Details
Commit message · Cory Fields

signals: Add a simplified boost-compatible implementation

This re-implements the tiny portion of boost::signals2 that we currently use.

It is enough to be useful as a generic multicast callback mechanism.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 27/100

This commit replaces Bitcoin Core's use of the Boost signals2 library with a new, simplified in-house implementation called btcsignals. It is a code refactoring/reimplementation intended to reduce dependency on Boost. The change itself does not fix a known bug or vulnerability, but any reimplementation of a threading/callback mechanism carries risk of introducing subtle concurrency or lifetime bugs.

AI review queuedsignals: remove boost compatibility guardsby Cory Fields · 34eabd77 · Apr 3, 2026 · 1 fileMessage 68 · AdequateInformational 15Details
Commit message · Cory Fields

signals: remove boost compatibility guards

These were necessary to work around unnecessary constraints that have been
fixed in the (upcoming) boost::signals2 version 1.91.

Our implementation's constraints match those of that version.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a small cleanup of a test file. It removes version-specific workarounds for older Boost library versions, keeping only the behavior needed for the newest Boost version. There is no security issue here.

Lower-prioritysignals: remove boost includes where possibleby Cory Fields · 375397eb · Apr 3, 2026 · 1 fileMessage 70 · AdequateInformational 15Details
Commit message · Cory Fields

signals: remove boost includes where possible

In both of these cases, boost was only needed for signals and not for
multi_index/test.

70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This is a routine build cleanup. A developer removed two leftover references to the Boost C++ library from the project's build instructions because those parts of the code no longer use Boost. There is no security issue here.

Lower-priorityRevert "signals: Temporarily add boost headers to bitcoind and bitcoin-node builds"by Cory Fields · 9958f4fe · Apr 3, 2026 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · Cory Fields

Revert "signals: Temporarily add boost headers to bitcoind and bitcoin-node builds"

This reverts commit 3df1a1405972076384946c71c45bb056cfdf8c41.

This was only necessary as an interim workaround.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit simply removes a temporary build dependency on Boost headers from two internal build targets. It is a cleanup change with no visible security relevance.

Lower-prioritysignals: remove boost::signals2 from depends and vcpkgby Cory Fields · b12f43a0 · Apr 3, 2026 · 2 filesMessage 50 · ThinInformational 15Details
Commit message · Cory Fields

signals: remove boost::signals2 from depends and vcpkg

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit simply removes an unused software component (Boost.Signals2) from two dependency lists used to build Bitcoin Core. It is a cleanup change, not a security fix.

Lower-prioritysignals: remove boost::signals2 mentions in linters and docsby Cory Fields · a4b16079 · Apr 3, 2026 · 2 filesMessage 65 · AdequateInformational 15Details
Commit message · Cory Fields

signals: remove boost::signals2 mentions in linters and docs

The documented example is no longer relevant, so remove it rather than updating
it to mention btcsignals.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit is a routine cleanup of documentation and a linting script. It updates an example in the developer notes to reference the project's own signal library (btcsignals) instead of the old Boost signals2 library, and removes three Boost signals2 header paths from the list of expected Boost includes checked by a linter. There is no code behavior change and no security relevance.

Lower-prioritysignals: re-add forward-declares to interface headersby Cory Fields · 091736a1 · Apr 3, 2026 · 2 filesMessage 65 · AdequateInformational 15Details
Commit message · Cory Fields

signals: re-add forward-declares to interface headers

The real includes were only needed temporarily while supporting btcsignals as
an alias for boost::signals2.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This is a routine code cleanup commit. It replaces a full header include with a simple forward declaration in two interface header files. There is no security-relevant change and no indication of a vulnerability being fixed.

AI review queuedsignals: add signals testsby Cory Fields · 63c68e2a · Apr 3, 2026 · 2 filesMessage 68 · AdequateInformational 15Details
Commit message · Cory Fields

signals: add signals tests

These tests are compatible with boost::signals2 as well as the replacement
implementation that will be introduced in the next commit.

This is intended to demonstrate some equivalency between the implementations.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds new automated tests for an internal signal/slot library called btcsignals. It does not change any production code, fix a bug, or alter behavior visible to users or attackers. The tests are described by the author as preparation for a future replacement implementation.

Security candidaterpc: fix initialization-order-fiasco by lazy-init of decodepsbt_inputsby Eugene Siegel · d517fa0a · Apr 3, 2026 · 2 filesMessage 73 · AdequateLow 25Details
Commit message · Eugene Siegel

rpc: fix initialization-order-fiasco by lazy-init of decodepsbt_inputs

Prior to this commit, decodepsbt_inputs would call TxDoc during initialization
which lives in another TLU. TxDoc relies on CURRENCY_UNIT to be initialized when
it may not have been (note this is different from the TLU containing
decodepsbt_inputs which also has a CURRENCY_UNIT). Fix this by lazy initializing
decodepsbt_inputs.

Prevent the issue from occurring in the future by also doing the same for
decodepsbt_outputs and getblock_vin.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 25/100

This commit fixes a subtle startup bug in Bitcoin Core's RPC help system. Some help text for commands like 'decodepsbt' and 'getblock' was being built before all global constants were ready, which could cause crashes or garbled output when the program starts. The fix delays building that help text until it is actually needed. It is a reliability fix, not a remote attack vector.

Lower-prioritydepends: remove workaround for Make older than 4.2.90by fanquake · f1e14dfb · Apr 3, 2026 · 3 filesMessage 73 · AdequateInformational 15Details
Commit message · fanquake

depends: remove workaround for Make older than 4.2.90

This was introduced for distros shipping older make, such as
Ubuntu 20.04 (4.2.1). It's likely that all distros being used for
Darwin and Qindows cross compilation, are shipping a newer make at
this point.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit removes a compatibility workaround in Bitcoin Core's build system for older versions of GNU Make (before 4.2.90). It simplifies how the build scripts find compiler and toolchain programs. There is no security issue here; it is a routine cleanup that assumes users building for macOS, FreeBSD, or Windows are now on a newer version of Make.

Lower-prioritytest: fix send_batch_request to pass callables when using --usecliby Pol Espinasa · 5603ae0f · Apr 2, 2026 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · Pol Espinasa

test: fix send_batch_request to pass callables when using --usecli

send_batch_request() was building raw dicts without a "jsonrpc" version, which made Core to treat them as version 1.0 requests.
This worked in normal mode, but failed with --usecli because TestNodeCLI.batch() expects callables, not dicts.

This commit fixes it by using get_request() which is defined in both AuthServiceProxy and TestNodeCLIAttr.
The assert is changed because by using get_reques() AuthServiceProxy treats it as "jsonrpc" version 2.0 requests, which don't return "error" keys.

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 15/100

This is a minor fix to a Bitcoin Core functional test script. It changes how test batch RPC requests are built so they work correctly when tests are run with the --usecli option. There is no change to production code, no security vulnerability, and no risk to real Bitcoin nodes or wallets.