Bitcoin Core

This commit refactors how Bitcoin Core's block builder (the miner) handles the maximum block weight setting. It replaces an older signed-size field with a new optional unsigned field and fixes a parsing quirk: a negative command-line value for -blockmaxweight is now treated as 0 before validation rejects it, instead of silently wrapping around to a huge positive number. The change is mostly a cleanup, but it removes a small overflow/underflow footgun in argument parsing.

This commit only adds a new automated test to Bitcoin Core. It checks that a configuration option called -blockmaxweight correctly limits the size of blocks produced through the IPC mining interface, both when a block template is first created and when it is refreshed. There is no change to production code, no bug fix, and no security patch.

This commit adds a new automated test for Bitcoin Core's mining interface. It checks that a feature called waitNext(), used by external mining programs, correctly follows the node's configured minimum transaction fee policy (-blockmintxfee) and does not quietly ignore that setting. The commit itself only adds a test; it does not change the actual mining code. The test appears to be a regression test for a bug where waitNext() may have fallen back to default fee policy instead of using the configured one.

This commit is a code cleanup (refactor) in Bitcoin Core's test, benchmark, and fuzzing code. It changes how test code asks the node to create blocks, switching most callers from the internal BlockAssembler class to a public Mining interface. The commit message explicitly says it does not change what blocks are created, only how the creation calls are made. There is no security fix or vulnerability here.

This commit only moves a test helper function from one test file into a shared utility file. It does not change Bitcoin Core's actual code, network behavior, or security properties. It is a pure test-code refactoring with no security relevance.

This is a code cleanup in Bitcoin Core's internal testing tools. It changes when and how the test framework creates a command-line interface (CLI) helper for test nodes, and removes some redundant settings. There is no indication this fixes a security bug or affects live Bitcoin software.

This commit is a simple code cleanup in Bitcoin Core's internal test framework. It removes a small helper function called get_rpc_proxy and moves its logic directly into the one place that used it. There is no change to Bitcoin's network protocol, wallet handling, consensus rules, or production code. It only affects test infrastructure and does not introduce a security issue.

This is a test-only change that lets one of Bitcoin Core's automated functional tests run using the bitcoin-cli command-line tool in addition to the existing Python RPC proxy path. It does not change the actual Bitcoin node software, network protocol, wallet handling, or any user-facing behavior. There is no security issue here.

This is a minor code cleanup in a test file. It replaces a manual way of creating a connection to the Bitcoin node with a helper method that does the same thing. There is no security issue here.

This is a minor test-only change. It removes a flag that prevented a shutdown test from running with the command-line interface option and switches to a standard helper for creating an RPC connection. There is no change to the actual Bitcoin Core software that users run, and no security relevance.

This is a test-only change that lets one of Bitcoin Core's automated functional tests run in a mode where it calls the node through the command-line bitcoin-cli tool instead of only through the Python RPC library. It does not change any production code, consensus rules, wallet handling, or network behavior that real users rely on.

This commit is a cleanup of compiler warning annotations in a public C header. It removes 'you must use the return value' warnings from simple getter functions (like asking for the number of inputs in a transaction) and adds them to functions that return error codes or newly created objects. The change does not alter program behavior, fix a crash, or close a security hole; it only makes developer tooling warnings more accurate.

This is a test-only fix for a flaky automated test on Windows. It adds one more network error code (ECONNABORTED) to the list of temporary connection errors that the test framework should ignore while waiting for a Bitcoin node to start or shut down. It does not change Bitcoin Core's production code, network behavior, or security.

This is a minor GitHub Actions CI configuration fix. It moves a comment onto its own line so that the cache save and restore steps use identical path patterns. There is no security issue in the code change itself.

This is a routine Continuous Integration (CI) script cleanup. It turns on a stricter shell error mode (`pipefail`) and adjusts how build statistics are parsed so the script keeps working. There is no user-facing Bitcoin node behavior change and no security issue.

This commit simply removes two unused library links from the build configuration for bitcoin-cli, the command-line tool. There is no code change and no security issue is indicated.

This commit replaces the HTTP client library used by bitcoin-cli (libevent) with a new custom-built HTTP client. It is a large refactoring change that touches network communication, credential handling, and error messages. There is no direct evidence in the commit that this fixes a known security bug, but any rewrite of network and authentication code carries a risk of introducing subtle bugs in how bitcoin-cli talks to the Bitcoin server.

This commit only changes Bitcoin Core's internal functional test code. It replaces hardcoded {'rules': ['segwit']} parameters with a shared constant NORMAL_GBT_REQUEST_PARAMS when calling getblocktemplate in tests. There is no change to production node code, no change to consensus rules, and no security fix or vulnerability introduced.

This commit simply marks an old wallet startup option called -walletrbf as deprecated. Since a recent release already makes all transactions replaceable by default, the option is now redundant. The change adds a warning when the option is used and updates tests to expect that warning. There is no security vulnerability here.

This is a routine Bitcoin Core change that hides an old transaction status field called 'bip125-replaceable' from wallet RPC responses by default, marking it as deprecated. Users can still get it back by starting the node with -deprecatedrpc=bip125. It is not a security fix and does not introduce a vulnerability; it is a user-interface/API cleanup following earlier changes that made transactions replaceable by default.

This commit only adds a new automated test for an existing Bitcoin Core data structure. It does not change any production code, network behavior, or wallet logic. There is no security issue here.

This commit fixes a bug in how Bitcoin Core lists external hardware wallets (signers). Previously, if the list contained duplicate signers, the code would stop processing entirely after the first duplicate, potentially hiding valid non-duplicate signers from the user. The fix changes the behavior so duplicates are skipped while the rest of the list is still processed. This is a correctness and usability fix rather than a direct theft-of-funds vulnerability, but it could mislead a user about which hardware wallets are available.

This is a straightforward internal code cleanup in Bitcoin Core's wallet migration feature. It changes how wallet names are passed around so that the code stores names directly in a result structure rather than fetching names from live wallet objects. There is no security-relevant change visible in the diff, and the commit message explicitly calls it a refactor.

This commit only updates hardcoded test data used by Bitcoin Core's internal unit tests. The data is a pre-generated regtest (regression test) blockchain, and the change regenerates it so the tests continue to work with the current code. There is no change to production code, no network-facing change, and no security fix or vulnerability introduced.

This change tightens a safety check in Bitcoin Core's transaction memory pool (mempool) handling. When a group (package) of related transactions is submitted and one fails a final consensus check, the code now removes that failing transaction plus every transaction that comes after it in the package. The commit message calls it a 'belt-and-suspenders' fix to prevent the mempool from becoming internally inconsistent if a parent transaction fails but a child transaction does not. It is a defensive hardening patch rather than a confirmed exploitable bug.