Bitcoin Core

This is a cleanup change to one of Bitcoin Core's own automated tests. It removes an outdated comment about signature quirks and adjusts the test transactions so they follow normal network rules, allowing a special 'accept non-standard transactions' flag to be removed. It does not change any production code that runs on real Bitcoin nodes, so it has no direct security impact on the network or users.

This commit only adds plain-language comments and documentation to existing code. It does not change how the program behaves, does not fix any bug, and does not alter any logic that handles user data or network traffic. There is no security relevance.

This is a small code cleanup (refactor) in Bitcoin Core's asmap handling. It renames a function to use consistent capitalization and moves variable declarations closer to where they are used. There is no change to behavior, no bug fix, and no security-relevant change.

This is a code cleanup (refactor) change in Bitcoin Core. It replaces internal use of std::vector with std::span for asmap data so the same data isn't kept in memory twice, and updates the version-hash test value because the serialization format changed slightly. There is no security bug being fixed here.

This is a code cleanup change with no security impact. It moves the calculation of an 'asmap version' (previously called 'asmap checksum') into a single shared helper function and renames all references from 'checksum' to 'version' for consistency. The actual math used to compute the value is unchanged.

This commit is a code cleanup (refactor) in Bitcoin Core's asmap feature. It changes the internal representation of asmap data from a sequence of individual bits (std::vector<bool>) to a sequence of bytes (std::vector<std::byte>). The visible behavior of IP-to-ASN mapping, sanity checks, and file loading is intended to remain the same. There is no security fix or vulnerability indicated in the commit message or diff.

This commit only adds a new automated test to Bitcoin Core. The test builds an extremely deep Miniscript node tree and then exercises its destructor, clone, and move-assignment to confirm they do not overflow the call stack. It is a defensive regression test, not a fix for any currently broken or exploitable behavior.

This is a code cleanup change in Bitcoin Core's miniscript module. It removes an old type alias called NodeRef and a helper function called MakeNodeRef, replacing them with direct use of the Node type. It also removes an unused parameter from a test function. There is no change to how Bitcoin validates transactions, scripts, or signatures, and no security fix is described.

This commit rewrites how a data structure in Bitcoin Core's Miniscript code is torn down when no longer needed. The change is described as a non-functional refactor to avoid a potential stack overflow during destruction of deeply nested Miniscript expressions. There is no direct evidence in the commit that this fixes an exploitable vulnerability, and the change is not labeled as a security fix by the project.

This is an internal code cleanup in Bitcoin Core's miniscript module. It replaces pointer-based storage of miniscript nodes with direct object storage, while keeping the same behavior. The change is described by the authors as a pure refactor with no functional changes. There is no indication it fixes a security bug or introduces a new vulnerability, though any large refactor carries a small risk of unintended behavior changes.

This is a documentation-only change. A comment above a destructor was rewritten to no longer mention 'shared pointers' and was moved inside the function body. The actual code logic of the destructor did not change at all.

This commit is a straightforward internal code cleanup in Bitcoin Core's miniscript module. It changes several data structures from public structs with directly accessible fields to classes with private fields and public accessor methods, and removes 'const' from some fields so that objects can be moved efficiently in a later commit. There is no change to network rules, wallet behavior, or any user-visible functionality, and nothing in the diff suggests a security fix or vulnerability.

This is a small internal cleanup in Bitcoin Core's miniscript code. It removes the 'mutable' keyword from a list of child node pointers and adjusts a related pointer type. There is no user-facing behavior change and no security fix.

This commit fixes a flaky test problem on FreeBSD. When Bitcoin Core's test software asked the operating system for any available network port, FreeBSD could hand back a port number that the test framework already planned to use elsewhere, causing 'address already in use' failures. The change tells FreeBSD to pick ports only from the high-numbered range (49152-65535), which does not overlap with the test framework's reserved ports. It is a test-only reliability improvement, not a security fix.

This is a small build-system fix in Bitcoin Core's dependency builder. It prevents the CC environment variable (which tells a build which C compiler to use) from confusing the script that guesses what platform is being built on. The change makes cross-compilation detection more reliable, but it is not a runtime security fix for Bitcoin nodes or wallets.

This commit removes a redundant and misleadingly-named hash function called FilterHeaderHasher and replaces its single use with an existing, functionally identical BlockHasher. Both hashers do the exact same thing—read the first 8 bytes of a 256-bit value as the hash—so the change has no effect on runtime behavior. The author frames it as a naming/documentation bug because the old name wrongly implied the hasher was for filter-header values, when in fact it hashed block-hash keys. It is essentially a code-cleanup change with no known security impact.

This commit is a routine code-quality cleanup. It adjusts which C++ header files are included in several source files under src/primitives and tells the automated 'Include What You Use' (IWYU) checker to treat those files as strictly checked. There is no change to program logic, no bug fix, and no security-relevant behavior.

This change fixes a low-level programming issue in Bitcoin Core's custom memory pool allocator. The old code used a standard library function (`std::distance`) to calculate how many unused bytes remained in a memory chunk. That function can have undefined behavior when given null pointers, which could occur when no chunk had been allocated yet. The new code uses plain pointer subtraction, which is explicitly defined to give zero when both pointers are null. The practical security impact is likely limited because the undefined behavior only arises in a specific no-memory-allocated state and the result is used only to decide whether to add leftover bytes to a freelist.

This commit is a straightforward code cleanup that replaces older-style std::bind calls with the newer C++20 std::bind_front. It does not change what the program does, only how the code is written. There is no security issue here.

This commit only changes a single test file. It replaces a test setup that generated 101 fresh blocks with one that uses blocks already created by the test framework. There is no change to Bitcoin Core's actual network, wallet, or consensus code, so it cannot affect real users or funds.

This commit fixes a long-standing mistake in how Bitcoin Core reports an error when an OP_IF command is used without enough values on the script stack. In one specific spot, the wrong error code was returned for 11 years. The fix makes the error code consistent with every other similar case. This is a minor correctness/observability fix, not a vulnerability that lets an attacker steal funds or crash nodes.

This is a performance cleanup, not a security fix. A Bitcoin Core network function was doing unnecessary serialization work to calculate transaction byte sizes for a debug log line, even when debug logging was turned off. The change wraps that work in a check so it only runs when the relevant debug log category is actually enabled. There is no behavior change for users and no vulnerability is described or evident in the diff.

This is a small performance cleanup, not a security fix. Bitcoin Core was doing unnecessary work—calculating a block hash and adding up transaction byte sizes—every time it reconstructed a compact block, even when the relevant debug logging was turned off. The change simply skips that work when debug logging is disabled. The log output is unchanged when logging is on, and no network behavior or consensus rules change.

This commit is a simple rename-only code cleanup. It changes the name of a transaction size method from GetTotalSize to ComputeTotalSize to make it clear the size is recalculated each time rather than stored. No behavior, logic, or security properties change.

This commit tightens the bitcoin-wallet command-line tool so it can no longer create a wallet without an explicit name. Previously, the tool allowed creating an unnamed wallet in some situations, which could lead to confusion or accidental wallet files being placed in unexpected locations. The change adds clear error messages and tests to ensure the tool refuses to create unnamed wallets for both regular creation and creation from a dump file.