lint: remove excluded .cpp/.h files from whitespace check
What the developer wrote
Authored by fanquake
lint: remove excluded .cpp/.h files from whitespace check
These have been fixed since #32482 and
5d25a82b9a5e54f74cc066599541bc1d3da70988.
What changed, and why it matters
This commit removes three source-code files from a linting exclusion list. The lint check in question only enforces whitespace formatting rules. There is no change to Bitcoin Core's runtime behavior, consensus logic, networking, wallet, or any user-facing functionality. It is a pure code-quality tooling cleanup.
No security action required. Treat as routine repository maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes three entries from get_pathspecs_exclude_whitespace() in test/lint/test_runner/src/lint_text_format.rs: src/crypto/sha256_sse4.cpp, src/univalue/include/univalue_escapes.h, and src/univalue/test/object.cpp. These files had previously been granted exceptions from the whitespace-format lint because they contained trailing whitespace or other violations. The commit notes that those violations were already fixed in earlier commits (#32482 and 5d25a82b9a5e54f74cc066599541bc1d3da70988), so the exclusions are no longer needed. The change affects only CI lint tooling.
Changed components
test/lint/test_runner/src/lint_text_format.rsInspect captured patch +0 / −3
diff --git a/test/lint/test_runner/src/lint_text_format.rs b/test/lint/test_runner/src/lint_text_format.rs
index ca51e6db..1f7d540d 100644
--- a/test/lint/test_runner/src/lint_text_format.rs
+++ b/test/lint/test_runner/src/lint_text_format.rs
@@ -20,14 +20,11 @@ fn get_pathspecs_exclude_whitespace() -> Vec<String> {
// Temporary excludes, or existing violations
"contrib/init/bitcoind.openrc",
"contrib/macdeploy/macdeployqtplus",
- "src/crypto/sha256_sse4.cpp",
"src/qt/res/src/*.svg",
"test/functional/test_framework/crypto/ellswift_decode_test_vectors.csv",
"test/functional/test_framework/crypto/xswiftec_inv_test_vectors.csv",
"contrib/qos/tc.sh",
"contrib/verify-commits/gpg.sh",
- "src/univalue/include/univalue_escapes.h",
- "src/univalue/test/object.cpp",
"test/lint/git-subtree-check.sh",
]
.iter()
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.