What changed, and why it matters
This commit is purely cosmetic: it replaces tab characters with spaces in a lint script and removes that script from a list of files exempted from whitespace-format checks. There is no change to Bitcoin's network, wallet, consensus, or cryptographic code, and no security relevance.
No security action needed; this is a routine code-style/lint maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff converts indentation in test/lint/git-subtree-check.sh from tabs to spaces and removes the same file from get_pathspecs_exclude_whitespace() in test/lint/test_runner/src/lint_text_format.rs. No functional logic, command behavior, or security boundary is altered.
Changed components
test/lint/git-subtree-check.shtest/lint/test_runner/src/lint_text_format.rsInspect captured patch +27 / −28
diff --git a/test/lint/git-subtree-check.sh b/test/lint/git-subtree-check.sh
index 1eb83401..534fadba 100755
--- a/test/lint/git-subtree-check.sh
+++ b/test/lint/git-subtree-check.sh
@@ -47,33 +47,33 @@ fi
# Taken from git-subtree (Copyright (C) 2009 Avery Pennarun <apenwarr@gmail.com>)
find_latest_squash()
{
- dir="$1"
- sq=
- main=
- sub=
- git log --grep="^git-subtree-dir: $dir/*\$" \
- --pretty=format:'START %H%n%s%n%n%b%nEND%n' "$COMMIT" |
- while read a b _; do
- case "$a" in
- START) sq="$b" ;;
- git-subtree-mainline:) main="$b" ;;
- git-subtree-split:) sub="$b" ;;
- END)
- if [ -n "$sub" ]; then
- if [ -n "$main" ]; then
- # a rejoin commit?
- # Pretend its sub was a squash.
- sq="$sub"
- fi
- echo "$sq" "$sub"
- break
- fi
- sq=
- main=
- sub=
- ;;
- esac
- done
+ dir="$1"
+ sq=
+ main=
+ sub=
+ git log --grep="^git-subtree-dir: $dir/*\$" \
+ --pretty=format:'START %H%n%s%n%n%b%nEND%n' "$COMMIT" |
+ while read a b _; do
+ case "$a" in
+ START) sq="$b" ;;
+ git-subtree-mainline:) main="$b" ;;
+ git-subtree-split:) sub="$b" ;;
+ END)
+ if [ -n "$sub" ]; then
+ if [ -n "$main" ]; then
+ # a rejoin commit?
+ # Pretend its sub was a squash.
+ sq="$sub"
+ fi
+ echo "$sq" "$sub"
+ break
+ fi
+ sq=
+ main=
+ sub=
+ ;;
+ esac
+ done
}
# find latest subtree update
diff --git a/test/lint/test_runner/src/lint_text_format.rs b/test/lint/test_runner/src/lint_text_format.rs
index 120e9a71..98e27d8c 100644
--- a/test/lint/test_runner/src/lint_text_format.rs
+++ b/test/lint/test_runner/src/lint_text_format.rs
@@ -21,7 +21,6 @@ fn get_pathspecs_exclude_whitespace() -> Vec<String> {
"src/qt/res/src/*.svg",
"test/functional/test_framework/crypto/ellswift_decode_test_vectors.csv",
"test/functional/test_framework/crypto/xswiftec_inv_test_vectors.csv",
- "test/lint/git-subtree-check.sh",
]
.iter()
.map(|s| format!(":(exclude){s}")),
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.