What the developer wrote
Authored by fanquake
ci: use LIEF 0.17.5 in lint job
What changed, and why it matters
This commit updates a Python library used only in Bitcoin Core's continuous integration lint job from version 0.16.6 to 0.17.5, and removes a now-unneeded build compatibility patch. It does not change any code that runs in the Bitcoin Core software itself or affect how the network operates.
No security action required. Treat as routine dependency maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff changes the pinned LIEF version in ci/lint/01_install.sh from 0.16.6 to 0.17.5 and deletes contrib/guix/patches/lief-scikit-0-9.patch, which was a temporary workaround for python-scikit-build-core 0.9.x compatibility. The patch is no longer needed because LIEF 0.17.5 presumably supports the newer build tooling. This is a CI/build-maintenance change with no runtime security implications for Bitcoin Core nodes or wallets.
Changed components
ci/lint/01_install.shcontrib/guix/patches/lief-scikit-0-9.patchInspect captured patch +1 / −22
diff --git a/ci/lint/01_install.sh b/ci/lint/01_install.sh
index a6963a90..573dbca5 100755
--- a/ci/lint/01_install.sh
+++ b/ci/lint/01_install.sh
@@ -41,7 +41,7 @@ command -v python3
python3 --version
${CI_RETRY_EXE} pip3 install \
- lief==0.16.6 \
+ lief==0.17.5 \
mypy==1.19.1 \
pyzmq==27.1.0 \
ruff==0.15.5
diff --git a/contrib/guix/patches/lief-scikit-0-9.patch b/contrib/guix/patches/lief-scikit-0-9.patch
deleted file mode 100644
index 71e61783..00000000
--- a/contrib/guix/patches/lief-scikit-0-9.patch
+++ /dev/null
@@ -1,21 +0,0 @@
-Partially revert f23ced2f4ffc170d0a6f40ff4a1bee575e3447cf
-
-Restore compat with python-scikit-build-core 0.9.x
-Can be dropped when using python-scikit-build-core >= 0.10.x
-
---- a/api/python/backend/setup.py
-+++ b/api/python/backend/setup.py
-@@ -101,12 +101,12 @@ def _get_hooked_config(is_editable: bool) -> Optional[dict[str, Union[str, List[
- config_settings = {
- "logging.level": "DEBUG",
- "build-dir": config.build_dir,
-- "build.targets": config.build.targets,
- "install.strip": config.strip,
- "backport.find-python": "0",
- "wheel.py-api": config.build.py_api,
- "cmake.source-dir": SRC_DIR.as_posix(),
- "cmake.build-type": config.build.build_type,
-+ "cmake.targets": config.build.targets,
- "cmake.args": [
- *config.cmake_generator,
- *config.get_cmake_args(is_editable),
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.