What the developer wrote
Authored by fanquake
guix: drop CMake workaround
We are now using 3.31.x.
What changed, and why it matters
This commit removes a temporary build-script workaround that was only needed for older versions of CMake on Apple macOS builds. It is a routine cleanup with no security relevance.
No security action needed. Reviewers may verify that the CI/guix darwin build still passes with CMake 3.31.x.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes a sed-based fix in contrib/guix/libexec/build.sh that replaced ’ -u -r ’ with a space in generated cmake_install.cmake files. The workaround was required for CMake versions below 3.27 when building for darwin hosts. The project now uses CMake 3.31.x, so the workaround is no longer needed. The change is purely a build-system hygiene update.
Changed components
contrib/guix/libexec/build.shInspect captured patch +0 / −4
diff --git a/contrib/guix/libexec/build.sh b/contrib/guix/libexec/build.sh
index 092f934c..51354273 100755
--- a/contrib/guix/libexec/build.sh
+++ b/contrib/guix/libexec/build.sh
@@ -272,10 +272,6 @@ mkdir -p "$DISTSRC"
# Install built Bitcoin Core to $INSTALLPATH
case "$HOST" in
*darwin*)
- # This workaround can be dropped for CMake >= 3.27.
- # See the upstream commit 689616785f76acd844fd448c51c5b2a0711aafa2.
- find build -name 'cmake_install.cmake' -exec sed -i 's| -u -r | |g' {} +
-
cmake --install build --strip --prefix "${INSTALLPATH}" ${V:+--verbose}
;;
*)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.