Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This change fixes a Bitcoin Core wallet bug where the `importprunedfunds` RPC command could only re-import transactions that sent money to the wallet, not transactions that spent money from it. After this fix, both incoming and outgoing tr…
Logic bug in wallet transaction import scopeIncorrect balance possible after removing and re-importing spending transactionFix routes import through existing involvement check (IsMine + IsFromMe)
This commit adds a new Bitcoin Core wallet startup option called -maxfeerate. It lets users set a maximum fee rate (fee per unit of transaction size) that the wallet will allow when creating or broadcasting transactions. Previously, the wa…
New wallet startup option -maxfeerate to cap transaction fee rateNew transaction error type MAX_FEE_RATE_EXCEEDEDBroadcastTransaction now checks both max absolute fee and max fee rate
This Bitcoin Core update fixes a wallet-signing quirk. When a user chose the SIGHASH_SINGLE signature mode, an input that had no matching output index would sign essentially nothing meaningful. That signature could then stay valid even if …
Funds-redirection footgun from SIGHASH_SINGLE signatures with no committed outputInconsistent guard between SignTransaction and SignPSBTInput pathsFix centralizes the guard in the low-level signature creator to cover future signing paths
This change updates Bitcoin Core's I2P (Invisible Internet Project) privacy network settings to use newer, stronger encryption for the published 'leaseset' that describes how other peers can contact a node. The old setting included ElGamal…
Cryptographic algorithm update (ElGamal to MLKEM-768)Use of I2P 'legacy' encryption type removedConfiguration-only change in network privacy layer
This change fixes a labeling bug in Bitcoin Core's first-run disk-space warning. The estimate was stored in GiB (binary gigabytes, 1024-based) but displayed as GB (decimal gigabytes, 1000-based), and for pruned nodes it showed the full-cha…
This is a wallet bug, not a theft or remote-code bug. When a Bitcoin Core user turns on the optional 'avoidpartialspends' or 'avoid_reuse' setting, an output group rejected during coin selection could be counted twice as 'discarded.' That …
Logic error causing double-counting of discarded UTXO groupsCan trigger false 'insufficient funds' failure in coin selectionAffects avoidpartialspends / avoid_reuse wallets only
This is a documentation-only fix in a tutorial file. It changes two shell examples from using '>>' (append to file) to '>' (overwrite file). If a user followed the old instructions and ran the same command twice, the file would contain two…
No security signal: change is limited to documentationNo code changes to Bitcoin Core binaries, RPC, wallet, or consensus logicNo cryptographic, network, or privilege-boundary implications
This is a large internal code reorganization (refactor) in Bitcoin Core. It creates a new BlockTemplateManager class that takes over block-template creation, block submission, and tip-waiting helpers that were previously spread across seve…
Large refactor touching mining, RPC, interfaces, and test shutdown pathsNew object lifetime dependency: BlockTemplateManager holds references to mempool, chainman, and notifications; explicit reset ordering added in Shutdown/InitAndLoadChainstate/test setupsRemoval of early-init node.mining interface; BlockTemplateManager is now created after chainstate load, with a comment that it must exist before setChainstateLoaded(true) unblocks IPC waiters
This commit adds the first implementation of BIP352 (Silent Payments) to Bitcoin Core. Silent Payments are a new type of privacy-preserving Bitcoin address that lets someone receive payments without publicly revealing a fixed address. The …
New cryptographic feature implementation (BIP352 Silent Payments)Extensive use of secp256k1 silentpayments moduleInput public key extraction from P2PKH, P2WPKH, P2SH-P2WPKH, and P2TR inputs
This update fixes a wallet database loading bug where a damaged or tampered Bitcoin wallet file could cause the program to read past the end of a stored extended public key (xpub). The patch makes the loader check the stored xpub length be…
Out-of-bounds read in wallet descriptor cache deserializationASan container-overflow triggered by malformed on-disk recordMissing length validation between record size prefix and fixed-size decoder
This commit adds a new wallet RPC called listrawtransactions to Bitcoin Core. It is a feature addition that lets users list every transaction their wallet knows about, including internal transfers and consolidations that the existing listt…
No security-relevant bug fix or vulnerability patch is present in the diff.New RPC exposes additional wallet transaction metadata, but only to callers already authorized for wallet RPCs.Code is a refactor of existing gettransaction logic into shared helpers; no new cryptographic, network, or consensus code.
This Bitcoin Core update fixes several wallet bugs where a failed database write could leave a wallet in an inconsistent state. For example, encrypting a wallet or changing its passphrase could appear to succeed in memory while the change …
Atomicity fix for encryption state and descriptor key persistenceFailure to persist master key during encryption previously reported success in memoryPassphrase change could activate new passphrase only in memory
This commit only changes Bitcoin Core's internal functional test code. It replaces hard-coded test keys and addresses with ones generated from a new test helper class, and unifies how tests tell nodes not to create a default wallet. There …
This commit only adds a new automated test to Bitcoin Core. It checks that when two partially-signed Bitcoin transactions (PSBTs) are combined, any custom 'unknown' data fields attached to them are preserved correctly. There is no change t…
This is a Bitcoin Core wallet maintenance patch. It speeds up a wallet function that checks whether a descriptor already exists by caching a hash of the descriptor's canonical text, instead of rebuilding that text every time. It also tidie…
No security-relevant signal in commit message or diffChange is described as performance improvement and code cleanupBackwards-compatibility test notes a known miniscript wallet loading incompatibility between v31.0/v31.1 and other versions, but this is a documented compatibility quirk, not a vulnerability
This is a documentation-only fix for Bitcoin Core's machine-readable RPC help data. It changes several default values from literal strings to 'hint' labels (because the real default depends on context) and corrects one boolean default from…
OpenRPC schema/default mismatch correctionRPC help metadata type correction (string 'false' to boolean false)No executable code path changes
This commit fixes documentation metadata for six Bitcoin Core RPC arguments. It changes how default values are described so that automatically generated API docs and schemas are accurate. The actual behavior of the software when running is…
No runtime code changesOnly RPC help/schema metadata modifiedVendor explicitly states runtime behavior is unchanged
This commit fixes a bug in Bitcoin Core's MuHash3072 cryptographic code where dividing a MuHash object by itself (x /= x) produced the wrong mathematical result. The fix is straightforward: the code now saves the divisor's numerator before…
Cryptographic correctness bug in MuHash3072 division operatorSelf-aliasing in operator/= produces incorrect 1/D result instead of empty setNo production code path identified that triggers self-division
This is a build-compatibility fix, not a security patch. It changes how some constant data is stored internally so that Apple's macOS linker (ld64) can build Bitcoin Core correctly. The change avoids a linker bug that caused build failures…
No security-relevant code logic changedChange is a linker bug workaround, not a vulnerability fixConstants remain read-only; no new attack surface introduced
This commit refactors Bitcoin Core's wallet descriptor import feature so the same logic can be used by both the RPC command and a new GUI-facing interface. It also tightens one input rule: negative timestamps are now rejected, and the mini…
Refactor of security-sensitive wallet import code into shared CWallet pathNew input validation: negative timestamps rejected for importdescriptorsCentralization of descriptor range bound checks in CheckDescriptorRangeBounds
test/doc: remove misleading comment and improve tests
remove misleading comment for m_blocks_unlinked since for pruned nodes: - usually A is the missing data (just like in non-pruned nodes) - in PruneOneBlockFile, we remove entries once data for B is missing.
Co-authored-by: Martin Zumsande <mzumsande@gmail.com>
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100
This commit only touches documentation and test code. It removes an outdated comment about how pruned nodes track partially downloaded blocks and fixes a timing bug in a test where wallet status was being checked from a stale snapshot instead of live data. There are no changes to production code, no security fix, and no vulnerability.
Lower-prioritytest: add coverage for UB caused by FindMostWorkChainby stratospher · ca4a3802 · Jun 11, 2026 · 1 fileMessage 95 · StrongInformational 12Details
Commit message · stratospher
test: add coverage for UB caused by FindMostWorkChain
when pruned node2 finally receives the blocks from node0, node2 will process duplicate entires in ReceivedBlockTransactions twice but it will only insert into setBlockIndexCandidates if the block has more work that the current chain tip.
the duplicate entries in m_blocks_unlinked in this test are from height 1171 to 1294.
before this commit - we invalidated height 1320 and chain tip became 1319. so we won't add duplicate entries (all have <1319) into setBlockIndexCandidates and won't have coverage for this UB scenario.
with this commit - we invalidate height 1295 and chain tip became 1294. so we will process the duplicate entry 1294 in m_blocks_unlinked and have coverage for this UB.
Co-authored-by: Martin Zumsande <mzumsande@gmail.com>
95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
defensive validation
AI analysis · Informational 12/100
This commit only changes a test file. It adjusts which block height is invalidated in an existing functional test so that the test exercises a specific edge case involving duplicate block processing in pruned nodes. There is no change to production code, so it does not introduce or fix a live vulnerability by itself. It is a test-coverage improvement.
Lower-priorityvalidation: avoid duplicates in m_blocks_unlinkedby stratospher · c787b3b9 · Jun 11, 2026 · 1 fileMessage 68 · AdequateModerate 54Details
Commit message · stratospher
validation: avoid duplicates in m_blocks_unlinked
In a pruned node undergoing a deep reorg, FindMostWorkChain can insert duplicate entries into m_blocks_unlinked.
This can happen when: - Traversing from one candidate tip to the fork point adds blocks whose parents have been pruned. - Traversing from another candidate tip over the same fork inserts the same pairs again, since the blocks are shared across both branches.
When we finally download the missing parent from our peer and call ReceivedBlockTransactions to process m_blocks_unlinked, the same entry may be processed multiple times.
This can lead to re-insertion into setBlockIndexCandidates with a modified nSequenceId, violating its ordering invariants and causing undefined behavior. So avoid duplicate insertions into m_blocks_unlinked here.
Co-authored-by: Martin Zumsande <mzumsande@gmail.com>
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Moderate 54/100
This Bitcoin Core update fixes a bug where, during a deep chain reorganization on a pruned node, the same block entries could accidentally be added twice to an internal waiting list. If processed twice later, this could corrupt an ordered set used to choose the best chain, potentially causing crashes or undefined behavior. The fix prevents duplicates and adds a safety check.
Also assert that the availability of the satisfaction weight estimate does not depend on the signature-size assumption, and that assuming non-max-size signatures never increases the estimate.
83/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
signing boundaryfuzzing or regression evidence
AI analysis · Informational 15/100
This commit is a small fuzz-test improvement. It fixes an obvious test bug where the same function was being called twice with the same argument, and instead calls it with both possible arguments, then adds assertions about the results. It does not change any production wallet, consensus, or networking code, and there is no security fix or vulnerability indicated.
Lower-priorityqa: Use custom assert_greater_than() over naked assertby Hodlinator · 472b950b · Jun 10, 2026 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · Hodlinator
qa: Use custom assert_greater_than() over naked assert
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100
This is a tiny test-only cleanup that swaps a plain Python assert for a custom helper that prints better error messages when a test fails. It does not change any production code, network behavior, or security logic.
Lower-priorityfuzz: improve dbwrapper_concurrent_reads performanceby Andrew Toth · 1ce9e262 · Jun 10, 2026 · 1 fileMessage 50 · ThinInformational 15Details
✓ Specific, descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 15/100
This commit only changes a fuzz test file (a special kind of automated test that feeds random data to the code to find bugs). It rewrites how a concurrent-read fuzz target works, replacing a result-comparison approach with an oracle-based assertion approach and reusing a global thread pool. There is no change to production Bitcoin Core code, no fix to a real vulnerability, and no security-relevant change to how the software behaves on real networks or wallets.
AI review queuedtest: add coverage for importdescriptors when manually interrupting a wallet rescanby Pol Espinasa · ed11dd6a · Jun 10, 2026 · 1 fileMessage 87 · StrongInformational 15Details
Commit message · Pol Espinasa
test: add coverage for importdescriptors when manually interrupting a wallet rescan
Co-authored-by: w0xlt <woltx@protonmail.com>
87/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit adds a new automated test to Bitcoin Core. The test checks what happens when a user cancels a wallet rescan while importing descriptors. It does not change any production wallet code; it only adds test coverage. There is no security vulnerability here.
AI review queuedtest: add coverage for importdescriptors errors when using assumeutxoby Pol Espinasa · d90d7f0a · Jun 10, 2026 · 1 fileMessage 87 · StrongInformational 15Details
Commit message · Pol Espinasa
test: add coverage for importdescriptors errors when using assumeutxo
Co-authored-by: w0xlt <woltx@protonmail.com>
87/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only adds a new test case to Bitcoin Core's test suite. It checks that the wallet's importdescriptors RPC returns a specific error message when used during an in-progress assumeutxo background sync. There is no change to production code, no bug fix, and no security vulnerability being introduced or patched.
AI review queuedtest: add coverage for importdescriptors while wallet is rescanningby Pol Espinasa · ad388bf2 · Jun 10, 2026 · 1 fileMessage 87 · StrongInformational 15Details
Commit message · Pol Espinasa
test: add coverage for importdescriptors while wallet is rescanning
Co-authored-by: w0xlt <woltx@protonmail.com>
87/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only adds a new automated test to Bitcoin Core. It checks that if you try to import wallet descriptors while the wallet is already busy rescanning the blockchain, the second import attempt is rejected with a clear error message. There is no change to production wallet code, so this patch does not fix or introduce any live security issue by itself.
AI review queuedtest: updated different_key to be different_field and also used a single assert_equal with 3 args instead of multiple assert_equalsby kevkevinpal · ddceb4e6 · Jun 10, 2026 · 1 fileMessage 72 · AdequateInformational 15Details
Commit message · kevkevinpal
test: updated different_key to be different_field and also used a single assert_equal with 3 args instead of multiple assert_equals
72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This is a minor cleanup of a Bitcoin Core test file. It renames a helper function parameter from 'different_key' to 'different_field' and combines two separate length checks into one three-argument equality assertion. There is no change to production code, no security fix, and no behavior change in what the test verifies.
Security candidateiwyu: Fix warnings in `src/bench` and treat them as errorby Hennadii Stepanov · 6751a323 · Jun 10, 2026 · 58 filesMessage 50 · ThinInformational 15Details
Commit message · Hennadii Stepanov
iwyu: Fix warnings in `src/bench` and treat them as error
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 15/100
This commit is a code cleanup that adjusts which C++ header files are included in the project's benchmark code and a few related source files. It enables a stricter 'include what you use' (IWYU) check for the benchmark directory so missing or unnecessary #include lines are treated as errors in continuous integration. There is no change to program logic, no bug fix, and no security-relevant behavior.
Lower-priorityrefactor: Drop unused includes after iwyu CI bumpby MarcoFalke · fab52281 · Jun 10, 2026 · 2 filesMessage 72 · AdequateInformational 15Details
Commit message · MarcoFalke
refactor: Drop unused includes after iwyu CI bump
Now that the C++ std-lib was bumped in the CI task in the prior commit, some unused includes can (and must) be dropped.
72/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
AI analysis · Informational 15/100
This commit simply removes two unused C++ standard library header includes (<compare>) from source files because a code-quality tool (IWYU) now flags them after the CI's standard library version was bumped. There is no functional code change, no bug fix, and no security relevance.
ci: Bump APT_LLVM_V-based task configs to Ubuntu 26.04
Their clang version is pinned, so the only relevant change should be a more recent cmake, more recent C++ stdlib, and more recent Python version.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
AI analysis · Informational 15/100
This commit updates several Bitcoin Core automated testing scripts to use a newer version of the underlying Linux container image (Ubuntu 26.04 instead of Ubuntu 24.04 or Debian testing). The compiler version is kept the same, and the change only affects internal continuous integration (CI) environments, not the Bitcoin software users run. There is no indication this fixes or introduces a security vulnerability.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100
This commit simply swaps the Linux distribution used in Bitcoin Core's automated testing environment from Debian Trixie to Ubuntu 26.04. It updates container image names and a comment in a Valgrind suppression file. There is no change to the Bitcoin software itself, no bug fix, and no security-relevant behavior change.
AI review queuednet: move cs_main up in FetchBlock to fix rpc assert crashby Eugene Siegel · 359680b7 · Jun 9, 2026 · 1 fileMessage 85 · StrongModerate 54Details
Commit message · Eugene Siegel
net: move cs_main up in FetchBlock to fix rpc assert crash
1. FetchBlock runs in a http worker thread. It acquires a PeerRef, locks cs_main, then may later call BlockRequested which asserts that CNodeState exists for the peer.
2. FinalizeNode may run in either the bitcoind or b-net threads. It locks cs_main, fetches a PeerRef from RemovePeer, fetches a CNodeState, and later removes it from m_node_states.
Because of the lock placement in FetchBlock, the http worker thread in 1) can acquire a valid PeerRef and block while the b-net thread in 2) is cleaning up the peer in FinalizeNode. When the worker thread later acquires cs_main, it may crash in BlockRequested since no CNodeState exists. Fix this by acquiring the lock earlier in FetchBlock.
The lock can be replaced with a net-specific lock when the remaining CNodeState fields are moved to Peer.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 54/100
This commit fixes a rare crash in Bitcoin Core's networking code. When a user called a specific RPC command to fetch a block, the program could crash with an assertion failure if a peer disconnected at exactly the wrong moment. The fix moves a lock earlier so the peer's state cannot be cleaned up while the RPC thread is still using it. It is a stability bug, not a code-execution vulnerability, and requires precise timing to trigger.
Lower-prioritytest: Use SteadyClockContext in pcp_testsby MarcoFalke · fa03852e · Jun 9, 2026 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · MarcoFalke
test: Use SteadyClockContext in pcp_tests
This is easier to reason about, because it will automatically take care of properly setting INITIAL_MOCK_TIME in the ctor. Also, it allows to drop the ElapseTime and replace it with a call to operator+=()
100/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 15/100
This is a small internal cleanup of a test file. It swaps a hand-rolled mock clock helper for a standard test utility called SteadyClockContext. There is no change to the actual Bitcoin network code, no bug fix, and no security-relevant behavior change.
AI review queuedtest: Use FakeNodeClock in more placesby MarcoFalke · fa3716c4 · Jun 9, 2026 · 3 filesMessage 90 · StrongInformational 15Details
Commit message · MarcoFalke
test: Use FakeNodeClock in more places
The context is easier to reason about: E.g.,
* in TestBasicMining it allows to drop manual SetMockTime(0) calls, * in connections_desirable_service_flags it allows to drop manual calls to SetMockTime(GetTime<std::chrono::seconds>() + _n_) and replace them by operator+=(_n_) * in wallet_tests it clarifies that the mocktime does not persist outside the AddTx function
90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only changes Bitcoin Core's internal test code. It replaces the old global SetMockTime() helper with a new local FakeNodeClock object in three test files so that test time adjustments are scoped to each test and easier to read. There is no change to the actual Bitcoin node software that users run, so it cannot affect live wallets, transactions, or network security.
Lower-prioritytest: Add FakeNodeClock m_clock to TestChain100Setupby MarcoFalke · fae9623c · Jun 9, 2026 · 5 filesMessage 100 · StrongInformational 15Details
Commit message · MarcoFalke
test: Add FakeNodeClock m_clock to TestChain100Setup
Currently, all test cases using TestChain100Setup or a derived class like BuildChainTestingSetup are using mocktime by default due to the SetMockTime call in the TestChain100Setup ctor.
This is confusing, because test cases using mocktime explicitly seem to imply that before they set the mocktime, real time was used.
E.g. index_reorg_crash claimed in a comment to "Enable mock time".
Fix this issue by adding a FakeNodeClock m_clock field to TestChain100Setup. Then, use the m_clock instead of explicit calls to SetMockTime or to a (now) shadowing local FakeNodeClock variable.
100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 15/100
This commit is a test-only cleanup. It replaces scattered mock-time calls with a single shared fake clock in the test harness, making test behavior clearer and removing a misleading comment. It does not change production Bitcoin Core code or fix any security bug.
Lower-prioritybench, refactor: Use `std::string_view` for `BenchRunner` ctor parameterby Hennadii Stepanov · a6ed29d6 · Jun 9, 2026 · 2 filesMessage 73 · AdequateInformational 15Details
Commit message · Hennadii Stepanov
bench, refactor: Use `std::string_view` for `BenchRunner` ctor parameter
This avoids implicit conversions from string literals to `std::string`, eliminating the need to include `<string>` everywhere the `BENCHMARK()` macro is used.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100
This is a minor code cleanup in Bitcoin Core's internal benchmarking (performance testing) code. It changes a function parameter from std::string to std::string_view to avoid unnecessary header includes. There is no security relevance.
Lower-priorityci: use llvm 22.1.7by fanquake · 6d47f7cc · Jun 9, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · fanquake
ci: use llvm 22.1.7
50/100 · ThinMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100
This commit simply updates the version of the LLVM compiler toolchain used in automated testing from 22.1.3 to 22.1.7. It is a routine CI maintenance change with no apparent security relevance.
Document why we use LIBCXXABI_USE_LLVM_UNWINDER=OFF.
84/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Explains rationale or failure mode
AI analysis · Informational 15/100
This is a Bitcoin Core continuous integration (CI) build script change. It removes the libunwind runtime from an LLVM/Clang library build used for sanitizer testing and adds a comment explaining why. There is no user-facing code change, no wallet or consensus change, and no security fix or vulnerability introduced.
AI review queuedscripted-diff: Rename UNIQUE_NAME to BITCOIN_UNIQUE_NAMEby Hennadii Stepanov · fba713a2 · Jun 8, 2026 · 5 filesMessage 83 · StrongInformational 15Details
Commit message · Hennadii Stepanov
scripted-diff: Rename UNIQUE_NAME to BITCOIN_UNIQUE_NAME
The `nb30.h` Windows header defines `UNIQUE_NAME` as a macro.
This introduces a fragile dependency on header inclusion order: if Windows headers happen to be included before `UNIQUE_NAME` is used, the preprocessor expands it into a numeric literal, causing syntax errors.
Rename the macro to `BITCOIN_UNIQUE_NAME` to remove this fragility and avoid the collision entirely.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100
This commit is a simple rename of an internal helper macro from UNIQUE_NAME to BITCOIN_UNIQUE_NAME. The change prevents a potential future build failure on Windows because a Windows system header also defines UNIQUE_NAME. It does not change program behavior, fix a vulnerability, or affect live network code.
AI review queuedtest: add coverage for importdescriptor with an encrypted walletby Pol Espinasa · 84d07e47 · Jun 8, 2026 · 1 fileMessage 72 · AdequateInformational 15Details
Commit message · Pol Espinasa
test: add coverage for importdescriptor with an encrypted wallet
72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only adds a new test case to Bitcoin Core's test suite. It checks that trying to import a wallet descriptor into an encrypted wallet fails with a helpful error message when the wallet is still locked. There is no change to production wallet code, no bug fix, and no security vulnerability being addressed.
The cs_LastBlockFile mutex is redundant: all critical sections are already covered by cs_main. This is demonstrated in this patch by replacing all instances of locking cs_LastBlockFile with pairs of `AssertLockHeld(::cs_main)` and `EXCLUSIVE_LOCKS_REQUIRED(::cs_main)` annotations. No additional `::cs_main` LOCK(...)s are introduced.
It is also not clear for which sections `cs_LastBlockFile` is responsible for. It is annotated for `m_blockfile_cursors`, but sporadically and inconsistently also covers `m_blockfile_info`.
Since it has no semantic meaning, and seems confusing to developers, remove it.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 12/100
This commit removes a redundant internal lock called cs_LastBlockFile from Bitcoin Core's block storage code. The developer argues that the lock was unnecessary because another lock, cs_main, already protects the same data. The change replaces the old lock with explicit annotations and checks that cs_main is held. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a code cleanup and simplification.
Lower-prioritytest: Limit clocks to one active instanceby MarcoFalke · 35a814a0 · Jun 8, 2026 · 1 fileMessage 90 · StrongInformational 15Details
Commit message · MarcoFalke
test: Limit clocks to one active instance
SteadyClockContext and FakeNodeClock assume they are the only active instance. Overlapping them in the same scope would silently clobber each other.
Add a CRTP base class, LimitOne, that asserts at construction if another instance already exists.
90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100
This is a test-only change that adds a safety guard to prevent two test helper objects from being used at the same time. It does not affect the live Bitcoin network or production code, and there is no security vulnerability being fixed.