Bitcoin Core

This commit is a straightforward code cleanup: it moves the list of HTTP request methods (GET, POST, HEAD, PUT, UNKNOWN) out of a class and into a shared module-level type so two different parts of the codebase can use the same definitions. There is no security-relevant behavior change.

This is a pure code cleanup change. A single function that handles incoming HTTP requests was split into two functions: one that prepares the raw libevent request and wraps it, and another that performs the existing allow-checks and hands the request to worker threads. No behavior, security checks, or request handling logic was changed.

This commit adds support for HTTP 'chunked' transfer encoding to Bitcoin Core's built-in HTTP server. Before this change, the server only understood requests with a plain Content-Length body. The patch implements chunk-size parsing, chunk-extension handling, trailer skipping, and size limits. It also includes tests for valid, oversized, malformed, and delayed chunked requests. There is no direct evidence in the commit that this fixes a known security vulnerability, but adding chunked parsing is a sensitive network-facing change that could affect availability or request handling if implemented incorrectly.

This commit adds the ability for Bitcoin Core's built-in HTTP server to actually compose and send response messages back to connected clients. Previously, the server could read requests but had a placeholder 'TODO: send data' where replies should go. The change implements HTTP response formatting, buffering, and non-blocking socket sending, plus tests that verify a mock client receives a correct HTTP/1.1 reply. It is a normal feature-completion patch in an unfinished HTTP server refactor; there is no direct evidence it fixes a security bug, but any new network-facing code carries defensive-review interest.

This commit adds the ability for Bitcoin Core's new HTTP server to actually read incoming request data from connected clients. Previously, the server could accept connections but did not read what clients sent. The change is a normal feature addition with no security fix or vulnerability indicator visible in the code or commit message.

This commit only adds a new C++ class definition to a header file. It does not change any existing behavior, fix a bug, or alter how the program handles data. There is nothing here that would allow an attacker to exploit the software.

This commit is a routine internal refactor of Bitcoin Core's HTTP server. It moves connection-accepting logic into a dedicated background I/O thread, mirroring how the peer-to-peer network layer already handles sockets. There is no indication this fixes a security bug or introduces a known vulnerability; it is incremental feature work.

This commit adds a simple internal counter so each incoming HTTP connection can be assigned a unique sequential ID. It does not change any externally visible behavior, fix a bug, or close a security hole. It is a routine code-structure change.

This is a routine code-quality refactor. It changes an internal string-line reader to return lightweight string views instead of making full string copies. There is no security fix or behavior change visible in the commit.

This commit only moves existing HTTP server code into a new namespace called http_libevent. It does not change any behavior, fix any bug, or alter how the software handles network input. It is a pure code-organization change to make future replacements easier to review.

This commit introduces a new internal helper class for parsing and building HTTP headers in Bitcoin Core. It does not change any existing behavior or fix a known bug; it is purely new infrastructure code with tests. There is no indication this commit itself creates or fixes a security issue.

This commit adds a new helper class for formatting HTTP response headers in Bitcoin Core's internal web server. It does not change any existing behavior or fix any known problem; it is purely new infrastructure code with accompanying tests.

This commit adds a new internal HTTPServer class to Bitcoin Core that handles low-level network socket binding and listening for the HTTP RPC server. It is a code refactoring/introduction change with no obvious security bug. The new code is covered by unit tests that use mock sockets, so it does not open real network ports during testing.

This commit adds a new internal method for accepting incoming HTTP connections and includes unit tests for it. It is a routine code refactoring and testing change with no apparent security relevance.

This commit introduces a new HTTP request parser for Bitcoin Core's internal web server. It is a defensive, by-the-book implementation that explicitly rejects malformed request lines, bad HTTP versions, NUL bytes, conflicting Content-Length headers, oversized bodies, and non-numeric content lengths. The code is accompanied by extensive unit tests demonstrating these protections. There is no indication in the commit or supplied references that this fixes a known vulnerability; it appears to be a refactoring or hardening change.

This commit changes a low-level string utility so it no longer strips spaces from the beginning and end of lines it reads. It now only removes the actual line-ending characters (carriage return and newline). The change is described as a correctness fix so callers can decide for themselves whether spaces are allowed. It is not presented as a security fix, but overly aggressive trimming could in principle hide or alter data in network messages such as HTTP headers.

This commit only adds new automated tests to Bitcoin Core. It does not change the actual server code that handles HTTP requests. The tests verify that the existing HTTP server correctly rejects or handles common web attacks such as path traversal, request smuggling, null bytes, invalid HTTP versions, and malformed authentication headers. Because no production code is modified, the commit itself does not introduce or fix a vulnerability.

This is a harmless test-only change. It doubles the RPC timeout in one functional test so that a slow test step (mining a long chain) does not fail due to client-side timeout during parallel debug-mode test runs. It does not change any production Bitcoin Core code, consensus rules, networking, or wallet behavior.

This commit fixes a CI (Continuous Integration) configuration mistake. It restores the intended Docker cache provider for Bitcoin Core's own GitHub workflows, using 'warp' for the official bitcoin/bitcoin repository and 'gha' for forks. There is no security issue in the code change itself.

This commit is a documentation-only metadata change. It adds a new 'placeholder' flag to the internal description of several old, ignored RPC parameters so the help system can label them as kept only for backward compatibility. No code behavior changes, no bug fixes, and no security issue is present.

This commit adds small plumbing so that Bitcoin Core's RPC command metadata (descriptions, argument details, result formats) can be inspected by other code. It does not change any user-facing RPC behavior by itself; it merely exposes internal data structures that were already present. There is no obvious security bug in the diff.

This is a small bug-fix in Bitcoin Core's RPC help system. A special placeholder result type called Type::ANY previously caused the help() command to crash with an 'unreachable' assertion when it appeared inside a nested result description. The change makes it render as 'xxx' with description 'any' instead, matching how other types are displayed. It is a denial-of-service-style crash only for the help() RPC output, not for transaction processing, consensus, or wallet operations.

This commit fixes a bookkeeping bug in Bitcoin Core's RPC command registry. When a command was fully removed (for example, when a wallet is unloaded), the command's name was still left behind in an internal list. That caused tools like `getopenrpcinfo` and `listCommands` to report commands that no longer actually exist. The fix simply deletes the empty entry so removed commands disappear from listings. There is no direct evidence this can be exploited to steal funds or crash nodes, but it could mislead monitoring tools or client software that relies on the command list.

This is a routine code-cleanup change: it adds a missing #include <string_view> to a header file so it no longer depends on other headers to provide the std::string_view type. It does not change any program behavior or fix a security bug.

This commit only adds new unit tests for Bitcoin Core's internal test framework. It checks that a helper class for BIP32 extended keys produces the well-known public test-vector outputs. No production wallet, consensus, or networking code is changed, and no security bug is being fixed.