CommitWatch RSS
BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Source repository ↗
Repository coverage

3170 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

318security candidates668second-pass queue3006AI analyses
149commits · 30 days
333commits · 60 days
1306commits · 180 days
2863commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

71/100 average clarity
1175Strong · 80–100
1206Adequate · 60–79
701Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script2024588389
Antoine Poinsot22422170
Ava Chow19868191069
MarcoFalke41421408074
fanquake23121228058
Lőrinc18121177081
Hennadii Stepanov22316211064
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 1 hour, 1 minute ago

Low 32 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#34371: wallet: allow importprunedfunds for spending transactions

This change fixes a Bitcoin Core wallet bug where the `importprunedfunds` RPC command could only re-import transactions that sent money to the wallet, not transactions that spent money from it. After this fix, both incoming and outgoing tr…

Logic bug in wallet transaction import scopeIncorrect balance possible after removing and re-importing spending transactionFix routes import through existing involvement check (IsMine + IsFromMe)
ed7dd7cfby Ava Chow+36−203 files
No security note in commit
Open full analysis →Source commit ↗
Low 28 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#29278: Wallet: Add `maxfeerate` wallet startup option

This commit adds a new Bitcoin Core wallet startup option called -maxfeerate. It lets users set a maximum fee rate (fee per unit of transaction size) that the wallet will allow when creating or broadcasting transactions. Previously, the wa…

New wallet startup option -maxfeerate to cap transaction fee rateNew transaction error type MAX_FEE_RATE_EXCEEDEDBroadcastTransaction now checks both max absolute fee and max fee rate
f80aaf4bby Ava Chow+303−7930 files
No security note in commit
Open full analysis →Source commit ↗
Moderate 64 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35984: sign: skip signing SIGHASH_SINGLE inputs with no corresponding output

This Bitcoin Core update fixes a wallet-signing quirk. When a user chose the SIGHASH_SINGLE signature mode, an input that had no matching output index would sign essentially nothing meaningful. That signature could then stay valid even if …

Funds-redirection footgun from SIGHASH_SINGLE signatures with no committed outputInconsistent guard between SignTransaction and SignPSBTInput pathsFix centralizes the guard in the low-level signature creator to cover future signing paths
e19f83e9by Ava Chow+37−82 files
Vendor flagged security relevance
Open full analysis →Source commit ↗
Low 35 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35696: i2p: update leaseset encryption types

This change updates Bitcoin Core's I2P (Invisible Internet Project) privacy network settings to use newer, stronger encryption for the published 'leaseset' that describes how other peers can contact a node. The old setting included ElGamal…

Cryptographic algorithm update (ElGamal to MLKEM-768)Use of I2P 'legacy' encryption type removedConfiguration-only change in network privacy layer
65e075f8by Ava Chow+2−21 file
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35948: init: correct first-run disk space estimate

This change fixes a labeling bug in Bitcoin Core's first-run disk-space warning. The estimate was stored in GiB (binary gigabytes, 1024-based) but displayed as GB (decimal gigabytes, 1000-based), and for pruned nodes it showed the full-cha…

d26f19c7by Ava Chow+5−42 files
No security note in commit
Open full analysis →Source commit ↗
Low 44 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36284: wallet: don't double discard output groups with avoidpartialspends

This is a wallet bug, not a theft or remote-code bug. When a Bitcoin Core user turns on the optional 'avoidpartialspends' or 'avoid_reuse' setting, an output group rejected during coin selection could be counted twice as 'discarded.' That …

Logic error causing double-counting of discarded UTXO groupsCan trigger false 'insufficient funds' failure in coin selectionAffects avoidpartialspends / avoid_reuse wallets only
e8e7e91aby Ava Chow+43−14 files
No security note in commit
Open full analysis →Source commit ↗
Informational 18 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35890: doc: use overwrite (>) instead of append (>>) for one-shot PSBT files in offline-signing-tutorial.md

This is a documentation-only fix in a tutorial file. It changes two shell examples from using '>>' (append to file) to '>' (overwrite file). If a user followed the old instructions and ran the same command twice, the file would contain two…

No security signal: change is limited to documentationNo code changes to Bitcoin Core binaries, RPC, wallet, or consensus logicNo cryptographic, network, or privilege-boundary implications
bfdcd979by merge-script+2−21 file
No security note in commit
Open full analysis →Source commit ↗
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35675: mining: add block template manager

This is a large internal code reorganization (refactor) in Bitcoin Core. It creates a new BlockTemplateManager class that takes over block-template creation, block submission, and tip-waiting helpers that were previously spread across seve…

Large refactor touching mining, RPC, interfaces, and test shutdown pathsNew object lifetime dependency: BlockTemplateManager holds references to mempool, chainman, and notifications; explicit reset ordering added in Shutdown/InitAndLoadChainstate/test setupsRemoval of early-init node.mining interface; BlockTemplateManager is now created after chainstate load, with a comment that it must exist before setChainstateLoaded(true) unblocks IPC waiters
5c726f20by Ryan Ofsky+561−44926 files
No security note in commit
Open full analysis →Source commit ↗
Informational 12 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35301: Silent Payments: Implement bip352 (take 2)

This commit adds the first implementation of BIP352 (Silent Payments) to Bitcoin Core. Silent Payments are a new type of privacy-preserving Bitcoin address that lets someone receive payments without publicly revealing a fixed address. The …

New cryptographic feature implementation (BIP352 Silent Payments)Extensive use of secp256k1 silentpayments moduleInput public key extraction from P2PKH, P2WPKH, P2SH-P2WPKH, and P2TR inputs
be5d0b55by Ava Chow+6951−010 files
No security note in commit
Open full analysis →Source commit ↗
Low 45 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35440: wallet: check descriptor cache xpub length before decoding

This update fixes a wallet database loading bug where a damaged or tampered Bitcoin wallet file could cause the program to read past the end of a stored extended public key (xpub). The patch makes the loader check the stored xpub length be…

Out-of-bounds read in wallet descriptor cache deserializationASan container-overflow triggered by malformed on-disk recordMissing length validation between record size prefix and fixed-size decoder
b3f846ecby Ava Chow+225−8511 files
Vendor flagged security relevance
Open full analysis →Source commit ↗
Informational 20 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35813: wallet, rpc: Add listrawtransactions RPC

This commit adds a new wallet RPC called listrawtransactions to Bitcoin Core. It is a feature addition that lets users list every transaction their wallet knows about, including internal transfers and consolidations that the existing listt…

No security-relevant bug fix or vulnerability patch is present in the diff.New RPC exposes additional wallet transaction metadata, but only to callers already authorized for wallet RPCs.Code is a refactor of existing gettransaction logic into shared helpers; no new cryptographic, network, or consensus code.
2b95b45aby Ava Chow+334−276 files
No security note in commit
Open full analysis →Source commit ↗
Moderate 68 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35752: wallet: make encryption state updates atomic

This Bitcoin Core update fixes several wallet bugs where a failed database write could leave a wallet in an inconsistent state. For example, encrypting a wallet or changing its passphrase could appear to succeed in memory while the change …

Atomicity fix for encryption state and descriptor key persistenceFailure to persist master key during encryption previously reported success in memoryPassphrase change could activate new passphrase only in memory
7ee3d622by Ava Chow+379−16418 files
Vendor flagged security relevance
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35619: test: ExtendedPrivateKey follow-ups

This commit only changes Bitcoin Core's internal functional test code. It replaces hard-coded test keys and addresses with ones generated from a new test helper class, and unifies how tests tell nodes not to create a default wallet. There …

248ce46fby merge-script+18−244 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36261: test: cover PSBT unknown field merging

This commit only adds a new automated test to Bitcoin Core. It checks that when two partially-signed Bitcoin transactions (PSBTs) are combined, any custom 'unknown' data fields attached to them are preserved correctly. There is no change t…

bbc40edeby merge-script+130−01 file
No security note in commit
Open full analysis →Source commit ↗
Informational 18 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36230: wallet: Improve `HasWalletDescriptor` performance and other canonical descriptor string followups

This is a Bitcoin Core wallet maintenance patch. It speeds up a wallet function that checks whether a descriptor already exists by caching a hash of the descriptor's canonical text, instead of rebuilding that text every time. It also tidie…

No security-relevant signal in commit message or diffChange is described as performance improvement and code cleanupBackwards-compatibility test notes a known miniscript wallet loading incompatibility between v31.0/v31.1 and other versions, but this is a documented compatibility quirk, not a vulnerability
4a583f38by merge-script+97−429 files
No security note in commit
Open full analysis →Source commit ↗
Informational 21 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36297: rpc: Correct invalid OpenRPC defaults

This is a documentation-only fix for Bitcoin Core's machine-readable RPC help data. It changes several default values from literal strings to 'hint' labels (because the real default depends on context) and corrects one boolean default from…

OpenRPC schema/default mismatch correctionRPC help metadata type correction (string 'false' to boolean false)No executable code path changes
5f05d8c5by merge-script+6−63 files
No security note in commit
Open full analysis →Source commit ↗
Informational 20 AI analysisMessage 68 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

rpc: Correct OpenRPC default metadata

This commit fixes documentation metadata for six Bitcoin Core RPC arguments. It changes how default values are described so that automatically generated API docs and schemas are accurate. The actual behavior of the software when running is…

No runtime code changesOnly RPC help/schema metadata modifiedVendor explicitly states runtime behavior is unchanged
b7f740c5by will+6−63 files
No security note in commit
Open full analysis →Source commit ↗
Informational 24 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36286: crypto: Fix MuHash3072 division by itself

This commit fixes a bug in Bitcoin Core's MuHash3072 cryptographic code where dividing a MuHash object by itself (x /= x) produced the wrong mathematical result. The fix is straightforward: the code now saves the divisor's numerator before…

Cryptographic correctness bug in MuHash3072 division operatorSelf-aliasing in operator/= produces incorrect 1/D result instead of empty setNo production code path identified that triggers self-division
d48e76e6by merge-script+11−13 files
No security note in commit
Open full analysis →Source commit ↗
Informational 18 AI analysisMessage 93 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36285: refactor: Use static const over inline const to work around ld64 bug

This is a build-compatibility fix, not a security patch. It changes how some constant data is stored internally so that Apple's macOS linker (ld64) can build Bitcoin Core correctly. The change avoids a linker bug that caused build failures…

No security-relevant code logic changedChange is a linker bug workaround, not a vulnerability fixConstants remain read-only; no new attack surface introduced
ad97933aby merge-script+8−82 files
No security note in commit
Open full analysis →Source commit ↗
Informational 23 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#34861: wallet: Add importdescriptors interface

This commit refactors Bitcoin Core's wallet descriptor import feature so the same logic can be used by both the RPC command and a new GUI-facing interface. It also tightens one input rule: negative timestamps are now rejected, and the mini…

Refactor of security-sensitive wallet import code into shared CWallet pathNew input validation: negative timestamps rejected for importdescriptorsCentralization of descriptor range bound checks in CheckDescriptorRangeBounds
2bbbeaa6by Ava Chow+619−26415 files
No security note in commit
Open full analysis →Source commit ↗
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-prioritynet: add an add_even_if_unreachable argument to AddLocalby will · f4af02e8 · Jul 7, 2026 · 2 filesMessage 73 · AdequateInformational 15Details
Commit message · will

net: add an add_even_if_unreachable argument to AddLocal

Prepare for letting explicitly configured local addresses bypass the
reachable-net filter without tying that behavior to LOCAL_MANUAL score.

Pass an `add_even_if_unreachable` bool through `AddLocal()`, defaulting
to `false`.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a small, non-functional code cleanup. It adds a new optional parameter to an internal networking function so that a future change can allow user-specified local addresses to bypass a network-reachability check. The new parameter defaults to false, so existing behavior is unchanged. There is no security bug or fix here.

Lower-prioritynet: optimize compact block extra tx iterationby Lőrinc · 1a3cbf1b · Jul 6, 2026 · 1 fileMessage 68 · AdequateInformational 16Details
Commit message · Lőrinc

net: optimize compact block extra tx iteration

`vExtraTxnForCompact` was resized to its configured capacity on the first insertion.
Before the ring was filled, compact block reconstruction scanned default `{Wtxid::ZERO, nullptr}` entries created for unused slots.

Reserve the configured capacity and append entries until the cache is full, then keep the same ring-buffer overwrite behavior.
This preserves the configured maximum and replacement order while keeping reconstruction from scanning unused capacity.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 16/100

This is a small performance cleanup in Bitcoin Core's network code. A temporary cache used when reconstructing compact blocks used to be fully sized up front, meaning the code would repeatedly scan empty placeholder slots. The change instead grows the cache only as it fills, so reconstruction skips unused slots. There is no direct security vulnerability being fixed; it is an optimization that may slightly reduce CPU work during block reconstruction.

Lower-prioritydoc: archive release notes for v31.1by fanquake · 2b6e767d · Jul 6, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · fanquake

doc: archive release notes for v31.1

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit simply archives the release notes for Bitcoin Core version 31.1. It adds a documentation file summarizing what changed in that release, but does not change any program code. There is no direct security risk from this documentation-only change.

Lower-priorityp2p: Don't participate in addr relay with feeler connectionsby Daniela Brozzoni · b0735336 · Jul 6, 2026 · 2 filesMessage 83 · StrongInformational 19Details
Commit message · Daniela Brozzoni

p2p: Don't participate in addr relay with feeler connections

Feeler connections are short-lived connections made to check that a node
is alive, useful for test-before-evict from addrman, and for moving
addresses from the new to the tried table.

We currently send a GETADDR message to feelers, but then disconnect
before being able to receive a response. This wastes some bandwidth, so
we can avoid sending the GETADDR altogether.

Not sending the initial GETADDR will effectively disable addr relay:
we initialize addr relay for the peer when we send GETADDR, and the peer
initializes addr relay to us when they receive it. So the
peer will not relay any announcement to us, and we will not relay any
to them either. This is ok, since the use of feelers is to test if there
is a bitcoin node behind an address, not exchange addresses with them.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 19/100

This change is a small network-efficiency cleanup, not a security fix. Bitcoin Core's 'feeler' connections are brief probes used to check whether another node is online. Previously, the software would ask feeler peers for addresses (sending a GETADDR message) even though it disconnects almost immediately and never reads the reply. The patch stops that unnecessary request, saving a little bandwidth. It does not fix a vulnerability and does not change how attackers could interact with the network.

Lower-priorityinit: wake genesis wait after ImportBlocks() returnsby ismaelsadeeq · c1313b19 · Jul 6, 2026 · 2 filesMessage 83 · StrongLow 30Details
Commit message · ismaelsadeeq

init: wake genesis wait after ImportBlocks() returns

If shutdown interrupts ImportBlocks() before genesis activation,
no blockTip notification is sent. The wait predicate allows
shutdown to occur, but the condition variable is never
notified, so init can remain stuck waiting for genesis activation.

Notify the tip condition variable after ImportBlocks() returns so
interrupted imports wake the wait and let it observe the shutdown request.

Add test coverage for interrupting startup after reindex block files import
begins, which exercises the path where ImportBlocks() can return before genesis
activation.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Low 30/100

This commit fixes a bug where Bitcoin Core could hang during shutdown if the user started a 'reindex' and then asked the program to quit before it finished loading the very first block. The fix adds a notification so the shutdown request is noticed, plus a test that simulates this exact scenario. It is a reliability/availability fix, not a security vulnerability that an attacker can exploit.

Lower-priorityrefactor: Use `NetworkErrorString` for macOS code in `netif.cpp`by Hennadii Stepanov · eccb04a3 · Jul 6, 2026 · 1 fileMessage 97 · StrongInformational 15Details
Commit message · Hennadii Stepanov

refactor: Use `NetworkErrorString` for macOS code in `netif.cpp`

Although these `sysctl` calls report generic system errors rather
than network errors, `NetworkErrorString()` is identical to
`SysErrorString()` on POSIX systems, so this does not change behavior.
It allows removing `#include <util/syserror.h>`, which was only needed
by `__APPLE__` code and would otherwise require an `#ifdef` guard to
silence an IWYU unused-include warning on other platforms.

97/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Informational 15/100

This is a minor code cleanup in Bitcoin Core. It swaps one internal error-message helper for another that produces the exact same text on macOS and Linux, and removes an unused header include. There is no functional change and no security impact.

Lower-priorityci: ensure we use correct lld version in OpenBSD jobby fanquake · 22ac4ad9 · Jul 6, 2026 · 1 fileMessage 77 · AdequateInformational 15Details
Commit message · fanquake

ci: ensure we use correct lld version in OpenBSD job

If we don't suffix with -${APT_LLVM_V}, then lld-21 will be installed.

77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
AI analysis · Informational 15/100

This is a minor continuous-integration (CI) build fix for Bitcoin Core's OpenBSD cross-compilation job. It changes one package name so the build system installs the matching version of the LLVM linker (lld-22) instead of accidentally installing a different version (lld-21). It does not change any code that runs on users' wallets, nodes, or the Bitcoin network, and there is no security issue here.

Lower-prioritydepends: move FreeBSD SDK handling to CIby fanquake · 244739db · Jul 6, 2026 · 3 filesMessage 76 · AdequateInformational 15Details
Commit message · fanquake

depends: move FreeBSD SDK handling to CI

As pointed out by Hebasto, the approach used in #35397 and #35412 is
better, rather than hardcoding flags and putting the SDK handling into
depends.

76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 15/100

This commit is a build-system cleanup. It moves the handling of the FreeBSD software development kit (SDK) out of the shared dependency build files and into the continuous integration (CI) configuration. The actual compiler flags and download logic remain essentially the same; they are just placed in a more appropriate file. There is no user-facing change and no security fix or vulnerability introduced.

Lower-priorityci: FreeBSD 15.1by fanquake · 495f43f7 · Jul 6, 2026 · 1 fileMessage 40 · ThinInformational 15Details
Commit message · fanquake

ci: FreeBSD 15.1

40/100 · ThinMessage clarity
✓ Subject identifies a change✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This commit simply updates the FreeBSD version number used in automated testing from 15.0 to 15.1. It is a routine CI (continuous integration) maintenance change with no security relevance.

Lower-prioritytest: add CHECKSIGVERIFY/CHECKMULTISIGVERIFY failure script test vectorsby azuchi · a86a96d1 · Jul 6, 2026 · 1 fileMessage 72 · AdequateInformational 15Details
Commit message · azuchi

test: add CHECKSIGVERIFY/CHECKMULTISIGVERIFY failure script test vectors

72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 15/100

This commit only adds two new test cases to a JSON test file used by Bitcoin Core's automated test suite. The tests verify that certain script operations (CHECKSIGVERIFY and CHECKMULTISIGVERIFY) produce the expected error codes when they fail. No production code was changed, so this cannot introduce or fix a security vulnerability on its own.

AI review queuedSquashed 'src/ipc/libmultiprocess/' changes from 3edbe8f67c1..16bf05dea02by Ryan Ofsky · 6b0a9073 · Jul 5, 2026 · 25 filesMessage 91 · StrongLow 34Details
Commit message · Ryan Ofsky

Squashed 'src/ipc/libmultiprocess/' changes from 3edbe8f67c1..16bf05dea02

16bf05dea02 Merge bitcoin-core/libmultiprocess#302: refactor: rename EventLoop::m_num_clients to m_num_refs
dd537da9e40 Merge bitcoin-core/libmultiprocess#301: test: recursive async IPC calls and cleanups
400291de000 Merge bitcoin-core/libmultiprocess#299: ci: remove libevent from Core CIs
092be515adf Merge bitcoin-core/libmultiprocess#285: Add ReadList helper
5b617880c51 Merge bitcoin-core/libmultiprocess#283: Add `makePool` method on `ThreadMap`
d4998304154 refactor: rename EventLoop::m_num_clients to m_num_refs
6450345c985 type: reserve first when reading std::unordered_set
4d0f8db5f99 proxy: add ReadList helper and dedup map/set/vector read handlers
0e49d911867 Add `makePool` method on `ThreadMap`
5519f7f9485 test: recursive async IPC calls
a29ceff40bc ci: remove libevent from Core CIs
8412fcdc659 Merge bitcoin-core/libmultiprocess#295: Mark Waiter m_cv as guarded by m_mutex
1593ee2d18a Merge bitcoin-core/libmultiprocess#294: test: Add passDouble smoke test
9885d7dd33c Merge bitcoin-core/libmultiprocess#286: proxy-client: fix TSan data race in clientDestroy
fa35501c4f0 Mark Waiter m_cv as guarded by m_mutex
faaedb11f8a test: Add passDouble smoke test
733c64318d1 Merge bitcoin-core/libmultiprocess#292: type-number: fix clang-tidy modernize-use-nullptr
9cc3479ab33 Merge bitcoin-core/libmultiprocess#291: cmake: Add `mp_headers` custom target
201abd9e3a5 Merge bitcoin-core/libmultiprocess#289: cmake: make target_capnp_sources use CURRENT dirs
99820c8aecb Merge bitcoin-core/libmultiprocess#279: doc: Add comments to FIELD_* constants in proxy.h
73b985540c5 Merge bitcoin-core/libmultiprocess#278: doc: Fix and expand design.md
e7e91b2e23e Merge bitcoin-core/libmultiprocess#277: Add std::unordered_set support and a helper BuildList to dedup list build handlers
91a951f59ac tidy fix: modernize-use-nullptr
16362f42d01 cmake: Add `mp_headers` custom target
615a94fe3a2 cmake: document ONLY_CAPNP option in target_capnp_sources
90982f75c6b mpgen: iwyu changes required by previous commit
25bb3e67f39 proxy-client: fix TSan data race in clientDestroy
620f297f311 cmake: make target_capnp_sources use CURRENT dirs
9de4b885aa6 test: use camelCase + $Proxy.name for FooStruct fields
011b91793dd type: add std::unordered_set support
20d19b9644e proxy: add BuildList helper and dedup map/set/vector build handlers
e863c6cdf61 doc: Add comments to FIELD_* constants in proxy.h
18db0ab9570 doc: Fix and expand design.md
61de6975362 Merge bitcoin-core/libmultiprocess#273: proxy-client: tolerate exceptions from remote destroy during cleanup
9cec9d6ca55 Merge bitcoin-core/libmultiprocess#243: mpgen: support primitive std::optional struct fields
4aaff113745 Merge bitcoin-core/libmultiprocess#238: cmake, ci: updates for recent nixpkgs
2ac55a56b58 Merge bitcoin-core/libmultiprocess#218: Better error and log messages
6de92e1c732 proxy-client: tolerate exceptions from remote destroy during cleanup
90be8354d47 test: regression for ~ProxyClient destroy after peer disconnect
3c69d125a17 Merge bitcoin-core/libmultiprocess#260: event loop: tolerate unexpected exceptions in `post()` callbacks
b8a48c65e60 event loop: tolerate unexpected exceptions in `post()` callbacks
f787863d2cd Merge bitcoin-core/libmultiprocess#270: doc: Bump version 10 > 11
a22f6029103 doc: Bump version 10 > 11
4eae445d6d8 debug: Add TypeName() function and log statements for Proxy objects being created and destroyed
f326c5b1b7b logging: Add better logging on IPC server-side failures
6dbfa56a040 mpgen: support primitive std::optional struct fields
8d1277deb55 mpgen refactor: add AccessorType function
db716bbcba7 mpgen refactor: Move field handling code to FieldList class
db7acb3ce27 ci: Fix shell.nix compatibility with CMake 4.0
91a7759a9ab cmake: Fix IWYU in nix by adding CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES

git-subtree-dir: src/ipc/libmultiprocess
git-subtree-split: 16bf05dea02651f75733ff08531181aa774fc5a8

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Low 34/100

This is a routine subtree update that pulls in a new version of the libmultiprocess IPC helper library used by Bitcoin Core. The changes include bug fixes, new features (thread pools, unordered_set support, optional primitive fields), and code-quality improvements. The most security-relevant change is a fix for a crash during teardown: a remote 'destroy' RPC that fails after the peer disconnects could previously throw an exception out of a noexcept destructor, causing the program to abort. The patch now catches and logs that exception instead. Other changes harden error handling and thread-safety annotations but do not appear to introduce new vulnerabilities.

Lower-priorityrefactor: Drop support for FreeBSD < 14by Hennadii Stepanov · 2bab6bc7 · Jul 4, 2026 · 1 fileMessage 72 · AdequateInformational 16Details
Commit message · Hennadii Stepanov

refactor: Drop support for FreeBSD < 14

The current supported FreeBSD releases are 15.1 and 14.4.

72/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
AI analysis · Informational 16/100

This is a cleanup change that removes support for older FreeBSD versions (before 14.0) from a single networking source file. It does not fix a security bug, add new behavior, or change how Bitcoin Core runs on currently supported systems. The only practical effect is that the code no longer contains special handling for FreeBSD 13.x, which is no longer a supported operating system release.

Lower-priorityrefactor: Remove FreeBSD-specific workaroundby Hennadii Stepanov · 91b5c8a0 · Jul 4, 2026 · 1 fileMessage 80 · StrongInformational 15Details
Commit message · Hennadii Stepanov

refactor: Remove FreeBSD-specific workaround

The bug has been fixed upstream for in supported FreeBSD releases:
- 15.x: commit 4261507a5e3e73ef6f9535935d22785056954b19
- 14.x: commit 4fa4e6a3c80eb3a4f34877fcff60016e93e4be9d

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This is a cleanup change that removes a temporary compatibility fix for newer FreeBSD versions. The workaround was only needed because of a bug in FreeBSD's system headers, and that bug has now been fixed in supported FreeBSD releases. There is no security issue in the change itself.

Lower-prioritydoc: Clarify supported *BSD releasesby Hennadii Stepanov · 56701ff6 · Jul 4, 2026 · 3 filesMessage 68 · AdequateInformational 15Details
Commit message · Hennadii Stepanov

doc: Clarify supported *BSD releases

This change establishes a baseline for the oldest *BSD releases
supported by Bitcoin Core. Clarifying these minimum requirements paves
the way for dropping compatibility code and workarounds for unsupported
versions.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only updates three documentation files to clarify which versions of FreeBSD, NetBSD, and OpenBSD Bitcoin Core supports. No code was changed, and there is no security issue.

Lower-priorityrefactor: Drop unneeded `<sys/types.h>` include before `<ifaddrs.h>`by Hennadii Stepanov · 22c328d3 · Jul 4, 2026 · 2 filesMessage 85 · StrongInformational 15Details
Commit message · Hennadii Stepanov

refactor: Drop unneeded `<sys/types.h>` include before `<ifaddrs.h>`

Pure `getifaddrs()`/`freeifaddrs()` calls do not need any type
definitions beyond those provided by `<ifaddrs.h>` itself.

The subsequent `struct ifaddrs` processing in `netif.cpp` does not
involve any symbols from `<sys/types.h>`.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit simply removes an unnecessary C system header include (`<sys/types.h>`) from two files that already include `<ifaddrs.h>`. It is a code cleanup with no functional change and no security relevance.

AI review queueddoc: add release notesby Andrew Toth · 6d0ea4cf · Jul 4, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Andrew Toth

doc: add release notes

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates release note wording for a previous feature change. It does not modify any executable code, network behavior, or data handling. There is no security issue here.

Lower-prioritytxospenderindex: disable bloom filters to optimize disk usageby Andrew Toth · a2b1c869 · Jul 4, 2026 · 6 filesMessage 73 · AdequateInformational 15Details
Commit message · Andrew Toth

txospenderindex: disable bloom filters to optimize disk usage

LevelDB bloom filters are only consulted on Get point reads.
They are not consulted for iterator seeks.
txospenderindex only reads via iterator seeks, so building
them is wasted effort and space.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This change is a straightforward performance and disk-space optimization. It adds an option to disable LevelDB bloom filters for database instances that only scan through data with iterators, because bloom filters only help when looking up individual records directly. The txospenderindex is updated to use this new option. There is no security bug being fixed here.

Lower-priorityfuzz: Remove ConsumeUniValueby marcofleon · 9f3e4272 · Jul 3, 2026 · 3 filesMessage 68 · AdequateInformational 15Details
Commit message · marcofleon

fuzz: Remove ConsumeUniValue

The helper created a UniValue with hard-coded constants, which
isn't ideal for fuzz tests. Replace it in the ipc fuzz test with
parsing a UniValue directly from the fuzzed data provider.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 15/100

This commit removes a fuzz-test helper that built a UniValue from hard-coded constants and replaces it with parsing a UniValue from random fuzz data. It only affects test code and does not change production behavior or fix a security vulnerability.

Security candidatedoc: improve offline-signing-tutorial after 32489by Pablo Martin · 68cb7840 · Jul 3, 2026 · 1 fileMessage 76 · AdequateInformational 15Details
Commit message · Pablo Martin

doc: improve offline-signing-tutorial after 32489

General improvements noted in the #32489 review and deferred by the
author:

- Remove a stale NOTE referencing walletcreatefundedpsbt; the tutorial
was updated to use the send RPC instead.
- Fix listtransactions example output from {...} to [...]; the RPC
returns a JSON array, not an object.

76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathdocumentation-only discount
AI analysis · Informational 15/100

This commit only fixes two small mistakes in a documentation file: it removes an outdated note and corrects a JSON example from curly braces to square brackets. There is no code change and no security impact.

Lower-prioritydoc: Add release notes for 32489 (exportwatchonlywallet RPC)by Pablo Martin · cddbad32 · Jul 3, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Pablo Martin

doc: Add release notes for 32489 (exportwatchonlywallet RPC)

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only adds documentation: a new release-notes file describing a previously merged feature (`exportwatchonlywallet` RPC). There is no code change, no bug fix, and no security-relevant behavior change in this patch.

Lower-prioritydoc: add an AI contribution policyby will · 31abaa26 · Jul 2, 2026 · 6 filesMessage 68 · AdequateInformational 15Details
Commit message · will

doc: add an AI contribution policy

Document project expectations for AI-assisted contributions so contributors
understand when AI use is acceptable and when it creates review or moderation
burden.

Link to the document directly from the new PR and issues helptext.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit is purely administrative: it adds a written policy telling contributors how they may use AI tools (like ChatGPT) when filing bug reports, feature requests, and pull requests. It does not change any Bitcoin software code, network rules, or security mechanisms. There is no security vulnerability here.

AI review queuedwallet: Add CWallet::ExportWatchOnlyby Ava Chow · 444878ef · Jul 2, 2026 · 3 filesMessage 58 · ThinInformational 19Details
Commit message · Ava Chow

wallet: Add CWallet::ExportWatchOnly

ExportWatchOnly produces a watchonly wallet file from a CWallet. This
can be restored onto another instance of Bitcoin Core to allow that
instance to watch the same descriptors, and also have all of the same
initial address book and transactions.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit adds a new Bitcoin Core feature that lets a user export a copy of their wallet containing only public information (watch-only). It creates a separate wallet file with descriptors, address book, transactions, and locked coins, but explicitly excludes private keys. The change is a feature addition, not a fix for a known vulnerability. There is no evidence in the commit or supplied references that this is a security patch or that it addresses any reported security issue.

AI review queuedwallet, rpc: Add exportwatchonlywallet RPCby Ava Chow · d053e3e5 · Jul 2, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Ava Chow

wallet, rpc: Add exportwatchonlywallet RPC

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit adds a new wallet command called exportwatchonlywallet. It lets a user save a copy of their wallet that contains only public information—public descriptors, transactions, and address book data—without private keys. The change is purely additive and exposes no new security weakness based on the code shown.

AI review queuedtest: Test for exportwatchonlywalletby Ava Chow · a3880764 · Jul 2, 2026 · 2 filesMessage 57 · ThinInformational 15Details
Commit message · Ava Chow

test: Test for exportwatchonlywallet

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit adds a new automated test file for the exportwatchonlywallet feature in Bitcoin Core. It does not change any production wallet code; it only verifies that exporting a watch-only wallet correctly preserves descriptors, address labels, transactions, locked coins, and settings. There is no security issue in the diff itself.

Security candidatedoc: update offline-signing-tutorial to use exportwatchonlywallet rpcby Pol Espinasa · a15bdc05 · Jul 2, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Pol Espinasa

doc: update offline-signing-tutorial to use exportwatchonlywallet rpc

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet pathdocumentation-only discount
AI analysis · Informational 15/100

This is a documentation-only update to the Bitcoin Core offline-signing tutorial. It replaces instructions that used manual descriptor export/import with instructions that use a newer built-in RPC command (exportwatchonlywallet / restorewallet). No code behavior changed, and there is no security vulnerability in the commit.