Sparrow Wallet

This commit adds a safety feature for a new Bitcoin privacy technology called 'silent payments.' It records the relationship between a regular-looking payment address and its silent-payment counterpart in the wallet's database. The main goal is to prevent users from accidentally breaking silent-payment outputs when they later modify (RBF) a transaction, such as by removing inputs. The commit also blocks one risky UI action with a warning dialog when such a change would be unsafe.

This commit fixes a concurrency bug in Sparrow Wallet's Electrum server connection code. Previously, a single read lock was held continuously while waiting for data from the server, which could starve or block other client requests. The change releases that lock during socket reads and restructures the read loop so responses are delivered only when the lock is held. This is a reliability/performance fix that reduces the chance of the wallet becoming unresponsive or misbehaving when talking to an Electrum server, but it is not a direct theft-of-funds vulnerability.

This commit tightens which Bitcoin signature hash (sighash) types users can pick when sending to a silent payment address. Previously the UI offered all normal signing options; now it forces the recommended/required sighash (ALL for non-taproot, DEFAULT for taproot) and labels it as required. The change is defensive: using the wrong sighash type with silent payments could break privacy or make the transaction invalid, so the wallet now prevents that choice.

This commit removes the 'Receive To' button and menu option for a specific type of wallet called a 'single sig single purpose' (SINGLE_SP) wallet. Previously, these receive actions were shown for all wallets except BIP47 (PayNym) wallets. The change appears to be a UI hardening measure to prevent users from accidentally or inappropriately reusing addresses in wallets that are intended to be used only once.

This commit is a user-interface polish change for the Sparrow Wallet desktop app. It hides the 'Rescan Wallet' hyperlink when the wallet has already been scanned as far back as possible, and shows a helpful label instead. There is no indication it fixes a security vulnerability.

This commit changes Sparrow Wallet so that newly created or renamed single-signature (SINGLE_SP) wallets get a default 'birth date' set to the current time. The birth date tells the wallet how far back in the blockchain it needs to scan for transactions. Without it, the wallet would perform a full rescan of the entire blockchain, which is slow and resource-intensive. The change is a performance/usability improvement, not a security fix.

This commit changes how Sparrow Wallet decides whether a message from an Electrum server is a subscription notification. Previously it used a simple text search (looking for the word 'method' and absence of the word 'error'), which could be fooled by JSON strings containing those words. Now it uses a proper JSON parser to check whether the message actually has a 'method' field at the top level. This is a hardening fix: the old approach could misclassify server responses, possibly causing user notifications to be missed or processed incorrectly. There is no direct evidence in the commit that this was exploited or treated as a security bug by the vendor.

This commit fixes a small logic bug in how Sparrow Wallet caches scans for silent payments (a privacy-preserving way to receive Bitcoin). During a specific multi-step process called 'widening rollback,' if the user or a server disconnect had already cancelled the scan, the code could accidentally un-cancel it and restore old cached data. The fix simply checks 'if already cancelled, stay cancelled' before restoring the snapshot. It is a correctness/reliability fix rather than a direct theft-of-funds vulnerability, but it could cause the wallet to miss or misreport silent-payment transactions after a cancellation.

This commit fixes a display timing issue in the Sparrow bitcoin wallet. When a user makes a payment to themselves (a 'self-spend'), the wallet could briefly show an incomplete transaction notification—showing the money leaving but not the matching change coming back. The patch pre-fills internal wallet records so the first notification is complete and accurate. It is a correctness/UX fix, not a vulnerability that lets an attacker steal funds.

This commit adjusts network waiting periods when Sparrow Wallet connects to a Bitcoin server through the Tor privacy network. It gives Tor connections slightly more time before retrying, likely to reduce false failures caused by Tor's slower routing. There is no indication this fixes an exploitable security flaw.

This commit removes one of several ways Sparrow Wallet can broadcast Bitcoin transactions to the network. The deleted code supported broadcasting through Bisq's market service (both a clearnet website and a Tor onion address). It is a simple feature removal with no obvious security bug being fixed in the code itself.

This commit changes how Sparrow Wallet's connection to Electrum servers handles replies. Previously, the app tried to match an entire sent request object to a received response object to decide if the reply belonged to the current request. The new code instead compares only the numeric 'id' fields found in the JSON, and keeps reading and discarding any responses whose ids don't match. It also adds optional wire-level logging. The change is a defensive fix against 'stale' or out-of-order server responses being mistaken for the answer to the current request.

This commit simply swaps the web and Tor addresses used by Sparrow Wallet to broadcast Bitcoin transactions through the Bisq mempool service. It changes one line in a list of broadcast sources, replacing 'mempool.bisq.services' with 'markets.bisq.network' and updating the corresponding onion address. There is no code logic change and no indication of a security vulnerability being fixed.

This commit fixes how Sparrow Wallet updates its internal records when a user sends bitcoin to themselves using a 'silent payment' address. Previously, the wallet could fail to mark the coins being spent as spent, or could show an incorrect balance, because the wallet's update logic did not properly handle transactions discovered through the silent-payment channel. The patch makes the wallet consider both newly discovered silent-payment outputs and the inputs they spend in a single atomic update, and it also improves how broadcast transactions are tracked before they are sent to the network.

This commit changes how Sparrow Wallet creates address nodes when scanning silent payments. Previously, the wallet would fill a range of address indexes up to a target and then mark the matching one as a 'silent payment tweak' address. The new code adds a dedicated method that creates only the single silent-payment child node with its tweak value already set. The change appears intended to prevent silent-payment addresses from being created without their associated tweak data, which could otherwise lead to incorrect or missing balance tracking in single-sig (sp) wallets.

This commit is a code cleanup in Sparrow Wallet's transaction diagram display. It changes how the wallet classifies and draws transaction outputs on screen, introducing new output wrapper types for silent-payment change and consolidation. There is no direct evidence in the commit that it fixes a security vulnerability; it appears to be a UI refactor with minor correctness improvements.

This commit fixes a bug in Sparrow Wallet's silent payments feature. Previously, when scanning for incoming silent payments, the wallet only looked at transactions it had not already seen. This meant it could miss a special kind of transaction: one where the user sends bitcoin to themselves (a 'self-spend'). Because the wallet already knew about the transaction, it skipped re-scanning it for silent payment outputs, potentially causing the wallet to not display or account for those funds. The fix makes the wallet scan all relevant transactions, whether already known or not.

This commit adds support for loading and refreshing 'silent payments' (a newer Bitcoin privacy feature) wallets in Sparrow. It introduces server subscription management, scan caching, and UI wiring. There is no direct evidence in the commit of a security vulnerability, but the new code handles private scan keys and network state, so correctness matters. The change is large and touches concurrency, making subtle bugs possible, but nothing in the diff clearly enables theft, remote code execution, or data leakage.

This commit is a straightforward internal code cleanup: it moves the logic that fetches wallet transaction history out of a nested background-service class and into the main ElectrumServer class. The actual behavior, synchronization, and data flow remain essentially unchanged. There is no indication this fixes or introduces a security issue.

This commit adds support for a new Bitcoin privacy feature called 'silent payments' in the Sparrow Wallet. It lets the wallet ask compatible servers to scan for silent-payment transactions and report them back. The change also improves how Sparrow detects what a server can do, and it makes one error type more specific when Bitcoin Core cannot handle silent payments. There is no obvious security bug in the diff, but it does involve sending private scanning keys to an external server, which is inherent to the silent-payments protocol and is now done through a new RPC call.

This commit expands the list of hardware-wallet and air-gapped importers that Sparrow Wallet shows when a user creates a single-signature wallet using a 'single SP' policy type. Previously only ColdcardSinglesig was offered; now all singlesig file importers (Jade, Keystone, Passport, SeedSigner, etc.) and all card importers (Tapsigner, Satochip, etc.) are available. The change also broadens an exception handler in SpecterDIY so that non-IO errors during import are reported to the user instead of crashing or being swallowed. There is no direct security vulnerability in the diff; it is a feature/robustness improvement.

This commit simply swaps one SVG logo image for another in the Sparrow Wallet application. It changes the visual icon used for the BitView fee-rate source from a plain square to a stylized cube logo. There is no code change, no executable logic, and no security-relevant behavior.

This commit adds the ability to import a new kind of Bitcoin wallet—called a 'silent payment' (SP) singlesig wallet—through the same screens and file formats that already supported ordinary HD singlesig wallets. It updates dropdown menus, import logic, and several hardware-wallet/file parsers so users can choose between HD and SP when importing. There is no direct evidence in the commit of a security vulnerability; it reads as a feature expansion with explicit guardrails (some importers reject SP if they cannot support it).

This commit is a small internal cleanup: it stops converting a hardware wallet's extended public key (xpub) to a text string and back again, and instead keeps it as a typed object throughout the code. There is no visible user-facing change and no indication of a security fix.

This commit adds support for importing a special Bitcoin 'silent payments' scanning key from connected hardware wallets, while explicitly blocking three types of smartcards (Tapsigner, Keycard, Satochip) from being used with silent-payment wallets because they cannot support it. It is a feature addition, not a fix for an active security flaw.