clear a scanned wallet when a file, text payload or unrecognised qr is imported in the same pane
What the developer wrote
Authored by Craig Raw
clear a scanned wallet when a file, text payload or unrecognised qr is imported in the same pane
What changed, and why it matters
This commit fixes a UI state bug in Sparrow Wallet's import pane. Previously, when a user scanned or imported a wallet and then imported a non-wallet file, text payload, or unrecognized QR code in the same pane, the previously loaded wallet data was not cleared. This could mislead the user into thinking an old wallet was still active or associated with the new import. The fix explicitly sets the wallet list to null before handling these alternative import paths.
Treat as a minor UI/state hygiene fix. No immediate emergency action required, but users should upgrade to avoid potential confusion during wallet import workflows. Review whether similar stale-state issues exist in other import or scan panes.
Security signals we found
Stale UI state could mislead users about which wallet is loaded
Cross-import state retention in single import pane
User interface consistency fix with security-relevant consequences
Evidence from the diff
In FileImportPane.java, the wallets field is now set to null in three additional code paths: before importing a file via InputStream, before importing a QR payload as text, and when a scanned QR is unrecognized. Previously, wallets retained its prior value across these transitions, causing stale wallet state to persist in the import pane. The change also replaces a generic error expansion with a specific error message for unrecognized QR codes.
Changed components
src/main/java/com/sparrowwallet/sparrow/control/FileImportPane.javaInspect captured patch +4 / −2
### src/main/java/com/sparrowwallet/sparrow/control/FileImportPane.java
@@ -127,6 +127,7 @@ private void importFile(File file, String password) {
setExpanded(true);
} else {
try(InputStream inputStream = new BufferedInputStream(new FileInputStream(file))) {
+ wallets = null;
importFile(file.getName(), inputStream, password);
};
}
@@ -172,6 +173,7 @@ private void importQR() {
}
} else if(result.payload != null) {
try {
+ wallets = null;
importFile(importer.getName(), new ByteArrayInputStream(result.payload.getBytes(StandardCharsets.UTF_8)), null);
} catch(Exception e) {
log.error("Error importing QR", e);
@@ -188,8 +190,8 @@ private void importQR() {
log.error("Error importing QR", result.exception);
setError("Import Error", result.exception.getMessage());
} else {
- setError("Import Error", null);
- setExpanded(true);
+ wallets = null;
+ setError("Import Error", "The scanned QR code does not contain a wallet or key.");
}
}
}Why this scored 35/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.