SeedSigner

This commit only updates the GitHub pull request template. It restructures the description section, adds prompts for screenshots, fixes one documentation link, and reformats checklists. No application code, tests, build scripts, or security-sensitive files were changed.

This commit only updates the GitHub pull request template, which is a form contributors fill out when submitting code changes. It does not change any actual application code, so it has no direct security impact on the SeedSigner software or its users.

This commit only adjusts whitespace in a test screenshot generator file so that the opening parentheses line up visually. No code behavior, logic, or security-sensitive content changed.

This commit only rewords comments in two test helper files. No code behavior was changed, so it has no security relevance.

This commit is a test-code cleanup only. It replaces manual 'before/after' setup callbacks in the screenshot generator with reusable Python context managers that automatically clean up mock data. There is no change to the actual SeedSigner application or its security behavior.

This is a tiny code cleanup commit in a single display driver file. It adds the Python dataclass decorator to a class and renames one method parameter from 'state' to 'enabled' to match the rest of the code. There is no visible security relevance.

This commit is a routine internal code cleanup. It renames the parent display class from DisplayDriver to BaseDisplayDriver, makes a couple of methods optional instead of requiring every display subclass to implement them, and adjusts the ILI9341 display driver to inherit from the new base class. There is no visible security fix or vulnerability being addressed.

This commit is a routine internal code reorganization. It restructures how the SeedSigner app creates and manages its screen drivers, turning the existing display controller into a parent class and adding a factory pattern. There is no indication this change fixes a security bug or introduces a security vulnerability.

This commit hardens how SeedSigner loads multiselect settings from saved files or QR codes. Previously, an empty or malformed multiselect value (for example, an empty string, a lone comma, or a missing entry) could leave the setting empty, which might cause unexpected behavior when the app later uses that setting. The patch now strips empty pieces from comma-separated input and falls back to the default value whenever the result is empty. A new test checks four empty/missing cases.

This commit adds one extra test case (an empty list `[]`) to an existing unit test that checks how the SeedSigner settings code handles empty values. It is purely a test-file change and does not modify any production code, user-facing behavior, or security-sensitive logic.

This commit is a trivial cleanup of a test file. It removes an unused import (SettingsEntry), deletes a debug print statement, and fixes some whitespace. There is no change to the actual application code that handles seeds, keys, or user settings, so it has no security relevance.

This commit fixes a bug in how SeedSigner reloads saved settings. If a setting that is supposed to be a list of choices (a 'multiselect') was saved as empty/None, the app could behave incorrectly. The patch makes the app fall back to the default list instead. It is a defensive fix rather than a clear-cut remote exploit.

This commit fixes a bug in how SeedSigner reads setup information from a QR code. Previously, if a setting value was left blank (for example, 'sigs=' with nothing after the equals sign), the app would silently accept it and could misinterpret later settings. Now the app rejects blank values and reports an error. This is a defensive hardening change rather than a confirmed exploit, but it prevents potential misconfiguration or unexpected behavior.

This commit adds a user-experience guard so that settings where multiple options can be toggled now require at least one option to remain selected. Previously, a user could back out of such a setting with nothing selected, which could leave the device in an unintended or non-functional configuration. The fix shows a warning and returns the user to the setting until they pick at least one option.

This commit removes a duplicate setting in a single test string. It is a minor test cleanup with no security relevance.

This commit removes a helper function used only in a screenshot-generation test script. The deleted code fetched the latest SeedSigner release version from GitHub and temporarily overwrote version data so screenshots would display consistent version information. It is a test-only cleanup with no effect on the actual SeedSigner application or its security.

This commit only changes a test helper script that generates screenshots for documentation. It adds a mock that makes the screenshot generator pretend the software is running the latest released version instead of the current development code. There is no change to the actual SeedSigner application or its security behavior.

This commit only rewords comments and docstrings in test helper files that generate screenshots. No code behavior was changed, so it has no security relevance.

This commit is a test-only code cleanup. It replaces manual before/after setup callbacks with reusable Python context managers in the screenshot generator test harness. There is no change to the actual SeedSigner application code that users run, so it cannot affect real wallets, transactions, or security.

This commit adds a helper function that decides whether the running software is an official release image. It then uses that helper to hide extra technical details (fork name and commit hash) from the version screen only for official releases. There is no security fix or vulnerability here; it is a UI refinement with tests.

This commit is a routine improvement to how SeedSigner reads version information during automated GitHub testing. It adds a new environment variable SOURCE_SHA so that when outside contributors open pull requests, the displayed commit hash points to the contributor's actual latest commit rather than a temporary merge commit GitHub creates internally. There is no security vulnerability here.

This commit moves a GitHub Actions environment variable definition from inside a single test step to the top of the workflow file. It is a routine CI configuration cleanup with no apparent security relevance.

This commit only updates a test file to match how GitHub Actions environment variables are named. It does not change the actual application code that users run, and there is no security issue visible here.

This commit improves how the SeedSigner software detects its own version information when running automated tests in GitHub Actions. It adds new environment variables so that pull request builds correctly show the contributor's branch name and username instead of misleading placeholder values. There is no security vulnerability here; it is a quality-of-life improvement for build metadata.