SS
← All projectsSeedSigner

SeedSigner

Stateless, air-gapped Bitcoin signing software for Raspberry Pi hardware.

BitcoinHardware walletsNormal
Repository coverage

285 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

214security candidates37second-pass queue278AI analyses
14commits · 30 days
52commits · 60 days
111commits · 180 days
230commits · 365 days
Backfill bands
Aug 5 → Feb 6150 seen8 candidatesComplete
Feb 6 → Jun 629 seen0 candidatesComplete
Jun 6 → Jul 60 seen0 candidatesComplete
Jul 6 → Aug 57 seen1 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

53/100 average clarity
30Strong · 80–100
77Adequate · 60–79
108Thin · 40–59
70Opaque · 0–39
46security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Nick Klockenga413337769
kdmukai158114158348
okaybro282427068
newtonick181317049
PROWLERx15101010020
alvroble12711055
FazleRabbbiferdaus172868061
biel414037
SeedSigner111058
Chaitanya-Keyal111057
Kshitij111033
S1DDHEY111045
Analysis record

Published AI watches

Last scanned 47 minutes ago

High 80 AI analysisMessage 78 · Adequate
SS SeedSignerSeedSigner BitcoinHardware wallets

Merge pull request #1073 from kdmukai/2026-10_psbt_change_path_rules

This commit adds security checks to SeedSigner, an offline Bitcoin signing device, to prevent malicious or buggy wallet software from tricking users into sending change to derivation paths their wallet will never scan. It now verifies that…

New fatal error class PSBTChangeDerivationPathError for non-standard change derivation pathsNew fatal error class PSBTUnverifiableMixedInputBasePathsError for unverifiable mixed-base-path segwit v0 inputsChange output base path must match a verified input base path
5f321768by Nick Klockenga+1863−1397 files
Vendor flagged security relevance
High 81 AI analysisMessage 78 · Adequate
SS SeedSignerSeedSigner BitcoinHardware wallets

Merge pull request #1060 from kdmukai/2026-10_psbt_input_claims

This commit hardens SeedSigner's PSBT (Bitcoin transaction) parser so it no longer trusts a coordinator's claim that an input belongs to your seed. Before, the device only checked that your seed could derive the claimed key. Now it also re…

New attack-level exception: PSBTInputOwnershipContradictionError when an input claims the seed's key but the committed script does not use itInput ownership now verified by rebuilding the scriptPubKey from the claimed key rather than trusting PSBT bip32 derivationsTaproot key-path spends verified by re-applying the merkle-root tweak to the internal key and comparing to the committed output
995ce5c6by Nick Klockenga+990−1406 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 78 · Adequate
SS SeedSignerSeedSigner BitcoinHardware wallets

Reword the input claim checks' docstrings

This commit only rewrites comments and documentation strings in code and tests. No program logic, behavior, or security checks were changed.

081b1f40by kdmukai+13−155 files
No security note in commit
Moderate 69 AI analysisMessage 95 · Strong
SS SeedSignerSeedSigner BitcoinHardware wallets

Refuse mixed base paths on single sig segwit v0

This commit fixes a security flaw in SeedSigner, a small hardware wallet used to sign Bitcoin transactions. The bug could let a malicious transaction coordinator trick the device into accepting change money sent to a wallet path the user n…

New security check explicitly described as preventing a malicious coordinator from anchoring change to an unmonitored derivation pathNew exception class PSBTUnverifiableMixedInputBasePathsError with Warning-grade refusalUI flow now redirects to a blocking warning screen instead of allowing signing
9130ac75by kdmukai+432−875 files
Vendor flagged security relevance
Moderate 60 AI analysisMessage 73 · Adequate
SS SeedSignerSeedSigner BitcoinHardware wallets

Measure the change window from the smallest input index

This commit fixes a security check in SeedSigner, a small hardware-wallet-like device used to sign Bitcoin transactions. Previously, when deciding whether a change output's address was suspiciously far from the user's known addresses, the …

Fixes a window-widening attack against change-output verificationChange-output address index check now uses smallest input index instead of largestAdds hardened-input edge-case handling (window measured from 0)
512329beby kdmukai+57−102 files
Vendor flagged security relevance
Informational 12 AI analysisMessage 78 · Adequate
SS SeedSignerSeedSigner BitcoinHardware wallets

Test change at an extra level under the base path

This commit only adds a new test case to the project's test suite. It does not change any production code. The new test checks that the existing PSBT parser correctly rejects a specific kind of suspicious change output (one placed at a dee…

Adds defensive test coverage for PSBT change-output derivation-path validationRelates to preventing a coordinator with an account xpub from routing change to an unexpected deeper path
9c19e9d6by kdmukai+17−31 file
No security note in commit
High 81 AI analysisMessage 85 · Strong
SS SeedSignerSeedSigner BitcoinHardware wallets

Check change derivation paths against the inputs

This commit adds a safety check to SeedSigner that refuses to sign a Bitcoin transaction if the change output is being sent to a derivation path the user's wallet is unlikely to scan. Before this change, an attacker could trick a user into…

New attack-level exception PSBTChangeDerivationPathError for change sent to an unscanned derivation pathNew warning WARNING__CHANGE_ADDRESS_INDEX_BEYOND_WINDOW for change address indices far past spent indicesNew UI screen PSBTUnexpectedChangeDerivationPathView with DireWarningScreen and forced discard
862ed41bby kdmukai+1285−507 files
Vendor flagged security relevance
Informational 14 AI analysisMessage 68 · Adequate
SS SeedSignerSeedSigner BitcoinHardware wallets

Show the psbt's warnings through one View

This commit is a code cleanup, not a security fix. It consolidates several warning screens shown before signing a Bitcoin transaction into a single reusable view. The warnings themselves—such as 'high fee' and 'no change'—still behave the …

Refactor only: no change to validation, cryptography, or signing logicUser-facing warning text and flow remain equivalentAdds unit tests covering high-fee, no-change, and combined warning sequences
a8602100by kdmukai+163−784 files
No security note in commit
Informational 15 AI analysisMessage 95 · Strong
SS SeedSignerSeedSigner BitcoinHardware wallets

Add a test helper to set an input's locking script

This commit only reorganizes test code. It adds a helper function that replaces twelve nearly identical blocks of test setup code, with no changes to the actual wallet or signing logic that users rely on.

b297c869by kdmukai+31−553 files
No security note in commit
Informational 15 AI analysisMessage 85 · Strong
SS SeedSignerSeedSigner BitcoinHardware wallets

Document held findings at the steps that hold them

This commit only moves and rewrites documentation comments inside the code. It does not change how the program behaves, what it checks, or how it responds to malicious data. The logic for detecting and holding security findings in PSBT par…

1ba3c6a1by kdmukai+37−232 files
No security note in commit
High 78 AI analysisMessage 88 · Strong
SS SeedSignerSeedSigner BitcoinHardware wallets

Merge pull request #1047 from kdmukai/2026_09_psbt_input_scripts

This commit adds security checks to SeedSigner, a small offline Bitcoin signing device. Before the change, a malicious or buggy wallet coordinator could give the device a transaction where an input's hidden script did not match the public …

New validation logic compares supplied witness/redeem scripts against scriptPubKey hashesNew exception classes explicitly label script mismatch as an attack and missing/extraneous scripts as correctness problemsUI flow terminates signing before rendering transaction details when a script check fails
ada81cdeby Nick Klockenga+598−795 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 18 · Opaque
SS SeedSignerSeedSigner BitcoinHardware wallets

Enable Swahili

This commit simply adds Swahili as a new language option in the SeedSigner settings. It is a routine localization change with no security relevance.

c255bf57by kdmukai+2−01 file
No security note in commit
Moderate 51 AI analysisMessage 73 · Adequate
SS SeedSignerSeedSigner BitcoinHardware wallets

Merge pull request #1042 from Chaitanya-Keyal/op-return-push-opcode

This commit fixes how SeedSigner reads the extra data attached to OP_RETURN Bitcoin transaction outputs. Previously the code always assumed the data was introduced by OP_PUSHDATA1, which meant it would misread or crash on the more common d…

Fixes incorrect parsing of OP_RETURN data due to assumed push opcodeAdds robust handling for direct push, OP_PUSHDATA1/2/4, and OP_0-OP_16Introduces explicit malformed-script rejection instead of silent mis-parsing
d8f7956fby Nick Klockenga+375−156 files
No security note in commit
Moderate 64 AI analysisMessage 73 · Adequate
SS SeedSignerSeedSigner BitcoinHardware wallets

Merge pull request #1041 from Chaitanya-Keyal/psbt-negative-fee

This update makes SeedSigner refuse Bitcoin transaction files (PSBTs) where the outgoing amounts are larger than the incoming amounts. Before the fix, the device would have accepted such impossible transactions and shown the user a negativ…

Input validation: rejects PSBTs with mathematically impossible fee valuesUser-facing safeguard: prevents confusing negative fee from reaching transaction review screensNew exception class with clear semantics (PSBTNegativeFeeError)
ebc1e11fby Nick Klockenga+105−65 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
SS SeedSignerSeedSigner BitcoinHardware wallets

Drop the negative fee comment's claim that both totals are unverified

This commit only updates a code comment to remove an outdated claim. The actual security check for negative fees remains unchanged, and a prior code change already verifies input amounts before outputs are parsed. There is no functional se…

9994a04eby okaybro+3−41 file
No security note in commit
High 81 AI analysisMessage 88 · Strong
SS SeedSignerSeedSigner BitcoinHardware wallets

Merge pull request #995 from newtonick/psbt-verify

This commit fixes a security flaw in SeedSigner, a small offline Bitcoin signing device. Previously, when a user scanned a transaction to sign, the device added up the input amounts exactly as a malicious or compromised computer/coordinato…

Fixes a fee-display manipulation vulnerability where a compromised coordinator could understate input amounts to hide excessive real feesAdds explicit verification of each input's amount against the prior transaction before totaling inputsRaises dedicated security exceptions (PSBTInputAmountVerificationError, PSBTMissingInputUtxoError) and blocks the signing flow
e92c4ea6by Nick Klockenga+508−346 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 60 · Adequate
SS SeedSignerSeedSigner BitcoinHardware wallets

Trim the input-amount verification test docstrings

This commit only rewrites the explanatory text (docstrings) inside test code. No actual program logic, security checks, or test behavior changed. It is a documentation cleanup within tests.

afb7305aby newtonick+17−261 file
No security note in commit
Informational 12 AI analysisMessage 60 · Adequate
SS SeedSignerSeedSigner BitcoinHardware wallets

Tighten the input-amount test asserts and run the no-utxo test over every fixture

This commit only changes test code. It tightens some Python assertions (using 'is False' instead of '== False') and expands one test to run across more test fixtures. There is no change to the actual wallet or PSBT parsing logic that users…

222bf3d5by newtonick+12−91 file
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
SS SeedSignerSeedSigner BitcoinHardware wallets

Replace the parse() test helper with direct PSBTParser calls

This commit only changes a test file. It removes a small helper method called parse() and replaces its calls with the same one-line PSBTParser constructor call written out directly. There is no change to the actual wallet/security code tha…

a71b7b39by newtonick+11−131 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityMerge pull request #1010 from kdmukai/sync_pip_requirementsby Nick Klockenga · c38430b8 · Aug 20, 2026 · 2 filesMessage 73 · AdequateTriage 0Details
Commit message · Nick Klockenga

Merge pull request #1010 from kdmukai/sync_pip_requirements

[chore] Align dev requirements pins with the versions SeedSigner OS ships

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discountmerge-commit duplicate discount
Security candidateMerge pull request #1002 from kdmukai/psbt_parser_derivation_cacheby Nick Klockenga · 861d6e3c · Aug 20, 2026 · 2 filesMessage 73 · AdequateInformational 19Details
Commit message · Nick Klockenga

Merge pull request #1002 from kdmukai/psbt_parser_derivation_cache

[performance] PSBT parsing: remove redundant BIP32 derivations and Transaction rebuilds

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialsigning boundaryseed or entropy pathsigning or wallet pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Informational 19/100

This commit is a performance improvement for parsing Bitcoin transaction files (PSBTs). It adds a cache so the wallet doesn't repeatedly recalculate the same cryptographic key derivations, and it avoids rebuilding the whole transaction object many times. The change also removes a small block of code that handled an older multisig script type (p2sh) when deciding whether an output is change. The commit message and code comments describe this only as a performance optimization, not a security fix.

Security candidateMark coordinator-supplied change data as claimedby kdmukai · fc21710b · Aug 15, 2026 · 3 filesMessage 68 · AdequateInformational 15Details
Commit message · kdmukai

Mark coordinator-supplied change data as claimed

Nothing in a psbt proves the fingerprints and derivation paths it
carries, but change_data's fingerprint and derivation_path keys read
like facts -- the change details view splits one into a wallet path and
hands it straight to get_xpub. Renaming them to claimed_fingerprint and
claimed_derivation_path, along with the locals that carry them, puts the
trust boundary in the data itself rather than in the logic around it.

The class docstring now states the convention behind the prefix:
claimed_ for coordinator-supplied metadata, verified_ for what this
device proved by re-deriving from the signing seed, and the invariant
that no verified_ value comes from a claimed_ one without a derivation
in between. It also records that change_data covers self-transfers, not
just change-branch outputs. No logic changes; the two dict keys are the
only behavioral difference.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundaryseed or entropy pathsigning or wallet pathparser or protocol path
AI analysis · Informational 15/100

This commit is a code cleanup and documentation change, not a security fix. It renames variables and dictionary keys from 'fingerprint' and 'derivation_path' to 'claimed_fingerprint' and 'claimed_derivation_path' to make it clearer that data coming from a PSBT is coordinator-supplied and unverified. No program behavior changes; the same values flow the same way.

AI review queuedTighten the derivation cache guard testsby kdmukai · 65b1d3d9 · Aug 15, 2026 · 1 fileMessage 78 · AdequateInformational 15Details
Commit message · kdmukai

Tighten the derivation cache guard tests

The class docstring enumerated two claims while the class held six tests,
and each test already documents its own claim, so state the purpose instead
of maintaining a second copy.

test_get_cosigners_identical_with_and_without_cache only ever wrote to the
cache: its three cosigners sit below distinct parent xpubs, so all six level
lookups missed and nothing was read back. Call _get_cosigners a third time
against the populated cache so the comparison covers the read path, which is
where a wrong key would surface.

Move the two assert messages that restated their own expressions into
comments that give the reason instead.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathparser or protocol pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes test code. It tightens an existing unit test so it actually exercises the cache read path, and improves comments and docstrings. No production code was modified, so it cannot introduce or fix a security vulnerability in the application itself.

Security candidateCorrect the cap comment's memory figureby kdmukai · ab44e970 · Aug 14, 2026 · 1 fileMessage 68 · AdequateInformational 15Details
Commit message · kdmukai

Correct the cap comment's memory figure

The cache costs roughly 650KB at the cap, not 600KB. Drop the claim
that the cap guards against malicious memory exhaustion: the device is
airgapped and stateless, so a psbt that bloats the cache costs the user
a power cycle, not funds.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundaryseed or entropy pathsigning or wallet pathparser or protocol path
AI analysis · Informational 15/100

This commit only updates a code comment. It corrects an estimated memory figure from 600 KB to 650 KB and removes an outdated claim that the cache limit protects against malicious memory exhaustion. The actual code behavior and the cache limit value (1000 derivations) do not change. There is no functional security fix or vulnerability being patched.

Security candidateRequire the cache argument on the internal helpersby kdmukai · 5791d55e · Aug 14, 2026 · 2 filesMessage 83 · StrongLow 28Details
Commit message · kdmukai

Require the cache argument on the internal helpers

Defaulting it to None means a call site that forgets it silently
derives without a cache. No caller omitted it; now none can.
_derive_with_cache keeps its optional cache, since that branch is the
plain embit derive() the equivalence test compares against.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
seed or entropy pathsigning or wallet pathparser or protocol path
AI analysis · Low 28/100

This commit tightens up internal helper functions in a Bitcoin wallet's PSBT parser so that callers must explicitly pass a cache object (or None). Previously, the cache argument defaulted to None, meaning a future coding mistake could silently disable the derivation cache. The change is defensive: it makes accidental omissions impossible without breaking tests. There is no evidence of an exploitable vulnerability in the shipped code, because the commit message itself says no caller actually omitted the argument.

Security candidateScope the derivation cache to parse()by kdmukai · 0a735d58 · Aug 14, 2026 · 2 filesMessage 78 · AdequateLow 36Details
Commit message · kdmukai

Scope the derivation cache to parse()

Nothing outside parse() reads the cache, so it need not be an instance
attribute. As a local, "the cache does not outlive the parse" is a
property of scope rather than a teardown to maintain -- which also
retires the finally block, both initializations, and the test guarding
them.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
seed or entropy pathsigning or wallet pathparser or protocol path
AI analysis · Low 36/100

This commit is a code-quality and defense-in-depth change, not a fix for an active bug. It moves a temporary cache of derived Bitcoin keys from being a long-lived object property to a short-lived local variable that exists only during parsing. The cache already had a size cap, so unbounded memory growth was already prevented. The change makes it structurally impossible for the cache to leak beyond a single parse, which slightly reduces the risk that sensitive derived key material could remain in memory longer than necessary. It also removes the explicit cleanup code and one related test because the local variable naturally disappears when parsing finishes.

AI review queuedRecord cache sizes during the parse, not after itby kdmukai · 448e0eb6 · Aug 14, 2026 · 1 fileMessage 78 · AdequateInformational 15Details
Commit message · kdmukai

Record cache sizes during the parse, not after it

Reading the cache dict back once the parse is over depends on the parse
leaving that dict intact, which is an implementation detail rather than
the guarantee under test.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathparser or protocol pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes a test file. It makes the test measure the size of a temporary cache while the code is running, instead of reading the cache afterward. This is a test-quality improvement, not a security fix.

Security candidateExercise the cache's read path in the equivalence testby kdmukai · 19372889 · Aug 14, 2026 · 1 fileMessage 83 · StrongInformational 12Details
Commit message · kdmukai

Exercise the cache's read path in the equivalence test

Both psbts carried a single change output, so every derivation was a
first-time miss and the cached run only ever wrote to the cache. A
wrong value returned on a hit would have gone unnoticed. Carrying the
change output twice makes the second traversal read back what the
first one cached.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing boundarysigning or wallet pathparser or protocol path
AI analysis · Informational 12/100

This commit only changes a test file. It strengthens an existing test so that it actually exercises the read path of a caching mechanism, rather than only the write path. There is no change to production code, no fix for a vulnerability, and no indication of a security issue being patched.

Security candidateTrim the cache tests down to what catches a regressionby kdmukai · 2b1ce93c · Aug 14, 2026 · 1 fileMessage 83 · StrongInformational 13Details
Commit message · kdmukai

Trim the cache tests down to what catches a regression

"Explain how MAX_CACHED_DERIVATIONS was chosen and test the cap" left
test_cache_does_not_change_parse_output hand-rolling its own comparison
as a tuple of field reprs, and promised to move it onto the new
assert_same_parse_result helper. Do that, and put it on patch.object
like the rest of the suite instead of the monkeypatch fixture.

Then measure what the tests around it are worth, by breaking the cache
eleven different ways and recording which tests notice. Two results
stood out.

The equivalence test is differential: it parses once with the cache and
once without and requires the two to agree, so it can only catch a
break that makes those two runs disagree. Anything in logic they share
passes it. Breaking legacy p2sh change detection and breaking taproot
change detection both went unnoticed here; TestPSBTParser is what
catches those. Running it across four wallet types and both fingerprint
states was therefore buying nothing, and all eight cases detect exactly
what two of them do. Narrow it to one single-sig and one multisig psbt,
the two routes into the cache, and drop the fingerprint-zeroing
variants: test_zero_fingerprint_fill_over_many_inputs is what actually
catches a break in the fill path.

test_derive_with_cache_matches_plain_derive caught nothing that
test_get_cosigners_identical_with_and_without_cache does not also
catch, so remove it.

Nothing covered the parse dropping its cache when it ends. Deleting
that clear leaves the whole suite green, and the cache holds keys
derived from the signing seed, so add a test that asserts the parse
filled the cache it was handed and that the parser is no longer holding
it afterward.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing boundarysigning or wallet pathparser or protocol path
AI analysis · Informational 13/100

This commit only changes test code in tests/test_psbt_parser.py. It trims redundant test cases, switches from monkeypatch to patch.object, adds a helper assertion, and adds a new test verifying that a sensitive in-memory cache is cleared after parsing. There is no change to the actual PSBT parsing or caching logic in the application, so it does not introduce or fix a runtime security vulnerability on its own.

Security candidateHold the parent key in each cache entryby kdmukai · 003deda2 · Aug 14, 2026 · 1 fileMessage 80 · StrongModerate 59Details
Commit message · kdmukai

Hold the parent key in each cache entry

The cache keys on id(parent_key), which is the parent's address in
memory. Python is free to hand that address to a new object once the
original is released, so an entry outliving its parent could be matched
by an unrelated key that landed on the same address, and
_derive_with_cache would return that entry's child instead of deriving
the right one. It fails silently: a recycled address is
indistinguishable from a hit.

Nothing triggers this today, because every parent -- the signing seed's
root and the cosigner xpubs from psbt.xpubs -- is held for the whole
parse. But that is a property of the call sites rather than of the
function, and the failure would be a wrong key in the middle of change
detection.

Storing the parent alongside its derived child keeps that address
occupied for as long as the entry depending on it is alive. The entry
holds a reference to a key the parser already owns, so nothing new is
retained and nothing is copied. Costs 56 bytes per entry, so the cap now
holds the cache to about 600 KB; the comment is updated to match.

Reported by newtonick in review.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing boundaryseed or entropy pathsigning or wallet pathparser or protocol path
AI analysis · Moderate 59/100

This commit fixes a subtle caching bug in how SeedSigner derives child keys from parent keys when parsing Bitcoin transactions. The cache used the memory address of the parent key as its identifier, but Python can reuse that address after the parent is discarded. In theory, an unrelated new parent could land on the same address, causing the cache to return the wrong child key without any error. The fix stores the parent key inside each cache entry so its memory address stays occupied as long as the cached result exists. The commit itself says nothing currently triggers the bug because callers keep parents alive, but the function was unsafe on its own.

Security candidateExplain how MAX_CACHED_DERIVATIONS was chosen and test the capby kdmukai · b563f05f · Aug 14, 2026 · 2 filesMessage 83 · StrongLow 32Details
Commit message · kdmukai

Explain how MAX_CACHED_DERIVATIONS was chosen and test the cap

The cap was documented as a bound a real wallet would never approach.
That is backwards: a 3-of-5 multisig -- the largest common policy --
consolidating 200 inputs wants more cached levels than the cap allows.

That case is the watermark the number comes from. Record it, what the
cache costs at that size, and what going over means: the psbt still
parses correctly, it may just derive some levels more than once.

Nothing checked that last claim. Parse a multisig and a single-sig psbt
with the cache free to grow, then again with the cap low enough to fill
partway through, and require identical parser state. Assert the cap was
actually reached, so removing the cap outright fails the test rather
than passing it quietly.

Compare the two parses through a new assert_same_parse_result helper,
which checks field by field so a failure names the field that differs.
test_cache_does_not_change_parse_output still hand-rolls the same
comparison as a tuple of fields and should be moved onto the helper in
a follow-up.

Also give PSBTParser a class docstring; the cap comment had grown large
enough to read as one.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing boundaryseed or entropy pathsigning or wallet pathparser or protocol path
AI analysis · Low 32/100

This commit is a documentation and testing improvement for an existing safety cap in the PSBT parser. It does not change the cap's value or behavior; it explains why the cap exists (to stop a malicious PSBT from consuming unbounded memory), adds a test proving that hitting the cap does not corrupt the parse result, and clarifies that the cap was chosen based on a realistic large multisig transaction. There is no new vulnerability being fixed here, but the change makes the existing defense easier to understand and verify.

Security candidateDrop the duplicate p2sh branch in _parse_outputsby kdmukai · 272a6ace · Aug 14, 2026 · 1 fileMessage 78 · AdequateInformational 15Details
Commit message · kdmukai

Drop the duplicate p2sh branch in _parse_outputs

The change-detection block tested for a p2sh policy twice and built the
same script both times: a standalone if ahead of the policy chain, and
an elif inside it. For a p2sh policy neither p2wsh nor p2sh-p2wsh
matches, so control always reached the elif and reassigned an identical
script.p2sh over the first one, from the same redeem_script.

Removing the standalone if leaves a single if/elif chain covering every
policy type, and keeps the comment recording that this branch also
carries pre-segwit multisig (m/45').

Parse output is unchanged. Verified with the full test suite and by
diffing the complete parser state -- policy, amounts, destinations,
change_data, op_return_data -- across 112 scenarios: all seven wallet
script types against all seven recipient types, as spend-with-change,
full spend, self-transfer, and multi-recipient.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
seed or entropy pathsigning or wallet pathparser or protocol path
AI analysis · Informational 15/100

This commit removes a duplicated code branch that did the exact same thing twice in a row. The behavior of the program is unchanged; it is a minor cleanup with no security effect.

Security candidateCut repeated computation out of PSBTParser.parseby kdmukai · 1178055c · Aug 13, 2026 · 2 filesMessage 90 · StrongInformational 15Details
Commit message · kdmukai

Cut repeated computation out of PSBTParser.parse

Parsing repeats work that only needs doing once, which is noticeable on
the Pi Zero. Three changes remove that repetition. Parse output is
unchanged.

- _parse_outputs read psbt.tx at twelve points in its loop, and PSBT.tx
rebuilds the entire Transaction on each access; read it once up front.

- _fill_missing_fingerprints derived a whole child key per input and per
output purely to read the parent fingerprint stamped on it. HDKey
exposes that same value as my_fingerprint, which derives nothing.

- Cosigner and change-output checks re-derive the same BIP32 levels for
every input and output, since only the address at the end differs. A
new _derive_with_cache memoizes each level for the duration of one
parse; its docstring covers how the cache is keyed, bounded and
discarded, and why.

Verified byte-identical against every fixture in psbt_testing_util.py on
both mainnet and testnet. Tests parse each of them with the cache active
and bypassed and compare the full parser state and the resulting PSBT
bytes.

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
secret or key materialsigning boundaryseed or entropy pathsigning or wallet pathparser or protocol path
AI analysis · Informational 15/100

This commit is a performance optimization, not a security fix. It speeds up parsing of Bitcoin transaction files (PSBTs) on the slow Pi Zero hardware by avoiding repeated work: reading the transaction once instead of rebuilding it twelve times, using a direct fingerprint lookup instead of deriving a child key, and caching intermediate key derivations during parsing. The author explicitly states the parse output is unchanged and adds tests to prove the cached and uncached paths produce identical results.

Security candidateMerge pull request #991 from kdmukai/image_entropy_2_preview_poolby Nick Klockenga · 5088588d · Aug 13, 2026 · 4 filesMessage 78 · AdequateLow 25Details
Commit message · Nick Klockenga

Merge pull request #991 from kdmukai/image_entropy_2_preview_pool

[enhancement] Image Entropy: Require a full pool of distinct preview frames before capture

78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
entropy or randomnessseed or entropy pathsigning or wallet pathmerge-commit duplicate discount
AI analysis · Low 25/100

This change improves how SeedSigner creates a new seed from camera noise. Before taking the final picture, it now requires 50 distinct, non-blank preview frames. This is a defensive hardening measure: it prevents a stuck, covered, or repeating camera from being mistaken for good randomness. It is not a fix for an active attack, but it reduces the chance that a hardware or environment problem produces a weak or predictable seed.

Security candidateMerge pull request #990 from kdmukai/bugfix_image_entropy_held_buttonby Nick Klockenga · 2bbae4a5 · Aug 13, 2026 · 2 filesMessage 78 · AdequateModerate 60Details
Commit message · Nick Klockenga

Merge pull request #990 from kdmukai/bugfix_image_entropy_held_button

[bugfix] Image Entropy: Held button can skip live preview and final review

78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
entropy or randomnessseed or entropy pathsigning or wallet pathmerge-commit duplicate discount
AI analysis · Moderate 60/100

This commit fixes a user-interface bug in SeedSigner's 'image entropy' feature, where a user holding down a button could accidentally skip the live camera preview and the final photo review. Because the generated seed's randomness comes from the photo, skipping the review could let a user unknowingly accept a poor or unintended image. The patch now waits until the button is released before accepting the next press, and adds tests to confirm the behavior.

Security candidateMerge pull request #969 from ruipereira1/fix/ur2-bytewords-crc-widthby Nick Klockenga · 56637104 · Aug 10, 2026 · 3 filesMessage 73 · AdequateModerate 64Details
Commit message · Nick Klockenga

Merge pull request #969 from ruipereira1/fix/ur2-bytewords-crc-width

Serialize the Bytewords CRC as a fixed 4 bytes and re-enable the checksum check

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
seed or entropy pathsigning or wallet pathmerge-commit duplicate discount
AI analysis · Moderate 64/100

This commit fixes a bug in how SeedSigner creates and verifies Bytewords checksums, a format used to encode data (such as crypto wallet information) as readable words or compact strings. The checksum was sometimes output as 3 bytes instead of the required 4 bytes, which could cause other wallets or scanners to reject the encoded data. It also re-enables a previously disabled checksum verification, so corrupted data is now properly rejected instead of being silently accepted.

Lower-priorityMerge pull request #992 from kdmukai/screenshot_generator_ci_version_fixby Nick Klockenga · 358a34b8 · Aug 10, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Nick Klockenga

Merge pull request #992 from kdmukai/screenshot_generator_ci_version_fix

[CI] Bugfix: Screenshot generator: crashes when the latest-release fetch fails

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedFix CI crash in screenshot generator when latest-release fetch failsby kdmukai · a6dfb0cd · Aug 9, 2026 · 1 fileMessage 73 · AdequateInformational 17Details
Commit message · kdmukai

Fix CI crash in screenshot generator when latest-release fetch fails

The screenshot generator fetches the latest release tag at import time via an
unauthenticated GitHub API call. GitHub-hosted runners share outbound IPs and
the unauthenticated api.github.com limit is 60 req/hr/IP, so the call was
intermittently rate-limited (HTTP 403), returned (None, None), and fed None into
the mock_version_to_most_recent_release Version mock. That crashed rendering for
every locale with "TypeError: 'NoneType' object is not subscriptable" in the
OpeningSplash version string (and would likewise hit len(None) on the Version
settings screen).

Substitute a placeholder version name and timestamp when the fetch can't resolve
the latest release, so the "release build" screenshots still render instead of
feeding None into the mock. The real fetch is unchanged when it succeeds.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 17/100

This is a test-only fix for a CI screenshot generator. It stops the test suite from crashing when GitHub's public API rate-limits an unauthenticated version-lookup request. There is no security vulnerability in the actual SeedSigner wallet or user-facing code; the change only adds a fallback placeholder so screenshots keep rendering during automated tests.

Security candidateMerge pull request #987 from newtonick/add-security-mdby Nick Klockenga · aa1897e8 · Aug 9, 2026 · 1 fileMessage 78 · AdequateInformational 15Details
Commit message · Nick Klockenga

Merge pull request #987 from newtonick/add-security-md

Add SECURITY.md with vulnerability disclosure policy

78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
explicit security languagedocumentation-only discountmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit adds a SECURITY.md file to the repository. It is purely a policy document that tells people how to privately report security bugs and what information to include. It does not change any code, fix any vulnerability, or introduce any new functionality.

Lower-priorityadd simple Security policyby newtonick · 01dd0520 · Aug 7, 2026 · 1 fileMessage 40 · ThinTriage 0Details
Commit message · newtonick

add simple Security policy

40/100 · ThinMessage clarity
✓ Descriptive subject✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
documentation-only discount
Lower-priorityMerge pull request #956 from newtonick/fix-build-yml-versioningby Nick Klockenga · 1fb29563 · Jul 22, 2026 · 1 fileMessage 73 · AdequateInformational 17Details
Commit message · Nick Klockenga

Merge pull request #956 from newtonick/fix-build-yml-versioning

[CI] Fix for build.yml and writing `version.json`

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discountmerge-commit duplicate discount
AI analysis · Informational 17/100

This is a CI/build pipeline fix, not a security vulnerability fix. The change moves file cleanup from the GitHub Actions workflow into the operating-system build script so that the build script can use files like .git/ and tools/ to write a version.json file. It also adds a verification step to fail the build if version.json is missing or incomplete, preventing broken boot images from being published.

Lower-priorityfix build github action after version additionby newtonick · 7cf5cdd8 · Jul 22, 2026 · 1 fileMessage 45 · ThinInformational 16Details
Commit message · newtonick

fix build github action after version addition

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 16/100

This commit fixes the project's automated build process after adding a new version-tracking feature. It moves file cleanup from the GitHub Actions workflow into the build script so the script can read git history and tools, and adds a check to make sure a version.json file was created. If version.json is missing or incomplete, the app would freeze at startup; the new check prevents publishing such broken images. This is a build-pipeline reliability fix, not a direct security patch.

Security candidatefix: replace removed `get_seed` call in `PSBTSelectSeedView`by okaybro · 442b7a1a · Jul 22, 2026 · 2 filesMessage 77 · AdequateLow 43Details
Commit message · okaybro

fix: replace removed `get_seed` call in `PSBTSelectSeedView`

Co-authored-by: Nick Klockenga <127377+newtonick@users.noreply.github.com>

77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
signing boundaryseed or entropy pathsigning or wallet path
AI analysis · Low 43/100

This commit fixes a bug where selecting an existing seed during PSBT signing would crash because the code called a method (`get_seed`) that no longer exists. The fix uses the already-loaded list of seeds directly. The crash is a reliability issue, not a direct theft-of-funds vulnerability, but it could prevent a user from signing a transaction at a critical moment.

Security candidatechore: update seedsigner-screenshots submodule to latest devby okaybro · 387fa91f · Jul 21, 2026 · 1 fileMessage 77 · AdequateInformational 15Details
Commit message · okaybro

chore: update seedsigner-screenshots submodule to latest dev

Bumps the screenshots submodule from c157f6e to f04b02c (28 commits),
picking up the v0.8.7 screenshot updates.

77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
seed or entropy pathsigning or wallet path
AI analysis · Informational 15/100

This commit only updates a submodule containing screenshots used for documentation or testing. There is no code change to the SeedSigner application itself, so it has no security impact on users.