AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
High 78 Bitcoin

Merge pull request #1047 from kdmukai/2026_09_psbt_input_scripts

Public commit record

What the developer wrote

Authored by Nick Klockenga

88/100 · Strong
Merge pull request #1047 from kdmukai/2026_09_psbt_input_scripts

[security] Verify input scripts against the scriptPubKey they commit to
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
The short version

What changed, and why it matters

This commit adds security checks to SeedSigner, a small offline Bitcoin signing device. Before the change, a malicious or buggy wallet coordinator could give the device a transaction where an input's hidden script did not match the public address it claimed to spend from. That could trick the device into thinking a payment to an attacker's address was actually change coming back to the user. The patch now verifies that every input includes exactly the scripts it publicly commits to, and stops the signing flow with a warning if something is missing, wrong, or extra.

Recommended action

Treat this as a security fix and include it in the next release. Users building from source or running pre-release firmware should update to a revision that includes this merge. Wallet coordinators that create PSBTs for SeedSigner should ensure they supply only the scripts each input's scriptPubKey actually commits to.

Security signals we found

01

New validation logic compares supplied witness/redeem scripts against scriptPubKey hashes

02

New exception classes explicitly label script mismatch as an attack and missing/extraneous scripts as correctness problems

03

UI flow terminates signing before rendering transaction details when a script check fails

04

Tests demonstrate that a foreign witness_script or redeem_script is rejected even when the coin is owned by the user

05

Commit title and message are explicitly tagged [security]

Risk score

Why this scored 78/100

Our methodology →
Potential impact 24/30
Exploitability 18/25
Stealth signal 12/15
Affected reach 10/15
Confidence 9/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.