AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
High 80 Bitcoin

Merge pull request #1073 from kdmukai/2026-10_psbt_change_path_rules

Public commit record

What the developer wrote

Authored by Nick Klockenga

78/100 · Adequate
Merge pull request #1073 from kdmukai/2026-10_psbt_change_path_rules

[security] Check change derivation paths against the inputs
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
The short version

What changed, and why it matters

This commit adds security checks to SeedSigner, an offline Bitcoin signing device, to prevent malicious or buggy wallet software from tricking users into sending change to derivation paths their wallet will never scan. It now verifies that change outputs return to the same wallet (base derivation path) the transaction spends from, use only standard receive/change branches, and use non-hardened address indexes. It also blocks single-signature segwit v0 transactions that spend from multiple accounts unless each input includes the full previous transaction, because without that data a coordinator could fake an input's ownership to justify sending change to a hidden path. Change at an unusually far address index is now flagged with a warning instead of being silently accepted.

Recommended action

Users and downstream packagers should treat this as a security fix and update to the merged code. Reviewers should verify that the new derivation-path rules do not break legitimate multisig or self-transfer workflows in their coordinator software, and that the CHANGE_ADDRESS_INDEX_WINDOW threshold is appropriate for their wallet's gap limit and address lookahead settings.

Security signals we found

01

New fatal error class PSBTChangeDerivationPathError for non-standard change derivation paths

02

New fatal error class PSBTUnverifiableMixedInputBasePathsError for unverifiable mixed-base-path segwit v0 inputs

03

Change output base path must match a verified input base path

04

Change branch restricted to receive (0) or change (1)

05

Change address index must be non-hardened

06

Distant change address index flagged when >10,000 past smallest input index

07

Single-sig segwit v0 mixed base paths rejected unless all inputs provide non_witness_utxo

08

UI now shows dire warning for unsafe derivation path and warning for distant address

Risk score

Why this scored 80/100

Our methodology →
Potential impact 24/30
Exploitability 18/25
Stealth signal 12/15
Affected reach 12/15
Confidence 9/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.