This commit adds security checks to SeedSigner, an offline Bitcoin signing device, to prevent malicious or buggy wallet software from tricking users into sending change to derivation paths their wallet will never scan. It now verifies that…
New fatal error class PSBTChangeDerivationPathError for non-standard change derivation pathsNew fatal error class PSBTUnverifiableMixedInputBasePathsError for unverifiable mixed-base-path segwit v0 inputsChange output base path must match a verified input base path
This commit hardens SeedSigner's PSBT (Bitcoin transaction) parser so it no longer trusts a coordinator's claim that an input belongs to your seed. Before, the device only checked that your seed could derive the claimed key. Now it also re…
New attack-level exception: PSBTInputOwnershipContradictionError when an input claims the seed's key but the committed script does not use itInput ownership now verified by rebuilding the scriptPubKey from the claimed key rather than trusting PSBT bip32 derivationsTaproot key-path spends verified by re-applying the merkle-root tweak to the internal key and comparing to the committed output
This commit fixes a security flaw in SeedSigner, a small hardware wallet used to sign Bitcoin transactions. The bug could let a malicious transaction coordinator trick the device into accepting change money sent to a wallet path the user n…
New security check explicitly described as preventing a malicious coordinator from anchoring change to an unmonitored derivation pathNew exception class PSBTUnverifiableMixedInputBasePathsError with Warning-grade refusalUI flow now redirects to a blocking warning screen instead of allowing signing
This commit fixes a security check in SeedSigner, a small hardware-wallet-like device used to sign Bitcoin transactions. Previously, when deciding whether a change output's address was suspiciously far from the user's known addresses, the …
Fixes a window-widening attack against change-output verificationChange-output address index check now uses smallest input index instead of largestAdds hardened-input edge-case handling (window measured from 0)
This commit only adds a new test case to the project's test suite. It does not change any production code. The new test checks that the existing PSBT parser correctly rejects a specific kind of suspicious change output (one placed at a dee…
Adds defensive test coverage for PSBT change-output derivation-path validationRelates to preventing a coordinator with an account xpub from routing change to an unexpected deeper path
This commit adds a safety check to SeedSigner that refuses to sign a Bitcoin transaction if the change output is being sent to a derivation path the user's wallet is unlikely to scan. Before this change, an attacker could trick a user into…
New attack-level exception PSBTChangeDerivationPathError for change sent to an unscanned derivation pathNew warning WARNING__CHANGE_ADDRESS_INDEX_BEYOND_WINDOW for change address indices far past spent indicesNew UI screen PSBTUnexpectedChangeDerivationPathView with DireWarningScreen and forced discard
This commit is a code cleanup, not a security fix. It consolidates several warning screens shown before signing a Bitcoin transaction into a single reusable view. The warnings themselves—such as 'high fee' and 'no change'—still behave the …
Refactor only: no change to validation, cryptography, or signing logicUser-facing warning text and flow remain equivalentAdds unit tests covering high-fee, no-change, and combined warning sequences
This commit only reorganizes test code. It adds a helper function that replaces twelve nearly identical blocks of test setup code, with no changes to the actual wallet or signing logic that users rely on.
This commit only moves and rewrites documentation comments inside the code. It does not change how the program behaves, what it checks, or how it responds to malicious data. The logic for detecting and holding security findings in PSBT par…
This commit adds security checks to SeedSigner, a small offline Bitcoin signing device. Before the change, a malicious or buggy wallet coordinator could give the device a transaction where an input's hidden script did not match the public …
New validation logic compares supplied witness/redeem scripts against scriptPubKey hashesNew exception classes explicitly label script mismatch as an attack and missing/extraneous scripts as correctness problemsUI flow terminates signing before rendering transaction details when a script check fails
This commit simply adds Swahili as a new language option in the SeedSigner settings. It is a localization (translation) change with no security relevance.
This commit fixes how SeedSigner reads the extra data attached to OP_RETURN Bitcoin transaction outputs. Previously the code always assumed the data was introduced by OP_PUSHDATA1, which meant it would misread or crash on the more common d…
Fixes incorrect parsing of OP_RETURN data due to assumed push opcodeAdds robust handling for direct push, OP_PUSHDATA1/2/4, and OP_0-OP_16Introduces explicit malformed-script rejection instead of silent mis-parsing
This update makes SeedSigner refuse Bitcoin transaction files (PSBTs) where the outgoing amounts are larger than the incoming amounts. Before the fix, the device would have accepted such impossible transactions and shown the user a negativ…
Input validation: rejects PSBTs with mathematically impossible fee valuesUser-facing safeguard: prevents confusing negative fee from reaching transaction review screensNew exception class with clear semantics (PSBTNegativeFeeError)
This commit only updates a code comment to remove an outdated claim. The actual security check for negative fees remains unchanged, and a prior code change already verifies input amounts before outputs are parsed. There is no functional se…
This commit fixes a security flaw in SeedSigner, a small offline Bitcoin signing device. Previously, when a user scanned a transaction to sign, the device added up the input amounts exactly as a malicious or compromised computer/coordinato…
Fixes a fee-display manipulation vulnerability where a compromised coordinator could understate input amounts to hide excessive real feesAdds explicit verification of each input's amount against the prior transaction before totaling inputsRaises dedicated security exceptions (PSBTInputAmountVerificationError, PSBTMissingInputUtxoError) and blocks the signing flow
This commit only rewrites the explanatory text (docstrings) inside test code. No actual program logic, security checks, or test behavior changed. It is a documentation cleanup within tests.
This commit only changes test code. It tightens some Python assertions (using 'is False' instead of '== False') and expands one test to run across more test fixtures. There is no change to the actual wallet or PSBT parsing logic that users…
This commit only changes a test file. It removes a small helper method called parse() and replaces its calls with the same one-line PSBTParser constructor call written out directly. There is no change to the actual wallet/security code tha…