AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 64 Bitcoin

Merge pull request #1041 from Chaitanya-Keyal/psbt-negative-fee

Public commit record

What the developer wrote

Authored by Nick Klockenga

73/100 · Adequate
Merge pull request #1041 from Chaitanya-Keyal/psbt-negative-fee

Reject psbts whose outputs exceed their inputs
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This update makes SeedSigner refuse Bitcoin transaction files (PSBTs) where the outgoing amounts are larger than the incoming amounts. Before the fix, the device would have accepted such impossible transactions and shown the user a negative 'fee,' which could confuse someone into signing a transaction that the Bitcoin network would never accept. The change adds a clear error, a user-facing warning, and tests to confirm the behavior.

Recommended action

No action needed; this is a defensive hardening patch. Users and downstream projects should ensure they are running a version that includes this commit or later. Reviewers may want to confirm that no other PSBT parsing paths bypass this check.

Security signals we found

01

Input validation: rejects PSBTs with mathematically impossible fee values

02

User-facing safeguard: prevents confusing negative fee from reaching transaction review screens

03

New exception class with clear semantics (PSBTNegativeFeeError)

04

UI routing to discard malformed PSBT rather than crash or proceed

05

Test coverage for both negative-fee rejection and zero-fee acceptance boundaries

Risk score

Why this scored 64/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 12/15
Confidence 9/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.