XMR
← All projectsMonero Project

Monero

Reference Monero node, command-line wallet, consensus, networking, and cryptographic protocol implementation.

Cryptographic librariesMoneroNode implementationsPrivacy protocolsNormal
Repository coverage

743 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

219security candidates228second-pass queue447AI analyses
119commits · 30 days
240commits · 60 days
644commits · 180 days
742commits · 365 days
Backfill bands
Sep 27 → Mar 3192 seen34 candidatesComplete
Mar 31 → Jul 29369 seen101 candidatesComplete
Jul 29 → Aug 28128 seen36 candidatesComplete
Aug 28 → Sep 2788 seen21 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

51/100 average clarity
20Strong · 80–100
123Adequate · 60–79
534Thin · 40–59
66Opaque · 0–39
14security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
jeffro256633850257
koe313259
tobtoht1823283150
Cole Munz424177
Masamune222164
SNeedlewoods805152
selsta1744997051
j-berman432934058
jpk68881452046
Samy371023048
Thomas271015057
SChernykh1188062
Analysis record

Published AI watches

Last scanned 21 minutes ago

Low 42 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11462

This Monero wallet update fixes a bookkeeping bug. When a wallet imported a list of its owned outputs and that list was smaller than a previous import, internal lookup maps (key images and public keys) could still point to entries that no …

Internal index/cache consistency fix in wallet output handlingPrevents out-of-range references after transfer list resizeAdds defensive repair on wallet cache load for unrefreshed wallets
160e2150by tobtoht+29−02 files
No security note in commit
Low 26 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11460

This commit simplifies how Monero's simplewallet decides whether a payment ID is a real encrypted ID or a dummy placeholder. Previously, the wallet checked both the payment ID value and whether any destination was an integrated address, an…

Removal of a CHECK_AND_ASSERT_MES consistency check between destination flags and payment ID valueChange from dual-factor classification (address type + payload) to payload-only classificationPotential for previously rejected transactions to be accepted if the old check was overly strict
4b84712eby tobtoht+1−91 file
No security note in commit
Low 42 AI analysisMessage 50 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

wallet2: trim stale transfer maps after output imports

This Monero wallet patch cleans up internal lookup tables (key-image and public-key indexes) when the list of owned transaction outputs is shrunk, for example during an output import. Without the cleanup, those indexes could point to entri…

Out-of-bounds index retained in wallet lookup maps after container shrinkPotential wallet crash or incorrect spend selection due to stale key-image / public-key mappingRepair-on-load for legacy wallet caches that predate the fix
80f75eaaby selsta+29−02 files
No security note in commit
Low 25 AI analysisMessage 50 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

simplewallet: classify payment IDs by their payload

This small change removes a consistency check in Monero's command-line wallet when loading a saved transaction. Previously, the wallet verified that a 'dummy' payment ID label matched a special zero-value payment ID. Now it labels the paym…

Removal of a CHECK_AND_ASSERT_MES consistency checkRemoval of integrated-address validation for payment ID classificationChange in UI/labeling logic for loaded transactions
5937d5cfby selsta+1−91 file
No security note in commit
Informational 22 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11161

This commit updates Monero's built-in blockchain checkpoints to match the v0.18.5.3 release. Checkpoints are hard-coded reference points that help nodes quickly verify they are following the correct chain and resist certain attacks. The ch…

Hard-coded blockchain checkpoint data updated to a newer height/hashExpected compiled-in block hashes digest changedNo new code paths, cryptographic changes, or bug fixes visible in the diff
b0a9d51eby tobtoht+7−74 files
No security note in commit
Low 38 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11448

This is a small code fix in Monero's wallet that keeps the recorded breakdown of received amounts consistent when a transaction output is 'burnt' (replaced or spent as part of a transaction the wallet is processing). The change adds a chec…

Defensive consistency check added (THROW_WALLET_EXCEPTION_IF)Fixes internal accounting of received output amountsNo explicit security claim in commit or supplied references
24a01223by tobtoht+7−01 file
No security note in commit
Moderate 60 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11443

This patch fixes a spot in the Monero wallet where an untrusted remote server (daemon) could supply a misleading 'status' field. Previously, the wallet used that raw status directly in its error handling, which could potentially make a mal…

Untrusted input from remote daemon used in error-handling pathMissing trust check on daemon-reported RPC statusSingle-call-site hardening patch
c03c1f15by tobtoht+1−11 file
No security note in commit
Informational 15 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11406

This commit adds two new read-only options to the wallet's remote procedure call (RPC) interface so users can request their public view key and public spend key. Public keys are meant to be shared openly and are not secrets, so exposing th…

717a4235by tobtoht+17−03 files
No security note in commit
Informational 15 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11394

This commit only updates a submodule pointer for the external polyseed library from one commit hash to another. The actual code changes inside the submodule are not shown in the diff, and no public references were supplied. There is no vis…

c437e73fby tobtoht+1−11 file
No security note in commit
Moderate 64 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11391

This patch fixes a size-limit accounting bug in Monero's built-in HTTP server. When a client sends multiple HTTP requests back-to-back on the same connection (pipelining), leftover buffered data from the next request was not being counted …

Request size limit bypass via pipelined HTTP cachingDenial-of-service / memory pressure potential from oversized requestsFix in low-level network protocol handler
9b24b744by tobtoht+2−11 file
No security note in commit
Moderate 51 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11386

This patch fixes a privacy leak in Monero's wallet RPC server. Previously, the --no-dns flag was ignored when no wallet was loaded, so the validate_address RPC call could still perform a DNS lookup (OpenAlias) even though the user had expl…

Privacy leak: RPC ignored --no-dns when no wallet loadedDNS lookup performed despite explicit user opt-outOpenAlias resolution could disclose queried addresses/aliases to DNS resolvers
9df95286by tobtoht+33−25 files
No security note in commit
Low 48 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11385

This commit adds cleanup of three additional memory buffers in Monero's seed-phrase key-stretching code. Before the change, leftover copies of intermediate secrets could remain in stack memory after the function finished. An attacker who c…

Sensitive intermediate key material left in stack memory after function returnUse of sodium_memzero to clear cryptographic buffersPBKDF2 implementation handling mnemonic-derived secrets
1cd8ae93by tobtoht+3−01 file
No security note in commit
Informational 21 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11383

This update improves the Monero wallet's command that connects to a network node (daemon). It lets users supply a username/password and a proxy address when switching daemons, and it replaces an older one-step connection method with a newe…

Added mutex lock in wallet2::set_proxy to protect concurrent access to proxy and HTTP client stateset_daemon now passes RPC login credentials and proxy settings through the proper wallet2::set_daemon APITrust heuristic changed to only auto-trust local daemons when no proxy is in use
07e23b8fby tobtoht+78−172 files
No security note in commit
Low 42 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11253

This change alters how Monero creates a view-only wallet copy. Previously, the code exported outputs using a method that could strip some metadata. Now it copies the full internal transfer records directly, then wipes and clears the multi-…

Sensitive field sanitization before export (memwipe + clear of m_multisig_k)Change in data export path for view-only wallet creationPreservation of 'complete output metadata' implying previous path was incomplete
ff738959by tobtoht+9−31 file
No security note in commit
Moderate 69 AI analysisMessage 66 · Adequate
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11333

This Monero update hardens how public keys and transaction pubkeys are handled. It moves a low-level 'torsion clearing' routine into the core crypto library, adds checks that wallet/destination addresses are valid points on the main subgro…

Adds main-subgroup membership validation for public address keys (spend/view)Normalizes transaction public keys before use in payment-ID decryption and tx proofsMoves torsion-clearing primitive into core crypto layer to ensure consistent behavior
6f4b99abby tobtoht+178−15016 files
No security note in commit
Moderate 63 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11268

This Monero update fixes a networking bug where the server could accidentally block all of its worker threads while waiting for slow clients to accept data. If all workers became stuck this way, the node could stop processing any network t…

Removal of blocking condition-variable wait in network send pathFail-fast on send-queue overflow instead of parking worker threadsHTTP handler now propagates send failures and enters error state
dba16f07by tobtoht+205−3025 files
No security note in commit
Moderate 59 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11260

This Monero wallet patch adds stronger safety checks when a wallet prepares, signs, or loads multi-step transactions (unsigned transactions, multisig transactions, and cold-device transactions). It verifies that money going into the transa…

Adds duplicate-input detection across transaction setsAdds destination address type consistency checksAdds uint64 overflow guard for summed input amounts
66dd773eby tobtoht+265−454 files
No security note in commit
Low 34 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11144

This Monero update makes the network layer clean up leftover block download records when a peer connection fails or is rejected. Previously, rejected or disconnected peers could leave stale block spans in a queue, which might cause the nod…

Denial-of-service resistance: stale block spans from malicious or faulty peers could prevent a node from obtaining valid blocksState cleanup on peer disconnection/rejectionNo authentication or memory-safety bug evident in diff
ddfa2279by tobtoht+2−01 file
No security note in commit
Low 46 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11362

This small patch fixes a bug in the Monero wallet where, if an output had already been scanned once, the wallet would return early without clearing an error flag. In rare cases this could leave a stale 'error' state attached to a transacti…

Stale error-state propagation in wallet scanning logicMissing reset of tx_scan_info.error on cached/short-circuit code pathPotential for incorrect received-payment or scan-failure reporting
30860a26by tobtoht+3−01 file
No security note in commit
Low 34 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11366

This change fixes a binary search in the Monero wallet that previously could loop forever or behave incorrectly if something went wrong. The old code used an unbounded 'while (true)' loop and a midpoint calculation that could overflow. The…

Unbounded loop replaced with bounded iterationInteger overflow mitigation in midpoint calculationDefensive error handling added for search failure
c16cd3f7by tobtoht+4−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidatewallet_api: reject transaction file signing with hardware walletsby selsta · eeb82456 · Aug 3, 2026 · 1 fileMessage 50 · ThinLow 46Details
Commit message · selsta

wallet_api: reject transaction file signing with hardware wallets

Reported by zkao, a tool by zkSecurity

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 46/100

This change blocks a specific command—signing unsigned transaction files—from being used when a Monero wallet's private keys live on a hardware device (Ledger/Trezor). Before the patch, the software apparently allowed users to attempt this operation, which hardware wallets do not actually support. The patch now returns a clear error instead of proceeding. The risk is that a user or third-party tool could be misled into thinking a transaction was properly signed when it was not, potentially causing loss of funds or a failed/confused workflow. No exploit code is shown in the commit.

Security candidaterpc: hide sensitive txs from restricted block templatesby selsta · 8a393ed8 · Aug 3, 2026 · 8 filesMessage 50 · ThinModerate 63Details
Commit message · selsta

rpc: hide sensitive txs from restricted block templates

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Moderate 63/100

This Monero patch changes how block templates are built for restricted RPC users. Before, a remote user calling the get_block_template RPC on a restricted node could receive a block template containing sensitive transactions—specifically transactions that were relayed privately (such as Dandelion++ stem transactions). The patch adds a flag so restricted RPC callers get a template that only includes publicly broadcast transactions, while local/unrestricted callers still get the full template. This reduces information leakage about pending private transactions to untrusted RPC clients.

Security candidatecryptonote_protocol: avoid copying block span in add_blocksby jpk68 · e6d0d1e7 · Aug 2, 2026 · 1 fileMessage 50 · ThinInformational 16Details
Commit message · jpk68

cryptonote_protocol: avoid copying block span in add_blocks

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathparser or protocol path
AI analysis · Informational 16/100

This is a tiny performance tweak in Monero's network code. It changes one function call so that a batch of downloaded blocks is moved rather than copied into an internal queue. There is no security fix here and no indication it addresses a vulnerability.

Security candidatesimplewallet: use the swept account for index=all in sweep_mainby Cole Munz · e26eab8c · Aug 1, 2026 · 1 fileMessage 73 · AdequateLow 32Details
Commit message · Cole Munz

simplewallet: use the swept account for index=all in sweep_main

sweep_main() takes the account to sweep as a parameter, but the index=all
expansion still counts subaddresses on m_current_subaddress_account. sweep_all
and sweep_below pass the current account, so sweep_account is the one command
that ends up with the wrong set.

When the current account has fewer subaddresses than the account being swept,
the set is too small and outputs in the higher minor indices never make it into
the sweep. If none of the target's unlocked outputs land in that range,
create_transactions_all throws "No unlocked balance in the specified
subaddress(es)" for an account that plainly has a balance.

27d551d12f8d added the account parameter and pointed create_transactions_all at
it, but left this loop on the old field. The RPC path already does it the right
way, with get_num_subaddresses(req.account_index).

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
privacy or spend-authorization protocolsigning or wallet path
AI analysis · Low 32/100

This is a one-line bug fix in Monero's command-line wallet. The 'sweep_account' command, when asked to sweep all subaddresses of a different account than the one currently selected, accidentally looked at the wrong account's list of subaddresses. This could cause some funds to be left behind or the command to wrongly report that the target account had no spendable balance. It does not let an attacker steal funds; it is a user-facing functional bug that could surprise a wallet user.

Security candidatecryptonote_basic: keep additional derivations aligned in key image helperby Cole Munz · 5f767c6e · Aug 1, 2026 · 2 filesMessage 73 · AdequateHigh 76Details
Commit message · Cole Munz

cryptonote_basic: keep additional derivations aligned in key image helper

generate_key_image_helper only appended to additional_recv_derivations when
generate_key_derivation succeeded. A tx pubkey that is not a valid point makes
that call fail, so every later derivation shifted down one slot.

is_out_to_acc_precomp indexes that vector by the output index, so once the
list is short the lookup either falls off the bounds check or reads the
derivation belonging to a different output. Either way the helper reports that
the output does not belong to the address, and the wallet cannot build a key
image for an output it owns. Anyone who can put a transaction in front of the
wallet chooses those pubkeys.

The main tx pubkey a few lines up already handles a failed derivation by
keeping its slot and padding with identity, and wallet2 does the same in the
three places it builds this list (wallet2.cpp:2393, :7887, :13397). Do it here
too.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
privacy or spend-authorization protocolcryptography-sensitive path
AI analysis · High 76/100

This patch fixes a bug in how Monero wallets build key images for transaction outputs they own. When a transaction contained an invalid extra public key, the wallet would misalign its internal list of cryptographic derivations. This caused the wallet to either look at the wrong entry or fail to recognize its own output, preventing it from creating a key image. Because anyone can craft a transaction with such an invalid key, this could be used to stop a wallet from spending its own funds. The fix pads the failed derivation with a placeholder so the list stays aligned with output indexes.

Security candidatecryptonote_core: fully parse incoming block batchesby selsta · 967aa9f7 · Jul 30, 2026 · 1 fileMessage 50 · ThinLow 44Details
Commit message · selsta

cryptonote_core: fully parse incoming block batches

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Low 44/100

This change alters how Monero processes batches of incoming blocks. Previously, if any block in a batch was already known, the code would skip fully parsing the remaining blocks. Now it parses all blocks regardless. This could have hidden a bug where incomplete parsing led to inconsistent state, but the patch itself is small and the exact security impact is not stated by the vendor.

Security candidatecryptonote_protocol: avoid overlapping reserved spansby selsta · e59781ab · Jul 30, 2026 · 2 filesMessage 50 · ThinModerate 59Details
Commit message · selsta

cryptonote_protocol: avoid overlapping reserved spans

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathparser or protocol path
AI analysis · Moderate 59/100

This commit fixes a bug in how Monero nodes request blocks from peers during blockchain synchronization. Before the fix, a node could accidentally reserve the same range of blocks twice from different peers, wasting bandwidth and potentially causing synchronization confusion. The fix adds a check to skip over any block ranges that are already reserved. A new test confirms the behavior.

Security candidatecryptonote_protocol: include pruned weights in sync sizingby selsta · f543a36d · Jul 29, 2026 · 10 filesMessage 50 · ThinLow 45Details
Commit message · selsta

cryptonote_protocol: include pruned weights in sync sizing

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathparser or protocol path
AI analysis · Low 45/100

This Monero commit changes how a node calculates the size of upcoming block batches during sync. Previously, when a peer sent 'pruned' blocks (a compressed form), the node did not fully count those blocks toward its sync-size budget and only checked that their reported weight was non-zero. The patch makes the node use the pruned blocks' reported weights in its size calculations and verifies those weights against data already stored in its own chain. The main effect is to prevent a malicious or buggy peer from making the node request far more data than expected, which could slow or disrupt syncing. It is a hardening/DoS-mitigation change rather than a direct coin-theft bug.

Security candidatecryptonote_protocol: limit queued blocks dynamicallyby selsta · 89d8db06 · Jul 29, 2026 · 7 filesMessage 50 · ThinLow 38Details
Commit message · selsta

cryptonote_protocol: limit queued blocks dynamically

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathparser or protocol path
AI analysis · Low 38/100

This Monero commit rewrites how the peer-to-peer block download queue is limited. Instead of capping the number of 'spans' (batches) of blocks, it now caps the total number of queued blocks based on the measured download speed and a user-configurable target time. The change also fixes a couple of small arithmetic edge cases, such as avoiding division by zero when measuring microseconds and guarding against invalid or infinite block rates. The commit message and diff do not describe any security bug; it reads as a performance and robustness improvement to sync behavior.

Security candidateremove translationsby tobtoht · 74e03c43 · Jul 28, 2026 · 26 filesMessage 18 · OpaqueInformational 15Details
Commit message · tobtoht

remove translations

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
signing or wallet pathboot or update path
AI analysis · Informational 15/100

This commit removes the entire translation/internationalization system from the Monero command-line tools. It deletes translation files, build scripts, documentation, and the code that loaded and applied translated text. The remaining code now always displays English text. There is no security fix or vulnerability here; it is a feature-removal cleanup change.

Security candidatecryptonote_core: remove dead codeby Thomas · e7278c0a · Jul 28, 2026 · 7 filesMessage 58 · ThinInformational 15Details
Commit message · Thomas

cryptonote_core: remove dead code

Never had a caller:
- Blockchain::init taking HardFork*&: added in 8f863e742, no caller in
any revision since
- tx_memory_pool::get_txpool_weight, set_txpool_max_weight: added as
get_txpool_size and set_txpool_max_size in bc61ae69b alongside
--max-txpool-size, which is wired through tx_memory_pool::init
instead; renamed size to weight in 5ffb2ff9b, still uncalled
- get_transaction_version: added in b750fb27b, no caller since

Dead when their last user went:
- core::get_blocks taking vector<pair<blobdata, block>>, both overloads:
last caller removed in 9faef1f83; ed2c81ed9 later converted the
already-dead signatures from std::list to std::vector. The
vector<block> overload is still used by core_tests and is kept
- blocks_container: 9e82b694d removed the in-memory blockchain that
used it
- tx_by_fee_and_receive_time_entry: 445319d3f replaced the sorted
container it keyed with a boost::bimap
- m_store_blockchain_interval: its do_call went with the original
blockchain_storage format in 9e82b694d
- m_fork_moaner: its do_call went with the "We are most likely forked"
message in f0371210e

Also drops two break statements after a return in ver_mixed_rct_semantics
and the doc comments belonging to the removed declarations.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
signing boundarycryptography-sensitive path
AI analysis · Informational 15/100

This commit is a routine cleanup that removes unused functions, type aliases, and unreachable code from Monero's core blockchain and transaction-pool modules. The removed code had no callers, so the change cannot be used to attack the network or users. It is purely a maintenance refactor.

Security candidateringct: cleanup proveRctCLSAGSimpleby jeffro256 · 6620c2db · Jul 27, 2026 · 1360 filesMessage 50 · ThinInformational 15Details
Commit message · jeffro256

ringct: cleanup proveRctCLSAGSimple

1. Document parameters
2. Document inner variables
3. Remove dead variables
4. Remove unneseccary allocations

50/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body
Why it was queued
privacy or spend-authorization protocolcryptography-sensitive pathseed or entropy pathsigning or wallet pathboot or update pathauthentication pathparser or protocol path
AI analysis · Informational 15/100

This commit is titled as a cleanup of a single RingCT function (proveRctCLSAGSimple), but the supplied diff is actually a massive repository import/addition of 1,360 files (696,994 insertions) including the entire Monero codebase, build system, CI workflows, documentation, tests, and submodules. There is no actual code change to proveRctCLSAGSimple visible in the provided diff. No security-relevant change is present in the materials supplied.

Security candidatep2p: stop buffered dispatch after fatal notificationsby selsta · 1bae55ae · Jul 27, 2026 · 4 filesMessage 50 · ThinModerate 59Details
Commit message · selsta

p2p: stop buffered dispatch after fatal notifications

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathparser or protocol path
AI analysis · Moderate 59/100

This patch changes how Monero's peer-to-peer networking layer handles bad or rejected messages. Previously, when a message handler decided to drop a peer, it often returned a generic success-like code (1) or a 'handler not defined' error. The patch makes these handlers return a specific connection error code, and makes the lower-level protocol stop processing further buffered messages from that peer when it sees a fatal error. This prevents a misbehaving or malicious peer from forcing the node to keep handling queued messages after the node has already decided to disconnect. The change also ensures notifications (one-way messages) return OK instead of a handler-not-defined error when a command is filtered, avoiding spurious errors.

Security candidatetxpool: fix time_in_pool age calculationby selsta · 265f7b28 · Jul 26, 2026 · 1 fileMessage 45 · ThinInformational 19Details
Commit message · selsta

txpool: fix time_in_pool age calculation

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 19/100

This commit fixes a simple arithmetic bug in how long a transaction has been waiting in the memory pool ("time in pool") was calculated. The old code subtracted the current time from the receive time in the wrong order, which could produce a very large, nonsensical age value instead of a small positive number. The fix ensures the age is always the current time minus the receive time, or zero if the clock somehow runs backward. This is a correctness fix for statistics/ranking of pending transactions, not a direct funds-theft or code-execution vulnerability.

Security candidatewallet2: check for overflow when calculating fee from weightby selsta · e2a4f68e · Jul 26, 2026 · 1 fileMessage 55 · ThinModerate 59Details
Commit message · selsta

wallet2: check for overflow when calculating fee from weight

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
memory safetysigning or wallet path
AI analysis · Moderate 59/100

This commit adds an overflow check when the Monero wallet calculates transaction fees from a transaction's weight. Before the patch, multiplying a large 'weight' value by a non-zero 'base_fee' could silently wrap around to a tiny number, potentially causing the wallet to propose an incorrect (possibly far too low) fee. The fix now throws an internal wallet error instead of silently producing a wrong result.

Security candidatedevice_trezor: improve error message for view key exportby jpk68 · 6e35278b · Jul 26, 2026 · 1 fileMessage 50 · ThinInformational 17Details
Commit message · jpk68

device_trezor: improve error message for view key export

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
privacy or spend-authorization protocol
AI analysis · Informational 17/100

This commit changes how Monero's Trezor hardware wallet integration handles one specific error. Previously, if a user cancelled the view-key export on their Trezor device, the code fell through to a generic 'Get secret keys exception' message and returned false. Now it immediately throws a clearer error: 'Key export rejected on device.' This is a user-experience and diagnostic improvement, not a fix for an exploitable security flaw.

Security candidateOptimize hashing of generic typesby SChernykh · 8b012e4d · Jul 24, 2026 · 4 filesMessage 60 · AdequateLow 45Details
Commit message · SChernykh

Optimize hashing of generic types

Use a proper hash function instead of f(x)=x to achieve better distribution of hash values

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathseed or entropy path
AI analysis · Low 45/100

This commit changes how Monero hashes certain internal data types. Previously, some types were hashed using a simple identity function that directly used raw bytes as the hash value, which can cause many items to land in the same hash-table bucket and potentially leak information through timing or collision patterns. The patch replaces that with SipHash-2-4, a keyed, cryptographically designed hash function, using a secret random key generated at startup. This is a defensive hardening change; the commit message frames it only as a performance/distribution optimization, not as a security fix.

Security candidatecrypto: add FCMP++ generators T, U, & Vby jeffro256 · 9696cae5 · Jul 23, 2026 · 2 filesMessage 76 · AdequateInformational 15Details
Commit message · jeffro256

crypto: add FCMP++ generators T, U, & V

Sources in FCMP++ repo:
- T: https://github.com/monero-oxide/monero-oxide/blob/0e438aed2cce5c0ab8a935916c1a89bb0077f97f/monero-oxide/ed25519/src/compressed_point.rs#L76-L79
- U: https://github.com/monero-oxide/monero-oxide/blob/0e438aed2cce5c0ab8a935916c1a89bb0077f97f/monero-oxide/ringct/fcmp%2B%2B/generators/src/lib.rs#L16-L18
- V: https://github.com/monero-oxide/monero-oxide/blob/0e438aed2cce5c0ab8a935916c1a89bb0077f97f/monero-oxide/ringct/fcmp%2B%2B/generators/src/lib.rs#L20-L22

76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
privacy or spend-authorization protocolcryptography-sensitive path
AI analysis · Informational 15/100

This commit adds three new cryptographic generator points (named T, U, and V) to Monero's code. These are special numbers used in a new privacy feature called FCMP++. The commit also adds helper functions to recreate and access these generators. There is no indication of a security bug or vulnerability in this change; it is a straightforward addition of constants needed for future protocol work.

Security candidatecrypto: add Ed25519->X25519 conversion functionsby jeffro256 · 6c395945 · Jul 22, 2026 · 2 filesMessage 60 · AdequateInformational 18Details
Commit message · jeffro256

crypto: add Ed25519->X25519 conversion functions

Reviewed-by: koe <ukoe@protonmail.com>
Reviewed-by: j-berman <justinberman@protonmail.com>

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 18/100

This commit adds two new math helper functions that convert points between two related elliptic-curve formats used in cryptography (Ed25519 and X25519). It is a pure addition of utility code; there is no bug fix, no change to existing behavior, and no indication it addresses a security flaw. The code includes a safety check that rejects the special 'identity' (zero) point, which is a sensible defensive measure.

Security candidatecmake: add wire dependency for cryptonote_core RTTI linkageby selsta · 9e3c336e · Jul 21, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · selsta

cmake: add wire dependency for cryptonote_core RTTI linkage

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathdocumentation-only discount
AI analysis · Informational 15/100

This is a one-line build-system change that adds a missing library dependency ('wire') so another component can compile and link correctly. There is no indication it fixes a security vulnerability; it appears to be a routine build fix.

Security candidatecrypto: avoid unaligned word accessesby Samy · 4b042bbf · Jul 21, 2026 · 4 filesMessage 45 · ThinLow 47Details
Commit message · Samy

crypto: avoid unaligned word accesses

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Low 47/100

This commit removes compiler directives that forced certain cryptographic data structures to be packed tightly without padding, and replaces some direct multi-byte memory reads with safer memcpy operations. On some processors, reading a multi-byte value from a memory address that is not aligned to that value's size can cause a crash or reduced performance. The change makes the code safer and more portable across different CPU architectures, but it does not appear to fix an exploitable remote vulnerability in the Monero network itself.

Security candidatecrypto: fix ARMv8 slow-hash inline assembly constraintsby selsta · 8e8e04dd · Jul 21, 2026 · 1 fileMessage 50 · ThinLow 31Details
Commit message · selsta

crypto: fix ARMv8 slow-hash inline assembly constraints

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Low 31/100

This commit fixes the way a Monero cryptographic function for ARMv8 processors describes its inline assembly code to the C compiler. Previously, the assembly block did not properly tell the compiler which memory and CPU registers it reads and writes. This can lead to subtle bugs where the compiler optimizes code incorrectly around the assembly, potentially causing wrong hash results or memory corruption on ARMv8 devices. The fix adds proper input/output constraints and a clobber list so the compiler knows exactly what the assembly touches.

Security candidateserialization: validate RingCT prunable JSON typeby selsta · 37749997 · Jul 21, 2026 · 1 fileMessage 45 · ThinLow 47Details
Commit message · selsta

serialization: validate RingCT prunable JSON type

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
defensive validationprivacy or spend-authorization protocol
AI analysis · Low 47/100

This commit adds a type check in Monero's JSON deserialization code. Before the fix, when reading a RingCT signature from JSON, the code assumed the 'prunable' field was a JSON object and accessed it directly. If someone supplied a non-object value (like a number or string), the code could read memory incorrectly or crash. The patch now throws a clear error if the type is wrong.

Security candidateFCMP++: output_to_tuple {output pubkey, commitment} -> {O,I,C}by j-berman · 99bda32d · Jul 21, 2026 · 8 filesMessage 73 · AdequateInformational 12Details
Commit message · j-berman

FCMP++: output_to_tuple {output pubkey, commitment} -> {O,I,C}

- Function to convert an {output pubkey, commitment} to an output
tuple {O,I,C} in prepartion to insert the output tuple into the
curve tree.
- O = torsion cleared valid output pubkey checked for identity.
- I = key image generator.
- C = torsion cleared valid Commitment checked for identity.
- None of {O,I,C} should have torsion nor == identity.
- Introduces the OutputPair variant, which can either be Legacy
or Carrot V1 types. Legacy outputs are not checked for torsion
at consensus, and use the legacy biased hash to point fn to derive
the key image generator (I). Carrot V1 outputs **are** checked for
torsion at consensus, and use the unbiased hash to point to derive
the key image generator (I).

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
consensus or confidential-proof validationprivacy or spend-authorization protocol
AI analysis · Informational 12/100

This commit adds new code for an upcoming Monero privacy feature called FCMP++. It creates a helper function that converts an output's public key and commitment into a special three-part tuple used by the new system. The commit is defensive in nature: it carefully clears mathematical 'torsion' from points, rejects identity points, and explicitly avoids a subtle double-spend risk that could occur if the wrong version of a key were used around a network upgrade. There is no indication this commit fixes an active bug or vulnerability; it appears to be a building block for future functionality.

Security candidatewallet: derive encrypted payment ID dummy/real status from tx.extra, not cd.destsby waris ) · afcfd976 · Jul 21, 2026 · 3 filesMessage 50 · ThinModerate 59Details
Commit message · waris )

wallet: derive encrypted payment ID dummy/real status from tx.extra, not cd.dests

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
privacy or spend-authorization protocolsigning or wallet path
AI analysis · Moderate 59/100

This Monero wallet patch changes how the wallet decides whether an encrypted payment ID is real or a dummy placeholder. Previously, the wallet relied on destination address data (cd.dests), which could be manipulated by a malicious signer or loaded transaction to make a real payment ID look fake, or a fake one look real. The patch now derives that status directly from the transaction's extra field, where the payment ID is actually stored, and adds a consistency check. This is a security fix for a potential information leak or user deception during multi-step transaction signing.