AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 29 Cryptographic libraries

Polyseed support for 'wallet2', Wallet API, CLI wallet app, wallet RPC server

Public commit record

What the developer wrote

Authored by rbrunner7

73/100 · Adequate
Polyseed support for 'wallet2', Wallet API, CLI wallet app, wallet RPC server

Co-authored-by: tevador <tevador@gmail.com>
Co-authored-by: tobtoht <tob@featherwallet.org>
Co-authored-by: Czarek Nakamoto <cyjan@mrcyjanek.net>
Co-authored-by: selsta
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit adds support for a new type of wallet backup phrase called Polyseed to the Monero wallet software. It touches many wallet components (CLI, RPC, library API) so users can create, restore, and display Polyseed backups alongside the older 25-word legacy seeds. The change also stores a new Polyseed field in encrypted wallet files and handles passphrases/seed offsets in a specific way. There is no direct evidence in the commit that this fixes an active security bug; it reads as a large feature addition. However, because it changes how secret key material is serialized, encrypted, and derived from seed words, any mistakes in this area could affect wallet security or recoverability.

Recommended action

Treat this as a high-risk feature commit rather than a confirmed vulnerability. Reviewers should audit the Polyseed C++ wrapper and PBKDF2 implementation, verify that the new key-stream XOR ordering cannot corrupt existing multisig wallets, confirm that passphrase handling does not introduce confusion between encrypted Polyseeds and legacy seed offsets, and ensure the new account_keys fields are safely encrypted and wiped from memory. Fuzzing mnemonic parsing and regression-testing wallet file upgrade/downgrade paths are also recommended.

Security signals we found

01

Changes secret-key serialization format (m_polyseed and m_monero_c_passphrase added to account_keys KV map)

02

Modifies key-stream XOR encryption to include new fields, with explicit backward-compatibility ordering comment

03

Adds new seed-derivation path using external polyseed library and PBKDF2-HMAC-SHA256

04

Handles encrypted Polyseeds vs legacy seed-offset passphrases with branching logic

05

Adds wallet file attribute parsing for 'feather.seed' and auto-migration to Polyseed

06

Background sync code now restores m_polyseed from keys file after reload

07

Large feature patch (+1653/-280) increases attack surface in mnemonic handling

Risk score

Why this scored 29/100

Our methodology →
Potential impact 5/30
Exploitability 3/25
Stealth signal 4/15
Affected reach 8/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.