Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
53/100 average clarity
22Strong · 80–100
158Adequate · 60–79
690Thin · 40–59
66Opaque · 0–39
14security candidates with opaque commit messaging
This commit only adds a new automated test tool (a fuzzer) for the Monero wallet. It does not change any production wallet, node, or consensus code. It cannot by itself introduce a vulnerability that affects real users, nor does it fix one…
This is a cleanup and refactoring patch for Monero's new FCMP++ (full-chain membership proof) database and transaction handling code. It renames a method, fixes typos and comments, tightens a constant name, adds a safety check that outputs…
Added runtime invariant check that locked outputs do not unlock below the default unlock blockRefactored transparent-amount commitment collection to reduce indirection and potential misuseClarified unlock-time semantics and coinbase detection in migration code
This commit is a cleanup and hardening patch following an earlier pull request. It adds a safety check to make sure outputs are not incorrectly treated as spendable before they should be, fixes several typos and variable-name issues, rewri…
Added invariant check that outputs unlock no earlier than the default unlock block before adding locked outputs to the databaseRefactored transparent-amount commitment collection to remove std::reference_wrapper indirection, reducing complexityCorrected constant-name typos in spendable-age calculations
This is a one-line fix in Monero's wallet software that adjusts how far ahead the wallet tries to 'skip' scanning after a blockchain reorganization (reorg). A reorg happens when the network briefly disagrees on the chain of blocks and then…
Incorrect scan resume height after blockchain reorgPotential missed transaction detectionBalance accuracy issue in wallet
This commit is a code cleanup that replaces the non-standard WIN32 preprocessor macro with the compiler-defined _WIN32 macro across 18 files. It does not change program logic or behavior; it only makes Windows-specific code detection more …
No functional code changes observedPreprocessor macro standardization onlyWindows-specific code paths remain identical in behavior
This commit only adds a new automated security test (a fuzzer) for Monero's wallet cache file parser. It does not change any production wallet code, fix a bug, or introduce a vulnerability. It is a testing-only addition intended to help fi…
Adds a fuzz target for wallet cache deserializationNo changes to production code pathsNo patch of a reported vulnerability
This Monero update adds a cache that remembers which transactions in the memory pool have already failed expensive input verification, so the node does not waste CPU re-checking the same bad transaction repeatedly. It is a performance and …
Adds caching of invalid input verification IDs to avoid repeated expensive ring signature verificationReduces CPU consumption for transactions that re-enter or remain in the mempool with unchanged invalid inputsCould mitigate a minor denial-of-service vector where a node repeatedly re-verifies a bad transaction
This patch changes how Monero's daemon calculates the total coinbase transaction sum (emission plus fees) for a range of blocks. Previously, the code called a general 'get_transactions' helper that could trigger a deadlock because it might…
Deadlock avoidance in consensus-related coinbase emission calculationChange from general transaction retrieval to direct, pruned database readAddition of functional test covering coinbase sum correctness
This change is a performance optimization for the Monero wallet's balance-reporting RPC. When a user asks for balances across many subaddresses, the code now pre-counts unspent outputs in one pass instead of re-scanning the entire transact…
This update adds a safety check in the Monero wallet's fast refresh process. Previously, if a malicious or buggy remote server told the wallet to start syncing from a block height beyond the wallet's known blockchain data, the wallet could…
Added bounds check on untrusted server-supplied start_height against local hash chain sizeDefensive hardening at wallet/daemon trust boundaryUnit test demonstrates rejection of out-of-bounds refresh request
This commit tightens filename validation in the Monero wallet's remote-control interface (RPC server). It now rejects wallet names that are just '.' or '..', contain a hidden null character, or contain path separators like '/' (and on Wind…
Path-traversal defense: blocks directory separators and parent-directory references in wallet filenamesNull-byte injection defense: rejects embedded NUL characters that could truncate or confuse downstream path handlingRPC input validation hardening in wallet_rpc_server
This Monero wallet update fixes a file-handling bug in the 'save wallet as' function. Previously, the code compared only the main wallet cache path and used a simple path check that could be fooled by symlinks or filenames ending in '.keys…
Path overlap / self-overwrite protection for wallet cache and keys filesSymlink and hardlink alias detection using boost::filesystem::equivalentRejection of ambiguous paths where .keys file and cache file could collide
This commit adds an optional, faster way to set up N-of-N Monero multisig wallets. Normally, all signers must complete a final verification round to prove they are active and have finished setup. The new 'fast non-interactive setup' skips …
New feature adds a non-default, opt-in fast setup path that intentionally weakens a liveness/verification guaranteeForce-update flag (force_update_use_with_caution) is used internally to bypass the normal post-KEX roundUser-facing and API documentation clearly warn that funds may become inaccessible if other signers do not complete setup
This change refactors how Monero's wallet fetches transaction data when creating or verifying 'spend proofs'—cryptographic receipts that prove you spent funds. Previously, spend-proof code fetched transactions directly from the network dae…
Refactoring of spend-proof transaction lookup to a single helperAddition of explicit RPC timeout parameter to transaction fetch helperImproved daemon RPC error/status reporting in get_tx_for_proof
This commit refactors how the Monero wallet fetches a transaction when verifying a payment proof (the check_tx_key feature). It replaces a direct daemon RPC call with a helper function called get_tx_for_proof, which is described in the com…
Replaces direct /gettransactions RPC with centralized helper for proof verificationCommit title explicitly frames change as 'verify v1 txid in check_tx_key'Removes local tx_hash == txid equality check in favor of helper-internal verification
This change stops a Monero wallet from creating 'InProofs' (receipt proofs) for transactions that the wallet itself sent. InProofs are meant to prove to someone else that you received money. If a wallet could generate an InProof for a tran…
Prevents generation of misleading InProofs for outgoing/self-sent transactionsAdds explicit runtime guard in wallet proof generation pathFunctional tests updated to assert refusal behavior
This patch fixes a bug in the Monero wallet where, if a pending transaction failed, the wallet could incorrectly mark coins as unspent even though they had already been spent by a separate confirmed transaction. This could let the wallet t…
Incorrect state reset on failure pathPotential double-spend attempt caused by stale UTXO selectionWallet balance/availability inconsistency after failed pending tx
This commit only adds a new automated fuzz-testing harness for Monero wallet features. It does not change any production wallet code, fix a bug, or alter network behavior. It is a test-only addition intended to help find bugs in the future…
Adds fuzz targets for payment URI parsing and transaction proof verificationNo changes to production wallet, consensus, or network codeNo bug fix or behavior change in existing source files
This Monero update fixes a bug in how nodes ask each other for blockchain history. Previously, a node could get stuck or drop a peer when it already knew about some blocks from another connection, because it would not ask for the next batc…
P2P protocol synchronization logic changePotential denial-of-service via peer dropping or sync stallNo authentication or cryptographic boundary crossed
This commit fixes a bug in how the Monero wallet saves itself to disk. Previously, the wallet could accidentally overwrite or corrupt its own files when the user chose a path that overlapped with existing wallet files, such as saving to a …
File overwrite / corruption prevention in wallet save path handlingSymlink and hardlink alias detection via filesystem equivalent() checksRejection of overlapping source/destination wallet files
cryptonote_core: remove Boost serialization for tx_source_entry
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 11/100
This commit removes the Boost serialization code for a Monero internal data structure called tx_source_entry. It deletes about 20 lines of code that described how this structure is converted to/from a serialized format. The change appears to be a cleanup or hardening step, not a fix for an active vulnerability. There is no direct evidence in the commit that this change addresses a security bug, and no public references were provided.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
privacy or spend-authorization protocolcryptography-sensitive pathsigning or wallet path
AI analysis · Informational 17/100
This commit renames and rewrites a Monero function used to compute a 'zero-commitment' Pedersen commitment (a cryptographic value that hides transaction amounts). The new implementation uses a precomputed table and a vartime (variable-time) bit-by-bit addition to make the calculation about six times faster. The commit does not claim to fix any security bug, and the diff itself shows no signs of a vulnerability. The main risk is that the new code must produce exactly the same results as the old code, otherwise consensus between nodes could break.
Security candidatesrc: update checkpoints to match v0.18.4.6by selsta · f459bd65 · Feb 13, 2026 · 4 filesMessage 45 · ThinInformational 15Details
Commit message · selsta
src: update checkpoints to match v0.18.4.6
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit is a routine maintenance update that adds a new blockchain checkpoint and updates version references in documentation. Checkpoints are like agreed-upon 'milestones' in the blockchain that help nodes sync faster and resist certain attacks. There is no indication of a security fix or vulnerability in this change.
* Use -O3 and other flags instead of -Ofast - https://discourse.llvm.org/t/rfc-deprecate-ofast/78687 - https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html * Find libunwind library based on C++ compiler type, not C compiler type * In stack_trace.cpp, pass stream modifiers to `std::stringstream` first, then send string to log * In stack_trace.cpp, remove dead code related to `stack_trace_log` path * Remove `virtual` method attributues from `final` class `cryptonote::core` * Remove unused `this` capture in cryptonote protocol handler * Remove unused variable `bad` in net node * Use `std::make_unsigned` instead of `boost::make_unsigned` - https://github.com/boostorg/type_traits/issues/171 - https://github.com/boostorg/type_traits/issues/202 - https://github.com/boostorg/type_traits/pull/199 * Cleanup `include`s in pair serialization * Test convergence b/t `std::make_unsigned` and `boost::make_unsigned`
Fixes compilation and silences warnings on: clang version 21.1.6 Linux 6.18.8-3-cachyos
69/100 · AdequateMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathparser or protocol path
AI analysis · Low 27/100
This is a routine maintenance patch that makes Monero compile cleanly on the upcoming Clang 21 compiler. The most notable change is replacing the aggressive '-Ofast' optimization flag with '-O3 -ffast-math -fno-semantic-interposition', which removes a compiler option that could theoretically allow unsafe floating-point and memory optimizations. The rest of the patch removes dead code, unused variables, and compiler warnings. There is no direct evidence this fixes an active security vulnerability, but the compiler-flag change is a sensible hardening step.
src: dynamic span, to calculate span limit dynamically
Co-authored-by: nahuhh - jberman review - cryptonote_protocol: don't arbitrarily download 1000 blocks ahead - further restrict `proceed` to require `queue_proceed` in all cases. ensure queue_proceed is true if we need the next block, even if we already exceed the span and size limits
cryptonote_protocol: improved logging + const usage in span downloader
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive pathparser or protocol path
AI analysis · Low 26/100
This Monero commit changes how many future blocks a node asks peers for during initial sync. Previously the node would always download up to 1,000 blocks ahead regardless of conditions. Now it calculates a dynamic limit based on recent download speed and a user-configurable 'span-limit' (default 2 minutes of blocks). The change also tightens the logic so the node only proceeds to request more blocks when it actually needs the next block or when queue limits allow. It is primarily a performance and robustness improvement, not a clear security fix, though the old behavior could have made nodes easier to overload with excessive download requests.
✓ Subject identifies a change✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathseed or entropy pathsigning or wallet pathboot or update pathauthentication pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Informational 15/100
This commit is a massive merge of pull request #9494 titled 'dynamic block sync size' into the Monero repository. The supplied diff only shows the addition of repository boilerplate files (git attributes, GitHub Actions CI workflows, gitignore, gitmodules, CMakeLists.txt, Dockerfile, Doxyfile, etc.) and does not include the actual code changes related to 'dynamic block sync size'. There is no security-relevant code change visible in the provided materials.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
boot or update path
AI analysis · Informational 20/100
This commit swaps out one Monero project domain ending in .no for one ending in .co in three places: software update checks, a DNS debugging tool, and a peer network blocklist. It is a routine infrastructure/domain-list change. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be domain housekeeping, possibly because the .no domain was lost, expired, or no longer controlled by the project.
Does the following to speedup the `/is_key_image_spent` RPC endpoint: - Reads all on-chain key images in one LMDB read transacion - Uses `cryptonote_core::are_key_images_spent_in_pool()` instead of `cryptonote_core::get_pool_transactions_and_spent_keys_info()` for pool querying. This only does a LMDB read per key image if in the pool. - Filters known on-chain spent key images before querying for key images spent in pool
This RPC endpoint was causing major daemon slowdowns in the Carrot/FCMP++ Alpha Stressnet when using the `rescan_spent` command, especially for large wallets. The effect was much worse if the mempool was full.
privacy or spend-authorization protocolcryptography-sensitive path
AI analysis · Informational 18/100
This commit is a performance optimization for a Monero daemon RPC endpoint called /is_key_image_spent. It speeds up wallet rescan operations by reading on-chain key images in a single database transaction and by querying the memory pool more efficiently. The change is framed as a fix for severe daemon slowdowns during stress testing, not as a security vulnerability. There is no direct evidence in the commit of a security flaw, but the prior behavior could be abused to cause denial of service by sending many expensive queries.
cryptonote_core: cache input verification results directly in mempool
This replaces `ver_rct_non_semantics_simple_cached()` with an API that offloads the responsibility of tracking input verification successes to the caller. The main caller of this function in the codebase, `cryptonote::Blockchain()` instead keeps track of the verification results for transaction in the mempool by storing a "verification ID" in the mempool metadata table (with `txpool_tx_meta_t`). This has several benefits, including:
* When the mempool is large (>8192 txs), we no longer experience cache misses and unnecessarily re-verify ring signatures. This greatly improves block propagation time for FCMP++ blocks under load * For the same reason, reorg handling can be sped up by storing verification IDs of transactions popped from the chain * Speeds up re-validating every mempool transaction on fork change (monerod revalidates the whole tx-pool on HFs #10142) * Caches results for every single type of Monero transaction, not just latest RCT type * Cache persists over a node restart * Uses 512KiB less RAM (8192*2*32B) * No additional storage or DB migration required since `txpool_tx_meta_t` already had padding allocated * Moves more verification logic out of `cryptonote::Blockchain`
Furthermore, this opens the door to future multi-threaded block verification speed-ups. Right now, transactions' input proof verification is limited to one transaction at a time. However, one can imagine a scenario with verification IDs where input proofs are optimistically multi-threaded in advance of block processing. Then, even though ring member fetching and verification is single-threaded inside of `cryptonote::Blockchain::check_tx_inputs()`, the single thread can skip the CPU-intensive cryptographic code if the verification ID allows it.
Also changes the default log category in `tx_verification_utils.cpp` from "blockchain" to "verify".
91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarydefensive validationprivacy or spend-authorization protocolcryptography-sensitive path
AI analysis · Low 39/100
This commit is a performance refactor of how Monero nodes cache expensive ring-signature verification results for transactions sitting in the memory pool (mempool). It replaces an in-memory cache limited to 8,192 entries with a persistent verification ID stored in each mempool transaction's metadata. The change is described by the author as improving block propagation and reorg handling, not as a security fix. The main risk is that if the verification ID is ever set incorrectly or reused with the wrong mix-ring data, a node could skip cryptographic checks on a bad transaction, which would be a consensus bug. The diff includes careful checks and unit tests, but it is a large, complex change touching core consensus code.
Security candidatesrc: update checkpoints to match v0.18.4.5by selsta · 59055896 · Dec 29, 2025 · 4 filesMessage 45 · ThinInformational 21Details
Commit message · selsta
src: update checkpoints to match v0.18.4.5
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 21/100
This commit updates Monero's built-in blockchain checkpoints to match the latest software release (v0.18.4.5). Checkpoints are hardcoded reference points that help nodes quickly verify they are following the correct chain and protect against certain types of attacks. The change is routine maintenance: it adds one new checkpoint at block height 3576000, updates a hash that verifies the checkpoint data file, and updates the recommended minimum version in documentation. There is no indication this fixes an active security vulnerability.
Security candidatewallet2: fix edge case where tx's ki's remain marked unspentby j-berman · ab9bc649 · Dec 12, 2025 · 1 fileMessage 85 · StrongModerate 57Details
Commit message · j-berman
wallet2: fix edge case where tx's ki's remain marked unspent
If a tx is marked as failed (because it never shows up in the daemon's pool), its key images get reset back to unspent so they can be used in future txs.
If the tx re-enters the daemon's pool (e.g. it's removed from the pool and then relayed back), then the wallet incorrectly maintains that the tx's key images are unspent.
This change ensures the wallet re-marks the tx's key images as spent if the tx re-appears in the node's pool.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
privacy or spend-authorization protocolsigning or wallet path
AI analysis · Moderate 57/100
This patch fixes a bookkeeping bug in the Monero wallet. When a transaction temporarily disappears from the network's pending pool and is later re-broadcast, the wallet could wrongly treat the coins it spends as still available. That could let the wallet try to spend the same coins twice, producing a conflict that prevents any of those follow-up transactions from confirming until the wallet state is manually repaired.
p2p: fix race causing dropped connections during sync
Without this commit: 1) read height from DB 2) add block to chain in separate thread 3) read chain for block id's and request them from peer 4) ERR in handle_response_chain_entry, peer's first block is the one that was added to the chain, which has block idx=height from step 1.
This commit reads the chain for height and highest block id's in one go while holding the m_blockchain_lock to avoid the race.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
cryptography-sensitive pathparser or protocol path
AI analysis · Low 29/100
This patch fixes a timing bug in Monero's peer-to-peer syncing. Previously, a node could read its own blockchain height, then a new block could be added in another thread, and then the node would ask a peer for older blocks using an out-of-date height. This mismatch could cause the node to think the peer's first returned block was wrong and drop the connection, making sync slower or less reliable. The fix reads the height and the list of block hashes together under the same lock so they cannot get out of step.
Security candidateRemove invalid constexprby Lee *!* Clagett · 86927f33 · Dec 4, 2025 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Lee *!* Clagett
Remove invalid constexpr
28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This is a tiny C++ code cleanup. The function `cn_variant1_check` was marked `constexpr` (a hint that it can be evaluated at compile time), but because it contains a runtime-only check (`if (variant == 1 && length < 43)` followed by an error path), that marking is invalid in newer C++ standards. The patch simply removes the `constexpr` keyword so the code compiles correctly. There is no change to what the function actually does, no security behavior change, and no bug fix beyond compiler compliance.
Security candidatecryptonote_core: set prep-blocks-threads to max threadsby 0xfffc · dc1d0dd8 · Nov 30, 2025 · 1 fileMessage 50 · ThinInformational 19Details
Commit message · 0xfffc
cryptonote_core: set prep-blocks-threads to max threads
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 19/100
This commit changes a default setting for how many threads Monero uses when preparing block hashes. Previously it was hardcoded to 4 threads; now it uses the number of CPU cores the computer reports (falling back to 4 if that number can't be determined). This is a performance tuning change, not a security fix. There is no direct evidence in the commit that it addresses a vulnerability.
Security candidatetx_memory_pool: speedup get_complement() for large requestsby jeffro256 · 0673c957 · Nov 26, 2025 · 6 filesMessage 73 · AdequateLow 29Details
Commit message · jeffro256
tx_memory_pool: speedup get_complement() for large requests
Changes complexity from M*N to (2*N+M)*log2(M). The FCMP++ stressnet recently hit mempool sizes of ~55k txs. If the requesting node's mempool is populated, this results in an average of (55000*55000)/2 (about 1.5 billion) comparisons for the responding node. Under this commit, this would be reduced to (55000+55000)*log2(55000) comparisons (about 2.6 million), a 99.83% reduction.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive pathparser or protocol path
AI analysis · Low 29/100
This commit is a performance optimization for Monero's transaction memory pool. When one node asks another for transactions it is missing, the old code compared every requested hash against every pool transaction one-by-one, which becomes extremely slow when the pool is large (tens of thousands of transactions). The new code sorts the requested hashes once and uses binary search, cutting the work by roughly 99.8%. The main security-relevant angle is that the old code could be abused to make a node waste CPU time, potentially contributing to a denial-of-service condition.
Security candidateDaemon: relay empty fluffy block on found blockby j-berman · 1fd6f275 · Nov 12, 2025 · 1 fileMessage 45 · ThinLow 44Details
Commit message · j-berman
Daemon: relay empty fluffy block on found block
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Low 44/100
This commit changes how a Monero node announces a newly found block to peers. Previously, the node would fetch and attach the actual transaction data to the announcement. After the change, it sends an 'empty fluffy block' announcement that contains only the block header and a list of transaction hashes, leaving peers to request missing transactions themselves. This is a network-efficiency optimization, but it removes a local consistency check and shifts responsibility for transaction availability to peers.
Security candidatetx pool: only increment m_txpool_weight for newly added pool txsby j-berman · a378b596 · Nov 12, 2025 · 1 fileMessage 93 · StrongModerate 53Details
Commit message · j-berman
tx pool: only increment m_txpool_weight for newly added pool txs
Otherwise we can end up double counting txs towards the weight, which can over-state the pool weight. E.g. relay tx to node in stem phase, add its weight to pool weight, then receive tx from another node, then bump the pool weight again. That double counts the tx towards the pool weight.
If the weight exceeds the max, the node will "prune" txs from the pool. Thus, over-counting is probably a cause of, but perhaps not the only cause of: https://github.com/seraphis-migration/monero/issues/148
93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive path
AI analysis · Moderate 53/100
This fix corrects a bookkeeping bug in Monero's transaction memory pool. The pool tracks its total weight (size) and prunes transactions when it thinks it is too full. Because the same transaction could be counted twice—once when relayed privately and again when received from another peer—the pool could believe it was over its weight limit and remove transactions prematurely. This could make the node behave differently from honest nodes, potentially affecting transaction relay and network consistency, but it does not directly steal funds or break cryptography.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
privacy or spend-authorization protocol
AI analysis · Moderate 56/100
This change hardens how the Monero wallet software talks to a Ledger hardware wallet. Previously, if the user rejected exporting the secret view key from the Ledger, the software silently accepted a fake placeholder key and continued with reduced functionality. Now the software throws a clear error and stops. This prevents a scenario where the wallet might proceed in a confused state after the user explicitly denied key export.
✓ Subject identifies a change! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
cryptography-sensitive pathparser or protocol path
AI analysis · Moderate 64/100
This patch fixes a deadlock bug in Monero's logging system. A deadlock is a situation where two or more parts of the program get stuck waiting on each other forever, which can freeze the software. The fix changes how log messages are built so that user-provided code (which might itself use locks) is evaluated before the logger takes its own internal lock, preventing the logger's lock and user locks from being held at the same time in a way that could cause a freeze. The commit includes a new test that reproduces the deadlock scenario.
Security candidatecryptonote_protocol: accurate next_needed_height when there is an overlapby 0xFFFC0000 · 52b4c73a · Nov 10, 2025 · 1 fileMessage 50 · ThinLow 31Details
Commit message · 0xFFFC0000
cryptonote_protocol: accurate next_needed_height when there is an overlap
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathparser or protocol path
AI analysis · Low 31/100
This patch fixes a bookkeeping bug in how Monero decides which blockchain blocks to request next from peers. Previously, when two requested block ranges overlapped, the node could incorrectly think it already had a block it did not have, causing it to skip asking for that block. That could stall synchronization or leave a node stuck on an older chain. The fix correctly merges overlapping or adjacent ranges when calculating the next missing height.
Security candidatesrc: update checkpoints to match v0.18.4.4by selsta · ef3fe664 · Nov 10, 2025 · 4 filesMessage 45 · ThinInformational 15Details
Commit message · selsta
src: update checkpoints to match v0.18.4.4
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit is a routine maintenance update that adds a new blockchain checkpoint and updates version references in documentation. Checkpoints are a normal mechanism that help Monero nodes agree on the correct chain history and speed up initial synchronization. There is no indication of a security fix, vulnerability, or malicious change in the diff.
Blockchain: cancel pop_blocks() operation on interupt
On SIGINT, `Blockchain::cancel()` is called, which sets `m_cancel` to `true`. This commit stops attempting to pop blocks from the chain once that flag is set. This should leave the blockchain in a well-define state, even if the `pop_blocks()` operation itself did not "complete".
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive path
AI analysis · Informational 21/100
This change makes Monero's blockchain rewind operation stop early if the user sends an interrupt signal (Ctrl-C). Previously, the code would keep popping blocks even after being told to cancel, which could leave the blockchain database in an inconsistent or poorly defined state. The fix is a one-line check of a cancellation flag inside the loop that removes blocks.
✓ Descriptive subject! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
cryptography-sensitive pathseed or entropy pathsigning or wallet pathboot or update pathauthentication pathparser or protocol path
AI analysis · Informational 15/100
This commit is titled 'rpc: remove COMMAND_RPC_SUBMIT_RAW_TX', but the actual diff supplied is not an RPC removal. It is a massive initial import or re-import of the entire Monero repository (693,211 added lines across 1,360 files). No security-relevant code change is visible in the provided diff, and the diff does not show the removal of any RPC command. The supplied materials are inconsistent with the commit title.
Security candidatesimplewallet: use passed decrypted payment ID from wallet2 for notificationsby jeffro256 · 1bcca58d · Nov 6, 2025 · 5 filesMessage 65 · AdequateLow 27Details
Commit message · jeffro256
simplewallet: use passed decrypted payment ID from wallet2 for notifications
Adds payment ID paramater to `on_money_received()` wallet callback.
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
privacy or spend-authorization protocolsigning or wallet path
AI analysis · Low 27/100
This Monero commit changes how payment IDs are handled when the wallet receives money. Previously, the user-facing wallet interface (simplewallet) decrypted the payment ID itself from transaction data. Now, the core wallet engine (wallet2) decrypts or extracts the payment ID earlier in processing and passes the already-decrypted value to the interface. This is mostly a code cleanup and consistency improvement. It does not appear to be a security fix on its own, but it touches privacy-sensitive payment ID handling and removes duplicated decryption logic.
Security candidateBlockchainDB: rm `skip_coinbase` in `get_blocks_from()`by jeffro256 · a863bf70 · Oct 13, 2025 · 5 filesMessage 73 · AdequateInformational 18Details
Commit message · jeffro256
BlockchainDB: rm `skip_coinbase` in `get_blocks_from()`
Parameter `skip_coinbase` was always set to `true`, and didn't actually skip the coinbase transactions. The method broke when set to `false`.
Noticed by @akildemir
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
proof-of-work or emission validationcryptography-sensitive path
AI analysis · Informational 18/100
This is a small code cleanup, not a security fix. A database function had a 'skip coinbase' option that was always turned on and didn't actually work when turned off. The patch removes the broken, unused option entirely. The only caller kept using the same behavior, so nothing changes for users.