XMR
← All projectsMonero Project

Monero

Reference Monero node, command-line wallet, consensus, networking, and cryptographic protocol implementation.

Cryptographic librariesMoneroNode implementationsPrivacy protocolsNormal
Repository coverage

936 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

278security candidates305second-pass queue583AI analyses
116commits · 30 days
247commits · 60 days
684commits · 180 days
899commits · 365 days
Backfill bands
Sep 27 → Mar 3192 seen34 candidatesComplete
Mar 31 → Jul 29369 seen101 candidatesComplete
Jul 29 → Aug 28128 seen36 candidatesComplete
Aug 28 → Sep 2788 seen21 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

53/100 average clarity
22Strong · 80–100
158Adequate · 60–79
690Thin · 40–59
66Opaque · 0–39
14security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
jeffro256664153257
koe424258
tobtoht35281200155
Cole Munz424177
Masamune222164
SNeedlewoods906152
selsta17751100051
j-berman443035058
jpk68931655046
Samy451129048
Thomas271015057
SChernykh1188062
Analysis record

Published AI watches

Last scanned 25 minutes ago

Informational 15 AI analysisMessage 68 · Adequate
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11439

This commit only adds a new automated test tool (a fuzzer) for the Monero wallet. It does not change any production wallet, node, or consensus code. It cannot by itself introduce a vulnerability that affects real users, nor does it fix one…

f8632a38by tobtoht+355−02 files
No security note in commit
Informational 24 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11741

This is a cleanup and refactoring patch for Monero's new FCMP++ (full-chain membership proof) database and transaction handling code. It renames a method, fixes typos and comments, tightens a constant name, adds a safety check that outputs…

Added runtime invariant check that locked outputs do not unlock below the default unlock blockRefactored transparent-amount commitment collection to reduce indirection and potential misuseClarified unlock-time semantics and coinbase detection in migration code
f9e6b2c1by tobtoht+77−598 files
No security note in commit
Low 25 AI analysisMessage 53 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

db: cleanup following PR #11425

This commit is a cleanup and hardening patch following an earlier pull request. It adds a safety check to make sure outputs are not incorrectly treated as spendable before they should be, fixes several typos and variable-name issues, rewri…

Added invariant check that outputs unlock no earlier than the default unlock block before adding locked outputs to the databaseRefactored transparent-amount commitment collection to remove std::reference_wrapper indirection, reducing complexityCorrected constant-name typos in spendable-age calculations
e108199dby koe+77−598 files
No security note in commit
Low 30 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11732

This is a one-line fix in Monero's wallet software that adjusts how far ahead the wallet tries to 'skip' scanning after a blockchain reorganization (reorg). A reorg happens when the network briefly disagrees on the chain of blocks and then…

Incorrect scan resume height after blockchain reorgPotential missed transaction detectionBalance accuracy issue in wallet
4ab1a673by tobtoht+1−01 file
No security note in commit
Informational 19 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11739

This commit is a code cleanup that replaces the non-standard WIN32 preprocessor macro with the compiler-defined _WIN32 macro across 18 files. It does not change program logic or behavior; it only makes Windows-specific code detection more …

No functional code changes observedPreprocessor macro standardization onlyWindows-specific code paths remain identical in behavior
90ab1660by tobtoht+52−5218 files
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11438

This commit only adds a new automated security test (a fuzzer) for Monero's wallet cache file parser. It does not change any production wallet code, fix a bug, or introduce a vulnerability. It is a testing-only addition intended to help fi…

Adds a fuzz target for wallet cache deserializationNo changes to production code pathsNo patch of a reported vulnerability
7b6d76b1by tobtoht+144−02 files
No security note in commit
Low 26 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11737

This Monero update adds a cache that remembers which transactions in the memory pool have already failed expensive input verification, so the node does not waste CPU re-checking the same bad transaction repeatedly. It is a performance and …

Adds caching of invalid input verification IDs to avoid repeated expensive ring signature verificationReduces CPU consumption for transactions that re-enter or remain in the mempool with unchanged invalid inputsCould mitigate a minor denial-of-service vector where a node repeatedly re-verifies a bad transaction
dfa1a30dby tobtoht+56−104 files
No security note in commit
Moderate 51 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11710

This patch changes how Monero's daemon calculates the total coinbase transaction sum (emission plus fees) for a range of blocks. Previously, the code called a general 'get_transactions' helper that could trigger a deadlock because it might…

Deadlock avoidance in consensus-related coinbase emission calculationChange from general transaction retrieval to direct, pruned database readAddition of functional test covering coinbase sum correctness
e64f2bc1by tobtoht+8−42 files
No security note in commit
Informational 19 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11714

This change is a performance optimization for the Monero wallet's balance-reporting RPC. When a user asks for balances across many subaddresses, the code now pre-counts unspent outputs in one pass instead of re-scanning the entire transact…

da768cd9by tobtoht+18−12 files
No security note in commit
Moderate 59 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11720

This update adds a safety check in the Monero wallet's fast refresh process. Previously, if a malicious or buggy remote server told the wallet to start syncing from a block height beyond the wallet's known blockchain data, the wallet could…

Added bounds check on untrusted server-supplied start_height against local hash chain sizeDefensive hardening at wallet/daemon trust boundaryUnit test demonstrates rejection of out-of-bounds refresh request
c4a1491bby tobtoht+34−02 files
No security note in commit
Moderate 61 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11724

This commit tightens filename validation in the Monero wallet's remote-control interface (RPC server). It now rejects wallet names that are just '.' or '..', contain a hidden null character, or contain path separators like '/' (and on Wind…

Path-traversal defense: blocks directory separators and parent-directory references in wallet filenamesNull-byte injection defense: rejects embedded NUL characters that could truncate or confuse downstream path handlingRPC input validation hardening in wallet_rpc_server
084af8f6by tobtoht+3−61 file
No security note in commit
Moderate 67 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11726

This Monero wallet update fixes a file-handling bug in the 'save wallet as' function. Previously, the code compared only the main wallet cache path and used a simple path check that could be fooled by symlinks or filenames ending in '.keys…

Path overlap / self-overwrite protection for wallet cache and keys filesSymlink and hardlink alias detection using boost::filesystem::equivalentRejection of ambiguous paths where .keys file and cache file could collide
b5402182by tobtoht+266−62 files
No security note in commit
Low 27 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11697

This commit adds an optional, faster way to set up N-of-N Monero multisig wallets. Normally, all signers must complete a final verification round to prove they are active and have finished setup. The new 'fast non-interactive setup' skips …

New feature adds a non-default, opt-in fast setup path that intentionally weakens a liveness/verification guaranteeForce-update flag (force_update_use_with_caution) is used internally to bypass the normal post-KEX roundUser-facing and API documentation clearly warn that funds may become inaccessible if other signers do not complete setup
df52dd3eby tobtoht+301−1512 files
No security note in commit
Moderate 57 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11696

This change refactors how Monero's wallet fetches transaction data when creating or verifying 'spend proofs'—cryptographic receipts that prove you spent funds. Previously, spend-proof code fetched transactions directly from the network dae…

Refactoring of spend-proof transaction lookup to a single helperAddition of explicit RPC timeout parameter to transaction fetch helperImproved daemon RPC error/status reporting in get_tx_for_proof
49ee3f43by tobtoht+9−422 files
No security note in commit
Low 37 AI analysisMessage 68 · Adequate
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11693

This commit refactors how the Monero wallet fetches a transaction when verifying a payment proof (the check_tx_key feature). It replaces a direct daemon RPC call with a helper function called get_tx_for_proof, which is described in the com…

Replaces direct /gettransactions RPC with centralized helper for proof verificationCommit title explicitly frames change as 'verify v1 txid in check_tx_key'Removes local tx_hash == txid equality check in favor of helper-internal verification
a2ef2c6aby tobtoht+5−241 file
No security note in commit
Low 44 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11655

This change stops a Monero wallet from creating 'InProofs' (receipt proofs) for transactions that the wallet itself sent. InProofs are meant to prove to someone else that you received money. If a wallet could generate an InProof for a tran…

Prevents generation of misleading InProofs for outgoing/self-sent transactionsAdds explicit runtime guard in wallet proof generation pathFunctional tests updated to assert refusal behavior
61055c9dby tobtoht+47−392 files
No security note in commit
Moderate 57 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11603

This patch fixes a bug in the Monero wallet where, if a pending transaction failed, the wallet could incorrectly mark coins as unspent even though they had already been spent by a separate confirmed transaction. This could let the wallet t…

Incorrect state reset on failure pathPotential double-spend attempt caused by stale UTXO selectionWallet balance/availability inconsistency after failed pending tx
7b3f6271by tobtoht+2−01 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11492

This commit only adds a new automated fuzz-testing harness for Monero wallet features. It does not change any production wallet code, fix a bug, or alter network behavior. It is a test-only addition intended to help find bugs in the future…

Adds fuzz targets for payment URI parsing and transaction proof verificationNo changes to production wallet, consensus, or network codeNo bug fix or behavior change in existing source files
4014125fby tobtoht+364−02 files
No security note in commit
Low 27 AI analysisMessage 66 · Adequate
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11653

This Monero update fixes a bug in how nodes ask each other for blockchain history. Previously, a node could get stuck or drop a peer when it already knew about some blocks from another connection, because it would not ask for the next batc…

P2P protocol synchronization logic changePotential denial-of-service via peer dropping or sync stallNo authentication or cryptographic boundary crossed
8b99fe43by tobtoht+55−02 files
No security note in commit
Moderate 65 AI analysisMessage 45 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

wallet2: handle .keys saves and overlapping paths

This commit fixes a bug in how the Monero wallet saves itself to disk. Previously, the wallet could accidentally overwrite or corrupt its own files when the user chose a path that overlapped with existing wallet files, such as saving to a …

File overwrite / corruption prevention in wallet save path handlingSymlink and hardlink alias detection via filesystem equivalent() checksRejection of overlapping source/destination wallet files
4cc0e506by Samy+266−62 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedMerge pull request #11265by tobtoht · 3b18aeb1 · Sep 24, 2026 · 2 filesMessage 58 · ThinModerate 59Details
Commit message · tobtoht

Merge pull request #11265

3f7dc4e wallet2: reject malformed multisig_info on import (jpk68)

ACKs: UkoeHB, SNeedlewoods

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This Monero wallet update adds safety checks when a wallet imports 'multisig_info' data shared between co-signers in a multi-signature wallet. It now rejects files where the declared signer doesn't match the file header, or where the number of partial key images or signing nonces is wrong. These checks prevent malformed or mismatched multisig data from being processed further. The change includes new unit tests that confirm the rejections work.

AI review queuedMerge pull request #11244by tobtoht · c0944a04 · Sep 24, 2026 · 1 fileMessage 58 · ThinModerate 61Details
Commit message · tobtoht

Merge pull request #11244

bf54d18 wallet2: validate scan_tx daemon responses (Samy)

ACKs: jpk68, selsta

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 61/100

This update adds a safety check in the Monero wallet software. When the wallet asks a network node (daemon) for details about specific transactions, it now verifies that the transactions it gets back are actually the ones it asked for. Without this check, a malicious or compromised node could potentially return the wrong transactions, which might confuse the wallet about balances or transaction history. The fix makes the wallet reject any response where the returned transaction IDs do not match the requested ones.

Security candidateblockchain: return false from get_tx_outputs_gindexs on TX_DNEby Thomas · cb611949 · Sep 23, 2026 · 1 fileMessage 50 · ThinLow 41Details
Commit message · Thomas

blockchain: return false from get_tx_outputs_gindexs on TX_DNE

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Low 41/100

This commit hardens a Monero blockchain lookup function so it returns a clean failure instead of letting an internal 'transaction does not exist' exception bubble up. The change makes the node more robust when asked about outputs for a transaction that is missing from the database, which could previously crash or abort the calling code path.

AI review queuednet: detect half-closed sockets before connection reuseby Guoqiang Liu · bb8f10c4 · Sep 22, 2026 · 5 filesMessage 83 · StrongModerate 63Details
Commit message · Guoqiang Liu

net: detect half-closed sockets before connection reuse

Track peer EOF and TLS closure before reusing idle connections. Make disconnect idempotent while preserving buffered data and pending operation lifetimes. Add loopback coverage for EOF, socket modes, and TLS shutdown behavior.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 63/100

This patch fixes a connection-reuse bug in Monero's networking helper. Previously, the client could reuse a TCP connection that the peer had already half-closed (for example, after sending data and shutting down its send side). That could lead to sending new requests over a dead connection, reading stale or truncated data, or reusing a TLS session after the peer sent a close alert. The change makes the client check for peer EOF and TLS close-notify before declaring a connection reusable, and makes disconnect safe to call multiple times without crashing or corrupting buffered data.

Security candidatecryptonote_core: reject duplicate tx hashes before pool lookupby selsta · 52a7ff30 · Sep 20, 2026 · 1 fileMessage 50 · ThinModerate 57Details
Commit message · selsta

cryptonote_core: reject duplicate tx hashes before pool lookup

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Moderate 57/100

This change adds a safety check in Monero's core code that rejects a block if it contains the same transaction hash more than once, before looking those transactions up in the memory pool. Duplicate transaction hashes in a single block could cause inconsistent behavior or be exploited to manipulate how transactions are fetched and included. The fix is small and defensive, but the commit message does not describe a specific attack or security impact.

AI review queuedwallet: persist set_daemon params across wallet loads. - allow set_daemon without a wallet loadedby nahuhh · de19ff65 · Sep 20, 2026 · 6 filesMessage 65 · AdequateLow 27Details
Commit message · nahuhh

wallet: persist set_daemon params across wallet loads.
- allow set_daemon without a wallet loaded

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 27/100

This Monero commit changes how the wallet remembers which daemon (server) it should connect to. Previously, if you told the wallet RPC server to use a specific daemon before any wallet was open, that setting was lost as soon as you opened or created a wallet. Now that setting is saved and automatically applied to wallets opened or created later. The change also lets you call set_daemon even when no wallet is loaded. There is one small security-relevant side effect: because the daemon settings now persist, a test helper that temporarily switches to a wrong daemon had to explicitly restore the 'trusted' flag afterward, otherwise the restored daemon would be treated as untrusted. The commit itself is a feature/fix for configuration persistence, not an exploit.

AI review queuedwallet: let set_daemon override --proxyby nahuhh · a7aed9b9 · Sep 20, 2026 · 3 filesMessage 45 · ThinLow 35Details
Commit message · nahuhh

wallet: let set_daemon override --proxy

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 35/100

This Monero wallet commit changes how proxy settings are handled. Previously, if you started the wallet with a global --proxy option, you could not later use the set_daemon command to pick a different proxy for a specific daemon. The commit removes that restriction, allowing set_daemon to override the global proxy. This is a behavior change that could matter for privacy and security, but the commit itself does not show an obvious vulnerability—just a relaxation of a guard rule.

AI review queuedwallet2: validate legacy transfer output indicesby selsta · 4c824408 · Sep 20, 2026 · 1 fileMessage 60 · AdequateModerate 57Details
Commit message · selsta

wallet2: validate legacy transfer output indices

Reported by xmrack and the MAGIC Monero Fund.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Moderate 57/100

This commit adds a safety check when loading older Monero wallet data. It ensures that a stored 'output index' (which points to a specific coin within a past transaction) does not point past the number of outputs that transaction actually has. Without this check, a malformed or manipulated old wallet file could reference a non-existent output, potentially causing crashes or undefined behavior when the wallet later uses that index.

AI review queuedwallet2: check reserve proof additional key indexby selsta · 923ee545 · Sep 20, 2026 · 1 fileMessage 60 · AdequateModerate 57Details
Commit message · selsta

wallet2: check reserve proof additional key index

Reported by xmrack and the MAGIC Monero Fund.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 57/100

This patch tightens a safety check in Monero's wallet when creating a 'reserve proof' (a cryptographic receipt proving funds exist). Previously the wallet only checked whether any extra public keys existed at all; now it checks whether the specific key needed for the output actually exists. Without this check, the wallet could read past the end of an empty list and crash or behave unpredictably, but the change is small and the error path already threw an exception.

AI review queuedwallet2: validate key data in password and device checksby selsta · cbf33310 · Sep 20, 2026 · 1 fileMessage 65 · AdequateModerate 59Details
Commit message · selsta

wallet2: validate key data in password and device checks

Reported by xmrack and the MAGIC Monero Fund.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This update adds safety checks to Monero's wallet code when reading wallet key files. Previously, the code assumed the file contained a properly formatted JSON object with a 'key_data' text field. If a file was malformed or missing that field, the program could read from invalid memory and crash or behave unpredictably. The patch now checks the structure before using the data and returns an error instead.

AI review queuedwallet2: normalize account tags before assignmentby selsta · b76c4b7a · Sep 20, 2026 · 1 fileMessage 60 · AdequateLow 36Details
Commit message · selsta

wallet2: normalize account tags before assignment

Reported by xmrack and the MAGIC Monero Fund.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 36/100

This small change makes the wallet refresh its account-tag list before assigning a tag to accounts. Without this refresh, the wallet might act on stale or inconsistent tag data, which could lead to tags being applied to the wrong accounts or to duplicate/confused labels. The commit message and reporter credit suggest this was treated as a real bug, but the diff itself does not show an obvious exploit path.

Security candidatePolyseed support for 'wallet2', Wallet API, CLI wallet app, wallet RPC serverby rbrunner7 · c8699f24 · Sep 20, 2026 · 31 filesMessage 73 · AdequateLow 29Details
Commit message · rbrunner7

Polyseed support for 'wallet2', Wallet API, CLI wallet app, wallet RPC server

Co-authored-by: tevador <tevador@gmail.com>
Co-authored-by: tobtoht <tob@featherwallet.org>
Co-authored-by: Czarek Nakamoto <cyjan@mrcyjanek.net>
Co-authored-by: selsta

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive pathseed or entropy pathsigning or wallet path
AI analysis · Low 29/100

This commit adds support for a new type of wallet backup phrase called Polyseed to the Monero wallet software. It touches many wallet components (CLI, RPC, library API) so users can create, restore, and display Polyseed backups alongside the older 25-word legacy seeds. The change also stores a new Polyseed field in encrypted wallet files and handles passphrases/seed offsets in a specific way. There is no direct evidence in the commit that this fixes an active security bug; it reads as a large feature addition. However, because it changes how secret key material is serialized, encrypted, and derived from seed words, any mistakes in this area could affect wallet security or recoverability.

AI review queuedExpose wallet exist as rpc commandby Deverick · 3e727c6a · Sep 20, 2026 · 5 filesMessage 45 · ThinLow 25Details
Commit message · Deverick

Expose wallet exist as rpc command

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 25/100

This commit adds a new wallet RPC command called wallet_exists that lets a caller check whether a wallet file already exists on the server. It also refactors existing filename validation into a shared helper. The change is mostly a feature addition, but it does expose filesystem information (file presence) over the RPC interface, which can aid reconnaissance if the RPC endpoint is reachable by an attacker.

Security candidatedevice: protect against buffer overflowby jpk68 · f4626116 · Sep 19, 2026 · 1 fileMessage 50 · ThinModerate 58Details
Commit message · jpk68

device: protect against buffer overflow

50/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
memory safety
AI analysis · Moderate 58/100

This commit adds a safety check in the code that talks to USB hardware wallets (Ledger/Trezor-style devices via HID). Previously, when receiving a response in chunks, the code could keep writing past the end of a fixed-size buffer if a malicious or misbehaving device sent more data than expected. The new check stops this before each read, preventing a buffer overflow. The fix uses an assertion, which means the program will abort rather than continue in an unsafe state.

AI review queuedwallet2: validate block hash when repairing empty hashchainby selsta · 7e2e857a · Sep 19, 2026 · 1 fileMessage 50 · ThinLow 42Details
Commit message · selsta

wallet2: validate block hash when repairing empty hashchain

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Low 42/100

This commit adds a safety check in Monero's wallet code. When the wallet tries to repair its local record of the blockchain (the 'hashchain'), it now refuses to continue if the network node returns a block hash that isn't a valid hexadecimal string. Before this change, an invalid or malformed hash could silently be converted to an empty or garbage value, potentially corrupting the wallet's view of the blockchain.

AI review queuedwallet2: preserve required SSL when allowing chained certificatesby selsta · 27c443c8 · Sep 16, 2026 · 1 fileMessage 50 · ThinLow 46Details
Commit message · selsta

wallet2: preserve required SSL when allowing chained certificates

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Low 46/100

This small patch fixes a logic bug in how the Monero wallet decides whether SSL/TLS is required when connecting to a daemon. Previously, the wallet only treated SSL as required when the user explicitly pinned a specific certificate ('user_certificates' mode). If the user supplied a custom CA file or allowed certificate fingerprints, the code did not mark SSL as required, which could let the wallet silently fall back to an unencrypted connection in some situations. The fix introduces a separate flag so that supplying a CA file or fingerprints now correctly forces SSL to be required, preserving the user's intended security setting.

Security candidatewallet: fix inconsistent tx pubkey handlingby selsta · b19cf443 · Sep 15, 2026 · 8 filesMessage 45 · ThinModerate 63Details
Commit message · selsta

wallet: fix inconsistent tx pubkey handling

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet pathparser or protocol path
AI analysis · Moderate 63/100

This Monero commit fixes how the wallet handles transaction public keys and address public keys so that keys with small-order or non-standard curve points (called 'torsion' points) are normalized or rejected before being used. It also tightens validation of destination addresses and makes transaction-proof logic more consistent. In plain terms, the patch closes gaps where a malformed key could confuse the wallet about who paid whom or whether a payment proof is valid.

Security candidatecrypto: move torsion clearing into cryptoby selsta · 3becac8d · Sep 15, 2026 · 10 filesMessage 45 · ThinLow 25Details
Commit message · selsta

crypto: move torsion clearing into crypto

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Low 25/100

This commit is a code cleanup: it moves the logic that removes small-subgroup 'torsion' from elliptic-curve points out of a newer, specialized module (fcmp_pp) and into the core cryptography library (crypto). The same mathematical operation is now shared by the ring signature code and the new FCMP++ code. There is no direct evidence in the commit that this fixes an active vulnerability; it looks like a refactoring to avoid duplicated constants and helper functions.

Security candidatecryptonote_basic: log invalid hash input sizeby selsta · fda97806 · Sep 15, 2026 · 1 fileMessage 45 · ThinInformational 14Details
Commit message · selsta

cryptonote_basic: log invalid hash input size

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 14/100

This commit changes a single error log message. Instead of printing the full invalid hash string, it now prints only the length of that string. This is a minor logging improvement and does not change any program behavior, security boundary, or data flow.

AI review queuedwallet_api: clear stale daemon loginby selsta · b2b8c816 · Sep 14, 2026 · 1 fileMessage 45 · ThinLow 37Details
Commit message · selsta

wallet_api: clear stale daemon login

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 37/100

This small patch fixes a state-cleanup bug in Monero's wallet API. Previously, when a wallet connected to a new daemon without providing a username, it could accidentally reuse login credentials from an earlier connection. The patch now explicitly clears those old credentials when no username is supplied, preventing the wallet from sending stale authentication to the wrong daemon.

Security candidatehttp: bind Digest authentication to the request URIby selsta · 6c79985a · Sep 14, 2026 · 2 filesMessage 70 · AdequateLow 37Details
Commit message · selsta

http: bind Digest authentication to the request URI

This has limited practical impact for our RPC use case,
but closes a gap in Digest validation.

70/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Names security-relevant behavior explicitly
Why it was queued
access controlauthentication path
AI analysis · Low 37/100

This commit fixes a security gap in how HTTP Digest authentication was validated in Monero's built-in HTTP server. Previously, a valid authentication response for one URL could potentially be accepted for a different URL. The fix now checks that the URL in the authentication response matches the URL actually being requested. The commit message itself says the practical impact for Monero's RPC use is limited.

Security candidateblockchain: fix lock ordering in check_against_checkpointsby selsta · 46807c46 · Sep 14, 2026 · 1 fileMessage 50 · ThinModerate 57Details
Commit message · selsta

blockchain: fix lock ordering in check_against_checkpoints

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Moderate 57/100

This commit changes the order in which two internal locks are acquired in a Monero blockchain checkpoint-checking function. Lock ordering bugs are a common source of deadlocks, where two parts of the program wait forever for each other. The patch itself is very small and appears to be a partial fix rather than a complete security overhaul. There is no direct evidence in the commit that this was exploited or that it caused a concrete vulnerability, but inconsistent lock ordering in critical consensus code is a recognized reliability and potential security risk.

AI review queuedwallet2: filter unchecked RPC error statusesby selsta · fe371dd7 · Sep 13, 2026 · 1 fileMessage 45 · ThinLow 38Details
Commit message · selsta

wallet2: filter unchecked RPC error statuses

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 38/100

This commit changes how the Monero wallet handles error responses from the daemon (the network node it talks to). Previously, certain RPC calls used a macro that did not check the daemon's returned status code in all cases. The new code explicitly checks that status and throws a proper wallet error if the daemon reports a failure. In practical terms, this reduces the chance that the wallet will silently continue with stale or incomplete data when the daemon is actually telling it something went wrong. It is a hardening fix rather than a clear-cut exploit patch, and the commit message does not describe a specific vulnerability.

AI review queuedwallet2: validate public node addresses before displayby selsta · dab064fd · Sep 13, 2026 · 2 filesMessage 50 · ThinLow 38Details
Commit message · selsta

wallet2: validate public node addresses before display

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Low 38/100

This commit adds validation and formatting fixes for public Monero node addresses shown in the wallet. It prevents invalid or malformed node entries (such as those with port 0 or unparseable hostnames) from being displayed, and it correctly wraps IPv6 addresses in brackets so they are not misread. The change reduces the chance that a user connects to or trusts a bogus node listed among public nodes, but it does not by itself stop an attacker from listing a malicious node—only from listing one with an obviously invalid address.

AI review queuedwallet2: keep received amount breakdown consistentby selsta · ab343dc8 · Sep 13, 2026 · 1 fileMessage 50 · ThinLow 31Details
Commit message · selsta

wallet2: keep received amount breakdown consistent

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 31/100

This patch changes how a Monero wallet records the breakdown of received amounts when an existing output is 'burnt' and replaced by a new one during transaction processing. It ensures the stored amount list stays consistent with the actual new output value. The commit message frames this as a consistency fix, not a security fix, and the supplied materials do not show any exploit path.