XMR
← All projectsMonero Project

Monero

Reference Monero node, command-line wallet, consensus, networking, and cryptographic protocol implementation.

Cryptographic librariesMoneroNode implementationsPrivacy protocolsNormal
Repository coverage

936 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

278security candidates305second-pass queue583AI analyses
116commits · 30 days
247commits · 60 days
684commits · 180 days
899commits · 365 days
Backfill bands
Sep 27 → Mar 3192 seen34 candidatesComplete
Mar 31 → Jul 29369 seen101 candidatesComplete
Jul 29 → Aug 28128 seen36 candidatesComplete
Aug 28 → Sep 2788 seen21 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

53/100 average clarity
22Strong · 80–100
158Adequate · 60–79
690Thin · 40–59
66Opaque · 0–39
14security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
jeffro256664153257
koe424258
tobtoht35281200155
Cole Munz424177
Masamune222164
SNeedlewoods906152
selsta17751100051
j-berman443035058
jpk68931655046
Samy451129048
Thomas271015057
SChernykh1188062
Analysis record

Published AI watches

Last scanned 18 minutes ago

Informational 15 AI analysisMessage 68 · Adequate
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11439

This commit only adds a new automated test tool (a fuzzer) for the Monero wallet. It does not change any production wallet, node, or consensus code. It cannot by itself introduce a vulnerability that affects real users, nor does it fix one…

f8632a38by tobtoht+355−02 files
No security note in commit
Informational 24 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11741

This is a cleanup and refactoring patch for Monero's new FCMP++ (full-chain membership proof) database and transaction handling code. It renames a method, fixes typos and comments, tightens a constant name, adds a safety check that outputs…

Added runtime invariant check that locked outputs do not unlock below the default unlock blockRefactored transparent-amount commitment collection to reduce indirection and potential misuseClarified unlock-time semantics and coinbase detection in migration code
f9e6b2c1by tobtoht+77−598 files
No security note in commit
Low 25 AI analysisMessage 53 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

db: cleanup following PR #11425

This commit is a cleanup and hardening patch following an earlier pull request. It adds a safety check to make sure outputs are not incorrectly treated as spendable before they should be, fixes several typos and variable-name issues, rewri…

Added invariant check that outputs unlock no earlier than the default unlock block before adding locked outputs to the databaseRefactored transparent-amount commitment collection to remove std::reference_wrapper indirection, reducing complexityCorrected constant-name typos in spendable-age calculations
e108199dby koe+77−598 files
No security note in commit
Low 30 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11732

This is a one-line fix in Monero's wallet software that adjusts how far ahead the wallet tries to 'skip' scanning after a blockchain reorganization (reorg). A reorg happens when the network briefly disagrees on the chain of blocks and then…

Incorrect scan resume height after blockchain reorgPotential missed transaction detectionBalance accuracy issue in wallet
4ab1a673by tobtoht+1−01 file
No security note in commit
Informational 19 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11739

This commit is a code cleanup that replaces the non-standard WIN32 preprocessor macro with the compiler-defined _WIN32 macro across 18 files. It does not change program logic or behavior; it only makes Windows-specific code detection more …

No functional code changes observedPreprocessor macro standardization onlyWindows-specific code paths remain identical in behavior
90ab1660by tobtoht+52−5218 files
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11438

This commit only adds a new automated security test (a fuzzer) for Monero's wallet cache file parser. It does not change any production wallet code, fix a bug, or introduce a vulnerability. It is a testing-only addition intended to help fi…

Adds a fuzz target for wallet cache deserializationNo changes to production code pathsNo patch of a reported vulnerability
7b6d76b1by tobtoht+144−02 files
No security note in commit
Low 26 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11737

This Monero update adds a cache that remembers which transactions in the memory pool have already failed expensive input verification, so the node does not waste CPU re-checking the same bad transaction repeatedly. It is a performance and …

Adds caching of invalid input verification IDs to avoid repeated expensive ring signature verificationReduces CPU consumption for transactions that re-enter or remain in the mempool with unchanged invalid inputsCould mitigate a minor denial-of-service vector where a node repeatedly re-verifies a bad transaction
dfa1a30dby tobtoht+56−104 files
No security note in commit
Moderate 51 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11710

This patch changes how Monero's daemon calculates the total coinbase transaction sum (emission plus fees) for a range of blocks. Previously, the code called a general 'get_transactions' helper that could trigger a deadlock because it might…

Deadlock avoidance in consensus-related coinbase emission calculationChange from general transaction retrieval to direct, pruned database readAddition of functional test covering coinbase sum correctness
e64f2bc1by tobtoht+8−42 files
No security note in commit
Informational 19 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11714

This change is a performance optimization for the Monero wallet's balance-reporting RPC. When a user asks for balances across many subaddresses, the code now pre-counts unspent outputs in one pass instead of re-scanning the entire transact…

da768cd9by tobtoht+18−12 files
No security note in commit
Moderate 59 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11720

This update adds a safety check in the Monero wallet's fast refresh process. Previously, if a malicious or buggy remote server told the wallet to start syncing from a block height beyond the wallet's known blockchain data, the wallet could…

Added bounds check on untrusted server-supplied start_height against local hash chain sizeDefensive hardening at wallet/daemon trust boundaryUnit test demonstrates rejection of out-of-bounds refresh request
c4a1491bby tobtoht+34−02 files
No security note in commit
Moderate 61 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11724

This commit tightens filename validation in the Monero wallet's remote-control interface (RPC server). It now rejects wallet names that are just '.' or '..', contain a hidden null character, or contain path separators like '/' (and on Wind…

Path-traversal defense: blocks directory separators and parent-directory references in wallet filenamesNull-byte injection defense: rejects embedded NUL characters that could truncate or confuse downstream path handlingRPC input validation hardening in wallet_rpc_server
084af8f6by tobtoht+3−61 file
No security note in commit
Moderate 67 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11726

This Monero wallet update fixes a file-handling bug in the 'save wallet as' function. Previously, the code compared only the main wallet cache path and used a simple path check that could be fooled by symlinks or filenames ending in '.keys…

Path overlap / self-overwrite protection for wallet cache and keys filesSymlink and hardlink alias detection using boost::filesystem::equivalentRejection of ambiguous paths where .keys file and cache file could collide
b5402182by tobtoht+266−62 files
No security note in commit
Low 27 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11697

This commit adds an optional, faster way to set up N-of-N Monero multisig wallets. Normally, all signers must complete a final verification round to prove they are active and have finished setup. The new 'fast non-interactive setup' skips …

New feature adds a non-default, opt-in fast setup path that intentionally weakens a liveness/verification guaranteeForce-update flag (force_update_use_with_caution) is used internally to bypass the normal post-KEX roundUser-facing and API documentation clearly warn that funds may become inaccessible if other signers do not complete setup
df52dd3eby tobtoht+301−1512 files
No security note in commit
Moderate 57 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11696

This change refactors how Monero's wallet fetches transaction data when creating or verifying 'spend proofs'—cryptographic receipts that prove you spent funds. Previously, spend-proof code fetched transactions directly from the network dae…

Refactoring of spend-proof transaction lookup to a single helperAddition of explicit RPC timeout parameter to transaction fetch helperImproved daemon RPC error/status reporting in get_tx_for_proof
49ee3f43by tobtoht+9−422 files
No security note in commit
Low 37 AI analysisMessage 68 · Adequate
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11693

This commit refactors how the Monero wallet fetches a transaction when verifying a payment proof (the check_tx_key feature). It replaces a direct daemon RPC call with a helper function called get_tx_for_proof, which is described in the com…

Replaces direct /gettransactions RPC with centralized helper for proof verificationCommit title explicitly frames change as 'verify v1 txid in check_tx_key'Removes local tx_hash == txid equality check in favor of helper-internal verification
a2ef2c6aby tobtoht+5−241 file
No security note in commit
Low 44 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11655

This change stops a Monero wallet from creating 'InProofs' (receipt proofs) for transactions that the wallet itself sent. InProofs are meant to prove to someone else that you received money. If a wallet could generate an InProof for a tran…

Prevents generation of misleading InProofs for outgoing/self-sent transactionsAdds explicit runtime guard in wallet proof generation pathFunctional tests updated to assert refusal behavior
61055c9dby tobtoht+47−392 files
No security note in commit
Moderate 57 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11603

This patch fixes a bug in the Monero wallet where, if a pending transaction failed, the wallet could incorrectly mark coins as unspent even though they had already been spent by a separate confirmed transaction. This could let the wallet t…

Incorrect state reset on failure pathPotential double-spend attempt caused by stale UTXO selectionWallet balance/availability inconsistency after failed pending tx
7b3f6271by tobtoht+2−01 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11492

This commit only adds a new automated fuzz-testing harness for Monero wallet features. It does not change any production wallet code, fix a bug, or alter network behavior. It is a test-only addition intended to help find bugs in the future…

Adds fuzz targets for payment URI parsing and transaction proof verificationNo changes to production wallet, consensus, or network codeNo bug fix or behavior change in existing source files
4014125fby tobtoht+364−02 files
No security note in commit
Low 27 AI analysisMessage 66 · Adequate
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11653

This Monero update fixes a bug in how nodes ask each other for blockchain history. Previously, a node could get stuck or drop a peer when it already knew about some blocks from another connection, because it would not ask for the next batc…

P2P protocol synchronization logic changePotential denial-of-service via peer dropping or sync stallNo authentication or cryptographic boundary crossed
8b99fe43by tobtoht+55−02 files
No security note in commit
Moderate 65 AI analysisMessage 45 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

wallet2: handle .keys saves and overlapping paths

This commit fixes a bug in how the Monero wallet saves itself to disk. Previously, the wallet could accidentally overwrite or corrupt its own files when the user chose a path that overlapped with existing wallet files, such as saving to a …

File overwrite / corruption prevention in wallet save path handlingSymlink and hardlink alias detection via filesystem equivalent() checksRejection of overlapping source/destination wallet files
4cc0e506by Samy+266−62 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedwallet2: sanitize untrusted daemon status in sweep unmixableby selsta · ff1157b1 · Sep 30, 2026 · 1 fileMessage 50 · ThinLow 46Details
Commit message · selsta

wallet2: sanitize untrusted daemon status in sweep unmixable

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Low 46/100

This commit changes how a Monero wallet handles error status codes returned by a remote daemon during a cleanup operation called 'sweep unmixable.' Previously, the wallet trusted the daemon's raw status response. Now it passes that status through a helper that treats certain errors differently when the daemon is not trusted. This is a hardening fix: a malicious or compromised remote node could potentially return a misleading status code that the wallet would treat as a fatal error, possibly disrupting the operation or influencing wallet behavior. The patch narrows what the wallet believes from an untrusted daemon.

AI review queuedOSS-Fuzz: Add fuzzer targets wallet scanby Arthur SC Chan · ddf38582 · Sep 30, 2026 · 2 filesMessage 70 · AdequateInformational 15Details
Commit message · Arthur SC Chan

OSS-Fuzz: Add fuzzer targets wallet scan

Signed-off-by: Arthur SC Chan <arthur.chan@adalogics.com>

70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidencesigning or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds a new automated test tool (a fuzzer) for the Monero wallet's transaction-scanning logic. It does not change any production wallet, node, or consensus code. Fuzzers feed random data to functions to find crashes or bugs during testing, but adding one is a defensive quality-assurance change, not a vulnerability fix or a security flaw in itself.

Security candidateFCMP++: tree building DB integrationby j-berman · ba217373 · Sep 28, 2026 · 35 filesMessage 45 · ThinLow 32Details
Commit message · j-berman

FCMP++: tree building DB integration

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Low 32/100

This is a large Monero commit that integrates a new privacy feature called FCMP++ (Full Chain Membership Proof) into the blockchain database. It adds new database tables, changes how outputs are indexed, and introduces a migration from database version 5 to 7. The changes are gated behind a build flag `ENABLE_FCMP_INTEGRATION` and are not enabled by default. There is no direct evidence in the commit that this fixes a known security vulnerability; it appears to be feature development for a future privacy upgrade.

AI review queuedMerge pull request #11364by tobtoht · 2f9d1bbb · Sep 28, 2026 · 1 fileMessage 58 · ThinLow 45Details
Commit message · tobtoht

Merge pull request #11364

be2cd75 wallet2: ignore long PIDs when block version is unknown (selsta)

ACKs: jpk68, tobtoht

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 45/100

This tiny change adjusts how the Monero wallet treats old-style unencrypted payment IDs when it cannot determine the block version of the transaction. Previously, if the block version was unknown (reported as 0), the wallet would still process the long payment ID. Now it ignores it, matching the intended privacy-preserving behavior for modern blocks. The risk is reduced privacy or accidental information leakage in edge cases, not theft of funds.

Security candidateMerge pull request #11371by tobtoht · e4979244 · Sep 28, 2026 · 3 filesMessage 58 · ThinModerate 63Details
Commit message · tobtoht

Merge pull request #11371

24f918a cryptonote_protocol: tighten pruned transaction blob validation (selsta)

ACKs: jeffro256, jpk68

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Moderate 63/100

This Monero update tightens how the network handles trimmed-down (pruned) transaction data shared between nodes. Before, a node could accept extra junk bytes tacked onto the end of a pruned transaction blob. Now it rejects such blobs. This closes a potential avenue for malformed data to be accepted or processed unexpectedly, which could lead to inconsistent node state or denial-of-service issues.

AI review queuedMerge pull request #11368by tobtoht · b5ab65c3 · Sep 28, 2026 · 4 filesMessage 66 · AdequateInformational 19Details
Commit message · tobtoht

Merge pull request #11368

5626dfc wallet2: restore from a Polyseed with --generate-from-json (Thomas)
0214b32 simplewallet: keep the restore height from --generate-from-json (Thomas)

ACKs: jpk68, selsta

66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit fixes a wallet-creation bug: when restoring a Monero wallet from a special newer-style seed (called a Polyseed) using a JSON configuration file, the wallet software previously treated it like an older Electrum-style seed. This could cause the restore height to be set incorrectly and could apply an optional seed passphrase to the wrong key derivation path. The patch makes the JSON restore path recognize Polyseeds and handle their passphrase and birthday height correctly. It also preserves the restore height in the simplewallet command-line tool when no explicit restore height is provided.

AI review queuedMerge pull request #11365by tobtoht · 74ab3773 · Sep 28, 2026 · 7 filesMessage 66 · AdequateInformational 23Details
Commit message · tobtoht

Merge pull request #11365

af7d613 wallet_rpc: add get_wallet_info (SNeedlewoods)
67dc8ea wallet: add get_proxy (SNeedlewoods)

ACKs: selsta, jpk68

66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 23/100

This commit adds a new read-only wallet command called get_wallet_info that lets an authenticated user ask the wallet for basic metadata such as the wallet file name, address, wallet type, which network it is on, the daemon address, and any configured proxy. It also fixes a small consistency bug where the stored proxy setting was not updated when set_proxy was called. The change is informational only: it does not move, spend, or expose private keys, and it is blocked in restricted RPC mode. The main security consideration is that it makes it slightly easier for a logged-in RPC user to learn the wallet's network setup, which could help target further attacks if the RPC endpoint is already compromised.

Security candidateMerge pull request #11007by tobtoht · 9314ec5d · Sep 28, 2026 · 10 filesMessage 66 · AdequateLow 46Details
Commit message · tobtoht

Merge pull request #11007

f543a36 cryptonote_protocol: include pruned weights in sync sizing (selsta)
89d8db0 cryptonote_protocol: limit queued blocks dynamically (selsta)

ACKs: jpk68, plowsof

66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Low 46/100

This Monero update improves how nodes download and queue blocks during blockchain synchronization. It changes the way pruned block sizes are counted, adds a check that pruned block weights match known values, and switches the download queue limit from a fixed number of spans to a dynamic number of blocks based on download speed. The changes are defensive: they reduce the chance that a misbehaving peer can feed incorrect block-size data that would make a node request too much or too little data, and they fix arithmetic overflow/underflow risks in the sync-size calculations. There is no direct evidence in the commit that these flaws were exploited or that the project calls this a security fix.

Security candidateMerge pull request #11373by tobtoht · 9401067c · Sep 28, 2026 · 1 fileMessage 58 · ThinLow 34Details
Commit message · tobtoht

Merge pull request #11373

0a58a8e polyseed: do not strip unassigned code points when normalizing (Thomas)

ACKs: jpk68, rbrunner7, selsta

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
seed or entropy pathmerge-commit duplicate discount
AI analysis · Low 34/100

This change removes the 'strip unassigned code points' option from two Unicode text normalization functions used when handling Polyseed mnemonic seed phrases. Previously, characters that Unicode has not officially assigned any meaning to were silently removed during normalization. Now they are preserved. The practical effect is that a seed phrase containing such rare characters would normalize differently before and after this patch, which could in theory change the wallet key derived from the phrase. The commit message does not call this a security fix; it is described as a correctness fix for normalization.

Security candidateMerge pull request #11369by tobtoht · 3b7d8421 · Sep 28, 2026 · 5 filesMessage 63 · AdequateLow 46Details
Commit message · tobtoht

Merge pull request #11369

e521789 crypto: random and siphash static-init-safety (jeffro256)

ACKs: jpk68, selsta, thomasbuilds

63/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
cryptography-sensitive pathseed or entropy pathmerge-commit duplicate discount
AI analysis · Low 46/100

This Monero commit changes how sensitive random-number and hash-key setup is performed. Previously, some initialization code could run automatically during program startup in a way that wasn't guaranteed to be thread-safe, and the secret SipHash key was directly accessible as a global variable. The patch makes initialization happen on first use using platform-native 'run once' primitives, splits the SipHash key initialization into its own guarded routine, and hides the key behind an accessor function. These are defensive hardening improvements; the commit message does not frame them as fixing an active vulnerability.

Security candidateMerge pull request #11374by tobtoht · 7a50b92c · Sep 28, 2026 · 2 filesMessage 58 · ThinInformational 15Details
Commit message · tobtoht

Merge pull request #11374

5ac9aa3 fcmp_pp: fix some typos (jpk68)

ACKs: redsh4de, jeffro256, selsta, PyXMR2025

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only fixes spelling mistakes in code comments and documentation strings. No actual program logic, math formulas, or executable code was changed. It cannot affect security in any way.

Security candidateMerge pull request #11348by tobtoht · f037512d · Sep 26, 2026 · 1 fileMessage 63 · AdequateModerate 65Details
Commit message · tobtoht

Merge pull request #11348

f462611 device: protect against buffer overflow (jpk68)

ACKs: selsta, PyXMR2025

63/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetymerge-commit duplicate discount
AI analysis · Moderate 65/100

This commit adds a safety check in Monero's hardware wallet USB communication code. Before reading another chunk of data from a Ledger/Trezor-like device, it now verifies that the next chunk will fit inside the fixed-size memory buffer. Without this check, a malicious or malfunctioning USB device could trick the software into writing past the end of the buffer, potentially crashing the wallet or corrupting memory. The fix is a straightforward bounds check, but it is only one of several reads in the same loop, so it may be a partial hardening rather than a complete fix for every overflow path.

AI review queuedMerge pull request #11346by tobtoht · 1019b788 · Sep 26, 2026 · 1 fileMessage 58 · ThinLow 42Details
Commit message · tobtoht

Merge pull request #11346

7e2e857 wallet2: validate block hash when repairing empty hashchain (selsta)

ACKs: PyXMR2025, jpk68

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 42/100

This patch adds a safety check in Monero's wallet code when it asks the connected node (daemon) for a block hash to repair an empty local record of past blocks. Previously, if the daemon returned malformed or invalid data, the wallet would silently treat the conversion as successful and use an uninitialized or corrupted hash. Now the wallet explicitly checks whether the conversion succeeded and throws an error if it did not. This is a defensive hardening fix that prevents the wallet from accepting an invalid block hash during a recovery operation.

Security candidateMerge pull request #11261by tobtoht · 78a49af3 · Sep 26, 2026 · 3 filesMessage 58 · ThinModerate 63Details
Commit message · tobtoht

Merge pull request #11261

9cef02d cryptonote_protocol: reject conflicting span reservations (selsta)

ACKs: jpk68, plowsof

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Moderate 63/100

This change fixes a bug in how Monero nodes reserve chunks ('spans') of blocks to download from peers. Previously, two different peers could be assigned the same starting block height with different expected block hashes, causing confusion about which blocks to request and potentially wasting bandwidth or delaying sync. The fix makes the reservation step check for conflicts before committing, and returns failure if the same height is already reserved by another peer. There is no direct evidence in the commit message that this was publicly disclosed as a security vulnerability.

Security candidateMerge pull request #11359by tobtoht · 5cf4a5bf · Sep 26, 2026 · 1 fileMessage 58 · ThinModerate 57Details
Commit message · tobtoht

Merge pull request #11359

52a7ff3 cryptonote_core: reject duplicate tx hashes before pool lookup (selsta)

ACKs: jpk68, SChernykh, PyXMR2025

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Moderate 57/100

This change adds a safety check when a Monero node packages a block for relay to other nodes. Before this patch, if a block somehow contained the same transaction hash twice, the node would not notice and could produce an invalid or malformed block package. The fix detects duplicate transaction hashes and throws an error instead of silently continuing. The commit message does not describe this as a security fix, so its security relevance is uncertain, but duplicate-hash bugs in consensus-related code can sometimes be exploited to cause network disruption or inconsistent state.

AI review queuedMerge pull request #11350by tobtoht · cc6fb1d2 · Sep 26, 2026 · 5 filesMessage 58 · ThinInformational 24Details
Commit message · tobtoht

Merge pull request #11350

3e727c6 Expose wallet exist as rpc command (Deverick)

ACKs: PyXMR2025, jpk68, selsta

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 24/100

This commit adds a new wallet RPC command called wallet_exists that lets a caller check whether a wallet file or its keys file already exists in the configured wallet directory. It also refactors existing filename validation into a shared helper. The new command is blocked in restricted RPC mode and reuses the same path-separator checks as create/open wallet, so it does not appear to introduce a new security vulnerability. It could, however, make it slightly easier for an authenticated RPC user to probe for wallet names.

Security candidateMerge pull request #11264by tobtoht · 325976c6 · Sep 25, 2026 · 6 filesMessage 58 · ThinModerate 59Details
Commit message · tobtoht

Merge pull request #11264

3125e6d multisig: reject mismatched key image component count (jpk68)

ACKs: selsta, UkoeHB

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
privacy or spend-authorization protocolsigning or wallet pathmerge-commit duplicate discount
AI analysis · Moderate 59/100

This Monero update tightens validation around multisig key images and imported multisig data. Multisig wallets require several participants to combine pieces (partial key images and signing nonces) to spend funds. The patch makes the wallet reject incomplete or duplicate pieces before it accepts them, instead of silently building a broken key image. It also fixes an incorrect count check used when importing multisig data. The changes are defensive hardening; they do not by themselves show that money could be stolen, but they close paths where malformed or inconsistent data could cause incorrect key images, failed transactions, or potential misuse.

AI review queuedMerge pull request #11263by tobtoht · 0ac3a540 · Sep 25, 2026 · 2 filesMessage 66 · AdequateModerate 59Details
Commit message · tobtoht

Merge pull request #11263

cbf3331 wallet2: validate key data in password and device checks (selsta)
923ee54 wallet2: check reserve proof additional key index (selsta)
4c82440 wallet2: validate legacy transfer output indices (selsta)
b76c4b7 wallet2: normalize account tags before assignment (selsta)

ACKs: thomasbuilds*, jpk68

66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This Monero wallet update adds several safety checks to prevent the wallet software from crashing or behaving incorrectly when handling unusual wallet files, transaction proofs, or old account data. It does not appear to be a remote money-stealing bug, but rather hardening against malformed inputs that could cause errors or unexpected behavior.

Security candidateMerge pull request #11006by tobtoht · f53e87ac · Sep 25, 2026 · 3 filesMessage 66 · AdequateModerate 57Details
Commit message · tobtoht

Merge pull request #11006

967aa9f cryptonote_core: fully parse incoming block batches (selsta)
e59781a cryptonote_protocol: avoid overlapping reserved spans (selsta)

ACKs: jpk68, plowsof

66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Moderate 57/100

This Monero update fixes two related bugs in how the node downloads and processes batches of blocks from peers. First, it ensures every block in an incoming batch is fully parsed even when some blocks are already known, so the node does not accidentally skip validation steps. Second, it prevents the node from asking different peers for the same block ranges twice at the same time, which could waste bandwidth and potentially confuse the sync logic. The commit does not describe these changes as security fixes, but they touch on consensus-critical code paths.

AI review queuedMerge pull request #11319by tobtoht · e478eb5a · Sep 25, 2026 · 5 filesMessage 66 · AdequateLow 48Details
Commit message · tobtoht

Merge pull request #11319

fe371dd wallet2: filter unchecked RPC error statuses (selsta)
dab064f wallet2: validate public node addresses before display (selsta)
5834007 common: sanitize message writer console output (selsta)

ACKs: SNeedlewoods, thomasbuilds, jpk68

66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 48/100

This Monero wallet update fixes three separate issues: it prevents weird or malicious text from log/console messages from confusing the terminal (terminal escape-sequence injection), it stops the wallet from trusting and displaying invalid public node addresses from the network, and it improves error handling when the wallet talks to a daemon so that untrusted RPC responses are not silently accepted. None of these directly steal funds, but they reduce ways an attacker could trick a user or hide problems.

AI review queuedwallet: batch account balances for RPCby Samy · bcd17917 · Sep 25, 2026 · 4 filesMessage 68 · AdequateInformational 19Details
Commit message · Samy

wallet: batch account balances for RPC

`get_accounts` currently scans all transfers twice for each matching
account. compute account balances in one pass, including pending change
and incoming payments, while preserving strict and unlocked balance
rules.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit is a performance optimization for the Monero wallet's RPC interface. It changes how account balances are calculated so that all accounts are scanned in a single pass instead of scanning the entire transaction history separately for each account. The commit also adds tests to verify that the new batch calculation produces the same results as the old individual calculation. There is no indication this fixes a security vulnerability; it appears to be a correctness-preserving efficiency improvement.

Security candidateMerge pull request #11155by tobtoht · 1add2d74 · Sep 24, 2026 · 3 filesMessage 63 · AdequateHigh 77Details
Commit message · tobtoht

Merge pull request #11155

879b09f crypto: check key image in ring signature verif (jeffro256)

ACKs: UkoeHB, thomasbuilds, jpk68, selsta

63/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundaryprivacy or spend-authorization protocolcryptography-sensitive pathmerge-commit duplicate discount
AI analysis · High 77/100

This patch tightens validation of Monero 'key images'—the special values that prevent the same coin from being spent twice. Before the change, a malformed key image that was either the identity point or had a small-order/torsion component could potentially slip through ring-signature verification. The fix rejects the identity key image outright and multiplies the key image by the curve order to confirm it lies on the proper subgroup, returning false if it does not. This closes a path that could let an attacker craft a signature that looks valid but does not actually mark a real coin as spent, which in Monero can translate to a double-spend or balance-inflation risk.

Security candidateMerge pull request #11033by tobtoht · ca98e4fa · Sep 24, 2026 · 8 filesMessage 58 · ThinModerate 64Details
Commit message · tobtoht

Merge pull request #11033

8a393ed rpc: hide sensitive txs from restricted block templates (selsta)

ACKs: jpk68, SChernykh

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Moderate 64/100

This change fixes a privacy leak in Monero's restricted RPC mode. When a node operator enabled restricted RPC (used for public RPC endpoints), the get_block_template RPC call could still include sensitive transactions—specifically Dandelion++ stem transactions that are not yet meant to be publicly broadcast. A remote user could request a block template from a restricted RPC node and learn about transactions that ordinary network participants should not yet see, weakening transaction privacy. The patch adds an include_sensitive flag that defaults to true for normal callers but is set to false when the request comes through a restricted RPC context, so those transactions are excluded from the returned template.

Security candidateMerge pull request #11321by tobtoht · d1bcbc76 · Sep 24, 2026 · 1 fileMessage 58 · ThinLow 46Details
Commit message · tobtoht

Merge pull request #11321

46807c4 blockchain: fix lock ordering in check_against_checkpoints (selsta)

ACKs: jpk68, SNeedlewoods

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Low 46/100

This patch changes the order in which two internal locks are acquired in a Monero blockchain-checking function. In multi-threaded software, taking locks in the wrong order can cause a 'deadlock,' where two parts of the program wait forever for each other and the node can freeze. The change makes the lock order consistent with the rest of the codebase, which is a defensive fix. There is no direct evidence in the commit that an attacker can trigger the deadlock on demand, but lock-order bugs are a classic source of denial-of-service problems in network-facing daemons.

AI review queuedMerge pull request #11274by tobtoht · d5ad72e5 · Sep 24, 2026 · 2 filesMessage 58 · ThinLow 37Details
Commit message · tobtoht

Merge pull request #11274

a319868 wallet2: validate account tags before mutation (Samy)

ACKs: jpk68, selsta

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 37/100

This commit fixes a bug in Monero's wallet software where the program would partially change account labels before checking whether all requested accounts actually exist. The fix moves the boundary check to the very beginning so the operation either fully succeeds or fully fails, and no partial changes are saved. The practical security impact is limited because the bug only affects account tagging metadata, not balances or transactions.