XMR
← All projectsMonero Project

Monero

Reference Monero node, command-line wallet, consensus, networking, and cryptographic protocol implementation.

Cryptographic librariesMoneroNode implementationsPrivacy protocolsNormal
Repository coverage

743 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

219security candidates228second-pass queue447AI analyses
113commits · 30 days
234commits · 60 days
643commits · 180 days
742commits · 365 days
Backfill bands
Sep 27 → Mar 3192 seen34 candidatesComplete
Mar 31 → Jul 29369 seen101 candidatesComplete
Jul 29 → Aug 28128 seen36 candidatesComplete
Aug 28 → Sep 2788 seen21 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

51/100 average clarity
20Strong · 80–100
123Adequate · 60–79
534Thin · 40–59
66Opaque · 0–39
14security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
jeffro256633850257
koe313259
tobtoht1823283150
Cole Munz424177
Masamune222164
SNeedlewoods805152
selsta1744997051
j-berman432934058
jpk68881452046
Samy371023048
Thomas271015057
SChernykh1188062
Analysis record

Published AI watches

Last scanned 46 minutes ago

Low 42 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11462

This Monero wallet update fixes a bookkeeping bug. When a wallet imported a list of its owned outputs and that list was smaller than a previous import, internal lookup maps (key images and public keys) could still point to entries that no …

Internal index/cache consistency fix in wallet output handlingPrevents out-of-range references after transfer list resizeAdds defensive repair on wallet cache load for unrefreshed wallets
160e2150by tobtoht+29−02 files
No security note in commit
Low 26 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11460

This commit simplifies how Monero's simplewallet decides whether a payment ID is a real encrypted ID or a dummy placeholder. Previously, the wallet checked both the payment ID value and whether any destination was an integrated address, an…

Removal of a CHECK_AND_ASSERT_MES consistency check between destination flags and payment ID valueChange from dual-factor classification (address type + payload) to payload-only classificationPotential for previously rejected transactions to be accepted if the old check was overly strict
4b84712eby tobtoht+1−91 file
No security note in commit
Low 42 AI analysisMessage 50 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

wallet2: trim stale transfer maps after output imports

This Monero wallet patch cleans up internal lookup tables (key-image and public-key indexes) when the list of owned transaction outputs is shrunk, for example during an output import. Without the cleanup, those indexes could point to entri…

Out-of-bounds index retained in wallet lookup maps after container shrinkPotential wallet crash or incorrect spend selection due to stale key-image / public-key mappingRepair-on-load for legacy wallet caches that predate the fix
80f75eaaby selsta+29−02 files
No security note in commit
Low 25 AI analysisMessage 50 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

simplewallet: classify payment IDs by their payload

This small change removes a consistency check in Monero's command-line wallet when loading a saved transaction. Previously, the wallet verified that a 'dummy' payment ID label matched a special zero-value payment ID. Now it labels the paym…

Removal of a CHECK_AND_ASSERT_MES consistency checkRemoval of integrated-address validation for payment ID classificationChange in UI/labeling logic for loaded transactions
5937d5cfby selsta+1−91 file
No security note in commit
Informational 22 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11161

This commit updates Monero's built-in blockchain checkpoints to match the v0.18.5.3 release. Checkpoints are hard-coded reference points that help nodes quickly verify they are following the correct chain and resist certain attacks. The ch…

Hard-coded blockchain checkpoint data updated to a newer height/hashExpected compiled-in block hashes digest changedNo new code paths, cryptographic changes, or bug fixes visible in the diff
b0a9d51eby tobtoht+7−74 files
No security note in commit
Low 38 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11448

This is a small code fix in Monero's wallet that keeps the recorded breakdown of received amounts consistent when a transaction output is 'burnt' (replaced or spent as part of a transaction the wallet is processing). The change adds a chec…

Defensive consistency check added (THROW_WALLET_EXCEPTION_IF)Fixes internal accounting of received output amountsNo explicit security claim in commit or supplied references
24a01223by tobtoht+7−01 file
No security note in commit
Moderate 60 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11443

This patch fixes a spot in the Monero wallet where an untrusted remote server (daemon) could supply a misleading 'status' field. Previously, the wallet used that raw status directly in its error handling, which could potentially make a mal…

Untrusted input from remote daemon used in error-handling pathMissing trust check on daemon-reported RPC statusSingle-call-site hardening patch
c03c1f15by tobtoht+1−11 file
No security note in commit
Informational 15 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11406

This commit adds two new read-only options to the wallet's remote procedure call (RPC) interface so users can request their public view key and public spend key. Public keys are meant to be shared openly and are not secrets, so exposing th…

717a4235by tobtoht+17−03 files
No security note in commit
Informational 15 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11394

This commit only updates a submodule pointer for the external polyseed library from one commit hash to another. The actual code changes inside the submodule are not shown in the diff, and no public references were supplied. There is no vis…

c437e73fby tobtoht+1−11 file
No security note in commit
Moderate 64 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11391

This patch fixes a size-limit accounting bug in Monero's built-in HTTP server. When a client sends multiple HTTP requests back-to-back on the same connection (pipelining), leftover buffered data from the next request was not being counted …

Request size limit bypass via pipelined HTTP cachingDenial-of-service / memory pressure potential from oversized requestsFix in low-level network protocol handler
9b24b744by tobtoht+2−11 file
No security note in commit
Moderate 51 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11386

This patch fixes a privacy leak in Monero's wallet RPC server. Previously, the --no-dns flag was ignored when no wallet was loaded, so the validate_address RPC call could still perform a DNS lookup (OpenAlias) even though the user had expl…

Privacy leak: RPC ignored --no-dns when no wallet loadedDNS lookup performed despite explicit user opt-outOpenAlias resolution could disclose queried addresses/aliases to DNS resolvers
9df95286by tobtoht+33−25 files
No security note in commit
Low 48 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11385

This commit adds cleanup of three additional memory buffers in Monero's seed-phrase key-stretching code. Before the change, leftover copies of intermediate secrets could remain in stack memory after the function finished. An attacker who c…

Sensitive intermediate key material left in stack memory after function returnUse of sodium_memzero to clear cryptographic buffersPBKDF2 implementation handling mnemonic-derived secrets
1cd8ae93by tobtoht+3−01 file
No security note in commit
Informational 21 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11383

This update improves the Monero wallet's command that connects to a network node (daemon). It lets users supply a username/password and a proxy address when switching daemons, and it replaces an older one-step connection method with a newe…

Added mutex lock in wallet2::set_proxy to protect concurrent access to proxy and HTTP client stateset_daemon now passes RPC login credentials and proxy settings through the proper wallet2::set_daemon APITrust heuristic changed to only auto-trust local daemons when no proxy is in use
07e23b8fby tobtoht+78−172 files
No security note in commit
Low 42 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11253

This change alters how Monero creates a view-only wallet copy. Previously, the code exported outputs using a method that could strip some metadata. Now it copies the full internal transfer records directly, then wipes and clears the multi-…

Sensitive field sanitization before export (memwipe + clear of m_multisig_k)Change in data export path for view-only wallet creationPreservation of 'complete output metadata' implying previous path was incomplete
ff738959by tobtoht+9−31 file
No security note in commit
Moderate 69 AI analysisMessage 66 · Adequate
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11333

This Monero update hardens how public keys and transaction pubkeys are handled. It moves a low-level 'torsion clearing' routine into the core crypto library, adds checks that wallet/destination addresses are valid points on the main subgro…

Adds main-subgroup membership validation for public address keys (spend/view)Normalizes transaction public keys before use in payment-ID decryption and tx proofsMoves torsion-clearing primitive into core crypto layer to ensure consistent behavior
6f4b99abby tobtoht+178−15016 files
No security note in commit
Moderate 63 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11268

This Monero update fixes a networking bug where the server could accidentally block all of its worker threads while waiting for slow clients to accept data. If all workers became stuck this way, the node could stop processing any network t…

Removal of blocking condition-variable wait in network send pathFail-fast on send-queue overflow instead of parking worker threadsHTTP handler now propagates send failures and enters error state
dba16f07by tobtoht+205−3025 files
No security note in commit
Moderate 59 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11260

This Monero wallet patch adds stronger safety checks when a wallet prepares, signs, or loads multi-step transactions (unsigned transactions, multisig transactions, and cold-device transactions). It verifies that money going into the transa…

Adds duplicate-input detection across transaction setsAdds destination address type consistency checksAdds uint64 overflow guard for summed input amounts
66dd773eby tobtoht+265−454 files
No security note in commit
Low 34 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11144

This Monero update makes the network layer clean up leftover block download records when a peer connection fails or is rejected. Previously, rejected or disconnected peers could leave stale block spans in a queue, which might cause the nod…

Denial-of-service resistance: stale block spans from malicious or faulty peers could prevent a node from obtaining valid blocksState cleanup on peer disconnection/rejectionNo authentication or memory-safety bug evident in diff
ddfa2279by tobtoht+2−01 file
No security note in commit
Low 46 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11362

This small patch fixes a bug in the Monero wallet where, if an output had already been scanned once, the wallet would return early without clearing an error flag. In rare cases this could leave a stale 'error' state attached to a transacti…

Stale error-state propagation in wallet scanning logicMissing reset of tx_scan_info.error on cached/short-circuit code pathPotential for incorrect received-payment or scan-failure reporting
30860a26by tobtoht+3−01 file
No security note in commit
Low 34 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11366

This change fixes a binary search in the Monero wallet that previously could loop forever or behave incorrectly if something went wrong. The old code used an unbounded 'while (true)' loop and a midpoint calculation that could overflow. The…

Unbounded loop replaced with bounded iterationInteger overflow mitigation in midpoint calculationDefensive error handling added for search failure
c16cd3f7by tobtoht+4−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedrpc: restrict get_alt_blocks_hashesby selsta · 758aa14f · May 15, 2026 · 1 fileMessage 35 · OpaqueLow 45Details
Commit message · selsta

rpc: restrict get_alt_blocks_hashes

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 45/100

This commit changes one line in Monero's RPC server so that the get_alt_blocks_hashes endpoint is no longer available when the node is running in restricted mode. Previously, any caller could ask a restricted node for the list of alternative (orphaned/uncles) block hashes. The change suggests the developers decided this information should be treated as privileged, but the commit message does not explain why.

Security candidatecryptonote_protocol: fix peer overview loggingby selsta · 6fc7aa83 · May 14, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · selsta

cryptonote_protocol: fix peer overview logging

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathparser or protocol path
AI analysis · Informational 15/100

This commit fixes a minor logging bug in the Monero peer-to-peer protocol code. The previous code accidentally added a number to a character (using '+' instead of '<<'), which produced incorrect characters in a debug peer-overview string. The fix simply prints the number and character separately. There is no security impact.

Security candidateRemove obsolete test-drop-download debug optionsby selsta · f4795a00 · May 14, 2026 · 5 filesMessage 78 · AdequateInformational 15Details
Commit message · selsta

Remove obsolete test-drop-download debug options

These options were introduced in 2015 as manual debug helpers for
network-limit testing. They are not used by the current test suite.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
cryptography-sensitive pathparser or protocol path
AI analysis · Informational 15/100

This commit removes two old command-line debug options, --test-drop-download and --test-drop-download-height, that were added in 2015 to help developers manually test network behavior by discarding downloaded blocks. The commit deletes the option definitions, the code that read them, the code that skipped block processing when they were set, and related shell-completion hints. There is no security fix here; it is a cleanup of unused debugging flags.

Security candidatemonero_blockchain_export: >2.5x blocksdat export speedby jeffro256 · fbd7776b · May 13, 2026 · 1319 filesMessage 65 · AdequateInformational 15Details
Commit message · jeffro256

monero_blockchain_export: >2.5x blocksdat export speed

Uses efficient DB traversal to slash disk read time, which is a large chunk of the run-time.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathseed or entropy pathsigning or wallet pathboot or update pathauthentication pathparser or protocol path
AI analysis · Informational 15/100

This commit is a large repository initialization or merge that adds the entire Monero codebase plus build/CI files. The stated purpose is to speed up the blockchain export tool by reading the database more efficiently. There is no indication in the commit message or the visible changes that this is a security fix or introduces a security vulnerability.

Security candidatefix spelling in comments and docsby Thomas · 2c327aa3 · May 13, 2026 · 61 filesMessage 45 · ThinInformational 15Details
Commit message · Thomas

fix spelling in comments and docs

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet pathparser or protocol path
AI analysis · Informational 15/100

This commit is a large-scale spelling and typo correction across comments, documentation, and a few string literals. It changes no program logic, no function behavior, and no executable code paths. There is no security relevance.

AI review queuedwallet: fix RPC describe transfer source entryby jeffro256 · 123e33d3 · May 13, 2026 · 1 fileMessage 45 · ThinLow 26Details
Commit message · jeffro256

wallet: fix RPC describe transfer source entry

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 26/100

This commit fixes a bug in the Monero wallet's RPC 'describe transfer' feature. Previously, the code used the wrong index (real_output_in_tx_index) to look up the real ring member in the list of possible transaction sources. The fix uses the correct index (real_output). This could have caused the RPC response to report the wrong global index and public key for the real source of funds, potentially misleading wallet users or downstream tools that rely on this data.

AI review queuedupdate rapidjson submoduleby tobtoht · 9e422aa5 · May 13, 2026 · 2 filesMessage 35 · OpaqueLow 35Details
Commit message · tobtoht

update rapidjson submodule

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 35/100

This commit updates the RapidJSON submodule used by Monero and adds a Windows-specific workaround in the Trezor hardware wallet transport code. The workaround undefines the Windows macro 'GetObject' before including RapidJSON headers, because that macro conflicts with a RapidJSON method name. This is a compatibility fix for a known upstream issue, not a direct security patch. It likely prevents build or runtime problems on Windows when communicating with Trezor devices, but the commit itself does not describe any vulnerability or exploit.

AI review queuedwallet: remove output blackballingby tobtoht · 3af06e53 · May 11, 2026 · 12 filesMessage 35 · OpaqueInformational 22Details
Commit message · tobtoht

wallet: remove output blackballing

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 22/100

This commit removes the 'output blackballing' feature from the Monero wallet software. Blackballing let users mark certain blockchain outputs as 'spent' so their own wallet would avoid picking them as decoys in ring signatures. The change deletes the supporting utility, the wallet commands, the API methods, and the database table used to store these marks. It is a feature-removal cleanup, not a fix for an active security vulnerability in the code itself.

AI review queuedwallet: roll back unlocker count on decrypt failureby fuyua9 · 9a186975 · May 10, 2026 · 2 filesMessage 50 · ThinLow 44Details
Commit message · fuyua9

wallet: roll back unlocker count on decrypt failure

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 44/100

This commit fixes a bookkeeping bug in the Monero wallet's key-unlock mechanism. Previously, if a user entered the wrong password while trying to decrypt wallet keys, the internal counter that tracks active unlockers was increased but never decreased. That left the wallet thinking it was still unlocked even though the keys had not actually been decrypted. The fix rolls back the counter and removes the wallet's entry from the tracking map when decryption fails. The included test confirms that after a failed unlock attempt, a later correct password still works and keys remain properly locked in between.

Security candidateblockchain_db: fix remove_block * remove_block should set the cursor before deletionby 0xFFFC0000 · a00b7dd5 · May 10, 2026 · 1321 filesMessage 65 · AdequateLow 30Details
Commit message · 0xFFFC0000

blockchain_db: fix remove_block
* remove_block should set the cursor before deletion

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathseed or entropy pathsigning or wallet pathboot or update pathauthentication pathparser or protocol path
AI analysis · Low 30/100

This commit is titled as a fix for the blockchain database's 'remove_block' function, specifically that the cursor should be set before deletion. However, the actual supplied diff is enormous (665,233 added lines across 1,321 files) and appears to be a full repository import or merge rather than a focused patch. The specific code change described in the title cannot be verified from the provided diff because the relevant file (src/blockchain_db/lmdb/db_lmdb.cpp) is not shown in the diff excerpt. The security relevance is therefore uncertain based only on the materials given.

Security candidateUpdated RandomX to v1.2.2by SChernykh · a82fdf97 · May 10, 2026 · 1 fileMessage 45 · ThinInformational 2Details
Commit message · SChernykh

Updated RandomX to v1.2.2

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
proof-of-work or emission validationseed or entropy path
AI analysis · Informational 2/100

This commit updates a bundled external component called RandomX from one version to another (v1.2.2). The actual code changes are not visible because the diff was not provided, and no verified references were supplied. Without seeing what changed, it is impossible to tell whether this update fixes a security problem, fixes a regular bug, or just refreshes the dependency.

AI review queueduse latest hard fork block for get_approximate_blockchain_height & update approximate_rolled_back_blocksby SNeedlewoods · 50c3c50b · May 10, 2026 · 1 fileMessage 50 · ThinInformational 21Details
Commit message · SNeedlewoods

use latest hard fork block for get_approximate_blockchain_height & update approximate_rolled_back_blocks

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 21/100

This commit updates the wallet's method for estimating the current blockchain height. Previously, the wallet used a fixed old hard-fork point and a fixed rollback adjustment. Now it uses the latest hard-fork data and updated rollback figures. The change is primarily about keeping the estimate accurate as the network evolves. It is not a direct fix for a code execution or theft vulnerability, but an inaccurate estimate could in theory affect wallet behavior such as when it considers itself synced or which outputs it scans.

Security candidateserialization: avoid blob memcpy of secret_key vectorby selsta · 6460917c · May 9, 2026 · 2 filesMessage 50 · ThinModerate 56Details
Commit message · selsta

serialization: avoid blob memcpy of secret_key vector

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Moderate 56/100

This commit changes how Monero stores and loads a list of sensitive multisignature wallet keys. Previously, the code used a generic 'copy the raw bytes' path for a container of secret keys. That generic path could leave copies of secret key bytes in temporary memory or use a copy method not safe for non-trivial types. The patch forces the keys to be converted through an explicitly cleared intermediate type and adds a compile-time guard so the generic blob-copy helper can only be used on simple, safe types. In short: it reduces the chance that secret key material leaks or gets mishandled during wallet serialization.

Security candidatecrypto: fix calloc warningsby ComputeryPony · d31c3cad · May 9, 2026 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · ComputeryPony

crypto: fix calloc warnings

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100

This commit swaps the two arguments in two calloc() calls so they follow the conventional order (number of elements first, then element size). On standard platforms this produces identical memory allocation results and does not change program behavior or fix any security bug. It only silences compiler warnings.

AI review queuedwallet: add `wallet2_basic` library typesby jeffro256 · b4c54499 · May 8, 2026 · 11 filesMessage 68 · AdequateInformational 12Details
Commit message · jeffro256

wallet: add `wallet2_basic` library types

The `wallet2_basic` library is a minimalistic library for loading / storing historic `wallet2` files. It has several design goals:
* Enable future migration away from monolithic `wallet2` codebase without losing funds
* Simplify FCMP++/Carrot integration
* Speed-up compile-time for current codebase, but especially the FCMP++/Carrot integration, which is split over several translation units

Co-authored-by: j-berman <justinberman@protonmail.com>
Co-authored-by: selsta <selsta@sent.at>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit is a large but straightforward code reorganization. It moves wallet data structures (such as transaction records, address book entries, and settings enums) out of the giant wallet2 module into a new smaller library called wallet2_basic. The existing wallet2 code now references these shared types instead of defining them itself. There is no user-facing behavior change, no new feature, and no obvious security fix or vulnerability introduced in the visible diff.

Security candidatezmq: apply restricted-mode privacy filtering to get_transaction_poolby greatjourney589 · 7af90094 · May 8, 2026 · 6 filesMessage 81 · StrongModerate 51Details
Commit message · greatjourney589

zmq: apply restricted-mode privacy filtering to get_transaction_pool

Add an include_sensitive parameter to tx_memory_pool::get_pool_for_rpc
(and its core passthrough), mirroring the include_sensitive_data
parameter on the HTTP analog get_transactions_and_spent_keys_info.
When false, receive_time and last_relayed_time are zeroed using the
same masking already applied on the HTTP path.

The ZMQ handler in daemon_handler.cpp passes !m_restricted, so
--restricted-zmq-rpc callers now receive the same privacy-filtered view
as restricted HTTP callers instead of the unfiltered timing metadata
they previously got. Stem-phase txs continue to be excluded regardless
(relay_category::broadcasted filter unchanged).

Refs #10529.

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive path
AI analysis · Moderate 51/100

This commit fixes a privacy gap in Monero's restricted ZeroMQ RPC mode. Before the patch, someone using the --restricted-zmq-rpc option could still see exact times when transactions arrived and were last relayed through the get_transaction_pool ZMQ call. The HTTP restricted mode already hid those timing details, but the ZMQ path did not. The patch adds the same on/off privacy filter to the ZMQ path so restricted callers now get zeroed-out timestamps, matching restricted HTTP behavior. Timing metadata can help an observer deanonymize or trace transactions, so this is a privacy hardening fix.

AI review queuedwallet_rpc_server: add missing trusted daemon checkby selsta · dae0f4cf · May 7, 2026 · 1 fileMessage 50 · ThinModerate 60Details
Commit message · selsta

wallet_rpc_server: add missing trusted daemon check

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 60/100

This commit adds a safety check to a Monero wallet command called rescan_spent. Previously, the command could be run even when the wallet was connected to a daemon it did not trust. The fix now refuses to run the command unless the daemon is marked as trusted. This matters because an untrusted daemon could potentially lie about which coins have been spent, which may confuse the wallet's balance or, in the worst case, be used to manipulate transaction creation.

AI review queuedepee: remove LOCAL_ASSERTby jeffro256 · 681ea9f1 · May 7, 2026 · 4 filesMessage 68 · AdequateInformational 15Details
Commit message · jeffro256

epee: remove LOCAL_ASSERT

LOCAL_ASSERT was only defined on Windows,
only used in the `CHECK_AND_ASSERT` macro,
and was disabled in unit tests anyways,
but only in the main translation unit,
which didn't have local asserts,
since get_set_enable_assert was inline,
so the disabling didn't even do anything.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit removes a Windows-only debug assertion helper called LOCAL_ASSERT that was effectively dead code. It does not change how the software handles errors in normal builds, and it does not introduce a security vulnerability.

AI review queuedcmake: require unbound idiomaticallyby tobtoht · b1a81cc0 · May 6, 2026 · 5 filesMessage 35 · OpaqueInformational 19Details
Commit message · tobtoht

cmake: require unbound idiomatically

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 19/100

This commit is a build-system cleanup. It changes how the Monero software finds and links the Unbound DNS library during compilation, switching to a more standard CMake method. There is no direct evidence in the commit that it fixes a security vulnerability in running Monero software.

Security candidatecmake: only link Boost Chrono where neededby tobtoht · 90fc50c3 · May 6, 2026 · 12 filesMessage 45 · ThinInformational 15Details
Commit message · tobtoht

cmake: only link Boost Chrono where needed

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet pathdocumentation-only discount
AI analysis · Informational 15/100

This commit is a routine build-system cleanup. It removes the Boost Chrono library from the link lists of components that don't actually use it, and adds it to the one component that does. There is no change to program logic, no bug fix, and no security relevance visible in the diff.

Security candidateepee: better scope leaverby jeffro256 · 05ab3168 · May 6, 2026 · 6 filesMessage 58 · ThinInformational 17Details
Commit message · jeffro256

epee: better scope leaver

1. Doesn't allocate a `boost::shared_ptr`
2. Doesn't use a vtable
3. Doesn't use `std::function` wrapper
4. Doesn't necessarily copy functional object
5. Doesn't need a factory function for simple declaration (yay CTAD)
6. Isolated to its own header
7. Name doesn't suck as much

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive pathsigning or wallet pathparser or protocol path
AI analysis · Informational 17/100

This is a code-quality refactor, not a security fix. It replaces an older, heavier C++ scope-cleanup helper with a lighter, modern one. The change touches several parts of the program but does not add or remove any security behavior; it only changes how cleanup actions are expressed internally.

Security candidateepee: fail digest auth cleanly when MD5 is unavailableby selsta · 46c857ef · May 4, 2026 · 1 fileMessage 55 · ThinLow 33Details
Commit message · selsta

epee: fail digest auth cleanly when MD5 is unavailable

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
authentication path
AI analysis · Low 33/100

This change makes Monero's HTTP digest authentication code handle failures in the MD5 hashing functions more gracefully. Previously, if OpenSSL's MD5 operations failed (for example, because MD5 was disabled in the cryptographic library), the code would silently continue with invalid or empty hash values, potentially allowing authentication to proceed incorrectly. Now the code checks each hashing step and aborts the authentication attempt cleanly if MD5 cannot be computed.

Security candidatenet: replace deprecated boost::asio::strand::wrap with bind_executorby ryurt46 · a5ab8e57 · May 4, 2026 · 2 filesMessage 50 · ThinInformational 15Details
Commit message · ryurt46

net: replace deprecated boost::asio::strand::wrap with bind_executor

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathparser or protocol path
AI analysis · Informational 15/100

This is a routine code modernization change. It replaces an older, deprecated Boost networking function called strand.wrap with the newer equivalent bind_executor in two files. There is no indication this fixes a security bug; it simply keeps the code compatible with newer versions of the Boost library.

Security candidatecrypto: implement CTHR_THREAD_CLOSE to avoid leaking memoryby ComputeryPony · f73c72d4 · May 3, 2026 · 1 fileMessage 62 · AdequateLow 35Details
Commit message · ComputeryPony

crypto: implement CTHR_THREAD_CLOSE to avoid leaking memory

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Explains rationale or failure mode! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Low 35/100

This commit fixes a thread resource leak in Monero's cryptography code. Previously, a helper macro called CTHR_THREAD_CLOSE was defined as doing nothing, meaning threads were created and joined but never properly detached. On systems using POSIX threads (pthreads), this can leave thread resources unreleased, causing gradual memory use growth. The fix makes CTHR_THREAD_CLOSE call pthread_detach, which tells the system it can clean up the thread after it finishes. This is a reliability and resource-management fix rather than a direct remote exploit, but resource exhaustion can sometimes affect service availability.

Security candidateringct: make h2d fallibleby jeffro256 · 2210f851 · May 2, 2026 · 7 filesMessage 58 · ThinModerate 65Details
Commit message · jeffro256

ringct: make h2d fallible

One theoretically could have crafted a "long amount" (pre-v10) RingCT transaction
with non-0 padding bytes in the decoded amount which fails receiver scanning, but
passes third-party wallet proof checking.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
privacy or spend-authorization protocol
AI analysis · Moderate 65/100

This Monero patch fixes a RingCT amount-decoding function that previously ignored extra bytes beyond the first 8 in a 32-byte amount field. A pre-v10 'long amount' transaction could hide non-zero padding after the real amount. The receiver's wallet would fail to decode it, but a third-party wallet checking a proof might accept it, creating a mismatch between what the sender proves and what the recipient can actually spend. The change makes the decoder reject such malformed amounts.