Monero

This small patch changes how a Monero peer-to-peer network connection decides whether to proceed with closing. Previously, if the connection was not in the 'RUNNING' state, close() simply returned false and did nothing. Now it returns true (success) if the connection is already in a terminal state (TERMINATED or WASTED), and only returns false if the caller does not want to wait for shutdown and the connection is not running. The change makes connection cleanup more predictable and prevents callers from thinking a close failed when the connection was already dead. There is no direct evidence in the commit that this fixes an exploitable security vulnerability, but it removes a logic path that could leave connections in an inconsistent state.

This commit fixes a test-only data-directory path so that certain internal test modes once again store their temporary blockchain data in a separate 'fake' folder rather than potentially mixing with the main config folder. It does not change live mainnet/regtest node behavior and appears to be a regression fix for unit-test isolation.

This commit removes a function called save_limit_to_file and the calls to it. The function body was already empty (it did nothing), so this is a dead-code cleanup with no functional change to the program. There is no security issue visible in the diff.

This change moves a duplicate-transaction check so it only runs after the peer connection is in a normal, ready state. Before, a peer could send transaction data during protocol setup, and the node would parse and validate those transactions before confirming the connection was properly established. The patch prevents unnecessary processing of potentially malformed or duplicate transaction blobs during handshake phases.

This commit is a routine cleanup that removes unused variables and adds one safety check. It fixes compiler warnings about variables being assigned but never read. The only functional change is a new error throw if a reserve proof signature fails to parse, which makes the wallet fail more cleanly instead of continuing with bad data. There is no indication this fixes an active security vulnerability.

This commit adds a safety check in Monero's wallet code when creating or verifying a 'spend proof'—a cryptographic receipt that proves you spent funds in a specific transaction. Previously, the wallet asked the daemon (network node) for a transaction by ID but did not verify that the returned transaction actually matched the requested ID. The fix throws an error if the daemon returns a different transaction than the one the wallet asked for. This could prevent a malicious or buggy daemon from tricking the wallet into generating or accepting a proof for the wrong transaction.

This commit only fixes compiler warnings by adding the word 'void' inside empty parentheses of three C function definitions. In C, empty parentheses mean something slightly different than '(void)', so modern compilers warn about it. This is a code-quality cleanup with no security effect.

This commit updates Monero's built-in blockchain checkpoints to match the v0.18.5.0 release. Checkpoints are hardcoded trusted block hashes that help nodes quickly verify they are following the correct chain and protect against certain attacks. The change is routine release housekeeping: it advances the latest checkpoint from block 3,609,000 to block 3,661,900, updates the binary checkpoint data file, refreshes the expected hash of that file, and updates the README's recommended version table. There is no code logic change and no indication of a security vulnerability being fixed.

This commit hardens how Monero's serialization code reserves memory when unpacking data from untrusted network or storage inputs. Before, a maliciously crafted message could claim an enormous number of elements and trick the software into reserving a huge chunk of RAM, enabling memory exhaustion (denial of service). The patch now caps the reserved memory based on how many bytes are actually left in the input buffer and the largest plausible compression ratio for the element type, so a small blob cannot trigger a giant allocation.

This commit changes how the Monero wallet validates hidden transaction amounts in two places: when checking a transaction key and when verifying a reserve proof. It replaces custom code that manually decoded encrypted amounts with a shared helper function called decodeRct. The stated goal is consistency and using the standard decoding path. The change removes several manual safety checks (for example, checks that the encrypted mask and amount values are valid curve scalars) and no longer verifies that the decoded amount matches the transaction's public commitment. That could, in theory, allow a maliciously crafted proof or transaction to make the wallet accept an incorrect amount, though the practical exploit path is unclear without more context.

This change adds a friendly yellow warning in Monero's command-line wallet when a user tries to mine with more threads than their CPU actually has. It does not change any security behavior, permissions, or network logic; it only gives performance advice to the user.

This commit removes about 80 lines of CMake build configuration that automatically selected special ARM processor floating-point and CPU bug-workaround compiler flags. Without these flags, Monero may build differently (or fail to build/run correctly) on some ARM devices, but the change itself is a build-system cleanup, not a direct code vulnerability. The removed code included workarounds for known ARM Cortex-A53 CPU errata (hardware bugs 835769 and 843419). Dropping those workarounds could, in theory, allow rare hardware-triggered misbehavior on affected ARMv8 chips, but only if the compiler/toolchain no longer applies equivalent fixes by default.

This commit removes the miniupnp library and all UPnP port-forwarding support from the Monero daemon. UPnP is a protocol that lets programs automatically open ports on home routers, but it has a long history of security bugs and can expose services to the internet unexpectedly. The change keeps the --igd command-line option for backward compatibility but makes it non-functional, and removes the --no-igd option because it is no longer needed. This is a defensive hardening change rather than a fix for a specific known Monero vulnerability.

This Monero wallet code change removes an old way of receiving transaction data from the daemon (the network-facing full node) and switches to a newer, more structured format. It also adds a check to prevent a subtraction underflow when calculating how many blockchain confirmations a transaction has. The underflow could have caused incorrect confirmation counts, but the code throws an exception rather than silently misbehaving, so the practical security impact appears limited.

This is a one-character typo fix in a Fish shell auto-completion helper file. The completion script for monero-wallet-rpc accidentally listed one command-line option under the wrong program name (monero-wallet-cli instead of monero-wallet-rpc). It does not change any actual wallet or daemon code, and cannot affect security.