Monero

This patch fixes a threading bug in Monero's peer-discovery code. The old code launched background threads that wrote into a local variable (`dns_results`) owned by the main function. If the main function finished or the variable went out of scope while a thread was still running, the thread would write to freed memory. That is undefined behavior and could crash the node or, in theory, be abused to corrupt memory. The fix moves the shared data into a heap-allocated structure kept alive with a smart pointer and protects it with a mutex, so threads can finish safely even if the main code no longer waits for them.

This commit changes how Monero's wallet reads cryptographic data from imported files. It replaces direct pointer casts with explicit memory copying (memcpy). This is a defensive coding fix that primarily addresses alignment and strict-aliasing issues, which can cause crashes or undefined behavior on some platforms. It is not a clear-cut remote exploit fix, but it removes a class of low-level memory-safety risks when loading wallet-related import data.

This is a one-line bug fix in Monero's embedded HTTP protocol handler. The code was accidentally passing the major HTTP version number twice to a parsing function, instead of passing both the major and minor version numbers. The fix makes the parser receive the correct minor version number. This is clearly a bug, but from the diff alone it is hard to tell whether it has any practical security consequence.

This change makes Monero's Ledger hardware wallet integration ask for the private view key only when it is first needed, rather than immediately when connecting. If the user refuses, the software no longer fails and can continue in a slower mode where the Ledger does more cryptographic work. The change also clears the cached view key from memory when disconnecting. It is a usability improvement, not a fix for an active security flaw.

This commit fixes a bug where Monero's transaction creation code did not check whether a hardware wallet device successfully generated the one-time public key and view tag for a transaction output. If the hardware device call failed, the code would continue using uninitialized cryptographic values, which could lead to creating an invalid or insecure transaction. The fix adds an explicit error check that aborts transaction creation if the key generation fails.

This commit is a defensive code cleanup in Monero's transaction verification system. It restructures how a temporary list of extra block transactions (the 'pool supplement') is handled so that callers cannot accidentally forget to mark the list as unverified when adding new transactions. Before, outside code directly inserted transactions and separately reset a verification flag, which created a risk that someone could add a transaction without resetting the flag and potentially use a stale 'already verified' status. Now, adding or clearing transactions automatically resets the flag, and only the dedicated verification function can set it to a valid version. There is no direct evidence in the commit of an actual exploit or bug being fixed, but the change removes a fragile pattern that could lead to consensus or security issues.

This commit fixes a bug in Monero's blockchain code where a node could accidentally report the wrong block size (weight) to a peer. The bug happened because the code used a mismatched index when some requested blocks were missing. A peer receiving the wrong weight might ban the node, hurting network connectivity. The fix also removes an unnecessary database lookup.

This commit fixes a bug in Monero's wallet RPC server where editing an address book entry could accidentally drop or mishandle the payment ID associated with an integrated address. The fix ensures the payment ID flag is preserved correctly, and new tests check that converting between integrated and standard addresses works as expected. In practical terms, this could have caused users to send funds without the intended payment identifier, making transactions harder to track or reconcile.

This commit removes source-code file names and line numbers from Monero's translation files. It is a routine cleanup to make translation updates smaller and less noisy. There is no change to program logic, no bug fix, and no security improvement or regression.

This commit fixes a use-after-free bug in Monero's transaction pool (tx_pool). The code was storing a reference to a transaction ID, then deleting the underlying data structure that held that ID, and later still using the now-stale reference. The fix simply copies the ID value instead of holding a reference, so it remains valid after deletion. This is a memory-safety bug that could cause crashes or, in the worst case, be exploited to manipulate transaction processing, though the commit itself does not describe any exploit.

This commit adds a new --wallet-dir command-line option to the Monero command-line wallet (monero-wallet-cli). It lets users specify a single directory where wallet files should be looked for and saved. The change is a convenience/usability feature and does not appear to fix a security bug or introduce a dangerous capability. The code only accepts absolute paths for the directory and ignores the option if an absolute wallet-file path is given, which reduces the chance of tricking the wallet into writing files somewhere unexpected.

This change makes Monero's network address handling for Tor and I2P more consistent by converting hostnames to lowercase when they are read from stored or received data. Before this fix, an address like 'EXAMPLE.onion' written in capital letters would be treated differently from 'example.onion', which could cause mismatches, failed connections, or possibly bypass security checks that rely on exact string comparison. The patch adds a normalization step during deserialization and includes tests to confirm it works.

This commit fixes a bug in Monero's wallet RPC server where the rescan_blockchain command was not passing through a new keep_key_images option. A hard rescan normally destroys key images (the proof that a coin has already been spent), so the patch also blocks the contradictory combination of a hard rescan while trying to preserve key images. The change is mostly a missing-parameter fix, but mishandling key images could in theory affect wallet balance accuracy or spendability.

This commit changes Monero's CI testing workflow to optionally reduce the number of slow-hash iterations during automated pull-request tests, so the tests run faster. It does not change the real Monero mining or transaction verification code used by ordinary nodes or wallets. The production default of about 1 million iterations stays the same unless someone explicitly compiles with a special override flag. The main risk is accidental: if a binary were built with the reduced iteration count and used in production, the proof-of-work would be much weaker. But the commit only applies the override inside GitHub's test runners for pull requests.

This commit updates the Fish shell auto-completion scripts for Monero command-line tools. It changes the suggested file extensions for SSL private keys and certificates from .pem to .key and .crt respectively. This is a cosmetic/usability improvement for tab-completion only and does not change how the actual software handles SSL files or introduce any security vulnerability.

This commit is a routine code cleanup: it removes a duplicate copy of a helper function that converts a number of seconds into a human-readable phrase like '5 minutes' or '2 days', and makes the wallet use a shared version already present elsewhere. There is no change to security-sensitive logic, no bug fix, and no vulnerability.