LD
← All projectsLedger

Ledger Bitcoin app

Open-source Bitcoin application running on Ledger devices; the device OS is outside this repository.

BitcoinHardware walletsNormal
Repository coverage

447 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

148security candidates154second-pass queue402AI analyses
19commits · 30 days
63commits · 60 days
249commits · 180 days
414commits · 365 days
Backfill bands
Aug 5 → Feb 670 seen8 candidatesComplete
Feb 6 → Jun 6149 seen21 candidatesComplete
Jun 6 → Jul 623 seen0 candidatesComplete
Jul 6 → Aug 555 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

57/100 average clarity
50Strong · 80–100
152Adequate · 60–79
186Thin · 40–59
59Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Salvatore Ingala2981122561062
Ilya Artemov962696145
Ruben Waterman666083
Aymeric Robert434063
github-actions[bot]17117046
Mathias BROUSSET17015039
José Luis Landabaso Díaz404067
iartemov-ledger201051
Cerberus Merlin101062
Michael Evans101073
Charles-Edouard de la Vergne101045
Analysis record

Published AI watches

Last scanned 48 minutes ago

Informational 20 AI analysisMessage 83 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

tests: pin all Python test dependencies to exact versions

This commit pins the exact versions of Python testing tools used by the project's automated tests. Previously, the test setup allowed any newly released version of those tools to be installed automatically, which could introduce unexpected…

Supply-chain risk reduction for test/CI dependenciesPrevents unreviewed automatic upgrades of speculos and raggerNo change to firmware or published package code
def417a3by Salvatore Ingala+329−142 files
No security note in commit
Informational 15 AI analysisMessage 38 · Opaque
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Bump version to 2.6.0

This commit is a routine version bump from 2.5.1 to 2.6.0 in the Ledger Bitcoin app. It only updates the version number in the Makefile and the release date in the CHANGELOG. There are no code changes, no bug fixes, and no security-related…

2b424b54by Salvatore Ingala+4−42 files
No security note in commit
Moderate 66 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #581 from LedgerHQ/client-fixes

This commit tightens how the Ledger Bitcoin app and its companion client libraries read PSBT (Partially Signed Bitcoin Transaction) data. It adds checks that reject malformed or suspicious PSBTs: truncated fields, unexpected extra bytes af…

Hardened PSBT deserialization against truncation and trailing dataAdded duplicate-key detection in PSBT mapsRejected PSBTv2-only fields inside PSBTv0 to prevent locktime/field override attacks
f8f790a3by Salvatore Ingala+544−17018 files
No security note in commit
Low 47 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

python client: reject PSBTv2-only fields in a PSBTv0

This commit tightens input validation in the Python helper library that prepares Bitcoin transaction data for Ledger hardware wallets. It now rejects PSBT files that claim to be the older version 0 format but contain fields that only belon…

Input-validation hardening: stricter parsing of PSBT version 0 to reject v2-only key typesConsistency fix across clients: aligns Python client with HS and Rust client behaviorLocktime normalization during v0-to-v2 conversion to prevent per-input locktime from overriding transaction locktime
84165be7by Salvatore Ingala+92−02 files
No security note in commit
Informational 24 AI analysisMessage 83 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

tests: update authproxy.py to the latest version from Bitcoin Core

This commit updates a test helper file used to talk to a Bitcoin node during automated testing. The old helper could accidentally send the same command twice if the network connection hiccuped, which could cause a test-only action like sen…

Removed transparent retry of non-idempotent RPC requests after connection resetsTest helper could execute state-changing RPCs twice before the fixNew connection-per-call configuration mitigates idle-timeout disconnects without retry risk
c7ca508eby Salvatore Ingala+91−522 files
Vendor flagged security relevance
Low 40 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject duplicate keys and trailing data when parsing a PSBT in the JS client

This commit fixes the JavaScript PSBT (Partially Signed Bitcoin Transaction) parser in Ledger's Bitcoin app so it now rejects malformed PSBTs that contain duplicate keys or extra trailing bytes. Previously, such malformed data could be acc…

BIP-174 non-compliance: duplicate keys and trailing data were previously acceptedState reuse bug: deserializing multiple PSBTs in the same instance could merge mapsInput validation gap in client-side PSBT parsing
4942a4aeby Salvatore Ingala+40−02 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

ragger: fail if a request succeeds without showing the expected screens

This commit fixes the automated test harness, not the Ledger Bitcoin app itself. Previously, the test framework could silently pass even when the device completed a request without showing the expected on-screen review. The change makes te…

Test-hardening only: no firmware or runtime application code changedFixes false-negative test results where a request could succeed without expected UI reviewCorrects scope of navigation settings to avoid leaking across nested or subsequent calls
202d352aby Salvatore Ingala+76−957 files
No security note in commit
Low 37 AI analysisMessage 88 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

unit tests: Fix length overflow in unit-test PSBT parser

This commit fixes an arithmetic overflow bug in a test-only PSBT (Bitcoin transaction format) parser used in unit tests. The bug could let a crafted test input make the parser think a data length is huge, potentially confusing the mock dis…

Integer overflow/wrap-around in length calculationOut-of-bounds length derived from arithmetic on attacker-influenced offsetsUnit-test-only code path, not device firmware
6a2a9262by Salvatore Ingala+6−21 file
No security note in commit
Low 48 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

rust client: reject PSBTv2-only fields when converting a PSBTv0

This commit fixes a bug in the Ledger Bitcoin app's Rust client where a PSBT v0 (an older transaction format) could silently carry fields that only have meaning in PSBT v2. When converting v0 to v2, those fields could override values taken…

Input validation added for cross-format PSBT conversionPrevents v2-only fields from overriding unsigned-transaction-derived valuesBIP-370 compliance enforcement for PSBTv0
602055d6by Salvatore Ingala+66−91 file
No security note in commit
Moderate 51 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject PSBTv2-only fields when converting a PSBTv0 in the JS client

This commit fixes a bug in the Ledger Bitcoin app's JavaScript client library. When converting an older-style Bitcoin transaction file (PSBT version 0) into the newer PSBT version 2 format, the library previously ignored fields that are on…

Input validation fix: rejects malformed PSBTv0 containing v2-only fieldsPrevents silent override of transaction locktime during PSBTv0-to-v2 conversionAdds missing BIP-370 key type constants for required time/height locktime
a1f6dc84by Salvatore Ingala+66−22 files
No security note in commit
High 72 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject duplicate keys and truncated maps when parsing PSBT maps in sign_psbt

This commit fixes a bug in how the Ledger Bitcoin app client parses PSBT (Partially Signed Bitcoin Transaction) maps. Previously, if the same key appeared twice in a map, the parser silently kept the last value. A malicious or malformed PS…

Silent overwrite of duplicate PSBT map keys could create commitment mismatch between client and deviceTruncated PSBT maps were silently accepted due to exception swallowing in deserialization loopsTrailing data after PSBT maps was ignored, allowing reserialization to silently normalize malformed inputs
75df80f9by Salvatore Ingala+107−104 files
Vendor flagged security relevance
High 72 AI analysisMessage 53 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #579 from LedgerHQ/misc-fixes

This commit fixes several bugs in Ledger's Bitcoin app. The most serious ones are: (1) a set of miniscript policy analyzer mistakes that could let the app accept Bitcoin wallet policies whose scripts are too large or too expensive to execu…

Miniscript cost/property analysis errors that could allow oversized/undercosted wallet policiesHost-driven infinite-loop / denial-of-service via zero-length GET_MORE_ELEMENTS responsesUI state inconsistency causing a security warning to be prematurely dismissed
ec389348by Salvatore Ingala+413−3113 files
No security note in commit
Low 26 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #576 from LedgerHQ/musig2_improvements

This commit improves the Ledger Bitcoin app's MuSig2 multi-signature feature. It lets wallet software pre-generate public nonces before a transaction is known, adds an optional MUSIG2_SESSION_ID field so multiple signing sessions can be in…

New PSBT proprietary field parsing with length validation (1-32 bytes, empty rejected)Session ID now commits to wallet policy plus optional MUSIG2_SESSION_IDSession storage limit raised from 8 to 32 with LRU eviction
26d22adcby Salvatore Ingala+710−7216 files
No security note in commit
Informational 18 AI analysisMessage 85 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Use signed scratch arrays in the thresh ops and stack size computations

This commit is a small code cleanup in Ledger's Bitcoin app. It changes two local arrays from unsigned (uint16_t) to signed (int16_t) in functions that count operations and stack sizes for Bitcoin miniscript 'thresh' policies. The commit m…

Signed/unsigned type mismatch in sentinel handlingPotential latent integer interpretation bug in miniscript threshold policy analysisCode clarity improvement around invalid (dis)satisfaction markers
4ff6f2f0by Salvatore Ingala+4−41 file
No security note in commit
Low 48 AI analysisMessage 91 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Align miniscript type and ops computations with bitcoin-core

This commit fixes the Ledger Bitcoin app's internal checker for Miniscript wallet policies. The checker was incorrectly rejecting some valid Bitcoin spending policies as unsafe, and in a few places it was computing safety properties using …

Logic change in Miniscript policy analysisAlignment with upstream Bitcoin Core reference implementationRelaxation of overly strict non-malleability and timelock-mixing checks
4694d317by Salvatore Ingala+26−132 files
No security note in commit
Moderate 68 AI analysisMessage 86 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix ops computation for andor fragments

This commit fixes a bug in how the Ledger Bitcoin app counts the number of Bitcoin script operations (ops) needed to spend certain wallet policies that use a 'miniscript andor' fragment. Because the count was wrong, the app could allow use…

Incorrect miniscript ops accounting for andor fragmentPolicy sanity check bypass leading to unspendable registered walletsReference alignment with Bitcoin Core implementation
86159d1eby Salvatore Ingala+40−13 files
Vendor flagged security relevance
High 74 AI analysisMessage 78 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix ops computation for l: and u: fragments

This commit fixes a bug in how the Ledger Bitcoin app counts Bitcoin script operations ('ops') for two specific Miniscript fragments, 'l:' and 'u:'. Because the count was too low, the app could accept wallet policies that look valid but ar…

Undercounting of script operation budget leading to acceptance of unspendable policiesIncorrect handling of Miniscript wrapper dissatisfaction semanticsPolicy sanity check bypass via operation-count accounting flaw
b6ac1de8by Salvatore Ingala+39−33 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

doc: document the MUSIG2_SESSION_ID PSBT field

This commit only updates documentation and the changelog. It explains a new optional PSBT field called MUSIG2_SESSION_ID that lets software wallets manage multiple MuSig2 signing sessions for the same wallet policy on a Ledger device. Ther…

8d8ed9afby Salvatore Ingala+28−62 files
No security note in commit
Informational 15 AI analysisMessage 78 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

musig_sessions: store up to 32 sessions

This commit is a simple capacity increase, not a security fix. It raises the number of simultaneous MuSig2 signing sessions the Ledger Bitcoin app can keep in memory from 8 to 32, because users with multiple MuSig accounts or wallets that …

a6798172by Salvatore Ingala+12−54 files
No security note in commit
Low 26 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

sign_psbt: fail before the UI if the MuSig2 session is missing

This commit improves the user experience and error handling for Ledger's Bitcoin app when using MuSig2 multi-signatures. Previously, if a required MuSig2 session was missing during the second round of signing, the device would only report …

UX-hardening: fail-fast before user approval instead of afterNew specific error code EC_SIGN_PSBT_MUSIG2_SESSION_NOT_FOUND for missing MuSig2 sessionsRefactored session storage lookup to support non-destructive existence check
2d04b144by Salvatore Ingala+118−187 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedAdd testcase for registering a policy with too high confusion scoreby Salvatore Ingala · 20963719 · Jul 17, 2026 · 1 fileMessage 83 · StrongInformational 15Details
Commit message · Salvatore Ingala

Add testcase for registering a policy with too high confusion score

The test verifies that register_wallet still succeeds, but showing
the raw descriptor template (fallback to usual behavior) rather
than the cleartext version.

Also, slightly refactored the shared code across unit tests.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds a new unit test and refactors shared test helper code. It does not change the actual Ledger Bitcoin app firmware behavior. The new test verifies that when a wallet policy is too confusing to display safely, the app falls back to showing the raw technical descriptor instead of a user-friendly version. This is a defensive test for an existing safety mechanism, not a fix for a vulnerability.

AI review queuedAdd testcases with snapshots for multisig k-of-n and several taproot leavesby Salvatore Ingala · fd75dadd · Jul 17, 2026 · 108 filesMessage 50 · ThinInformational 15Details
Commit message · Salvatore Ingala

Add testcases with snapshots for multisig k-of-n and several taproot leaves

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds new test cases and screen snapshots for the Ledger Bitcoin app. It exercises two wallet-registration scenarios: a 2-of-3 multisig wallet and a Taproot wallet with multiple spending paths. There are no changes to the app's actual code, so this cannot introduce a security vulnerability or fix one in the shipped firmware.

AI review queuedShow cleartext representation of wallet policy, when possibleby Salvatore Ingala · f883a913 · Jul 17, 2026 · 7 filesMessage 83 · StrongInformational 22Details
Commit message · Salvatore Ingala

Show cleartext representation of wallet policy, when possible

Wires the cleartext engine into the register-wallet flow: the handler
computes the confusion score and, when below the threshold, renders the
cleartext spending-path lines shown before the raw descriptor template.

For multisig wallet policies specifically, this also simplifies the UX by
omitting the raw descriptor template altogether. This is safe for such
simple policies, with very little ambiguity. In the long term, we might be
able to extend this to more complex wallet policies, but that needs to be
done intentionally, and possibly be an opt-in feature that is explicitly
requested by software wallets that adapt their own UX accordingly.

Unit tests of register_wallet had to be adapted slightly to take into
account that the descriptor is not always shown.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 22/100

This commit changes how Ledger devices display Bitcoin wallet policies during setup. Instead of always showing the raw technical descriptor, it tries to show a human-readable summary ("cleartext") of the spending rules. For simple multisig wallets, it hides the raw descriptor entirely because the plain-English summary is considered unambiguous. This is a UX improvement, not a fix for a known vulnerability, but it touches security-critical user confirmation code.

AI review queuedapp-bitcoin-new rename to app-bitcoinby Ilya Artemov · 3975774b · Jul 7, 2026 · 17 filesMessage 45 · ThinInformational 15Details
Commit message · Ilya Artemov

app-bitcoin-new rename to app-bitcoin

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a simple project rename from 'app-bitcoin-new' to 'app-bitcoin'. It only updates URLs, repository references, and documentation strings across 17 files. There are no code logic changes, no security fixes, and no behavior changes.

AI review queueddocs: Add user documentationby Salvatore Ingala · f32a3610 · Jun 24, 2026 · 4 filesMessage 87 · StrongInformational 15Details
Commit message · Salvatore Ingala

docs: Add user documentation

Existing documentation is rather detailed on the wire protocol, but
lacks a higher level technical overview of the features and
operating principles of the app.

This commit adds two new high-level guides for technical readers
that are not interested in the details of the wire protocol:

- features.md: high-level overview of the app's features
- integration.md: integration concepts and security model

Also, wallet.md was trimmed to avoid repeating what is in BIP-388.

87/100 · StrongMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Names security-relevant behavior explicitly
Why it was queued
signing or wallet pathdocumentation-only discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds and reorganizes user and developer documentation. No program code, build scripts, tests, or cryptographic logic were changed. It is not a security patch and does not introduce or fix any vulnerability.

AI review queuedSIGHASH gating: status screen on disabled rejectionby Ilya Artemov · 0e35a24d · Jun 23, 2026 · 4 filesMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

SIGHASH gating: status screen on disabled rejection

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a user-experience improvement, not a security fix. When a Bitcoin transaction uses a non-standard sighash and the user has not enabled the 'Allow non-standard sighash' setting, the app already rejected the transaction. Now it also shows an on-screen message explaining why it was rejected, so the user is not left confused.

AI review queuedSIGHASH gating: update Ragger snapshotsby github-actions[bot] · 84e9bc7c · Jun 23, 2026 · 177 filesMessage 45 · ThinInformational 15Details
Commit message · github-actions[bot]

SIGHASH gating: update Ragger snapshots

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 15/100

This commit only updates test screenshot snapshots for the Ledger Bitcoin app. It does not change any application code, so it cannot directly fix or introduce a security vulnerability. The snapshots show what the device screen looks like during tests of a new 'SIGHASH gating' feature, but the actual security behavior is implemented elsewhere.

AI review queuedSIGHASH gating: tests_mainnetby Ilya Artemov · b67c7982 · Jun 23, 2026 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · Ilya Artemov

SIGHASH gating: tests_mainnet

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates a test script that navigates the Ledger device's on-screen dashboard. It adds extra button presses to account for a new 'App settings' menu item that appears before 'App info'. There is no change to the actual Bitcoin app code, cryptographic logic, or transaction signing behavior, so this commit does not introduce or fix a security issue by itself.

AI review queuedSIGHASH gating: functional testsby Ilya Artemov · cb60be9a · Jun 23, 2026 · 3 filesMessage 45 · ThinInformational 15Details
Commit message · Ilya Artemov

SIGHASH gating: functional tests

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds automated functional tests for a new device setting that controls whether non-standard Bitcoin signature hash (sighash) types are allowed. It does not change the app code that runs on the Ledger device, so it cannot introduce a security vulnerability by itself. The tests verify that dangerous sighash types are blocked by default and require the user to explicitly enable a setting to allow them.

AI review queuedSIGHASH gating: implementationby Ilya Artemov · 296bed60 · Jun 23, 2026 · 6 filesMessage 35 · OpaqueLow 48Details
Commit message · Ilya Artemov

SIGHASH gating: implementation

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Low 48/100

This commit adds a user-controlled setting to the Ledger Bitcoin app that blocks non-standard Bitcoin transaction signing modes by default. Previously, these modes were allowed with only a warning. Now the app rejects them unless the user explicitly turns on 'Allow non-standard sighash' in settings and confirms a warning. This is a security-hardening change, not a vulnerability fix in the traditional sense, but it reduces the risk of users accidentally signing transactions that protect fewer funds than they expect.

AI review queuedRemove bad include directive with CFLAGSby Charles-Edouard de la Vergne · 704b361a · Jun 16, 2026 · 2 filesMessage 45 · ThinInformational 17Details
Commit message · Charles-Edouard de la Vergne

Remove bad include directive with CFLAGS

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 17/100

This commit removes a leftover debugging include from the build and adds a missing standard header to one source file. It is a cleanup/fix for build hygiene, not a security patch for an exploitable vulnerability. There is no evidence in the commit or supplied references that this fixes a security issue.

AI review queuedValidate key classification in register_wallet unit testsby Salvatore Ingala · 5cefe555 · Jun 16, 2026 · 3 filesMessage 83 · StrongInformational 12Details
Commit message · Salvatore Ingala

Validate key classification in register_wallet unit tests

By recording what the UI mock receives, we verify that the
handler correctly classifies the key expressions as internal,
external or unspendable.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit only adds and improves unit tests for the Ledger Bitcoin app. It records what the user-interface confirmation function receives during wallet registration tests, then checks that the app correctly labels each key as internal (ours), external (someone else's), or unspendable. It also adds a new test case for a fingerprint-collision scenario. There is no change to the actual app code that runs on the device, so this is a testing/quality improvement rather than a security fix.

AI review queuedUnit tests for get_extended_pubkeyby Salvatore Ingala · 88fa41c7 · Jun 16, 2026 · 4 filesMessage 68 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Unit tests for get_extended_pubkey

Refactored the handler_get_extended_pubkey to move the actual
logic (after APDU parsing) into a separate function
get_extended_pubkey_response, which get be tested directly based
on the test vectors.

Rafactored some common TOML utilities into toml_helpers.h.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidencesigning or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds and reorganizes unit tests for the get_extended_pubkey feature. It does not change the actual app code that runs on the Ledger device, so it cannot introduce a security vulnerability or fix one in shipped software.

AI review queuedExtract test assets into TOML filesby Salvatore Ingala · 04cdef8b · Jun 16, 2026 · 8 filesMessage 55 · ThinInformational 15Details
Commit message · Salvatore Ingala

Extract test assets into TOML files

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a test-only refactoring change. It moves existing test data from a private unit-test file into shared TOML files in a new test_vectors/ directory so the same test cases can be reused by Python, C, and future Rust test suites. No application code that runs on the Ledger device was changed, and no security behavior of the app was modified.

AI review queuedNit from PR reviewby Salvatore Ingala · 795a0445 · Jun 16, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Nit from PR review

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only removes periods at the end of sentences in a test documentation file (test_vectors/README.md). It is a cosmetic formatting change with no effect on code, security, or functionality.

AI review queuedUnit tests for sign_messageby Salvatore Ingala · b4727094 · Jun 16, 2026 · 2 filesMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Unit tests for sign_message

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds new unit tests for the existing sign_message feature in Ledger's Bitcoin app. It does not change the actual signing code that runs on the device, so it cannot introduce a security vulnerability or fix one by itself. The tests exercise the handler with known test vectors and mock UI approval, and include one extra test for an over-long message length.

AI review queuedUpdate sign_message test vectorsby Salvatore Ingala · 867f69c8 · Jun 16, 2026 · 2 filesMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Update sign_message test vectors

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
fuzzing or regression evidencesigning or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates test data and documentation for the Bitcoin app's message-signing feature. It documents how the device displays messages (full text versus a hash) and adds matching test expectations. There is no code change and no security fix or vulnerability present in the diff.

AI review queuedAdd unit tests for register_walletby Salvatore Ingala · 0a99cb8e · Jun 16, 2026 · 2 filesMessage 55 · ThinInformational 15Details
Commit message · Salvatore Ingala

Add unit tests for register_wallet

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds new automated unit tests for the wallet-registration feature of the Ledger Bitcoin app. It does not change any production code, fix bugs, or alter app behavior. There is no security issue here.

AI review queuedenable stack protectorby Mathias BROUSSET · 257e9766 · Jun 12, 2026 · 2 filesMessage 28 · OpaqueLow 35Details
Commit message · Mathias BROUSSET

enable stack protector

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 35/100

This commit turns on a safety feature called the 'stack protector' in the Ledger Bitcoin app's build settings. The stack protector is a compiler guard that helps detect and block certain types of low-level memory attacks (stack buffer overflows) before they can take control of the device. The change itself is a hardening improvement, not a fix for a specific reported bug. It makes future exploitation of stack overflow flaws harder, but it does not remove any underlying vulnerability by itself.

AI review queuedApply clang-21 fixesby Salvatore Ingala · 87fa76f3 · Jun 8, 2026 · 17 filesMessage 28 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Apply clang-21 fixes

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is purely a code-style and formatting update to make the project compile cleanly with the newer clang-21 compiler. It adds or removes spaces inside braces (for example, changing `{0, -1, 0}` to `{ 0, -1, 0 }`) and re-wraps a few long function signatures so they fit on multiple lines. No program logic, security checks, or behavior were changed.

AI review queuedFix and simplify HAVE_SEMIHOSTED_PRINTFby Salvatore Ingala · cdc959d1 · Jun 3, 2026 · 2 filesMessage 35 · OpaqueInformational 18Details
Commit message · Salvatore Ingala

Fix and simplify HAVE_SEMIHOSTED_PRINTF

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 18/100

This commit cleans up how a special debug-only printing mode is enabled in the Ledger Bitcoin app. It only affects builds where DEBUG=10 is set, which is intended for use in the Speculos emulator and not on real hardware. The change moves a macro redefinition from the Makefile into a header file and removes an unused HAVE_PRINTF flag. There is no direct security vulnerability visible in the diff, but it touches debug infrastructure that could historically be misused if left enabled in production firmware.

AI review queuedAdd missing includeby Salvatore Ingala · 725fd66a · Jun 3, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Add missing include

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This is a one-line change adding a missing standard C header file (#include <string.h>) to a header file used for the MuSig multi-signature protocol. On its own, the change does not alter program behavior or fix a security flaw; it simply ensures the compiler has access to string-related standard definitions wherever this header is included. It may be a companion to a larger fix, but the diff itself contains no security-relevant logic.

AI review queuedDelete stale _zero_outputs_mutator; reduced code duplicationby Salvatore Ingala · db4d4c7b · Jun 1, 2026 · 3 filesMessage 50 · ThinInformational 15Details
Commit message · Salvatore Ingala

Delete stale _zero_outputs_mutator; reduced code duplication

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a routine code cleanup. It removes an unused test helper that set Bitcoin output amounts to zero, and consolidates duplicate placeholder-parsing code into a shared utility module. There is no indication it fixes or introduces a security vulnerability.

AI review queuedAdd address generation unit-testsby Salvatore Ingala · e1415280 · May 29, 2026 · 4 filesMessage 55 · ThinInformational 15Details
Commit message · Salvatore Ingala

Add address generation unit-tests

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds new unit tests and test-support code for Bitcoin address generation. It does not change the app that runs on the Ledger device, nor does it fix or introduce any security-relevant behavior. It is a testing/infrastructure change with no direct security impact.

AI review queuedImprove docs of get_merkle_preimage.h; remove stale TODOby Salvatore Ingala · 957eb8cd · May 19, 2026 · 2 filesMessage 30 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Improve docs of get_merkle_preimage.h; remove stale TODO

30/100 · OpaqueMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body! Contains work-in-progress language
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates comments and removes a stale TODO marker. No executable code, logic, or security behavior changed.