Remove bad include directive with CFLAGS
What the developer wrote
Authored by Charles-Edouard de la Vergne
Remove bad include directive with CFLAGS
What changed, and why it matters
This commit removes a leftover debugging include from the build and adds a missing standard header to one source file. It is a cleanup/fix for build hygiene, not a security patch for an exploitable vulnerability. There is no evidence in the commit or supplied references that this fixes a security issue.
No security action required; treat as routine build/maintenance cleanup.
Security signals we found
No security-relevant signal in diff
Build hygiene cleanup only
Missing standard header fixed
Evidence from the diff
The Makefile change removes CFLAGS += -include debug-helpers/debug.h, which forced inclusion of a debug helper header globally. The header change adds #include <stdbool.h> to src/swap/handle_swap_sign_transaction.h so the bool type used in the function signature is properly declared. These are build correctness and header hygiene fixes.
Changed components
Makefile build flagssrc/swap/handle_swap_sign_transaction.hInspect captured patch +2 / −3
diff --git a/Makefile b/Makefile
index 6923dd9..d87e739 100644
--- a/Makefile
+++ b/Makefile
@@ -188,9 +188,6 @@ ifneq ($(AUTOAPPROVE_FOR_PERF_TESTS),0)
endif
endif
-# debugging helper functions and macros
-CFLAGS += -include debug-helpers/debug.h
-
# DEFINES += HAVE_PRINT_STACK_POINTER
ifeq ($(DEBUG),10)
diff --git a/src/swap/handle_swap_sign_transaction.h b/src/swap/handle_swap_sign_transaction.h
index 8e2a785..1ab99c0 100644
--- a/src/swap/handle_swap_sign_transaction.h
+++ b/src/swap/handle_swap_sign_transaction.h
@@ -2,6 +2,8 @@
#ifdef HAVE_SWAP
+#include <stdbool.h>
+
void __attribute__((noreturn)) finalize_exchange_sign_transaction(bool is_success);
#endif /* HAVE_SWAP */
Why this scored 17/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.