AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 48 Bitcoin

rust client: reject PSBTv2-only fields when converting a PSBTv0

Public commit record

What the developer wrote

Authored by Salvatore Ingala

73/100 · Adequate
rust client: reject PSBTv2-only fields when converting a PSBTv0

Reject all the global, input and output fields that BIP-370 excludes
from PSBTv0, whatever their keydata, before converting to PSBTv2.
This avoids accidentally overwriting the intended value from the
unsigned transaction.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit fixes a bug in the Ledger Bitcoin app's Rust client where a PSBT v0 (an older transaction format) could silently carry fields that only have meaning in PSBT v2. When converting v0 to v2, those fields could override values taken from the unsigned transaction, potentially changing transaction details such as locktime. The patch now rejects such fields before conversion.

Recommended action

Review whether any other v2-only key types are missing from the rejection lists, and ensure downstream consumers of the Rust client are updated to a version containing this fix. Consider adding tests for global and output v2-only field rejection as well.

Security signals we found

01

Input validation added for cross-format PSBT conversion

02

Prevents v2-only fields from overriding unsigned-transaction-derived values

03

BIP-370 compliance enforcement for PSBTv0

04

Test added for rejection of per-input required locktimes

Risk score

Why this scored 48/100

Our methodology →
Potential impact 12/30
Exploitability 10/25
Stealth signal 8/15
Affected reach 7/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.