app-bitcoin-new rename to app-bitcoin
What changed, and why it matters
This commit is a simple project rename from 'app-bitcoin-new' to 'app-bitcoin'. It only updates URLs, repository references, and documentation strings across 17 files. There are no code logic changes, no security fixes, and no behavior changes.
No security action required. This is a routine repository rename. Verify that downstream consumers update their git remote/package URLs as needed.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff consists entirely of string substitutions replacing ‘LedgerHQ/app-bitcoin-new’ with ‘LedgerHQ/app-bitcoin’ in README files, package metadata (setup.cfg, package.json, Cargo.toml), GitHub workflow configuration, error messages, and code comments. No executable logic, APDU protocol, cryptographic operations, or validation checks were modified.
Changed components
Repository naming and metadataClient library documentation and package metadataGitHub Actions workflow Docker image repository referenceError message strings pointing users to the bug trackerInspect captured patch +21 / −21
diff --git a/.github/workflows/builder-image-workflow.yml b/.github/workflows/builder-image-workflow.yml
index 49b6246..cd7964c 100644
--- a/.github/workflows/builder-image-workflow.yml
+++ b/.github/workflows/builder-image-workflow.yml
@@ -22,7 +22,7 @@ jobs:
uses: docker/build-push-action@v1
with:
dockerfile: .github/workflows/Dockerfile
- repository: ledgerhq/app-bitcoin-new/speculos-bitcoin
+ repository: ledgerhq/app-bitcoin/speculos-bitcoin
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
diff --git a/README.md b/README.md
index 18098c0..411c0ef 100644
--- a/README.md
+++ b/README.md
@@ -16,8 +16,8 @@ It will allow you, whether you are developing on macOS, Windows or Linux to quic
* On macOS, install and launch [XQuartz](https://www.xquartz.org/) (make sure to go to XQuartz > Preferences > Security and check "Allow client connections").
* On Windows, install and launch [VcXsrv](https://sourceforge.net/projects/vcxsrv/) (make sure to configure it to disable access control).
* Install [VScode](https://code.visualstudio.com/download) and add [Ledger's extension](https://marketplace.visualstudio.com/items?itemName=LedgerHQ.ledger-dev-tools).
-* Open a terminal and clone `app-bitcoin-new` with `git clone git@github.com:LedgerHQ/app-bitcoin-new.git`.
-* Open the `app-bitcoin-new` folder with VSCode.
+* Open a terminal and clone `app-bitcoin` with `git clone git@github.com:LedgerHQ/app-bitcoin.git`.
+* Open the `app-bitcoin` folder with VSCode.
* Use Ledger extension's sidebar menu or open the tasks menu with `ctrl + shift + b` (`command + shift + b` on a Mac) to conveniently execute actions :
* Build the app for the device model of your choice with `Build`.
* Test your binary on [Speculos](https://github.com/LedgerHQ/speculos) with `Run with Speculos`.
diff --git a/bitcoin_client/README.md b/bitcoin_client/README.md
index 3183a9a..fb2bfc3 100644
--- a/bitcoin_client/README.md
+++ b/bitcoin_client/README.md
@@ -4,7 +4,7 @@
Client library for Ledger Bitcoin application.
-Main repository and documentation: https://github.com/LedgerHQ/app-bitcoin-new
+Main repository and documentation: https://github.com/LedgerHQ/app-bitcoin
## Install
diff --git a/bitcoin_client/ledger_bitcoin/client.py b/bitcoin_client/ledger_bitcoin/client.py
index 16fa04a..4cf4ae1 100644
--- a/bitcoin_client/ledger_bitcoin/client.py
+++ b/bitcoin_client/ledger_bitcoin/client.py
@@ -226,7 +226,7 @@ class NewClient(Client):
first_addr_device = self.get_wallet_address(wallet, wallet_hmac, 0, 0, False)
if first_addr_device != self._derive_address_for_policy(wallet, False, 0):
- raise RuntimeError("Invalid address. Please update your Bitcoin app. If the problem persists, report a bug at https://github.com/LedgerHQ/app-bitcoin-new")
+ raise RuntimeError("Invalid address. Please update your Bitcoin app. If the problem persists, report a bug at https://github.com/LedgerHQ/app-bitcoin")
return wallet_id, wallet_hmac
@@ -267,7 +267,7 @@ class NewClient(Client):
# sanity check: for miniscripts, derive the address independently
if result != self._derive_address_for_policy(wallet, change, address_index):
- raise RuntimeError("Invalid address. Please update your Bitcoin app. If the problem persists, report a bug at https://github.com/LedgerHQ/app-bitcoin-new")
+ raise RuntimeError("Invalid address. Please update your Bitcoin app. If the problem persists, report a bug at https://github.com/LedgerHQ/app-bitcoin")
return result
diff --git a/bitcoin_client/setup.cfg b/bitcoin_client/setup.cfg
index 9d44335..252c656 100644
--- a/bitcoin_client/setup.cfg
+++ b/bitcoin_client/setup.cfg
@@ -6,9 +6,9 @@ author_email = hello@ledger.fr
description = Client for Ledger Nano Bitcoin application
long_description = file: README.md
long_description_content_type = text/markdown
-url = https://github.com/LedgerHQ/app-bitcoin-new
+url = https://github.com/LedgerHQ/app-bitcoin
project_urls =
- Bug Tracker = https://github.com/LedgerHQ/app-bitcoin-new/issues
+ Bug Tracker = https://github.com/LedgerHQ/app-bitcoin/issues
classifiers =
Programming Language :: Python :: 3
License :: OSI Approved :: Apache Software License
diff --git a/bitcoin_client_js/README.md b/bitcoin_client_js/README.md
index 6dad550..ee317bb 100644
--- a/bitcoin_client_js/README.md
+++ b/bitcoin_client_js/README.md
@@ -4,7 +4,7 @@
TypeScript client for Ledger Bitcoin application. Supports versions 2.1.0 and above of the app.
-Main repository and documentation: https://github.com/LedgerHQ/app-bitcoin-new
+Main repository and documentation: https://github.com/LedgerHQ/app-bitcoin
## Install
diff --git a/bitcoin_client_js/package.json b/bitcoin_client_js/package.json
index 08948b8..8107fd6 100644
--- a/bitcoin_client_js/package.json
+++ b/bitcoin_client_js/package.json
@@ -7,7 +7,7 @@
"typings": "build/main/index.d.ts",
"repository": {
"type": "git",
- "url": "git+https://github.com/LedgerHQ/app-bitcoin-new.git"
+ "url": "git+https://github.com/LedgerHQ/app-bitcoin.git"
},
"license": "Apache-2.0",
"keywords": [
diff --git a/bitcoin_client_js/src/lib/appClient.ts b/bitcoin_client_js/src/lib/appClient.ts
index 4e76011..b02b7d3 100644
--- a/bitcoin_client_js/src/lib/appClient.ts
+++ b/bitcoin_client_js/src/lib/appClient.ts
@@ -68,7 +68,7 @@ function makePartialSignature(pubkeyAugm: Buffer, signature: Buffer): PartialSig
/**
* This class encapsulates the APDU protocol documented at
- * https://github.com/LedgerHQ/app-bitcoin-new/blob/master/doc/bitcoin.md
+ * https://github.com/LedgerHQ/app-bitcoin/blob/master/doc/bitcoin.md
*/
export class AppClient {
readonly transport: Transport;
diff --git a/bitcoin_client_js/src/lib/merkelizedPsbt.ts b/bitcoin_client_js/src/lib/merkelizedPsbt.ts
index 05444fc..d805fac 100644
--- a/bitcoin_client_js/src/lib/merkelizedPsbt.ts
+++ b/bitcoin_client_js/src/lib/merkelizedPsbt.ts
@@ -10,7 +10,7 @@ import { PsbtV2 } from './psbtv2';
* so it can't always store the full psbt in memory.
*
* The signing process is documented at
- * https://github.com/LedgerHQ/app-bitcoin-new/blob/master/doc/bitcoin.md#sign_psbt
+ * https://github.com/LedgerHQ/app-bitcoin/blob/master/doc/bitcoin.md#sign_psbt
*/
export class MerkelizedPsbt extends PsbtV2 {
public readonly globalMerkleMap: MerkleMap;
diff --git a/bitcoin_client_js/src/lib/merkle.ts b/bitcoin_client_js/src/lib/merkle.ts
index 386289e..315e14e 100644
--- a/bitcoin_client_js/src/lib/merkle.ts
+++ b/bitcoin_client_js/src/lib/merkle.ts
@@ -7,7 +7,7 @@ function sha256AsBuffer(buf: Buffer): Buffer {
/**
* This class implements the merkle tree used by Ledger Bitcoin app v2+,
* which is documented at
- * https://github.com/LedgerHQ/app-bitcoin-new/blob/master/doc/merkle.md
+ * https://github.com/LedgerHQ/app-bitcoin/blob/master/doc/merkle.md
*/
export class Merkle {
private leaves: Buffer[];
diff --git a/bitcoin_client_js/src/lib/merkleMap.ts b/bitcoin_client_js/src/lib/merkleMap.ts
index 2f11060..6616df5 100644
--- a/bitcoin_client_js/src/lib/merkleMap.ts
+++ b/bitcoin_client_js/src/lib/merkleMap.ts
@@ -3,7 +3,7 @@ import { createVarint } from './varint';
/**
* This implements "Merkelized Maps", documented at
- * https://github.com/LedgerHQ/app-bitcoin-new/blob/master/doc/merkle.md#merkleized-maps
+ * https://github.com/LedgerHQ/app-bitcoin/blob/master/doc/merkle.md#merkleized-maps
*
* A merkelized map consist of two merkle trees, one for the keys of
* a map and one for the values of the same map, thus the two merkle
diff --git a/bitcoin_client_js/src/lib/policy.ts b/bitcoin_client_js/src/lib/policy.ts
index 42f1655..a4225e4 100644
--- a/bitcoin_client_js/src/lib/policy.ts
+++ b/bitcoin_client_js/src/lib/policy.ts
@@ -11,7 +11,7 @@ const WALLET_POLICY_V2 = 2;
* of a "Descriptor Template" and a list of "keys". A key is basically
* a serialized BIP32 extended public key with some added derivation path
* information. This is documented at
- * https://github.com/LedgerHQ/app-bitcoin-new/blob/master/doc/wallet.md
+ * https://github.com/LedgerHQ/app-bitcoin/blob/master/doc/wallet.md
*/
export class WalletPolicy {
readonly name: string;
diff --git a/bitcoin_client_rs/Cargo.toml b/bitcoin_client_rs/Cargo.toml
index 3926f54..ce1a1c9 100644
--- a/bitcoin_client_rs/Cargo.toml
+++ b/bitcoin_client_rs/Cargo.toml
@@ -4,7 +4,7 @@ version = "0.6.2"
authors = ["Ledger"]
edition = "2018"
description = "Ledger Bitcoin application client"
-repository = "https://github.com/LedgerHQ/app-bitcoin-new"
+repository = "https://github.com/LedgerHQ/app-bitcoin"
license = "Apache-2.0"
documentation = "https://docs.rs/ledger_bitcoin_client/"
diff --git a/bitcoin_client_rs/src/async_client.rs b/bitcoin_client_rs/src/async_client.rs
index 9012a59..1f28b8d 100644
--- a/bitcoin_client_rs/src/async_client.rs
+++ b/bitcoin_client_rs/src/async_client.rs
@@ -101,7 +101,7 @@ impl<T: Transport> BitcoinClient<T> {
.script_pubkey()
!= expected_address.assume_checked_ref().script_pubkey()
{
- return Err(BitcoinClientError::InvalidResponse("Invalid address. Please update your Bitcoin app. If the problem persists, report a bug at https://github.com/LedgerHQ/app-bitcoin-new".to_string()));
+ return Err(BitcoinClientError::InvalidResponse("Invalid address. Please update your Bitcoin app. If the problem persists, report a bug at https://github.com/LedgerHQ/app-bitcoin".to_string()));
}
Ok(())
diff --git a/bitcoin_client_rs/src/client.rs b/bitcoin_client_rs/src/client.rs
index efc7379..c29cf29 100644
--- a/bitcoin_client_rs/src/client.rs
+++ b/bitcoin_client_rs/src/client.rs
@@ -96,7 +96,7 @@ impl<T: Transport> BitcoinClient<T> {
.script_pubkey()
!= expected_address.assume_checked_ref().script_pubkey()
{
- return Err(BitcoinClientError::InvalidResponse("Invalid address. Please update your Bitcoin app. If the problem persists, report a bug at https://github.com/LedgerHQ/app-bitcoin-new".to_string()));
+ return Err(BitcoinClientError::InvalidResponse("Invalid address. Please update your Bitcoin app. If the problem persists, report a bug at https://github.com/LedgerHQ/app-bitcoin".to_string()));
}
Ok(())
diff --git a/dev-tools/playground/README.md b/dev-tools/playground/README.md
index 22281c5..6f585bd 100644
--- a/dev-tools/playground/README.md
+++ b/dev-tools/playground/README.md
@@ -16,7 +16,7 @@ Two front-ends:
## Setup
-All commands assume you're at the repo root (`app-bitcoin-new/`).
+All commands assume you're at the repo root (`app-bitcoin/`).
```bash
# 1. Create and activate a Python virtualenv (Python >= 3.8).
diff --git a/ragger_bitcoin/setup.cfg b/ragger_bitcoin/setup.cfg
index 867b7b0..3fdabe3 100644
--- a/ragger_bitcoin/setup.cfg
+++ b/ragger_bitcoin/setup.cfg
@@ -6,9 +6,9 @@ author_email = hello@ledger.fr
description = Ragger wrapper for Leger Bitcoin Client
long_description = file: README.md
long_description_content_type = text/markdown
-url = https://github.com/LedgerHQ/app-bitcoin-new
+url = https://github.com/LedgerHQ/app-bitcoin
project_urls =
- Bug Tracker = https://github.com/LedgerHQ/app-bitcoin-new
+ Bug Tracker = https://github.com/LedgerHQ/app-bitcoin
classifiers =
Programming Language :: Python :: 3
Programming Language :: Python :: 3.8
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.