AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 40 Bitcoin

Reject duplicate keys and trailing data when parsing a PSBT in the JS client

Public commit record

What the developer wrote

Authored by Salvatore Ingala

65/100 · Adequate
Reject duplicate keys and trailing data when parsing a PSBT in the JS client

Now both cases are rejected, improving compliance to BIP-174.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
The short version

What changed, and why it matters

This commit fixes the JavaScript PSBT (Partially Signed Bitcoin Transaction) parser in Ledger's Bitcoin app so it now rejects malformed PSBTs that contain duplicate keys or extra trailing bytes. Previously, such malformed data could be accepted, potentially causing the parser to behave inconsistently or mix up data from one PSBT with another. The fix also clears internal state before parsing, so reusing the same parser object does not accidentally keep old data.

Recommended action

Review whether the fixed parser behavior could have allowed malformed PSBTs to reach downstream signing logic, and consider whether a security advisory is warranted if prior versions could be induced to sign or display incorrect transaction data. Update dependent packages and notify users to upgrade the JS client.

Security signals we found

01

BIP-174 non-compliance: duplicate keys and trailing data were previously accepted

02

State reuse bug: deserializing multiple PSBTs in the same instance could merge maps

03

Input validation gap in client-side PSBT parsing

04

Potential for parser confusion or transaction misinterpretation

Risk score

Why this scored 40/100

Our methodology →
Potential impact 8/30
Exploitability 7/25
Stealth signal 6/15
Affected reach 8/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.