AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

ragger: fail if a request succeeds without showing the expected screens

Public commit record

What the developer wrote

Authored by Salvatore Ingala

73/100 · Adequate
ragger: fail if a request succeeds without showing the expected screens

The navigation only advanced through the instruction groups while an APDU
was pending, so a request that completed without showing the expected
review was accepted, and its screens were never compared.

Require every instruction group to be navigated when a request succeeds.
The only exception is a final status screen, since the response APDU is
sent before showing it.

A few of the instructions were outdated and contained useless extra
instructions, so they were removed. The silent MuSig2 round 1 is no longer
given the instructions meant for the signing review.

The navigation settings of a call also applied to nested calls (for
example, the address check in register_wallet) and, after an exception,
to later calls. They now apply to the requests of that call only.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit fixes the automated test harness, not the Ledger Bitcoin app itself. Previously, the test framework could silently pass even when the device completed a request without showing the expected on-screen review. The change makes tests fail if the expected screens are not shown, and it tidies up some test instructions. It does not change the security behavior of the device firmware or the wallet application that users interact with.

Recommended action

No user or operator action is required. This is a test-framework quality improvement. Reviewers may want to confirm that the new stricter test checks now pass against the current firmware and that any newly failing tests reflect real UI behavior rather than outdated instruction definitions.

Security signals we found

01

Test-hardening only: no firmware or runtime application code changed

02

Fixes false-negative test results where a request could succeed without expected UI review

03

Corrects scope of navigation settings to avoid leaking across nested or subsequent calls

04

Removes incorrect navigation instructions for silent MuSig2 round 1

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.