AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 51 Bitcoin

Reject PSBTv2-only fields when converting a PSBTv0 in the JS client

Public commit record

What the developer wrote

Authored by Salvatore Ingala

73/100 · Adequate
Reject PSBTv2-only fields when converting a PSBTv0 in the JS client

Reject all the global, input and output fields that BIP-370 excludes
from PSBTv0 before converting, instead of silently overwriting the
(possibly) intended value.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit fixes a bug in the Ledger Bitcoin app's JavaScript client library. When converting an older-style Bitcoin transaction file (PSBT version 0) into the newer PSBT version 2 format, the library previously ignored fields that are only legal in version 2. Those fields could silently override important transaction details, such as when the transaction can be spent (the locktime). The change now rejects such files with an error instead of converting them, preventing accidental or malicious transaction tampering from being hidden.

Recommended action

Users of the Ledger Bitcoin app JavaScript client should update to a version containing this commit. Developers integrating PSBTv0 conversion should verify that any PSBTv0 inputs they produce do not contain v2-only fields, as such inputs will now be rejected. Review other conversion paths for similar silent-overwrite behavior.

Security signals we found

01

Input validation fix: rejects malformed PSBTv0 containing v2-only fields

02

Prevents silent override of transaction locktime during PSBTv0-to-v2 conversion

03

Adds missing BIP-370 key type constants for required time/height locktime

04

Adds regression tests for locktime handling and v2-only field rejection

Risk score

Why this scored 51/100

Our methodology →
Potential impact 12/30
Exploitability 10/25
Stealth signal 8/15
Affected reach 10/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.