LD
← All projectsLedger

Ledger Bitcoin app

Open-source Bitcoin application running on Ledger devices; the device OS is outside this repository.

BitcoinHardware walletsNormal
Repository coverage

447 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

148security candidates154second-pass queue402AI analyses
19commits · 30 days
63commits · 60 days
249commits · 180 days
414commits · 365 days
Backfill bands
Aug 5 → Feb 670 seen8 candidatesComplete
Feb 6 → Jun 6149 seen21 candidatesComplete
Jun 6 → Jul 623 seen0 candidatesComplete
Jul 6 → Aug 555 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

57/100 average clarity
50Strong · 80–100
152Adequate · 60–79
186Thin · 40–59
59Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Salvatore Ingala2981122561062
Ilya Artemov962696145
Ruben Waterman666083
Aymeric Robert434063
github-actions[bot]17117046
Mathias BROUSSET17015039
José Luis Landabaso Díaz404067
iartemov-ledger201051
Cerberus Merlin101062
Michael Evans101073
Charles-Edouard de la Vergne101045
Analysis record

Published AI watches

Last scanned 44 minutes ago

Informational 20 AI analysisMessage 83 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

tests: pin all Python test dependencies to exact versions

This commit pins the exact versions of Python testing tools used by the project's automated tests. Previously, the test setup allowed any newly released version of those tools to be installed automatically, which could introduce unexpected…

Supply-chain risk reduction for test/CI dependenciesPrevents unreviewed automatic upgrades of speculos and raggerNo change to firmware or published package code
def417a3by Salvatore Ingala+329−142 files
No security note in commit
Informational 15 AI analysisMessage 38 · Opaque
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Bump version to 2.6.0

This commit is a routine version bump from 2.5.1 to 2.6.0 in the Ledger Bitcoin app. It only updates the version number in the Makefile and the release date in the CHANGELOG. There are no code changes, no bug fixes, and no security-related…

2b424b54by Salvatore Ingala+4−42 files
No security note in commit
Moderate 66 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #581 from LedgerHQ/client-fixes

This commit tightens how the Ledger Bitcoin app and its companion client libraries read PSBT (Partially Signed Bitcoin Transaction) data. It adds checks that reject malformed or suspicious PSBTs: truncated fields, unexpected extra bytes af…

Hardened PSBT deserialization against truncation and trailing dataAdded duplicate-key detection in PSBT mapsRejected PSBTv2-only fields inside PSBTv0 to prevent locktime/field override attacks
f8f790a3by Salvatore Ingala+544−17018 files
No security note in commit
Low 47 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

python client: reject PSBTv2-only fields in a PSBTv0

This commit tightens input validation in the Python helper library that prepares Bitcoin transaction data for Ledger hardware wallets. It now rejects PSBT files that claim to be the older version 0 format but contain fields that only belon…

Input-validation hardening: stricter parsing of PSBT version 0 to reject v2-only key typesConsistency fix across clients: aligns Python client with HS and Rust client behaviorLocktime normalization during v0-to-v2 conversion to prevent per-input locktime from overriding transaction locktime
84165be7by Salvatore Ingala+92−02 files
No security note in commit
Informational 24 AI analysisMessage 83 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

tests: update authproxy.py to the latest version from Bitcoin Core

This commit updates a test helper file used to talk to a Bitcoin node during automated testing. The old helper could accidentally send the same command twice if the network connection hiccuped, which could cause a test-only action like sen…

Removed transparent retry of non-idempotent RPC requests after connection resetsTest helper could execute state-changing RPCs twice before the fixNew connection-per-call configuration mitigates idle-timeout disconnects without retry risk
c7ca508eby Salvatore Ingala+91−522 files
Vendor flagged security relevance
Low 40 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject duplicate keys and trailing data when parsing a PSBT in the JS client

This commit fixes the JavaScript PSBT (Partially Signed Bitcoin Transaction) parser in Ledger's Bitcoin app so it now rejects malformed PSBTs that contain duplicate keys or extra trailing bytes. Previously, such malformed data could be acc…

BIP-174 non-compliance: duplicate keys and trailing data were previously acceptedState reuse bug: deserializing multiple PSBTs in the same instance could merge mapsInput validation gap in client-side PSBT parsing
4942a4aeby Salvatore Ingala+40−02 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

ragger: fail if a request succeeds without showing the expected screens

This commit fixes the automated test harness, not the Ledger Bitcoin app itself. Previously, the test framework could silently pass even when the device completed a request without showing the expected on-screen review. The change makes te…

Test-hardening only: no firmware or runtime application code changedFixes false-negative test results where a request could succeed without expected UI reviewCorrects scope of navigation settings to avoid leaking across nested or subsequent calls
202d352aby Salvatore Ingala+76−957 files
No security note in commit
Low 37 AI analysisMessage 88 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

unit tests: Fix length overflow in unit-test PSBT parser

This commit fixes an arithmetic overflow bug in a test-only PSBT (Bitcoin transaction format) parser used in unit tests. The bug could let a crafted test input make the parser think a data length is huge, potentially confusing the mock dis…

Integer overflow/wrap-around in length calculationOut-of-bounds length derived from arithmetic on attacker-influenced offsetsUnit-test-only code path, not device firmware
6a2a9262by Salvatore Ingala+6−21 file
No security note in commit
Low 48 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

rust client: reject PSBTv2-only fields when converting a PSBTv0

This commit fixes a bug in the Ledger Bitcoin app's Rust client where a PSBT v0 (an older transaction format) could silently carry fields that only have meaning in PSBT v2. When converting v0 to v2, those fields could override values taken…

Input validation added for cross-format PSBT conversionPrevents v2-only fields from overriding unsigned-transaction-derived valuesBIP-370 compliance enforcement for PSBTv0
602055d6by Salvatore Ingala+66−91 file
No security note in commit
Moderate 51 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject PSBTv2-only fields when converting a PSBTv0 in the JS client

This commit fixes a bug in the Ledger Bitcoin app's JavaScript client library. When converting an older-style Bitcoin transaction file (PSBT version 0) into the newer PSBT version 2 format, the library previously ignored fields that are on…

Input validation fix: rejects malformed PSBTv0 containing v2-only fieldsPrevents silent override of transaction locktime during PSBTv0-to-v2 conversionAdds missing BIP-370 key type constants for required time/height locktime
a1f6dc84by Salvatore Ingala+66−22 files
No security note in commit
High 72 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject duplicate keys and truncated maps when parsing PSBT maps in sign_psbt

This commit fixes a bug in how the Ledger Bitcoin app client parses PSBT (Partially Signed Bitcoin Transaction) maps. Previously, if the same key appeared twice in a map, the parser silently kept the last value. A malicious or malformed PS…

Silent overwrite of duplicate PSBT map keys could create commitment mismatch between client and deviceTruncated PSBT maps were silently accepted due to exception swallowing in deserialization loopsTrailing data after PSBT maps was ignored, allowing reserialization to silently normalize malformed inputs
75df80f9by Salvatore Ingala+107−104 files
Vendor flagged security relevance
High 72 AI analysisMessage 53 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #579 from LedgerHQ/misc-fixes

This commit fixes several bugs in Ledger's Bitcoin app. The most serious ones are: (1) a set of miniscript policy analyzer mistakes that could let the app accept Bitcoin wallet policies whose scripts are too large or too expensive to execu…

Miniscript cost/property analysis errors that could allow oversized/undercosted wallet policiesHost-driven infinite-loop / denial-of-service via zero-length GET_MORE_ELEMENTS responsesUI state inconsistency causing a security warning to be prematurely dismissed
ec389348by Salvatore Ingala+413−3113 files
No security note in commit
Low 26 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #576 from LedgerHQ/musig2_improvements

This commit improves the Ledger Bitcoin app's MuSig2 multi-signature feature. It lets wallet software pre-generate public nonces before a transaction is known, adds an optional MUSIG2_SESSION_ID field so multiple signing sessions can be in…

New PSBT proprietary field parsing with length validation (1-32 bytes, empty rejected)Session ID now commits to wallet policy plus optional MUSIG2_SESSION_IDSession storage limit raised from 8 to 32 with LRU eviction
26d22adcby Salvatore Ingala+710−7216 files
No security note in commit
Informational 18 AI analysisMessage 85 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Use signed scratch arrays in the thresh ops and stack size computations

This commit is a small code cleanup in Ledger's Bitcoin app. It changes two local arrays from unsigned (uint16_t) to signed (int16_t) in functions that count operations and stack sizes for Bitcoin miniscript 'thresh' policies. The commit m…

Signed/unsigned type mismatch in sentinel handlingPotential latent integer interpretation bug in miniscript threshold policy analysisCode clarity improvement around invalid (dis)satisfaction markers
4ff6f2f0by Salvatore Ingala+4−41 file
No security note in commit
Low 48 AI analysisMessage 91 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Align miniscript type and ops computations with bitcoin-core

This commit fixes the Ledger Bitcoin app's internal checker for Miniscript wallet policies. The checker was incorrectly rejecting some valid Bitcoin spending policies as unsafe, and in a few places it was computing safety properties using …

Logic change in Miniscript policy analysisAlignment with upstream Bitcoin Core reference implementationRelaxation of overly strict non-malleability and timelock-mixing checks
4694d317by Salvatore Ingala+26−132 files
No security note in commit
Moderate 68 AI analysisMessage 86 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix ops computation for andor fragments

This commit fixes a bug in how the Ledger Bitcoin app counts the number of Bitcoin script operations (ops) needed to spend certain wallet policies that use a 'miniscript andor' fragment. Because the count was wrong, the app could allow use…

Incorrect miniscript ops accounting for andor fragmentPolicy sanity check bypass leading to unspendable registered walletsReference alignment with Bitcoin Core implementation
86159d1eby Salvatore Ingala+40−13 files
Vendor flagged security relevance
High 74 AI analysisMessage 78 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix ops computation for l: and u: fragments

This commit fixes a bug in how the Ledger Bitcoin app counts Bitcoin script operations ('ops') for two specific Miniscript fragments, 'l:' and 'u:'. Because the count was too low, the app could accept wallet policies that look valid but ar…

Undercounting of script operation budget leading to acceptance of unspendable policiesIncorrect handling of Miniscript wrapper dissatisfaction semanticsPolicy sanity check bypass via operation-count accounting flaw
b6ac1de8by Salvatore Ingala+39−33 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

doc: document the MUSIG2_SESSION_ID PSBT field

This commit only updates documentation and the changelog. It explains a new optional PSBT field called MUSIG2_SESSION_ID that lets software wallets manage multiple MuSig2 signing sessions for the same wallet policy on a Ledger device. Ther…

8d8ed9afby Salvatore Ingala+28−62 files
No security note in commit
Informational 15 AI analysisMessage 78 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

musig_sessions: store up to 32 sessions

This commit is a simple capacity increase, not a security fix. It raises the number of simultaneous MuSig2 signing sessions the Ledger Bitcoin app can keep in memory from 8 to 32, because users with multiple MuSig accounts or wallets that …

a6798172by Salvatore Ingala+12−54 files
No security note in commit
Low 26 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

sign_psbt: fail before the UI if the MuSig2 session is missing

This commit improves the user experience and error handling for Ledger's Bitcoin app when using MuSig2 multi-signatures. Previously, if a required MuSig2 session was missing during the second round of signing, the device would only report …

UX-hardening: fail-fast before user approval instead of afterNew specific error code EC_SIGN_PSBT_MUSIG2_SESSION_NOT_FOUND for missing MuSig2 sessionsRefactored session storage lookup to support non-destructive existence check
2d04b144by Salvatore Ingala+118−187 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityBump Rust client library to 0.6.1by Salvatore Ingala · 7cc39189 · May 7, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Bump Rust client library to 0.6.1

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only changes a version number in a package configuration file from 0.6.0 to 0.6.1. There is no code change, no bug fix, and no security-related content visible in the diff.

Security candidateEnsure the version of the transaction is 2 for all e2e testsby Salvatore Ingala · 0dd48467 · May 7, 2026 · 4 filesMessage 83 · StrongInformational 15Details
Commit message · Salvatore Ingala

Ensure the version of the transaction is 2 for all e2e tests

Some of the psbts generated in the test suite had nVersion = 1,
which made combinepsbt fail (since changing the nVersion results
in a different sighash).

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing boundary
AI analysis · Informational 15/100

This commit only changes automated test files. It forces the test transactions to use Bitcoin transaction version 2 so that a test helper called combinepsbt works correctly. There is no change to the actual Ledger app code that users run, and no security fix or vulnerability is present in the diff.

Lower-priorityenable build comparison and stack usage reportby Mathias BROUSSET · 12a7834f · May 4, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Mathias BROUSSET

enable build comparison and stack usage report

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only changes GitHub CI workflow settings. It turns on two build-reporting features: comparing compiled outputs across builds and reporting how much stack memory the app uses during tests. There is no change to the actual Bitcoin app code, no bug fix, and no security patch.

AI review queuedupdate crate deploymentby Mathias BROUSSET · 7d19c7a3 · May 4, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Mathias BROUSSET

update crate deployment

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit removes two lines from a GitHub Actions CI workflow file. It disables a JFrog deployment step and stops passing a Cargo crate publishing token to that workflow job. There is no change to the actual Bitcoin app code, cryptography, or anything users install on their Ledger devices. It is purely an internal adjustment to how a Rust client library crate is published.

Lower-priorityAdd missing length validation for V2 wallet policiesby Salvatore Ingala · a2ba8560 · May 4, 2026 · 1 fileMessage 73 · AdequateModerate 58Details
Commit message · Salvatore Ingala

Add missing length validation for V2 wallet policies

With V2 wallet policies, the preimage of the wallet policy is
requested after the wallet poicy header, which already declares its
length. Therefore, the length of the preimage should always match.

Thanks to Rob Hamilton for the bug report.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Moderate 58/100

This commit fixes a missing safety check in Ledger's Bitcoin app when handling newer 'V2 wallet policies.' The app was told in advance how long the wallet policy data should be, but it never verified that the actual data matched that length. The fix adds a simple comparison: if the lengths don't match, the app now rejects the request. The commit credits Rob Hamilton for reporting the bug, but no public security advisory or CVE is included in the materials.

Lower-priorityadd call to reusable_app_release.yml for github releasesby Mathias BROUSSET · 8423c8f0 · Apr 27, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Mathias BROUSSET

add call to reusable_app_release.yml for github releases

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit adds a new GitHub Actions workflow file that automatically creates a GitHub release whenever a version tag like '1.2.3' is pushed. It calls a reusable release workflow maintained by Ledger. There is no change to the Bitcoin app code, device firmware, or any user-facing security behavior. It is purely a CI/CD automation addition.

Lower-priorityConsistently use version 1 for the protocol version in js clientby Salvatore Ingala · e53bfcdc · Apr 24, 2026 · 1 fileMessage 73 · AdequateInformational 19Details
Commit message · Salvatore Ingala

Consistently use version 1 for the protocol version in js client

While the protocol version is ignored on INS=CONTINUE_INTERRUPTED,
both the python and the Rust client consistently use version 1 for
all APDUs.
There is no reason for the JS client to behave differently.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 19/100

This is a tiny consistency fix in the JavaScript client for the Ledger Bitcoin app. It changes one number in a command that resumes interrupted operations so it matches the Python and Rust clients. The app already ignores this version number for this specific command, so the change is unlikely to have any security effect on its own. It mainly removes an unexplained difference between client implementations.

Security candidateAdd account context struct in sign_psbtby Salvatore Ingala · b7061e13 · Apr 24, 2026 · 3 filesMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Add account context struct in sign_psbt

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit is a straightforward internal code cleanup in Ledger's Bitcoin app. It groups several pieces of wallet-policy data into a new 'account context' structure and updates all references accordingly. There is no change to how transactions are validated, signed, or shown to the user, and no security bug is fixed or introduced in the visible diff.

AI review queuedTypo in commentby Salvatore Ingala · 3254b3fe · Apr 24, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Typo in comment

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit fixes a spelling mistake inside a code comment, removing an unnecessary semicolon. It does not change any executable code, logic, or behavior of the Bitcoin app.

Security candidatePartition init_global_state into smaller functionsby Salvatore Ingala · b0b6a1ad · Apr 24, 2026 · 2 filesMessage 73 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Partition init_global_state into smaller functions

Parsing the APDU, loading and verifying the wallet policy, and
parsing the global psbt map can be separated into independent
functions for simplicity.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit is a straightforward internal code cleanup: it splits one large function into three smaller, well-documented helper functions and moves one data field into a shared state structure. There is no change to what the code checks, accepts, or rejects. It does not fix a bug or add a security feature.

Security candidatePartition sign_psbt.c into smaller submodulesby Salvatore Ingala · 64c53b1a · Apr 24, 2026 · 28 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Partition sign_psbt.c into smaller submodules

Also, updated the copyright notices, or added where missing.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing boundarycryptography-sensitive pathsigning or wallet path
AI analysis · Informational 15/100

This commit is a large but purely structural code cleanup: it splits the single large sign_psbt.c file into many smaller, focused source files under src/handler/sign_psbt/. The actual logic, function bodies, validation checks, and security-sensitive operations appear to be moved verbatim into the new modules, with only minor header/include adjustments and copyright-notice updates. There is no indication of a behavior change, bug fix, or security patch.

Security candidateParse unknown yielded tags in python client for sign_psbtby Salvatore Ingala · 027541a4 · Apr 23, 2026 · 3 filesMessage 73 · AdequateInformational 19Details
Commit message · Salvatore Ingala

Parse unknown yielded tags in python client for sign_psbt

This allows future-proofing the client by returning an explicit
unknown yielded value (that can safely be logged/ignored) instead
of returning an incorrect enormous 'input index'.

The Rust client uses the same approach.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundary
AI analysis · Informational 19/100

This is a small defensive update to the Python companion library for Ledger's Bitcoin app. It changes how the client handles unexpected data returned by a future version of the hardware app, so that the data is labeled as 'unknown' rather than being misread as a transaction input number. It is a robustness/future-proofing fix, not a patch for an active security flaw.

AI review queued[auto-update] Update Ragger snapshotsby github-actions[bot] · 80d58591 · Apr 23, 2026 · 18 filesMessage 45 · ThinInformational 15Details
Commit message · github-actions[bot]

[auto-update] Update Ragger snapshots

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates automated test screenshot snapshots for Ledger's Bitcoin app. No application code, firmware, or user-facing behavior was changed. It is not a security fix and does not affect real devices or user funds.

Lower-priorityFix unicode symbol presence (incorrectly handled by NBGL)by Ilya Artemov · 183b192a · Apr 23, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

Fix unicode symbol presence (incorrectly handled by NBGL)

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit changes a single character in a user-facing warning message. It replaces a curly apostrophe (’), which the Ledger NBGL user-interface library was not displaying correctly, with a straight apostrophe ('). There is no security vulnerability here; it is purely a display/rendering fix.

Lower-priorityUse default version for clang-formatby Salvatore Ingala · b3dd2112 · Apr 23, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Use default version for clang-format

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit removes a pinned version number from an automated code-style checker used in Ledger's Bitcoin app repository. It only affects how the project runs its internal linting workflow and does not change any application code, cryptographic logic, or user-facing behavior. There is no security relevance.

Security candidateAdd sign_psbt test for MuSig round 1 and 2by Salvatore Ingala · a3120eca · Apr 23, 2026 · 2 filesMessage 55 · ThinInformational 15Details
Commit message · Salvatore Ingala

Add sign_psbt test for MuSig round 1 and 2

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit only adds new test cases for an existing feature (MuSig multi-signature signing) in the Rust client test suite. It does not change any production code, cryptographic logic, or application behavior. The changes are purely in test files: extending the test harness to check two new kinds of returned data (public nonces and partial signatures) and adding recorded device communication data for two MuSig signing scenarios. There is no indication of a security fix or vulnerability.

Lower-priorityBump Rust client version to 0.6.0by Salvatore Ingala · f5156ae3 · Apr 23, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Bump Rust client version to 0.6.0

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a routine version number bump for the Rust client package, changing it from 0.5.1 to 0.6.0. There is no code change, no security fix, and no functional change visible in the diff.

Security candidateGeneralize return value of sign_psbt in the Rust clientby Salvatore Ingala · dd9e3409 · Apr 23, 2026 · 8 filesMessage 85 · StrongInformational 18Details
Commit message · Salvatore Ingala

Generalize return value of sign_psbt in the Rust client

In order to support returning pubnonces and partial signatures for
Musig2 support, the objrects returned in sign_psbt are generalized
from PartialSignature to a SignPsbtYieldedObject enum.
This is a breaking change, therefore it requires a major release.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing boundarysigning or wallet pathparser or protocol path
AI analysis · Informational 18/100

This commit is a routine API update for the Ledger Bitcoin app's Rust client library. It changes what kind of data the library returns when a user signs a Bitcoin transaction (PSBT), so it can also return MuSig2 multi-signature material (public nonces and partial signatures) in addition to ordinary signatures. The commit message explicitly calls this a breaking change that requires a major release. There is no indication of a security bug being fixed or introduced.

AI review queuedAdd failing unit test for thresh parsingby Salvatore Ingala · 02ee776f · Apr 22, 2026 · 1 fileMessage 55 · ThinLow 27Details
Commit message · Salvatore Ingala

Add failing unit test for thresh parsing

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 27/100

This commit only adds two new test cases to the project's unit tests. The tests check that the wallet policy parser correctly rejects 'thresh' descriptors with an invalid threshold number (zero or larger than the number of available sub-policies). It does not change any production code. The commit itself is a test-only change and appears to be preparing the ground for a later fix, but it signals that the developers have identified a parsing edge case that currently fails.

AI review queuedUpdate ragger snapshotsby Salvatore Ingala · 92fe8e4a · Apr 22, 2026 · 10 filesMessage 28 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Update ragger snapshots

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates test screenshot snapshots (expected device screen images used by automated tests). No application code, firmware logic, or user-facing behavior was changed. It is not a security fix and does not introduce a vulnerability.

AI review queuedMake sure has_wallet_policy is not used uninitializedby Salvatore Ingala · 192a2da2 · Apr 22, 2026 · 2 filesMessage 73 · AdequateLow 48Details
Commit message · Salvatore Ingala

Make sure has_wallet_policy is not used uninitialized

In the streaming case, a stale has_wallet_policy that is set to
true would lead to the previous wallet name being shown (if any).

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 48/100

This commit fixes a bug in the Ledger Bitcoin app where a flag indicating whether a wallet policy name should be shown could be left in an old/stale state during streaming transaction reviews. In practice, if a user had previously reviewed a transaction with a named wallet policy, a later transaction that should not show that name might incorrectly reuse the old name on screen. This is a user-interface consistency bug that could mislead the user about which wallet policy is authorizing a spend, but it does not directly expose private keys or allow unauthorized signing.

AI review queuedEnsure the policy_map_descriptor buffer is 0-terminatedby Salvatore Ingala · 24bd597e · Apr 22, 2026 · 1 fileMessage 50 · ThinModerate 63Details
Commit message · Salvatore Ingala

Ensure the policy_map_descriptor buffer is 0-terminated

Reported by Cerberus

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 63/100

This commit fixes a buffer handling bug in the Ledger Bitcoin app's wallet registration code. The app now reserves one extra byte for the wallet policy descriptor string and explicitly writes a null terminator (the 'end of string' marker). Without this fix, code that reads the descriptor as a text string could keep reading past the intended data, potentially leaking nearby memory or behaving unpredictably. The issue was reported by an external party called Cerberus.

AI review queuedStore opreturn_amount as uint64_t in cross-chain swapsby Salvatore Ingala · a6470681 · Apr 22, 2026 · 1 fileMessage 65 · AdequateModerate 58Details
Commit message · Salvatore Ingala

Store opreturn_amount as uint64_t in cross-chain swaps

This prevents possible truncation problems

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 58/100

This commit fixes a variable type in Ledger's Bitcoin app used during cross-chain cryptocurrency swaps. The amount attached to an OP_RETURN output was being stored in a `size_t` variable, which on Ledger's embedded device is likely 32 bits, while the actual amount is a 64-bit value. This mismatch could cause the amount to be silently truncated (cut off), potentially allowing a swap to be validated with an incorrect amount. The fix changes the variable to `uint64_t` to match the real data size and prevent truncation.

AI review queuedMake sure k <= n when parsing threshby Salvatore Ingala · 597b161a · Apr 22, 2026 · 1 fileMessage 45 · ThinModerate 59Details
Commit message · Salvatore Ingala

Make sure k <= n when parsing thresh

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This commit fixes a missing safety check in the Ledger Bitcoin app's wallet policy parser. When reading a 'thresh(...)' policy (a multi-signature rule like '2 of 3 signatures needed'), the app now verifies that the required number of signatures (k) is not greater than the total number of available signers (n). Without this check, a malformed policy could ask for more signatures than keys exist, which could lead to an unusable or non-standard wallet policy being accepted by the device.

Security candidateAdd support for "musig()" in the rust clientby Salvatore Ingala · 244d6027 · Apr 21, 2026 · 4 filesMessage 80 · StrongLow 26Details
Commit message · Salvatore Ingala

Add support for "musig()" in the rust client

Since rust-miniscript currently doesn't support musig() key
expressions, it cannot be used for the calculation of addresses
for such wallet policies in the client.

Similarly to the python client, this implements the minimal code
for BIP327- and BIP328-complient key aggregation, in order to
replace musig() with the corresponding synthetic xpub, before
computing the address using rust-miniscript.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
secret or key materialcryptography-sensitive path
AI analysis · Low 26/100

This commit adds code to the Ledger Bitcoin app's Rust client that pre-processes wallet descriptors containing 'musig(...)' key groups before computing addresses. It implements a small BIP-327/BIP-328 key aggregation so the existing miniscript library can still parse the descriptor. It is a feature addition, not a reported vulnerability fix, but any new cryptographic code can introduce bugs that could cause wrong addresses or, in the worst case, weaken security if implemented incorrectly.