Fix unicode symbol presence (incorrectly handled by NBGL)
What the developer wrote
Authored by Ilya Artemov
Fix unicode symbol presence (incorrectly handled by NBGL)
What changed, and why it matters
This commit changes a single character in a user-facing warning message. It replaces a curly apostrophe (’), which the Ledger NBGL user-interface library was not displaying correctly, with a straight apostrophe ('). There is no security vulnerability here; it is purely a display/rendering fix.
No security action needed. Treat as a normal UI/display fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies one string constant in src/ui/display_nbgl.c. The message ‘This transaction has fees higher than 10% of the amount you’re sending.’ is changed to use a straight ASCII apostrophe instead of the Unicode right single quotation mark (U+2019). The commit message states this was ‘incorrectly handled by NBGL’ (Ledger’s newer UI library). This is a UI rendering/string-sanitization fix, not a code-execution, memory-safety, or cryptographic issue.
Changed components
src/ui/display_nbgl.cInspect captured patch +1 / −1
diff --git a/src/ui/display_nbgl.c b/src/ui/display_nbgl.c
index f07db37..e41fadb 100644
--- a/src/ui/display_nbgl.c
+++ b/src/ui/display_nbgl.c
@@ -34,7 +34,7 @@ const char GA_RISK_NON_STD_SIGHASH[] =
"This transaction uses non-standard signing rules (modified sighash). You could spend more "
"than expected.";
const char GA_WARN_HIGH_FEES[] =
- "This transaction has fees higher than 10% of the amount you’re sending.";
+ "This transaction has fees higher than 10% of the amount you're sending.";
#else
const char GA_SECURITY_RISK_TITLE[] = "Security risk";
const char GA_WARN_HIGH_FEES_TITLE[] = "High fees warning";
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.