LD
← All projectsLedger

Ledger Bitcoin app

Open-source Bitcoin application running on Ledger devices; the device OS is outside this repository.

BitcoinHardware walletsNormal
Repository coverage

374 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

101security candidates144second-pass queue345AI analyses
38commits · 30 days
95commits · 60 days
233commits · 180 days
370commits · 365 days
Backfill bands
Aug 5 → Feb 670 seen8 candidatesComplete
Feb 6 → Jun 6149 seen21 candidatesComplete
Jun 6 → Jul 623 seen0 candidatesComplete
Jul 6 → Aug 555 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

54/100 average clarity
22Strong · 80–100
117Adequate · 60–79
177Thin · 40–59
58Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Salvatore Ingala23271205658
Ilya Artemov962696145
Aymeric Robert434063
github-actions[bot]17117046
Mathias BROUSSET16015038
José Luis Landabaso Díaz404067
iartemov-ledger201051
Cerberus Merlin101062
Michael Evans101073
Charles-Edouard de la Vergne101045
Analysis record

Published AI watches

Last scanned 10 minutes ago

Low 37 AI analysisMessage 58 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #569 from LedgerHQ/client-fixes

This commit fixes how Ledger's Bitcoin client libraries convert older PSBTv0 transaction data into the newer PSBTv2 format that Ledger hardware wallets expect. The changes correct several field-handling bugs: the transaction locktime is no…

PSBTv0-to-v2 conversion bug fixesMissing input sequence defaulted to 0xffffffff (final sequence)Locktime assigned to transaction object instead of PSBT object
034b9d04by Salvatore Ingala+368−85911 files
No security note in commit
Informational 24 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

python client: use default value for nSequence if not given

This commit fixes a small bug in the Python helper library that builds unsigned Bitcoin transactions from PSBT data. Previously, if a PSBT did not explicitly include a per-input sequence number, the code would crash with an assertion error…

Behavioral change in transaction serialization helperRemoves an assertion that could cause crashes on valid PSBTs missing optional sequence fieldsAligns implementation with BIP-370 and HWI upstream behavior
2bf0eed6by Salvatore Ingala+3−21 file
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Bump ledger_bitcoin_client version to 0.7.0

This commit only updates a version number from 0.6.2 to 0.7.0 in two Rust package files. It is a routine bookkeeping change because the public interface of the PSBT module changed, requiring a minor version bump under semantic versioning r…

cfb530b9by Salvatore Ingala+2−22 files
No security note in commit
Informational 15 AI analysisMessage 83 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

js tests: drop a bogus required height locktime of 0 from test PSBTs

This commit only changes hardcoded test data used in JavaScript unit tests. It removes an invalid zero-value locktime field from two PSBT (Partially Signed Bitcoin Transaction) test fixtures so they conform to the BIP-370 standard. No prod…

ec992074by Salvatore Ingala+6−32 files
No security note in commit
Low 48 AI analysisMessage 95 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

python client: fix three PSBTv2 defects in psbt.py

This commit fixes three bugs in a Python helper that converts modern PSBTv2 transaction data into the older PSBTv0 format used by Ledger hardware wallets. The bugs could silently corrupt the transaction's lock time and version fields durin…

Silent data corruption in transaction serialization (nLockTime, tx_version, fallback_locktime)PSBTv2 to PSBTv0 conversion path affectedPotential for producing an unsigned transaction that does not match the PSBT's declared fields
04ba9e7bby Salvatore Ingala+6−31 file
No security note in commit
Low 35 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

rust client: build PSBTv2 maps from all pairs, not an enumerated list

This commit refactors how the Ledger Bitcoin app's Rust client converts a PSBT (Partially Signed Bitcoin Transaction) from version 0 to version 2. Previously, the code manually listed every PSBT field it knew how to serialize, which risked…

Refactor of PSBT serialization path used before signing on hardware walletRemoval of hand-maintained field enumeration that could omit or mis-serialize PSBT fieldsAddition of explicit error handling for PSBTs containing pre-existing v2 keys that conflict with v0 transaction data
a16bb101by Salvatore Ingala+344−8484 files
No security note in commit
Informational 15 AI analysisMessage 38 · Opaque
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Version bump to v2.5.1

This commit is a routine version bump from 2.5.0 to 2.5.1 for the Ledger Bitcoin app. It only updates the changelog and Makefile version number. No code changes are present in the diff, and no security fixes or vulnerabilities are describe…

e7618c98by Ilya Artemov+5−42 files
No security note in commit
Low 27 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #546 from LedgerHQ/simplify_ast

This commit is a large internal refactoring of the Ledger Bitcoin app's wallet-policy parser. It replaces compact 'relative pointers' with ordinary memory pointers in the abstract syntax tree (AST) used to represent Bitcoin wallet descript…

Large-scale memory-layout refactoring of security-critical parserRemoval of custom relative-pointer abstraction, eliminating a class of offset-calculation bugsIncrease in policy buffer size limits and key-info length limits
efee9c25by Salvatore Ingala+412−55812 files
No security note in commit
Low 37 AI analysisMessage 85 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Increase MAX_POLICY_KEY_INFO_LEN to the actual maximum; nits from PR review

This commit fixes a size limit in the Ledger Bitcoin app that was too small. The app uses this limit when registering Bitcoin wallet policies (descriptions of how to spend coins). The old limit underestimated how long a key description can…

Buffer/limit size correction for key origin infoRemoval of unused ledger_assert.h includeComment-only updates to serialized wallet policy length bounds
afd42b6dby Salvatore Ingala+5−61 file
No security note in commit
Low 32 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #556 from LedgerHQ/mem_opt

This commit removes an old memory workaround in Ledger's Bitcoin app. Previously, a large data structure used during transaction signing was stored in global memory instead of on the function's stack, because some Ledger devices were thoug…

Memory allocation model changed for high-risk signing pathStack-size build-time guard changed for Nano XGlobal cache removed; signing state now lives on stack
3aa53954by Salvatore Ingala+9−275 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #558 from LedgerHQ/embit_private

This commit simply renames an internal Python package from `embit` to `_embit` (a common convention indicating it is private/implementation detail) and updates all import statements accordingly. There is no functional code change and no se…

d438dd03by Salvatore Ingala+7−731 files
No security note in commit
Moderate 61 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #559 from LedgerHQ/parse_unhardened

This update fixes a boundary bug in how the Ledger Bitcoin app parses wallet policies that use multi-path key expressions like /<M;N>/*. The app was supposed to reject hardened (high-security) derivation indexes, but it incorrectly allowed…

Boundary condition error: hardened derivation index 0x80000000 accepted as unhardenedWallet policy parser validation bypass in multi-path key expressionsRegression unit test added for hardened boundary rejection
96e999feby Salvatore Ingala+49−298 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Label unsigned constants in constants.h

This commit only adds 'U' suffixes to numeric constants in a header file and makes a few matching type adjustments in C source files so the code still compiles cleanly with strict compiler warnings. It is a code-quality cleanup, not a secu…

e1fcefb4by Salvatore Ingala+27−276 files
No security note in commit
Low 25 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Pin @bitcoinerlab/descriptors to v3.1.7

This commit changes a JavaScript package dependency from allowing any compatible 3.x version of @bitcoinerlab/descriptors to a fixed, exact version (3.1.7). Pinning a dependency is often done to prevent unexpected future changes, but the c…

Dependency version pinningNo explicit security claim in commit messageNo code-level security fix visible in diff
6262d104by Salvatore Ingala+101−122 files
No security note in commit
Moderate 60 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject 0x80000000 as an unhardened step in wallet policy parsing

This commit fixes a boundary-check bug in how the Ledger Bitcoin app parses wallet policies (BIP-388). The app was supposed to reject any hardened derivation step in a specific range expression, but it allowed the value 2147483648 (0x80000…

Off-by-one boundary check in BIP-388 wallet policy parsingForbidden hardened derivation index accepted as unhardenedPotential failure or incorrect behavior in address derivation and signing
44f98a0eby Salvatore Ingala+2−21 file
Vendor flagged security relevance
Low 47 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add regression test for unhardened derivation step parsing

This commit only adds a new regression test to the Bitcoin app's test suite. The test checks that wallet policy key expressions reject a specific boundary value (2147483648, the first 'hardened' child index) where only 'unhardened' values …

Regression test for hardened/unhardened derivation index boundary parsingCommit message states older version accepted 0x80000000 as unhardenedNo production code change in this commit
ce2c25c6by Salvatore Ingala+20−01 file
No security note in commit
Informational 15 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Mark vendored embit clone 'private' in python client

This commit simply renames a vendored (internally bundled) copy of the 'embit' library inside the Python client from `embit` to `_embit`. The leading underscore is a Python convention meaning 'private/internal use only.' No code behavior c…

141e88f2by Salvatore Ingala+7−731 files
No security note in commit
Low 33 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Delete the hash context before return in compute_rand_i_j

This commit adds a memory wipe of a cryptographic hash context after it is used to derive a secret random value in the Ledger Bitcoin app's MuSig multi-signature code. The change is described by the developer as a 'defense-in-depth' measur…

explicit_bzero added to clear sensitive cryptographic contextMuSig signing randomness treated as sensitive after partial signatures are knownDefense-in-depth memory hygiene patch
121a18ceby Salvatore Ingala+3−01 file
Vendor flagged security relevance
Moderate 67 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Harden count_distinct_keys_info to correctly count the used keys

This commit fixes a bug in Ledger's Bitcoin app that could let a wallet policy slip through registration even when it contained unused or out-of-range public keys. The old code simply looked at the highest key index referenced in the walle…

Logic flaw in wallet policy validationPotential bypass of internal-key ownership check via unused key slotsBounds checking added for key indices
d94c51a2by Salvatore Ingala+52−124 files
Vendor flagged security relevance
Low 44 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject registering wallet policies with pubkeys not on the curve

This commit adds an early safety check in the Ledger Bitcoin app. Before registering a new wallet policy, the app now verifies that each public key is a valid point on the Bitcoin elliptic curve. Previously, an invalid public key would onl…

Input validation added for cryptographic public key pointsInvalid curve points now rejected at wallet registration time rather than deferred to address derivationUse of standard status word SW_INCORRECT_DATA for malformed input
d0c47c7aby Salvatore Ingala+9−01 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedupdate crate deploymentby Mathias BROUSSET · 7d19c7a3 · May 4, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Mathias BROUSSET

update crate deployment

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit removes two lines from a GitHub Actions CI workflow file. It disables a JFrog deployment step and stops passing a Cargo crate publishing token to that workflow job. There is no change to the actual Bitcoin app code, cryptography, or anything users install on their Ledger devices. It is purely an internal adjustment to how a Rust client library crate is published.

Lower-priorityAdd missing length validation for V2 wallet policiesby Salvatore Ingala · a2ba8560 · May 4, 2026 · 1 fileMessage 73 · AdequateModerate 58Details
Commit message · Salvatore Ingala

Add missing length validation for V2 wallet policies

With V2 wallet policies, the preimage of the wallet policy is
requested after the wallet poicy header, which already declares its
length. Therefore, the length of the preimage should always match.

Thanks to Rob Hamilton for the bug report.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Moderate 58/100

This commit fixes a missing safety check in Ledger's Bitcoin app when handling newer 'V2 wallet policies.' The app was told in advance how long the wallet policy data should be, but it never verified that the actual data matched that length. The fix adds a simple comparison: if the lengths don't match, the app now rejects the request. The commit credits Rob Hamilton for reporting the bug, but no public security advisory or CVE is included in the materials.

Lower-priorityadd call to reusable_app_release.yml for github releasesby Mathias BROUSSET · 8423c8f0 · Apr 27, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Mathias BROUSSET

add call to reusable_app_release.yml for github releases

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit adds a new GitHub Actions workflow file that automatically creates a GitHub release whenever a version tag like '1.2.3' is pushed. It calls a reusable release workflow maintained by Ledger. There is no change to the Bitcoin app code, device firmware, or any user-facing security behavior. It is purely a CI/CD automation addition.

Lower-priorityConsistently use version 1 for the protocol version in js clientby Salvatore Ingala · e53bfcdc · Apr 24, 2026 · 1 fileMessage 73 · AdequateInformational 19Details
Commit message · Salvatore Ingala

Consistently use version 1 for the protocol version in js client

While the protocol version is ignored on INS=CONTINUE_INTERRUPTED,
both the python and the Rust client consistently use version 1 for
all APDUs.
There is no reason for the JS client to behave differently.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 19/100

This is a tiny consistency fix in the JavaScript client for the Ledger Bitcoin app. It changes one number in a command that resumes interrupted operations so it matches the Python and Rust clients. The app already ignores this version number for this specific command, so the change is unlikely to have any security effect on its own. It mainly removes an unexplained difference between client implementations.

Security candidatePartition sign_psbt.c into smaller submodulesby Salvatore Ingala · 64c53b1a · Apr 24, 2026 · 28 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Partition sign_psbt.c into smaller submodules

Also, updated the copyright notices, or added where missing.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing boundarycryptography-sensitive pathsigning or wallet path
AI analysis · Informational 15/100

This commit is a large but purely structural code cleanup: it splits the single large sign_psbt.c file into many smaller, focused source files under src/handler/sign_psbt/. The actual logic, function bodies, validation checks, and security-sensitive operations appear to be moved verbatim into the new modules, with only minor header/include adjustments and copyright-notice updates. There is no indication of a behavior change, bug fix, or security patch.

Security candidateAdd account context struct in sign_psbtby Salvatore Ingala · b7061e13 · Apr 24, 2026 · 3 filesMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Add account context struct in sign_psbt

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit is a straightforward internal code cleanup in Ledger's Bitcoin app. It groups several pieces of wallet-policy data into a new 'account context' structure and updates all references accordingly. There is no change to how transactions are validated, signed, or shown to the user, and no security bug is fixed or introduced in the visible diff.

AI review queuedTypo in commentby Salvatore Ingala · 3254b3fe · Apr 24, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Typo in comment

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit fixes a spelling mistake inside a code comment, removing an unnecessary semicolon. It does not change any executable code, logic, or behavior of the Bitcoin app.

Security candidatePartition init_global_state into smaller functionsby Salvatore Ingala · b0b6a1ad · Apr 24, 2026 · 2 filesMessage 73 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Partition init_global_state into smaller functions

Parsing the APDU, loading and verifying the wallet policy, and
parsing the global psbt map can be separated into independent
functions for simplicity.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit is a straightforward internal code cleanup: it splits one large function into three smaller, well-documented helper functions and moves one data field into a shared state structure. There is no change to what the code checks, accepts, or rejects. It does not fix a bug or add a security feature.

Security candidateParse unknown yielded tags in python client for sign_psbtby Salvatore Ingala · 027541a4 · Apr 23, 2026 · 3 filesMessage 73 · AdequateInformational 19Details
Commit message · Salvatore Ingala

Parse unknown yielded tags in python client for sign_psbt

This allows future-proofing the client by returning an explicit
unknown yielded value (that can safely be logged/ignored) instead
of returning an incorrect enormous 'input index'.

The Rust client uses the same approach.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundary
AI analysis · Informational 19/100

This is a small defensive update to the Python companion library for Ledger's Bitcoin app. It changes how the client handles unexpected data returned by a future version of the hardware app, so that the data is labeled as 'unknown' rather than being misread as a transaction input number. It is a robustness/future-proofing fix, not a patch for an active security flaw.

AI review queued[auto-update] Update Ragger snapshotsby github-actions[bot] · 80d58591 · Apr 23, 2026 · 18 filesMessage 45 · ThinInformational 15Details
Commit message · github-actions[bot]

[auto-update] Update Ragger snapshots

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates automated test screenshot snapshots for Ledger's Bitcoin app. No application code, firmware, or user-facing behavior was changed. It is not a security fix and does not affect real devices or user funds.

Lower-priorityFix unicode symbol presence (incorrectly handled by NBGL)by Ilya Artemov · 183b192a · Apr 23, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

Fix unicode symbol presence (incorrectly handled by NBGL)

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit changes a single character in a user-facing warning message. It replaces a curly apostrophe (’), which the Ledger NBGL user-interface library was not displaying correctly, with a straight apostrophe ('). There is no security vulnerability here; it is purely a display/rendering fix.

Lower-priorityUse default version for clang-formatby Salvatore Ingala · b3dd2112 · Apr 23, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Use default version for clang-format

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit removes a pinned version number from an automated code-style checker used in Ledger's Bitcoin app repository. It only affects how the project runs its internal linting workflow and does not change any application code, cryptographic logic, or user-facing behavior. There is no security relevance.

Security candidateAdd sign_psbt test for MuSig round 1 and 2by Salvatore Ingala · a3120eca · Apr 23, 2026 · 2 filesMessage 55 · ThinInformational 15Details
Commit message · Salvatore Ingala

Add sign_psbt test for MuSig round 1 and 2

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit only adds new test cases for an existing feature (MuSig multi-signature signing) in the Rust client test suite. It does not change any production code, cryptographic logic, or application behavior. The changes are purely in test files: extending the test harness to check two new kinds of returned data (public nonces and partial signatures) and adding recorded device communication data for two MuSig signing scenarios. There is no indication of a security fix or vulnerability.

Security candidateGeneralize return value of sign_psbt in the Rust clientby Salvatore Ingala · dd9e3409 · Apr 23, 2026 · 8 filesMessage 85 · StrongInformational 18Details
Commit message · Salvatore Ingala

Generalize return value of sign_psbt in the Rust client

In order to support returning pubnonces and partial signatures for
Musig2 support, the objrects returned in sign_psbt are generalized
from PartialSignature to a SignPsbtYieldedObject enum.
This is a breaking change, therefore it requires a major release.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing boundarysigning or wallet pathparser or protocol path
AI analysis · Informational 18/100

This commit is a routine API update for the Ledger Bitcoin app's Rust client library. It changes what kind of data the library returns when a user signs a Bitcoin transaction (PSBT), so it can also return MuSig2 multi-signature material (public nonces and partial signatures) in addition to ordinary signatures. The commit message explicitly calls this a breaking change that requires a major release. There is no indication of a security bug being fixed or introduced.

Lower-priorityBump Rust client version to 0.6.0by Salvatore Ingala · f5156ae3 · Apr 23, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Bump Rust client version to 0.6.0

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a routine version number bump for the Rust client package, changing it from 0.5.1 to 0.6.0. There is no code change, no security fix, and no functional change visible in the diff.

AI review queuedUpdate ragger snapshotsby Salvatore Ingala · 92fe8e4a · Apr 22, 2026 · 10 filesMessage 28 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Update ragger snapshots

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates test screenshot snapshots (expected device screen images used by automated tests). No application code, firmware logic, or user-facing behavior was changed. It is not a security fix and does not introduce a vulnerability.

AI review queuedStore opreturn_amount as uint64_t in cross-chain swapsby Salvatore Ingala · a6470681 · Apr 22, 2026 · 1 fileMessage 65 · AdequateModerate 58Details
Commit message · Salvatore Ingala

Store opreturn_amount as uint64_t in cross-chain swaps

This prevents possible truncation problems

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 58/100

This commit fixes a variable type in Ledger's Bitcoin app used during cross-chain cryptocurrency swaps. The amount attached to an OP_RETURN output was being stored in a `size_t` variable, which on Ledger's embedded device is likely 32 bits, while the actual amount is a 64-bit value. This mismatch could cause the amount to be silently truncated (cut off), potentially allowing a swap to be validated with an incorrect amount. The fix changes the variable to `uint64_t` to match the real data size and prevent truncation.

AI review queuedEnsure the policy_map_descriptor buffer is 0-terminatedby Salvatore Ingala · 24bd597e · Apr 22, 2026 · 1 fileMessage 50 · ThinModerate 63Details
Commit message · Salvatore Ingala

Ensure the policy_map_descriptor buffer is 0-terminated

Reported by Cerberus

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 63/100

This commit fixes a buffer handling bug in the Ledger Bitcoin app's wallet registration code. The app now reserves one extra byte for the wallet policy descriptor string and explicitly writes a null terminator (the 'end of string' marker). Without this fix, code that reads the descriptor as a text string could keep reading past the intended data, potentially leaking nearby memory or behaving unpredictably. The issue was reported by an external party called Cerberus.

AI review queuedMake sure has_wallet_policy is not used uninitializedby Salvatore Ingala · 192a2da2 · Apr 22, 2026 · 2 filesMessage 73 · AdequateLow 48Details
Commit message · Salvatore Ingala

Make sure has_wallet_policy is not used uninitialized

In the streaming case, a stale has_wallet_policy that is set to
true would lead to the previous wallet name being shown (if any).

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 48/100

This commit fixes a bug in the Ledger Bitcoin app where a flag indicating whether a wallet policy name should be shown could be left in an old/stale state during streaming transaction reviews. In practice, if a user had previously reviewed a transaction with a named wallet policy, a later transaction that should not show that name might incorrectly reuse the old name on screen. This is a user-interface consistency bug that could mislead the user about which wallet policy is authorizing a spend, but it does not directly expose private keys or allow unauthorized signing.

AI review queuedMake sure k <= n when parsing threshby Salvatore Ingala · 597b161a · Apr 22, 2026 · 1 fileMessage 45 · ThinModerate 59Details
Commit message · Salvatore Ingala

Make sure k <= n when parsing thresh

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This commit fixes a missing safety check in the Ledger Bitcoin app's wallet policy parser. When reading a 'thresh(...)' policy (a multi-signature rule like '2 of 3 signatures needed'), the app now verifies that the required number of signatures (k) is not greater than the total number of available signers (n). Without this check, a malformed policy could ask for more signatures than keys exist, which could lead to an unusable or non-standard wallet policy being accepted by the device.

AI review queuedAdd failing unit test for thresh parsingby Salvatore Ingala · 02ee776f · Apr 22, 2026 · 1 fileMessage 55 · ThinLow 27Details
Commit message · Salvatore Ingala

Add failing unit test for thresh parsing

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 27/100

This commit only adds two new test cases to the project's unit tests. The tests check that the wallet policy parser correctly rejects 'thresh' descriptors with an invalid threshold number (zero or larger than the number of available sub-policies). It does not change any production code. The commit itself is a test-only change and appears to be preparing the ground for a later fix, but it signals that the developers have identified a parsing edge case that currently fails.

Security candidateImprove tests for replace_musigsby Salvatore Ingala · 25e77a99 · Apr 21, 2026 · 1 fileMessage 68 · AdequateInformational 14Details
Commit message · Salvatore Ingala

Improve tests for replace_musigs

- use the canonical /<0;1>/* derivation steps
- add a test with empty musig
- add a test with two separate musig() expressions

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
cryptography-sensitive path
AI analysis · Informational 14/100

This commit only changes test code for a Bitcoin descriptor helper. It updates existing test strings to use a newer standard derivation format and adds two new test cases (an empty multi-signature expression and a descriptor containing two separate multi-signature expressions). There is no change to production code, no fix, and no security-relevant behavior change.

Lower-priorityBump ledger_bitcoin_client version to 0.5.1by Salvatore Ingala · d630b1b6 · Apr 21, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Bump ledger_bitcoin_client version to 0.5.1

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only increases a version number in a package metadata file from 0.5.0 to 0.5.1. There are no code changes, no security fixes, and no functional changes visible in the diff.

Security candidateAdd support for "musig()" in the rust clientby Salvatore Ingala · 244d6027 · Apr 21, 2026 · 4 filesMessage 80 · StrongLow 26Details
Commit message · Salvatore Ingala

Add support for "musig()" in the rust client

Since rust-miniscript currently doesn't support musig() key
expressions, it cannot be used for the calculation of addresses
for such wallet policies in the client.

Similarly to the python client, this implements the minimal code
for BIP327- and BIP328-complient key aggregation, in order to
replace musig() with the corresponding synthetic xpub, before
computing the address using rust-miniscript.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
secret or key materialcryptography-sensitive path
AI analysis · Low 26/100

This commit adds code to the Ledger Bitcoin app's Rust client that pre-processes wallet descriptors containing 'musig(...)' key groups before computing addresses. It implements a small BIP-327/BIP-328 key aggregation so the existing miniscript library can still parse the descriptor. It is a feature addition, not a reported vulnerability fix, but any new cryptographic code can introduce bugs that could cause wrong addresses or, in the worst case, weaken security if implemented incorrectly.

Lower-priorityBump version of python client to 0.4.1 and update CHANGELOGby Ilya Artemov · 674b5cdb · Apr 16, 2026 · 2 filesMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

Bump version of python client to 0.4.1 and update CHANGELOG

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a routine version bump and changelog update for the Python client library. It adds a note that the new version supports an existing device command used to read a wallet fingerprint. There are no code changes to the app's security logic, no bug fixes, and no vulnerability indicators.