LD
← All projectsLedger

Ledger Bitcoin app

Open-source Bitcoin application running on Ledger devices; the device OS is outside this repository.

BitcoinHardware walletsNormal
Repository coverage

301 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

75security candidates126second-pass queue301AI analyses
51commits · 30 days
82commits · 60 days
231commits · 180 days
301commits · 365 days
Backfill bands
Aug 5 → Feb 670 seen8 candidatesComplete
Feb 6 → Jun 6149 seen21 candidatesComplete
Jun 6 → Jul 623 seen0 candidatesComplete
Jul 6 → Aug 555 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

51/100 average clarity
13Strong · 80–100
76Adequate · 60–79
157Thin · 40–59
55Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Salvatore Ingala16748167455
Ilya Artemov952695145
github-actions[bot]17117046
Mathias BROUSSET14014040
José Luis Landabaso Díaz404067
Cerberus Merlin101062
iartemov-ledger101043
Michael Evans101073
Charles-Edouard de la Vergne101045
Analysis record

Published AI watches

Last scanned 21 minutes ago

Moderate 59 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #542 from LedgerHQ/musig-fixes

This commit fixes missing error handling in the Ledger Bitcoin app's MuSig2 multi-signature code. Several cryptographic functions could fail silently or return incorrect results because their error codes were ignored. The patch now checks …

Missing error propagation in cryptographic point operationsUnchecked return value of crypto_tr_lift_x could lead to use of an unspecified pointUnchecked point_add return value in key aggregation, nonce aggregation, and tweaking
0fec192fby Salvatore Ingala+21−63 files
No security note in commit
Moderate 59 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix missing return value checks for point_add calls

This commit fixes three places in the Ledger Bitcoin app's MuSig2 code where the result of an elliptic-curve point-addition operation was not checked for failure. If point_add fails (for example, because it produced the special 'point at i…

Unchecked cryptographic operation return value (point_add)Potential use of invalid/infinite elliptic-curve point in MuSig2 aggregationMuSig2 nonce aggregation failure path now returns correct cosigner index
b1132395by Salvatore Ingala+14−52 files
No security note in commit
Moderate 59 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Propagate crypto_tr_lift_x errors in cpoint

This commit fixes a small but meaningful bug in the Ledger Bitcoin app's code that handles advanced multi-signature (MuSig) operations. A function called crypto_tr_lift_x can fail when given an invalid x-coordinate that does not correspond…

Unchecked return value from cryptographic point-lifting functionPotential use of invalid/uninitialized curve point in MuSig signing flowMissing error propagation in compressed public-key parsing
18647877by Salvatore Ingala+7−12 files
No security note in commit
High 72 AI analysisMessage 58 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #539 from LedgerHQ/fix-stack-exhaustion

This update fixes a stack-exhaustion weakness in Ledger's Bitcoin app. A malicious or unusually crafted wallet policy (the text string that describes how coins can be spent) could make the app recurse so deeply that it runs out of call sta…

Stack exhaustion / unbounded recursion in policy parsing and validationMissing depth accounting for miniscript wrapper chainsLarge automatic arrays inside recursive functions (compute_thresh_ops / compute_thresh_stacksize)
1621b7faby Salvatore Ingala+371−1427 files
Vendor flagged security relevance
Low 41 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reduce the stack frame of key_orderings_count

This commit rewrites a function in the Ledger Bitcoin app to use less memory. The old code stored a large table of key-derivation pairs for every possible class of key expression, which grew quadratically with the maximum number of key exp…

Large stack allocation removed (quadratic memory reduced to linear)Integer types narrowed based on stated boundsNo explicit security claim in commit message or diff comments
2e39aa2aby Salvatore Ingala+29−361 file
No security note in commit
Low 27 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Move the wallet confirmation stage out of the handler's frame

This commit refactors the Ledger Bitcoin app's wallet registration code so that the user-confirmation step runs in a separate function that the compiler is told not to inline. The stated goal is to reduce peak stack memory use by freeing l…

Stack memory layout hardening via noinline separation of validation and UI phasesReduction of peak stack footprint for deeply recursive policy validationRefactor only: no change to validation rules, cryptographic checks, or UI logic
ff2a7c7aby Salvatore Ingala+107−861 file
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Limit the amount of nesting for `thresh` fragments to 4

This commit fixes a stack-overflow risk in Ledger's Bitcoin app when parsing wallet policies that deeply nest 'thresh' miniscript fragments. It limits nesting to four levels and prevents two helper functions from being inlined so their lar…

Stack-frame bloat from inlined functions with large local arraysRecursive policy-tree walker with unbounded nested thresh inputPotential stack exhaustion / overflow on crafted miniscript policy
d4e23574by Salvatore Ingala+68−73 files
No security note in commit
Low 36 AI analysisMessage 55 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add functional tests for the policy depth limits

This commit adds automated tests to the Ledger Bitcoin app to check that very deep or heavily nested wallet policies are rejected safely. The tests confirm that an over-deep policy returns an error instead of freezing or crashing the devic…

Tests for policy recursion/depth limitsReference to app constants MAX_PARSE_SCRIPT_RECURSION_DEPTH and MAX_THRESH_NESTINGAssertion that over-deep policy does not crash the app
a81554f8by Salvatore Ingala+51−01 file
No security note in commit
Low 43 AI analysisMessage 70 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Lowers MAX_N_IN_THRESH to 24

This commit reduces a hard-coded limit in Ledger's Bitcoin app on how many branches a 'thresh' miniscript operator can have, from 128 down to 24. The change is framed as a memory-usage improvement, not a security fix. It also adds a test t…

Stack-memory pressure reduction in recursive miniscript analysisHard-coded threshold lowered to prevent large dynamic-programming tablesNew unit test checks rejection of oversized thresh fragments
97ad772aby Salvatore Ingala+38−33 files
No security note in commit
High 72 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Count miniscript wrappers in the parser's recursion depth limit

This commit fixes a bug in the Ledger Bitcoin app's wallet-policy parser. Miniscript 'wrappers' (short letters like 'n' that modify a policy) were not counted toward the parser's recursion-depth safety limit. A crafted wallet descriptor wi…

Stack-exhaustion / denial-of-service via crafted descriptor templateMissing recursion-depth accounting for parser-level wrapper expansionPatch adds explicit depth budget check and regression test
ed7cd029by Salvatore Ingala+75−63 files
Vendor flagged security relevance
Low 31 AI analysisMessage 50 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Delete MAX_POLICY_DEPTH; rather, align with MAX_PARSE_SCRIPT_RECURSION_DEPTH from the parsing stage

This commit changes how deeply nested Bitcoin wallet policies can be when processed by a Ledger hardware wallet app. It removes a separate, smaller limit (10 levels) and instead uses the same deeper limit already applied during an earlier …

Depth-limit constant unified across parsing and processing stagesRemoval of a stricter local limit that could create inconsistent policy acceptanceNo new input validation or memory safety bug introduced by the diff itself
bb5386b0by Salvatore Ingala+3−41 file
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix wrong comment in policy_node_thresh_t

This commit only changes a code comment to accurately describe how child scripts are stored. It does not alter any actual program logic, data structures, or behavior, so it has no security impact.

fbbdca3fby Salvatore Ingala+1−11 file
No security note in commit
Low 42 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Disable musig in key expressions of musig_a/sortedmulti_a

This commit temporarily blocks a specific advanced Bitcoin wallet feature (MuSig inside multi_a/sortedmulti_a) because the code that reads those wallet descriptions doesn't handle it correctly yet. It's a defensive change to prevent malfor…

Parser hardening for unsupported nested MuSig expressionsAddition of negative unit tests for malformed/unsupported policiesCommentary in code explicitly notes incompatibility and temporary disablement
558854ebby Salvatore Ingala+24−132 files
No security note in commit
Moderate 62 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Additional integrity checks for Merkle proofs

This commit adds extra safety checks when the Ledger Bitcoin app verifies Merkle proofs, which are cryptographic evidence used to confirm that a piece of data belongs to a larger set. The changes ensure that the proof length matches the ex…

Merkle proof length validation against leaf depthEnforcement of Merkle leaf prefix byte 0x00Prevention of streaming invalid preimage data before callback invocation
c44c9b8bby Salvatore Ingala+32−44 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 55 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add unit tests for get_merkle_preimage

This commit only adds new unit tests for existing code. It does not change any production behavior, fix a bug, or introduce new functionality. The tests verify that certain security checks (proof length and domain separator checks) already…

Test-only commit with no production code changesTests verify existing Merkle proof length validation rejects internal-node-as-leaf and overlong proofsTests verify existing leaf preimage domain-separator check rejects internal-node preimages and non-zero prefixes
05445baeby Salvatore Ingala+334−03 files
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Type consistency in psbt_parse_rawtx, and some other hardenings

This commit hardens a Bitcoin transaction parser in Ledger's app. It changes some numeric fields to safer types, adds bounds checks on transaction counts and sizes, rejects extra trailing bytes after a transaction, checks a previously-igno…

Integer type narrowing and sentinel change from -1 to SIZE_MAXBounds checks before uint64_t to unsigned int castsReturn value of parser_consolidate_buffers now checked
1af86279by Salvatore Ingala+66−173 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Sign consistency for parser steps; removed stale comment

This commit only changes the declared type of three array-length constants from signed int to unsigned size_t, and removes two stale comments about a 10,000-byte limit. There is no change to program logic, memory allocation, bounds checkin…

373f4a56by Salvatore Ingala+7−72 files
No security note in commit
Moderate 59 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Harden prevout tx parsing checks

This commit tightens how the Ledger Bitcoin app parses previous transaction data when signing Bitcoin transactions. It adds size limits and completion checks that prevent malformed or oversized previous transaction outputs from being proce…

Adds explicit bounds checks on prevout scriptPubKey lengthsSwitches signed integer length arithmetic to size_t to avoid negative-length edge casesAdds completion check for streamed raw previous transaction parsing
0df0add4by Salvatore Ingala+44−64 files
No security note in commit
Informational 18 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix taptree hash computation in test_utils

This commit fixes a copy-paste bug in test helper code used during automated testing of Ledger's Bitcoin app. The bug caused the right-hand branch of a Taproot script tree to be ignored and the left-hand branch to be hashed twice when comp…

Incorrect cryptographic hash construction in Taproot taptree root computationCopy-paste error causing left subtree to be hashed twice and right subtree omittedTest-only code path, not production firmware
7cba440aby Salvatore Ingala+6−52 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Do not truncate preset names

This commit removes manual shortening of preset names in a developer-only playground GUI and lets the UI toolkit handle truncation automatically. It is a cosmetic/usability fix with no apparent security relevance.

9f57d1a4by Salvatore Ingala+9−41 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityBump ledger_bitcoin_client version to 0.5.1by Salvatore Ingala · d630b1b6 · Apr 21, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Bump ledger_bitcoin_client version to 0.5.1

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only increases a version number in a package metadata file from 0.5.0 to 0.5.1. There are no code changes, no security fixes, and no functional changes visible in the diff.

Lower-priorityBump version of python client to 0.4.1 and update CHANGELOGby Ilya Artemov · 674b5cdb · Apr 16, 2026 · 2 filesMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

Bump version of python client to 0.4.1 and update CHANGELOG

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a routine version bump and changelog update for the Python client library. It adds a note that the new version supports an existing device command used to read a wallet fingerprint. There are no code changes to the app's security logic, no bug fixes, and no vulnerability indicators.

AI review queuedGET_MASTER_FINGERPRINT supportby Ilya Artemov · 4318b561 · Apr 16, 2026 · 2 filesMessage 25 · OpaqueInformational 18Details
Commit message · Ilya Artemov

GET_MASTER_FINGERPRINT support

25/100 · OpaqueMessage clarity
✓ Descriptive subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 18/100

This commit adds a new way for the Ledger Bitcoin client to ask the device for the wallet's master key fingerprint (a short public identifier). It also keeps an older fallback method for compatibility with devices that do not yet support the new command. The change is a feature addition in the client library, not a fix for a known vulnerability, and the commit message does not describe any security problem.

AI review queuedfix: Empty SIGN_MESSAGE request displays uninitialized stack memoryby Cerberus Merlin · be83e8f1 · Apr 13, 2026 · 1 fileMessage 62 · AdequateLow 49Details
Commit message · Cerberus Merlin

fix: Empty SIGN_MESSAGE request displays uninitialized stack memory

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 49/100

This commit fixes a bug where signing an empty Bitcoin message could cause the Ledger device to display random leftover data from its memory instead of a clean empty message. The fix simply ensures the message buffer starts as an empty string before any data is copied into it. This is an information disclosure issue: an attacker who can trigger an empty message signing request might get the device to show uninitialized stack memory on screen. It does not appear to allow stealing coins directly, but it is a security-relevant bug in a trusted display path.

Security candidateFail immediately on overflow before converting from uint64_t to uint32_tby Salvatore Ingala · cd8d3178 · Apr 13, 2026 · 2 filesMessage 55 · ThinModerate 61Details
Commit message · Salvatore Ingala

Fail immediately on overflow before converting from uint64_t to uint32_t

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
memory safety
AI analysis · Moderate 61/100

This commit fixes two spots in Ledger's Bitcoin app where a very large 64-bit number could be silently truncated to a smaller 32-bit number. After the truncation, the app would treat a huge requested data length as a small one, which could let an attacker read memory beyond what was intended or behave in unexpected ways. The fix now checks for overflow and fails immediately before the conversion happens.

Security candidateGuard against sizes that do not fit in an intby Salvatore Ingala · e4012c72 · Apr 13, 2026 · 1 fileMessage 45 · ThinModerate 58Details
Commit message · Salvatore Ingala

Guard against sizes that do not fit in an int

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Moderate 58/100

This commit adds a safety check in the Ledger Bitcoin app's code that handles BIP32 derivation paths extracted from a PSBT (Partially Signed Bitcoin Transaction). The change prevents a very large, attacker-chosen data length from being silently truncated when converted from a large unsigned integer (size_t) to a signed integer (int). Such truncation could theoretically cause the app to allocate or read/write the wrong amount of memory, potentially leading to crashes or memory corruption. The patch is narrow and defensive, but it does not show a complete exploit path.

AI review queuedBump version, update CHANGELOGby Salvatore Ingala · 7cb002bb · Mar 30, 2026 · 2 filesMessage 35 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Bump version, update CHANGELOG

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only bumps the app version number from 2.4.5 to 2.4.6 and updates the changelog. It does not change any source code, cryptographic logic, or security behavior. The changelog mentions that a prior release fixed a miniscript policy issue, but this commit itself is purely administrative packaging.

AI review queuedAdd missing return after error; fix wrong int-bool conversionby Salvatore Ingala · 800bd047 · Mar 30, 2026 · 1 fileMessage 50 · ThinModerate 59Details
Commit message · Salvatore Ingala

Add missing return after error; fix wrong int-bool conversion

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This commit fixes two bugs in the Ledger Bitcoin app's MuSig (multi-signature) signing code. First, a function that should return true/false was returning -1 on error, which could be misinterpreted as 'true' (success). Second, after detecting a failed signature aggregation and sending an error code to the computer, the code kept running instead of stopping, which could lead to signing with invalid or partial data. Both are security-relevant control-flow bugs in a cryptocurrency signing path.

AI review queuedUpdate copyright noticeby Salvatore Ingala · 5e47a122 · Mar 30, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Update copyright notice

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only changes the displayed copyright year from 2025 to 2026 in the app's about/credits screen. It is a routine legal notice update with no security relevance.

AI review queuedUpdate dashboard snapshotsby Salvatore Ingala · fc8d7ab6 · Mar 30, 2026 · 3 filesMessage 35 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Update dashboard snapshots

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates three test screenshot images used for comparing the app's dashboard display during automated testing. No application code, logic, or security-sensitive files were changed.

Security candidateValidate output index (if given) in psbt_parse_rawtxby Salvatore Ingala · 2330334b · Mar 27, 2026 · 1 fileMessage 50 · ThinModerate 58Details
Commit message · Salvatore Ingala

Validate output index (if given) in psbt_parse_rawtx

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarydefensive validationsigning or wallet path
AI analysis · Moderate 58/100

This commit adds a safety check in the Ledger Bitcoin app's code that parses raw transactions from PSBT data. Before finalizing, it now verifies that if the caller asked for a specific transaction output by index, that output actually exists. Without this check, the code could have proceeded using data from a non-existent or uninitialized output, potentially leading to incorrect transaction details being shown or signed.

Lower-priorityFail immediately if out_len is 0by Salvatore Ingala · 32737bdd · Mar 27, 2026 · 1 fileMessage 60 · AdequateLow 33Details
Commit message · Salvatore Ingala

Fail immediately if out_len is 0

Avoids potential underflows when later computing out_len - 1

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Low 33/100

This commit adds an early safety check in a Bitcoin address formatting function. It returns an error immediately if the output buffer has zero length, preventing a possible integer underflow when the code later computes out_len - 1. The change is defensive and reduces the risk of memory corruption or unexpected behavior, though the commit message only frames it as avoiding underflows and does not claim a specific exploitable vulnerability.

Lower-priorityAdd missing bound check in call_get_preimageby Salvatore Ingala · 7f8e57be · Mar 27, 2026 · 2 filesMessage 60 · AdequateHigh 72Details
Commit message · Salvatore Ingala

Add missing bound check in call_get_preimage

Also add return value checks on all calls to buffer_write_bytes.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · High 72/100

This commit fixes a missing safety check in the Ledger Bitcoin app's code that copies a 'preimage' (a piece of data used in Bitcoin transactions) into an output buffer. Before the fix, if the preimage was larger than the buffer, the app could write past the end of the buffer, corrupting memory. The patch adds a size check and also checks the result of every buffer write so the app stops safely instead of overflowing. This is a memory-safety bug that could potentially be exploited from a host computer talking to the device.

Security candidateZero output buffer for signatures on errorsby Salvatore Ingala · 1509119c · Mar 27, 2026 · 1 fileMessage 45 · ThinModerate 58Details
Commit message · Salvatore Ingala

Zero output buffer for signatures on errors

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarycryptography-sensitive path
AI analysis · Moderate 58/100

This commit fixes a security-sensitive cleanup bug in the Ledger Bitcoin app's signing code. When a cryptographic signing operation failed, the output buffer that would normally hold the signature was not being cleared. That means a partially computed or leftover value could be returned to the caller instead of a valid signature. The fix wipes the buffer to zero whenever an error occurs, ensuring no misleading or exploitable signature-like data is produced.

Security candidateWrong function mentioned in commentby Salvatore Ingala · f8689a27 · Mar 27, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Wrong function mentioned in comment

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100

This commit only fixes a typo in a code comment. The comment previously referenced the wrong function name ('bip32_CKDpub' instead of 'crypto_tr_tweak_pubkey'). No actual code logic was changed, so there is no security impact.

Security candidateAdd missing bound check in fpt_der_data_callbackby Salvatore Ingala · e92bc067 · Mar 27, 2026 · 1 fileMessage 45 · ThinModerate 60Details
Commit message · Salvatore Ingala

Add missing bound check in fpt_der_data_callback

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Moderate 60/100

This commit fixes a missing safety check in the Ledger Bitcoin app when reading BIP32 derivation data from a PSBT (Partially Signed Bitcoin Transaction). For non-Taproot transactions, the app was not verifying that the derivation data was not longer than the maximum supported size before copying it into a fixed-size internal buffer. This could allow a malicious or malformed PSBT to overflow that buffer, potentially corrupting memory and affecting the device's behavior during transaction signing.

AI review queuedDocument public functions in parser_ext.hby Salvatore Ingala · f36a2dcb · Mar 27, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Document public functions in parser_ext.h

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
parser or protocol pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds documentation comments to a header file describing existing functions. No code behavior was changed, so it cannot introduce or fix a security issue on its own.

AI review queuedMake sure raw_witnessUtxo is long enough before reading its 9th byteby Salvatore Ingala · 6f818772 · Mar 27, 2026 · 1 fileMessage 50 · ThinModerate 59Details
Commit message · Salvatore Ingala

Make sure raw_witnessUtxo is long enough before reading its 9th byte

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This commit fixes a length check in the Ledger Bitcoin app's PSBT signing code. Before reading the 9th byte of a witness UTXO field, the code now verifies the field is at least 9 bytes long. Previously, it only checked that some data was returned, which could lead to reading past the end of a malformed or truncated input. This is a defensive fix against an out-of-bounds read that could affect transaction amount calculations during signing.

AI review queuedUpdate Ragger snapshotsby Ilya Artemov · 0e55e907 · Mar 26, 2026 · 1090 filesMessage 28 · OpaqueInformational 15Details
Commit message · Ilya Artemov

Update Ragger snapshots

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates test screenshot snapshots for the Ledger Bitcoin app. It renames and replaces image files used by the Ragger automated UI testing framework, changing test case names from '4to17' and '4to18' to '4toMax' and '4toMaxPlus1'. No application source code, firmware, or runtime behavior is modified, so there is no direct security impact on users.

AI review queuedDecreasing stack consumption: Nano X test adaptationby Ilya Artemov · 4fd088d7 · Mar 26, 2026 · 3 filesMessage 60 · AdequateInformational 23Details
Commit message · Ilya Artemov

Decreasing stack consumption: Nano X test adaptation

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 23/100

This commit only changes test helper code so that automated tests for the Ledger Bitcoin app use a smaller number of outputs on the Nano X device. It does not change the actual app firmware. The change is a test-suite adaptation to match a previously reduced Nano X limit, not a fix for a new security bug.

Lower-priorityDecreasing stack consumption specifically on Nano X as there is a hard limit on OS side - decreasing the maximum output number for non-streamed reviewby Ilya Artemov · 1bcf9714 · Mar 26, 2026 · 1 fileMessage 50 · ThinLow 35Details
Commit message · Ilya Artemov

Decreasing stack consumption specifically on Nano X as there is a hard limit on OS side - decreasing the maximum output number for non-streamed review

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 35/100

This commit reduces how many Bitcoin transaction outputs the Ledger Nano X app can review at once (from 16 down to 8) in a specific non-streaming mode. The stated reason is to avoid exceeding the Nano X operating system's 8 KB stack limit, which could otherwise cause the app to crash or behave unpredictably when signing transactions with many outputs.

Security candidateBuild-time check to protect global variables from stack overflowby Ilya Artemov · 9771747d · Mar 26, 2026 · 1 fileMessage 55 · ThinLow 32Details
Commit message · Ilya Artemov

Build-time check to protect global variables from stack overflow

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
memory safety
AI analysis · Low 32/100

This commit adds a build-time safety check in the Ledger Bitcoin app's Makefile. It sets a minimum required stack size depending on the device (Nano X or other), which helps catch cases where too much memory is used globally and could overflow into the stack. It is a defensive hardening change, not a fix for a known active bug or attack.

Lower-priorityRespect lockfile in CI JS testsby Salvatore Ingala · e1a5fa39 · Mar 26, 2026 · 1 fileMessage 55 · ThinInformational 15Details
Commit message · Salvatore Ingala

Respect lockfile in CI JS tests

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit changes the JavaScript test step in the project's automated CI workflow to use 'yarn install --immutable' instead of 'yarn install'. This tells the package manager to strictly follow the existing lockfile and fail if it would need to change it. It is a supply-chain hygiene improvement for testing, not a fix for a runtime security vulnerability in the Bitcoin app itself.

Lower-priorityBump @ledgerhq/ledger-bitcoin to 0.3.1by Salvatore Ingala · f750c800 · Mar 25, 2026 · 2 filesMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Bump @ledgerhq/ledger-bitcoin to 0.3.1

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a routine version bump for a JavaScript package from 0.3.0 to 0.3.1. It only changes two package metadata files and contains no code changes. There is no indication of a security fix or vulnerability.

Security candidateValidate boundaries before assigningby Salvatore Ingala · 4f93090e · Mar 24, 2026 · 1 fileMessage 35 · OpaqueModerate 59Details
Commit message · Salvatore Ingala

Validate boundaries before assigning

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
signing boundarydefensive validationsigning or wallet path
AI analysis · Moderate 59/100

This commit fixes a boundary-check ordering bug in the Ledger Bitcoin app's wallet policy parser. Previously, the code stored an untrusted length value into a data structure before checking whether that length was too large. The fix moves the storage to after the validation check. This prevents a malformed wallet policy from causing the app to record an oversized length that could later lead to memory corruption or incorrect parsing.