AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 36 Bitcoin

Add functional tests for the policy depth limits

Public commit record

What the developer wrote

Authored by Salvatore Ingala

55/100 · Thin
Add functional tests for the policy depth limits
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
The short version

What changed, and why it matters

This commit adds automated tests to the Ledger Bitcoin app to check that very deep or heavily nested wallet policies are rejected safely. The tests confirm that an over-deep policy returns an error instead of freezing or crashing the device. The commit itself only adds tests; it does not change the app's actual handling code, so it is a defensive test addition rather than a fix.

Recommended action

No immediate action required. Treat as routine test hardening. If reviewing the broader codebase, verify that the production limits in src/common/wallet.h are enforced consistently and that the depth check cannot be bypassed by other policy constructs.

Security signals we found

01

Tests for policy recursion/depth limits

02

Reference to app constants MAX_PARSE_SCRIPT_RECURSION_DEPTH and MAX_THRESH_NESTING

03

Assertion that over-deep policy does not crash the app

04

No production code changes; purely test coverage

Risk score

Why this scored 36/100

Our methodology →
Potential impact 8/30
Exploitability 7/25
Stealth signal 6/15
Affected reach 5/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.