AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 19 Bitcoin

Fix presets with sighash flags in app playground

Public commit record

What the developer wrote

Authored by Salvatore Ingala

60/100 · Adequate
Fix presets with sighash flags in app playground

It didn't correctly manage 'negative fees' when the fee is
actually not computable.
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
The short version

What changed, and why it matters

This commit fixes a bug in internal developer/test tooling for Ledger's Bitcoin app. The bug caused test PSBTs (Partially Signed Bitcoin Transactions) with certain SIGHASH flags to be built incorrectly, because the tool wrongly assumed the transaction had to balance. The fix makes the test generator understand that some sighash types allow the transaction to be unbalanced. This is a test/playground fix, not a change to the app that runs on the hardware wallet.

Recommended action

No immediate security action required for end users. This is a developer/test-tool fix. Reviewers should verify that the updated test vectors still exercise the hardware app correctly for SIGHASH_NONE/SINGLE/ANYONECANPAY scenarios.

Security signals we found

01

Fixes incorrect transaction balancing assumption for non-ALL sighash types in test tooling

02

Adds explicit validation that remainder outputs are disallowed when amounts are not fully committed

03

Moves sighash assignment into PSBT creation to keep metadata consistent

Risk score

Why this scored 19/100

Our methodology →
Potential impact 2/30
Exploitability 1/25
Stealth signal 1/15
Affected reach 2/15
Confidence 9/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.