LD
← All projectsLedger

Ledger Bitcoin app

Open-source Bitcoin application running on Ledger devices; the device OS is outside this repository.

BitcoinHardware walletsNormal
Repository coverage

374 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

101security candidates144second-pass queue345AI analyses
40commits · 30 days
95commits · 60 days
233commits · 180 days
370commits · 365 days
Backfill bands
Aug 5 → Feb 670 seen8 candidatesComplete
Feb 6 → Jun 6149 seen21 candidatesComplete
Jun 6 → Jul 623 seen0 candidatesComplete
Jul 6 → Aug 555 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

54/100 average clarity
22Strong · 80–100
117Adequate · 60–79
177Thin · 40–59
58Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Salvatore Ingala23271205658
Ilya Artemov962696145
Aymeric Robert434063
github-actions[bot]17117046
Mathias BROUSSET16015038
José Luis Landabaso Díaz404067
iartemov-ledger201051
Cerberus Merlin101062
Michael Evans101073
Charles-Edouard de la Vergne101045
Analysis record

Published AI watches

Last scanned 16 minutes ago

Low 37 AI analysisMessage 58 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #569 from LedgerHQ/client-fixes

This commit fixes how Ledger's Bitcoin client libraries convert older PSBTv0 transaction data into the newer PSBTv2 format that Ledger hardware wallets expect. The changes correct several field-handling bugs: the transaction locktime is no…

PSBTv0-to-v2 conversion bug fixesMissing input sequence defaulted to 0xffffffff (final sequence)Locktime assigned to transaction object instead of PSBT object
034b9d04by Salvatore Ingala+368−85911 files
No security note in commit
Informational 24 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

python client: use default value for nSequence if not given

This commit fixes a small bug in the Python helper library that builds unsigned Bitcoin transactions from PSBT data. Previously, if a PSBT did not explicitly include a per-input sequence number, the code would crash with an assertion error…

Behavioral change in transaction serialization helperRemoves an assertion that could cause crashes on valid PSBTs missing optional sequence fieldsAligns implementation with BIP-370 and HWI upstream behavior
2bf0eed6by Salvatore Ingala+3−21 file
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Bump ledger_bitcoin_client version to 0.7.0

This commit only updates a version number from 0.6.2 to 0.7.0 in two Rust package files. It is a routine bookkeeping change because the public interface of the PSBT module changed, requiring a minor version bump under semantic versioning r…

cfb530b9by Salvatore Ingala+2−22 files
No security note in commit
Informational 15 AI analysisMessage 83 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

js tests: drop a bogus required height locktime of 0 from test PSBTs

This commit only changes hardcoded test data used in JavaScript unit tests. It removes an invalid zero-value locktime field from two PSBT (Partially Signed Bitcoin Transaction) test fixtures so they conform to the BIP-370 standard. No prod…

ec992074by Salvatore Ingala+6−32 files
No security note in commit
Low 48 AI analysisMessage 95 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

python client: fix three PSBTv2 defects in psbt.py

This commit fixes three bugs in a Python helper that converts modern PSBTv2 transaction data into the older PSBTv0 format used by Ledger hardware wallets. The bugs could silently corrupt the transaction's lock time and version fields durin…

Silent data corruption in transaction serialization (nLockTime, tx_version, fallback_locktime)PSBTv2 to PSBTv0 conversion path affectedPotential for producing an unsigned transaction that does not match the PSBT's declared fields
04ba9e7bby Salvatore Ingala+6−31 file
No security note in commit
Low 35 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

rust client: build PSBTv2 maps from all pairs, not an enumerated list

This commit refactors how the Ledger Bitcoin app's Rust client converts a PSBT (Partially Signed Bitcoin Transaction) from version 0 to version 2. Previously, the code manually listed every PSBT field it knew how to serialize, which risked…

Refactor of PSBT serialization path used before signing on hardware walletRemoval of hand-maintained field enumeration that could omit or mis-serialize PSBT fieldsAddition of explicit error handling for PSBTs containing pre-existing v2 keys that conflict with v0 transaction data
a16bb101by Salvatore Ingala+344−8484 files
No security note in commit
Informational 15 AI analysisMessage 38 · Opaque
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Version bump to v2.5.1

This commit is a routine version bump from 2.5.0 to 2.5.1 for the Ledger Bitcoin app. It only updates the changelog and Makefile version number. No code changes are present in the diff, and no security fixes or vulnerabilities are describe…

e7618c98by Ilya Artemov+5−42 files
No security note in commit
Low 27 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #546 from LedgerHQ/simplify_ast

This commit is a large internal refactoring of the Ledger Bitcoin app's wallet-policy parser. It replaces compact 'relative pointers' with ordinary memory pointers in the abstract syntax tree (AST) used to represent Bitcoin wallet descript…

Large-scale memory-layout refactoring of security-critical parserRemoval of custom relative-pointer abstraction, eliminating a class of offset-calculation bugsIncrease in policy buffer size limits and key-info length limits
efee9c25by Salvatore Ingala+412−55812 files
No security note in commit
Low 37 AI analysisMessage 85 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Increase MAX_POLICY_KEY_INFO_LEN to the actual maximum; nits from PR review

This commit fixes a size limit in the Ledger Bitcoin app that was too small. The app uses this limit when registering Bitcoin wallet policies (descriptions of how to spend coins). The old limit underestimated how long a key description can…

Buffer/limit size correction for key origin infoRemoval of unused ledger_assert.h includeComment-only updates to serialized wallet policy length bounds
afd42b6dby Salvatore Ingala+5−61 file
No security note in commit
Low 32 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #556 from LedgerHQ/mem_opt

This commit removes an old memory workaround in Ledger's Bitcoin app. Previously, a large data structure used during transaction signing was stored in global memory instead of on the function's stack, because some Ledger devices were thoug…

Memory allocation model changed for high-risk signing pathStack-size build-time guard changed for Nano XGlobal cache removed; signing state now lives on stack
3aa53954by Salvatore Ingala+9−275 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #558 from LedgerHQ/embit_private

This commit simply renames an internal Python package from `embit` to `_embit` (a common convention indicating it is private/implementation detail) and updates all import statements accordingly. There is no functional code change and no se…

d438dd03by Salvatore Ingala+7−731 files
No security note in commit
Moderate 61 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #559 from LedgerHQ/parse_unhardened

This update fixes a boundary bug in how the Ledger Bitcoin app parses wallet policies that use multi-path key expressions like /<M;N>/*. The app was supposed to reject hardened (high-security) derivation indexes, but it incorrectly allowed…

Boundary condition error: hardened derivation index 0x80000000 accepted as unhardenedWallet policy parser validation bypass in multi-path key expressionsRegression unit test added for hardened boundary rejection
96e999feby Salvatore Ingala+49−298 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Label unsigned constants in constants.h

This commit only adds 'U' suffixes to numeric constants in a header file and makes a few matching type adjustments in C source files so the code still compiles cleanly with strict compiler warnings. It is a code-quality cleanup, not a secu…

e1fcefb4by Salvatore Ingala+27−276 files
No security note in commit
Low 25 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Pin @bitcoinerlab/descriptors to v3.1.7

This commit changes a JavaScript package dependency from allowing any compatible 3.x version of @bitcoinerlab/descriptors to a fixed, exact version (3.1.7). Pinning a dependency is often done to prevent unexpected future changes, but the c…

Dependency version pinningNo explicit security claim in commit messageNo code-level security fix visible in diff
6262d104by Salvatore Ingala+101−122 files
No security note in commit
Moderate 60 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject 0x80000000 as an unhardened step in wallet policy parsing

This commit fixes a boundary-check bug in how the Ledger Bitcoin app parses wallet policies (BIP-388). The app was supposed to reject any hardened derivation step in a specific range expression, but it allowed the value 2147483648 (0x80000…

Off-by-one boundary check in BIP-388 wallet policy parsingForbidden hardened derivation index accepted as unhardenedPotential failure or incorrect behavior in address derivation and signing
44f98a0eby Salvatore Ingala+2−21 file
Vendor flagged security relevance
Low 47 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add regression test for unhardened derivation step parsing

This commit only adds a new regression test to the Bitcoin app's test suite. The test checks that wallet policy key expressions reject a specific boundary value (2147483648, the first 'hardened' child index) where only 'unhardened' values …

Regression test for hardened/unhardened derivation index boundary parsingCommit message states older version accepted 0x80000000 as unhardenedNo production code change in this commit
ce2c25c6by Salvatore Ingala+20−01 file
No security note in commit
Informational 15 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Mark vendored embit clone 'private' in python client

This commit simply renames a vendored (internally bundled) copy of the 'embit' library inside the Python client from `embit` to `_embit`. The leading underscore is a Python convention meaning 'private/internal use only.' No code behavior c…

141e88f2by Salvatore Ingala+7−731 files
No security note in commit
Low 33 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Delete the hash context before return in compute_rand_i_j

This commit adds a memory wipe of a cryptographic hash context after it is used to derive a secret random value in the Ledger Bitcoin app's MuSig multi-signature code. The change is described by the developer as a 'defense-in-depth' measur…

explicit_bzero added to clear sensitive cryptographic contextMuSig signing randomness treated as sensitive after partial signatures are knownDefense-in-depth memory hygiene patch
121a18ceby Salvatore Ingala+3−01 file
Vendor flagged security relevance
Moderate 67 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Harden count_distinct_keys_info to correctly count the used keys

This commit fixes a bug in Ledger's Bitcoin app that could let a wallet policy slip through registration even when it contained unused or out-of-range public keys. The old code simply looked at the highest key index referenced in the walle…

Logic flaw in wallet policy validationPotential bypass of internal-key ownership check via unused key slotsBounds checking added for key indices
d94c51a2by Salvatore Ingala+52−124 files
Vendor flagged security relevance
Low 44 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject registering wallet policies with pubkeys not on the curve

This commit adds an early safety check in the Ledger Bitcoin app. Before registering a new wallet policy, the app now verifies that each public key is a valid point on the Bitcoin elliptic curve. Previously, an invalid public key would onl…

Input validation added for cryptographic public key pointsInvalid curve points now rejected at wallet registration time rather than deferred to address derivationUse of standard status word SW_INCORRECT_DATA for malformed input
d0c47c7aby Salvatore Ingala+9−01 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityLet's use so far existing app-bitcoin-new docker imageby Ilya Artemov · 18599aea · Jul 7, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

Let's use so far existing app-bitcoin-new docker image

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit simply updates the GitHub Actions CI workflow to use the correct Docker image name for the newer 'app-bitcoin-new' project instead of the old 'app-bitcoin' image. It is a build/test infrastructure change with no effect on the app users install on their Ledger devices.

Lower-priorityapp-bitcoin-new rename to app-bitcoinby Ilya Artemov · 5f68df41 · Jul 7, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Ilya Artemov

app-bitcoin-new rename to app-bitcoin

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit is a simple repository rename from 'app-bitcoin-new' to 'app-bitcoin'. It changes only one line in a GitHub Actions workflow file, updating the Docker container image path used for automated testing. There is no code change, no security fix, and no vulnerability introduced.

Lower-priorityA note added to README.mdby Ilya Artemov · be0f6e90 · Jul 7, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Ilya Artemov

A note added to README.md

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only adds a short note to the README.md file explaining that the repository was renamed. There are no code changes, no security fixes, and no functional changes to the Ledger Bitcoin app.

AI review queuedapp-bitcoin-new rename to app-bitcoinby Ilya Artemov · 3975774b · Jul 7, 2026 · 17 filesMessage 45 · ThinInformational 15Details
Commit message · Ilya Artemov

app-bitcoin-new rename to app-bitcoin

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a simple project rename from 'app-bitcoin-new' to 'app-bitcoin'. It only updates URLs, repository references, and documentation strings across 17 files. There are no code logic changes, no security fixes, and no behavior changes.

Lower-priorityUpdate docs and CHANGELOG for BIP-87 supportby Salvatore Ingala · f7920f56 · Jul 7, 2026 · 3 filesMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Update docs and CHANGELOG for BIP-87 support

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only updates documentation and a changelog. It adds BIP-87 to the list of standard Bitcoin derivation paths whose extended public keys (xpubs) can be exported without requiring the user to confirm on the device screen. There is no code change in the commit itself, so it does not introduce or fix a security vulnerability directly.

Lower-priorityUpdate tests for BIP-87 supportby Salvatore Ingala · 518fc20d · Jul 7, 2026 · 2 filesMessage 55 · ThinInformational 15Details
Commit message · Salvatore Ingala

Update tests for BIP-87 support

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds new test cases for BIP-87 extended public key derivation. It does not change any application code, cryptographic logic, or security behavior. There is no indication of a security fix or vulnerability.

Lower-priorityAllow exporting BIP-87 xpubs without explicit user approvalby Salvatore Ingala · 08f5d1aa · Jul 7, 2026 · 1 fileMessage 73 · AdequateModerate 53Details
Commit message · Salvatore Ingala

Allow exporting BIP-87 xpubs without explicit user approval

BIP-87 is a scheme for derivation paths that is similar to BIP-48,
and intended for multisig accounts.
Since we support silent xpub export for BIP-48, it makes more sense
to also support it for BIP-87 for consistency.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Moderate 53/100

This commit expands an existing feature that lets a connected computer request extended public keys (xpubs) from a Ledger device without requiring the user to press 'Approve' on the device screen. It now allows this silent export for BIP-87 multisig derivation paths, matching the existing behavior for BIP-48. The change is presented by the developer as a consistency improvement, not as a security fix. It does not add new code paths; it only adds one more derivation-path standard to an existing allow-list.

AI review queueddocs: Add user documentationby Salvatore Ingala · f32a3610 · Jun 24, 2026 · 4 filesMessage 87 · StrongInformational 15Details
Commit message · Salvatore Ingala

docs: Add user documentation

Existing documentation is rather detailed on the wire protocol, but
lacks a higher level technical overview of the features and
operating principles of the app.

This commit adds two new high-level guides for technical readers
that are not interested in the details of the wire protocol:

- features.md: high-level overview of the app's features
- integration.md: integration concepts and security model

Also, wallet.md was trimmed to avoid repeating what is in BIP-388.

87/100 · StrongMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Names security-relevant behavior explicitly
Why it was queued
signing or wallet pathdocumentation-only discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds and reorganizes user and developer documentation. No program code, build scripts, tests, or cryptographic logic were changed. It is not a security patch and does not introduce or fix any vulnerability.

Lower-priority[auto-update] Update Ragger snapshotsby github-actions[bot] · df859c3b · Jun 23, 2026 · 5 filesMessage 45 · ThinInformational 15Details
Commit message · github-actions[bot]

[auto-update] Update Ragger snapshots

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only updates five test snapshot images used by the Ragger automated testing framework. These are expected screen captures for a test named 'test_sighash_none_rejected_by_default' across different Ledger device models. There are no code changes, no application behavior changes, and no security fix or vulnerability present.

Lower-prioritySIGHASH gating: status screen on disabled rejection - testsby Ilya Artemov · ef9d1ecc · Jun 23, 2026 · 1 fileMessage 60 · AdequateInformational 12Details
Commit message · Ilya Artemov

SIGHASH gating: status screen on disabled rejection - tests

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 12/100

This commit only adds a new automated test that checks the on-device error screen shown when a user tries to sign a Bitcoin transaction with a non-standard SIGHASH type while the non-standard SIGHASH setting is disabled. It does not change the app's actual signing behavior or security logic; it only verifies that the existing rejection screen appears correctly.

AI review queuedSIGHASH gating: status screen on disabled rejectionby Ilya Artemov · 0e35a24d · Jun 23, 2026 · 4 filesMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

SIGHASH gating: status screen on disabled rejection

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a user-experience improvement, not a security fix. When a Bitcoin transaction uses a non-standard sighash and the user has not enabled the 'Allow non-standard sighash' setting, the app already rejected the transaction. Now it also shows an on-screen message explaining why it was rejected, so the user is not left confused.

AI review queuedSIGHASH gating: update Ragger snapshotsby github-actions[bot] · 84e9bc7c · Jun 23, 2026 · 177 filesMessage 45 · ThinInformational 15Details
Commit message · github-actions[bot]

SIGHASH gating: update Ragger snapshots

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 15/100

This commit only updates test screenshot snapshots for the Ledger Bitcoin app. It does not change any application code, so it cannot directly fix or introduce a security vulnerability. The snapshots show what the device screen looks like during tests of a new 'SIGHASH gating' feature, but the actual security behavior is implemented elsewhere.

AI review queuedSIGHASH gating: tests_mainnetby Ilya Artemov · b67c7982 · Jun 23, 2026 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · Ilya Artemov

SIGHASH gating: tests_mainnet

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates a test script that navigates the Ledger device's on-screen dashboard. It adds extra button presses to account for a new 'App settings' menu item that appears before 'App info'. There is no change to the actual Bitcoin app code, cryptographic logic, or transaction signing behavior, so this commit does not introduce or fix a security issue by itself.

AI review queuedSIGHASH gating: functional testsby Ilya Artemov · cb60be9a · Jun 23, 2026 · 3 filesMessage 45 · ThinInformational 15Details
Commit message · Ilya Artemov

SIGHASH gating: functional tests

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds automated functional tests for a new device setting that controls whether non-standard Bitcoin signature hash (sighash) types are allowed. It does not change the app code that runs on the Ledger device, so it cannot introduce a security vulnerability by itself. The tests verify that dangerous sighash types are blocked by default and require the user to explicitly enable a setting to allow them.

Lower-prioritySIGHASH gating: unit testsby Ilya Artemov · d89aa8b5 · Jun 23, 2026 · 2 filesMessage 45 · ThinInformational 12Details
Commit message · Ilya Artemov

SIGHASH gating: unit tests

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 12/100

This commit only adds new automated unit tests for an existing function called classify_sighash. It does not change any production wallet code, fix a bug, or alter behavior. The tests verify that different Bitcoin signature-hash types are correctly categorized as safe, non-safe, or unsupported for legacy, SegWit v0, and Taproot transactions. By itself, this is a testing/infrastructure change with no direct security impact.

AI review queuedSIGHASH gating: implementationby Ilya Artemov · 296bed60 · Jun 23, 2026 · 6 filesMessage 35 · OpaqueLow 48Details
Commit message · Ilya Artemov

SIGHASH gating: implementation

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Low 48/100

This commit adds a user-controlled setting to the Ledger Bitcoin app that blocks non-standard Bitcoin transaction signing modes by default. Previously, these modes were allowed with only a warning. Now the app rejects them unless the user explicitly turns on 'Allow non-standard sighash' in settings and confirms a warning. This is a security-hardening change, not a vulnerability fix in the traditional sense, but it reduces the risk of users accidentally signing transactions that protect fewer funds than they expect.

Lower-priorityfix: TARGET_* constants propagationby Ilya Artemov · 56299efa · Jun 17, 2026 · 3 filesMessage 47 · ThinLow 35Details
Commit message · Ilya Artemov

fix: TARGET_* constants propagation

47/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Low 35/100

This commit fixes a build-configuration problem in Ledger's Bitcoin app. Two source files now explicitly include the SDK header that defines TARGET_* constants (such as TARGET_NANOX, TARGET_STAX, TARGET_FLEX), and the build adds the correct include path for unit tests. Without these constants, the code could silently fall back to default values, potentially changing behavior on different Ledger devices. The change also adds compile-time #error checks so the problem cannot happen silently again.

AI review queuedRemove bad include directive with CFLAGSby Charles-Edouard de la Vergne · 704b361a · Jun 16, 2026 · 2 filesMessage 45 · ThinInformational 17Details
Commit message · Charles-Edouard de la Vergne

Remove bad include directive with CFLAGS

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 17/100

This commit removes a leftover debugging include from the build and adds a missing standard header to one source file. It is a cleanup/fix for build hygiene, not a security patch for an exploitable vulnerability. There is no evidence in the commit or supplied references that this fixes a security issue.

AI review queuedNit from PR reviewby Salvatore Ingala · 795a0445 · Jun 16, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Nit from PR review

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only removes periods at the end of sentences in a test documentation file (test_vectors/README.md). It is a cosmetic formatting change with no effect on code, security, or functionality.

AI review queuedExtract test assets into TOML filesby Salvatore Ingala · 04cdef8b · Jun 16, 2026 · 8 filesMessage 55 · ThinInformational 15Details
Commit message · Salvatore Ingala

Extract test assets into TOML files

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a test-only refactoring change. It moves existing test data from a private unit-test file into shared TOML files in a new test_vectors/ directory so the same test cases can be reused by Python, C, and future Rust test suites. No application code that runs on the Ledger device was changed, and no security behavior of the app was modified.

AI review queuedUnit tests for get_extended_pubkeyby Salvatore Ingala · 88fa41c7 · Jun 16, 2026 · 4 filesMessage 68 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Unit tests for get_extended_pubkey

Refactored the handler_get_extended_pubkey to move the actual
logic (after APDU parsing) into a separate function
get_extended_pubkey_response, which get be tested directly based
on the test vectors.

Rafactored some common TOML utilities into toml_helpers.h.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidencesigning or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds and reorganizes unit tests for the get_extended_pubkey feature. It does not change the actual app code that runs on the Ledger device, so it cannot introduce a security vulnerability or fix one in shipped software.

AI review queuedUnit tests for sign_messageby Salvatore Ingala · b4727094 · Jun 16, 2026 · 2 filesMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Unit tests for sign_message

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds new unit tests for the existing sign_message feature in Ledger's Bitcoin app. It does not change the actual signing code that runs on the device, so it cannot introduce a security vulnerability or fix one by itself. The tests exercise the handler with known test vectors and mock UI approval, and include one extra test for an over-long message length.

AI review queuedUpdate sign_message test vectorsby Salvatore Ingala · 867f69c8 · Jun 16, 2026 · 2 filesMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Update sign_message test vectors

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
fuzzing or regression evidencesigning or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates test data and documentation for the Bitcoin app's message-signing feature. It documents how the device displays messages (full text versus a hash) and adds matching test expectations. There is no code change and no security fix or vulnerability present in the diff.

AI review queuedAdd unit tests for register_walletby Salvatore Ingala · 0a99cb8e · Jun 16, 2026 · 2 filesMessage 55 · ThinInformational 15Details
Commit message · Salvatore Ingala

Add unit tests for register_wallet

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds new automated unit tests for the wallet-registration feature of the Ledger Bitcoin app. It does not change any production code, fix bugs, or alter app behavior. There is no security issue here.

Lower-priorityImprove error handling of copy_optional_stringby Salvatore Ingala · 65884532 · Jun 16, 2026 · 1 fileMessage 60 · AdequateInformational 24Details
Commit message · Salvatore Ingala

Improve error handling of copy_optional_string

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 24/100

This commit tightens error handling in a unit-test helper that reads TOML configuration files. Previously, the helper treated any non-string value the same as a missing value, silently returning false. Now it explicitly distinguishes 'field is missing' (still returns false) from 'field exists but is the wrong type' (now logs an error and aborts). This is a hardening change in test infrastructure, not a fix for a demonstrated vulnerability in the Ledger app itself.