LD
← All projectsLedger

Ledger Bitcoin app

Open-source Bitcoin application running on Ledger devices; the device OS is outside this repository.

BitcoinHardware walletsNormal
Repository coverage

301 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

75security candidates126second-pass queue300AI analyses
51commits · 30 days
82commits · 60 days
231commits · 180 days
301commits · 365 days
Backfill bands
Aug 5 → Feb 670 seen8 candidatesComplete
Feb 6 → Jun 6149 seen21 candidatesComplete
Jun 6 → Jul 623 seen0 candidatesComplete
Jul 6 → Aug 555 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

51/100 average clarity
13Strong · 80–100
76Adequate · 60–79
157Thin · 40–59
55Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Salvatore Ingala16748167455
Ilya Artemov952694145
github-actions[bot]17117046
Mathias BROUSSET14014040
José Luis Landabaso Díaz404067
Cerberus Merlin101062
iartemov-ledger101043
Michael Evans101073
Charles-Edouard de la Vergne101045
Analysis record

Published AI watches

Last scanned 42 minutes ago

Moderate 59 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #542 from LedgerHQ/musig-fixes

This commit fixes missing error handling in the Ledger Bitcoin app's MuSig2 multi-signature code. Several cryptographic functions could fail silently or return incorrect results because their error codes were ignored. The patch now checks …

Missing error propagation in cryptographic point operationsUnchecked return value of crypto_tr_lift_x could lead to use of an unspecified pointUnchecked point_add return value in key aggregation, nonce aggregation, and tweaking
0fec192fby Salvatore Ingala+21−63 files
No security note in commit
Moderate 59 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix missing return value checks for point_add calls

This commit fixes three places in the Ledger Bitcoin app's MuSig2 code where the result of an elliptic-curve point-addition operation was not checked for failure. If point_add fails (for example, because it produced the special 'point at i…

Unchecked cryptographic operation return value (point_add)Potential use of invalid/infinite elliptic-curve point in MuSig2 aggregationMuSig2 nonce aggregation failure path now returns correct cosigner index
b1132395by Salvatore Ingala+14−52 files
No security note in commit
Moderate 59 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Propagate crypto_tr_lift_x errors in cpoint

This commit fixes a small but meaningful bug in the Ledger Bitcoin app's code that handles advanced multi-signature (MuSig) operations. A function called crypto_tr_lift_x can fail when given an invalid x-coordinate that does not correspond…

Unchecked return value from cryptographic point-lifting functionPotential use of invalid/uninitialized curve point in MuSig signing flowMissing error propagation in compressed public-key parsing
18647877by Salvatore Ingala+7−12 files
No security note in commit
High 72 AI analysisMessage 58 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #539 from LedgerHQ/fix-stack-exhaustion

This update fixes a stack-exhaustion weakness in Ledger's Bitcoin app. A malicious or unusually crafted wallet policy (the text string that describes how coins can be spent) could make the app recurse so deeply that it runs out of call sta…

Stack exhaustion / unbounded recursion in policy parsing and validationMissing depth accounting for miniscript wrapper chainsLarge automatic arrays inside recursive functions (compute_thresh_ops / compute_thresh_stacksize)
1621b7faby Salvatore Ingala+371−1427 files
Vendor flagged security relevance
Low 41 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reduce the stack frame of key_orderings_count

This commit rewrites a function in the Ledger Bitcoin app to use less memory. The old code stored a large table of key-derivation pairs for every possible class of key expression, which grew quadratically with the maximum number of key exp…

Large stack allocation removed (quadratic memory reduced to linear)Integer types narrowed based on stated boundsNo explicit security claim in commit message or diff comments
2e39aa2aby Salvatore Ingala+29−361 file
No security note in commit
Low 27 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Move the wallet confirmation stage out of the handler's frame

This commit refactors the Ledger Bitcoin app's wallet registration code so that the user-confirmation step runs in a separate function that the compiler is told not to inline. The stated goal is to reduce peak stack memory use by freeing l…

Stack memory layout hardening via noinline separation of validation and UI phasesReduction of peak stack footprint for deeply recursive policy validationRefactor only: no change to validation rules, cryptographic checks, or UI logic
ff2a7c7aby Salvatore Ingala+107−861 file
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Limit the amount of nesting for `thresh` fragments to 4

This commit fixes a stack-overflow risk in Ledger's Bitcoin app when parsing wallet policies that deeply nest 'thresh' miniscript fragments. It limits nesting to four levels and prevents two helper functions from being inlined so their lar…

Stack-frame bloat from inlined functions with large local arraysRecursive policy-tree walker with unbounded nested thresh inputPotential stack exhaustion / overflow on crafted miniscript policy
d4e23574by Salvatore Ingala+68−73 files
No security note in commit
Low 36 AI analysisMessage 55 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add functional tests for the policy depth limits

This commit adds automated tests to the Ledger Bitcoin app to check that very deep or heavily nested wallet policies are rejected safely. The tests confirm that an over-deep policy returns an error instead of freezing or crashing the devic…

Tests for policy recursion/depth limitsReference to app constants MAX_PARSE_SCRIPT_RECURSION_DEPTH and MAX_THRESH_NESTINGAssertion that over-deep policy does not crash the app
a81554f8by Salvatore Ingala+51−01 file
No security note in commit
Low 43 AI analysisMessage 70 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Lowers MAX_N_IN_THRESH to 24

This commit reduces a hard-coded limit in Ledger's Bitcoin app on how many branches a 'thresh' miniscript operator can have, from 128 down to 24. The change is framed as a memory-usage improvement, not a security fix. It also adds a test t…

Stack-memory pressure reduction in recursive miniscript analysisHard-coded threshold lowered to prevent large dynamic-programming tablesNew unit test checks rejection of oversized thresh fragments
97ad772aby Salvatore Ingala+38−33 files
No security note in commit
High 72 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Count miniscript wrappers in the parser's recursion depth limit

This commit fixes a bug in the Ledger Bitcoin app's wallet-policy parser. Miniscript 'wrappers' (short letters like 'n' that modify a policy) were not counted toward the parser's recursion-depth safety limit. A crafted wallet descriptor wi…

Stack-exhaustion / denial-of-service via crafted descriptor templateMissing recursion-depth accounting for parser-level wrapper expansionPatch adds explicit depth budget check and regression test
ed7cd029by Salvatore Ingala+75−63 files
Vendor flagged security relevance
Low 31 AI analysisMessage 50 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Delete MAX_POLICY_DEPTH; rather, align with MAX_PARSE_SCRIPT_RECURSION_DEPTH from the parsing stage

This commit changes how deeply nested Bitcoin wallet policies can be when processed by a Ledger hardware wallet app. It removes a separate, smaller limit (10 levels) and instead uses the same deeper limit already applied during an earlier …

Depth-limit constant unified across parsing and processing stagesRemoval of a stricter local limit that could create inconsistent policy acceptanceNo new input validation or memory safety bug introduced by the diff itself
bb5386b0by Salvatore Ingala+3−41 file
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix wrong comment in policy_node_thresh_t

This commit only changes a code comment to accurately describe how child scripts are stored. It does not alter any actual program logic, data structures, or behavior, so it has no security impact.

fbbdca3fby Salvatore Ingala+1−11 file
No security note in commit
Low 42 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Disable musig in key expressions of musig_a/sortedmulti_a

This commit temporarily blocks a specific advanced Bitcoin wallet feature (MuSig inside multi_a/sortedmulti_a) because the code that reads those wallet descriptions doesn't handle it correctly yet. It's a defensive change to prevent malfor…

Parser hardening for unsupported nested MuSig expressionsAddition of negative unit tests for malformed/unsupported policiesCommentary in code explicitly notes incompatibility and temporary disablement
558854ebby Salvatore Ingala+24−132 files
No security note in commit
Moderate 62 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Additional integrity checks for Merkle proofs

This commit adds extra safety checks when the Ledger Bitcoin app verifies Merkle proofs, which are cryptographic evidence used to confirm that a piece of data belongs to a larger set. The changes ensure that the proof length matches the ex…

Merkle proof length validation against leaf depthEnforcement of Merkle leaf prefix byte 0x00Prevention of streaming invalid preimage data before callback invocation
c44c9b8bby Salvatore Ingala+32−44 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 55 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add unit tests for get_merkle_preimage

This commit only adds new unit tests for existing code. It does not change any production behavior, fix a bug, or introduce new functionality. The tests verify that certain security checks (proof length and domain separator checks) already…

Test-only commit with no production code changesTests verify existing Merkle proof length validation rejects internal-node-as-leaf and overlong proofsTests verify existing leaf preimage domain-separator check rejects internal-node preimages and non-zero prefixes
05445baeby Salvatore Ingala+334−03 files
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Type consistency in psbt_parse_rawtx, and some other hardenings

This commit hardens a Bitcoin transaction parser in Ledger's app. It changes some numeric fields to safer types, adds bounds checks on transaction counts and sizes, rejects extra trailing bytes after a transaction, checks a previously-igno…

Integer type narrowing and sentinel change from -1 to SIZE_MAXBounds checks before uint64_t to unsigned int castsReturn value of parser_consolidate_buffers now checked
1af86279by Salvatore Ingala+66−173 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Sign consistency for parser steps; removed stale comment

This commit only changes the declared type of three array-length constants from signed int to unsigned size_t, and removes two stale comments about a 10,000-byte limit. There is no change to program logic, memory allocation, bounds checkin…

373f4a56by Salvatore Ingala+7−72 files
No security note in commit
Moderate 59 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Harden prevout tx parsing checks

This commit tightens how the Ledger Bitcoin app parses previous transaction data when signing Bitcoin transactions. It adds size limits and completion checks that prevent malformed or oversized previous transaction outputs from being proce…

Adds explicit bounds checks on prevout scriptPubKey lengthsSwitches signed integer length arithmetic to size_t to avoid negative-length edge casesAdds completion check for streamed raw previous transaction parsing
0df0add4by Salvatore Ingala+44−64 files
No security note in commit
Informational 18 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix taptree hash computation in test_utils

This commit fixes a copy-paste bug in test helper code used during automated testing of Ledger's Bitcoin app. The bug caused the right-hand branch of a Taproot script tree to be ignored and the left-hand branch to be hashed twice when comp…

Incorrect cryptographic hash construction in Taproot taptree root computationCopy-paste error causing left subtree to be hashed twice and right subtree omittedTest-only code path, not production firmware
7cba440aby Salvatore Ingala+6−52 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Do not truncate preset names

This commit removes manual shortening of preset names in a developer-only playground GUI and lets the UI toolkit handle truncation automatically. It is a cosmetic/usability fix with no apparent security relevance.

9f57d1a4by Salvatore Ingala+9−41 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedReplace VarInt with custom UncheckedVarIntby Salvatore Ingala · 6a66e4e2 · May 7, 2026 · 5 filesMessage 68 · AdequateLow 34Details
Commit message · Salvatore Ingala

Replace VarInt with custom UncheckedVarInt

rust-bitcoin version 0.32.9 started enforcing a consensus rule that
VarInt objects are at most 0x02000000, while the Bitcoin app
protocol uses it for arbitrary numbers up to 64 bits.

UncheckedVarInt works for any u64.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathparser or protocol pathsecond-pass: security-sensitive path
AI analysis · Low 34/100

This commit swaps the library's standard variable-length integer type for a custom one in Ledger's Bitcoin app client code. The change is needed because a newer version of the rust-bitcoin library started rejecting large varints that the Ledger protocol legitimately uses for non-Bitcoin data. The patch itself is a compatibility fix, not an obvious vulnerability, but it removes a safety boundary and any bugs in the new custom encoder/decoder could affect how the client talks to Ledger devices.

Lower-priorityenable build comparison and stack usage reportby Mathias BROUSSET · 12a7834f · May 4, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Mathias BROUSSET

enable build comparison and stack usage report

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only changes GitHub CI workflow settings. It turns on two build-reporting features: comparing compiled outputs across builds and reporting how much stack memory the app uses during tests. There is no change to the actual Bitcoin app code, no bug fix, and no security patch.

AI review queuedupdate crate deploymentby Mathias BROUSSET · 7d19c7a3 · May 4, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Mathias BROUSSET

update crate deployment

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit removes two lines from a GitHub Actions CI workflow file. It disables a JFrog deployment step and stops passing a Cargo crate publishing token to that workflow job. There is no change to the actual Bitcoin app code, cryptography, or anything users install on their Ledger devices. It is purely an internal adjustment to how a Rust client library crate is published.

Lower-priorityAdd missing length validation for V2 wallet policiesby Salvatore Ingala · a2ba8560 · May 4, 2026 · 1 fileMessage 73 · AdequateModerate 58Details
Commit message · Salvatore Ingala

Add missing length validation for V2 wallet policies

With V2 wallet policies, the preimage of the wallet policy is
requested after the wallet poicy header, which already declares its
length. Therefore, the length of the preimage should always match.

Thanks to Rob Hamilton for the bug report.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Moderate 58/100

This commit fixes a missing safety check in Ledger's Bitcoin app when handling newer 'V2 wallet policies.' The app was told in advance how long the wallet policy data should be, but it never verified that the actual data matched that length. The fix adds a simple comparison: if the lengths don't match, the app now rejects the request. The commit credits Rob Hamilton for reporting the bug, but no public security advisory or CVE is included in the materials.

Lower-priorityadd call to reusable_app_release.yml for github releasesby Mathias BROUSSET · 8423c8f0 · Apr 27, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Mathias BROUSSET

add call to reusable_app_release.yml for github releases

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit adds a new GitHub Actions workflow file that automatically creates a GitHub release whenever a version tag like '1.2.3' is pushed. It calls a reusable release workflow maintained by Ledger. There is no change to the Bitcoin app code, device firmware, or any user-facing security behavior. It is purely a CI/CD automation addition.

Lower-priorityConsistently use version 1 for the protocol version in js clientby Salvatore Ingala · e53bfcdc · Apr 24, 2026 · 1 fileMessage 73 · AdequateInformational 19Details
Commit message · Salvatore Ingala

Consistently use version 1 for the protocol version in js client

While the protocol version is ignored on INS=CONTINUE_INTERRUPTED,
both the python and the Rust client consistently use version 1 for
all APDUs.
There is no reason for the JS client to behave differently.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 19/100

This is a tiny consistency fix in the JavaScript client for the Ledger Bitcoin app. It changes one number in a command that resumes interrupted operations so it matches the Python and Rust clients. The app already ignores this version number for this specific command, so the change is unlikely to have any security effect on its own. It mainly removes an unexplained difference between client implementations.

AI review queuedTypo in commentby Salvatore Ingala · 3254b3fe · Apr 24, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Typo in comment

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit fixes a spelling mistake inside a code comment, removing an unnecessary semicolon. It does not change any executable code, logic, or behavior of the Bitcoin app.

Security candidatePartition sign_psbt.c into smaller submodulesby Salvatore Ingala · 64c53b1a · Apr 24, 2026 · 28 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Partition sign_psbt.c into smaller submodules

Also, updated the copyright notices, or added where missing.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing boundarycryptography-sensitive pathsigning or wallet path
AI analysis · Informational 15/100

This commit is a large but purely structural code cleanup: it splits the single large sign_psbt.c file into many smaller, focused source files under src/handler/sign_psbt/. The actual logic, function bodies, validation checks, and security-sensitive operations appear to be moved verbatim into the new modules, with only minor header/include adjustments and copyright-notice updates. There is no indication of a behavior change, bug fix, or security patch.

Security candidateAdd account context struct in sign_psbtby Salvatore Ingala · b7061e13 · Apr 24, 2026 · 3 filesMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Add account context struct in sign_psbt

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit is a straightforward internal code cleanup in Ledger's Bitcoin app. It groups several pieces of wallet-policy data into a new 'account context' structure and updates all references accordingly. There is no change to how transactions are validated, signed, or shown to the user, and no security bug is fixed or introduced in the visible diff.

Security candidatePartition init_global_state into smaller functionsby Salvatore Ingala · b0b6a1ad · Apr 24, 2026 · 2 filesMessage 73 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Partition init_global_state into smaller functions

Parsing the APDU, loading and verifying the wallet policy, and
parsing the global psbt map can be separated into independent
functions for simplicity.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit is a straightforward internal code cleanup: it splits one large function into three smaller, well-documented helper functions and moves one data field into a shared state structure. There is no change to what the code checks, accepts, or rejects. It does not fix a bug or add a security feature.

Security candidateParse unknown yielded tags in python client for sign_psbtby Salvatore Ingala · 027541a4 · Apr 23, 2026 · 3 filesMessage 73 · AdequateInformational 19Details
Commit message · Salvatore Ingala

Parse unknown yielded tags in python client for sign_psbt

This allows future-proofing the client by returning an explicit
unknown yielded value (that can safely be logged/ignored) instead
of returning an incorrect enormous 'input index'.

The Rust client uses the same approach.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundary
AI analysis · Informational 19/100

This is a small defensive update to the Python companion library for Ledger's Bitcoin app. It changes how the client handles unexpected data returned by a future version of the hardware app, so that the data is labeled as 'unknown' rather than being misread as a transaction input number. It is a robustness/future-proofing fix, not a patch for an active security flaw.

Lower-priorityFix unicode symbol presence (incorrectly handled by NBGL)by Ilya Artemov · 183b192a · Apr 23, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

Fix unicode symbol presence (incorrectly handled by NBGL)

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit changes a single character in a user-facing warning message. It replaces a curly apostrophe (’), which the Ledger NBGL user-interface library was not displaying correctly, with a straight apostrophe ('). There is no security vulnerability here; it is purely a display/rendering fix.

AI review queued[auto-update] Update Ragger snapshotsby github-actions[bot] · 80d58591 · Apr 23, 2026 · 18 filesMessage 45 · ThinInformational 15Details
Commit message · github-actions[bot]

[auto-update] Update Ragger snapshots

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates automated test screenshot snapshots for Ledger's Bitcoin app. No application code, firmware, or user-facing behavior was changed. It is not a security fix and does not affect real devices or user funds.

Lower-priorityUse default version for clang-formatby Salvatore Ingala · b3dd2112 · Apr 23, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Use default version for clang-format

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit removes a pinned version number from an automated code-style checker used in Ledger's Bitcoin app repository. It only affects how the project runs its internal linting workflow and does not change any application code, cryptographic logic, or user-facing behavior. There is no security relevance.

Security candidateGeneralize return value of sign_psbt in the Rust clientby Salvatore Ingala · dd9e3409 · Apr 23, 2026 · 8 filesMessage 85 · StrongInformational 18Details
Commit message · Salvatore Ingala

Generalize return value of sign_psbt in the Rust client

In order to support returning pubnonces and partial signatures for
Musig2 support, the objrects returned in sign_psbt are generalized
from PartialSignature to a SignPsbtYieldedObject enum.
This is a breaking change, therefore it requires a major release.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing boundarysigning or wallet pathparser or protocol path
AI analysis · Informational 18/100

This commit is a routine API update for the Ledger Bitcoin app's Rust client library. It changes what kind of data the library returns when a user signs a Bitcoin transaction (PSBT), so it can also return MuSig2 multi-signature material (public nonces and partial signatures) in addition to ordinary signatures. The commit message explicitly calls this a breaking change that requires a major release. There is no indication of a security bug being fixed or introduced.

Security candidateAdd sign_psbt test for MuSig round 1 and 2by Salvatore Ingala · a3120eca · Apr 23, 2026 · 2 filesMessage 55 · ThinInformational 15Details
Commit message · Salvatore Ingala

Add sign_psbt test for MuSig round 1 and 2

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit only adds new test cases for an existing feature (MuSig multi-signature signing) in the Rust client test suite. It does not change any production code, cryptographic logic, or application behavior. The changes are purely in test files: extending the test harness to check two new kinds of returned data (public nonces and partial signatures) and adding recorded device communication data for two MuSig signing scenarios. There is no indication of a security fix or vulnerability.

Lower-priorityBump Rust client version to 0.6.0by Salvatore Ingala · f5156ae3 · Apr 23, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Bump Rust client version to 0.6.0

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a routine version number bump for the Rust client package, changing it from 0.5.1 to 0.6.0. There is no code change, no security fix, and no functional change visible in the diff.

AI review queuedEnsure the policy_map_descriptor buffer is 0-terminatedby Salvatore Ingala · 24bd597e · Apr 22, 2026 · 1 fileMessage 50 · ThinModerate 63Details
Commit message · Salvatore Ingala

Ensure the policy_map_descriptor buffer is 0-terminated

Reported by Cerberus

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 63/100

This commit fixes a buffer handling bug in the Ledger Bitcoin app's wallet registration code. The app now reserves one extra byte for the wallet policy descriptor string and explicitly writes a null terminator (the 'end of string' marker). Without this fix, code that reads the descriptor as a text string could keep reading past the intended data, potentially leaking nearby memory or behaving unpredictably. The issue was reported by an external party called Cerberus.

AI review queuedMake sure has_wallet_policy is not used uninitializedby Salvatore Ingala · 192a2da2 · Apr 22, 2026 · 2 filesMessage 73 · AdequateLow 48Details
Commit message · Salvatore Ingala

Make sure has_wallet_policy is not used uninitialized

In the streaming case, a stale has_wallet_policy that is set to
true would lead to the previous wallet name being shown (if any).

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 48/100

This commit fixes a bug in the Ledger Bitcoin app where a flag indicating whether a wallet policy name should be shown could be left in an old/stale state during streaming transaction reviews. In practice, if a user had previously reviewed a transaction with a named wallet policy, a later transaction that should not show that name might incorrectly reuse the old name on screen. This is a user-interface consistency bug that could mislead the user about which wallet policy is authorizing a spend, but it does not directly expose private keys or allow unauthorized signing.

AI review queuedMake sure k <= n when parsing threshby Salvatore Ingala · 597b161a · Apr 22, 2026 · 1 fileMessage 45 · ThinModerate 59Details
Commit message · Salvatore Ingala

Make sure k <= n when parsing thresh

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This commit fixes a missing safety check in the Ledger Bitcoin app's wallet policy parser. When reading a 'thresh(...)' policy (a multi-signature rule like '2 of 3 signatures needed'), the app now verifies that the required number of signatures (k) is not greater than the total number of available signers (n). Without this check, a malformed policy could ask for more signatures than keys exist, which could lead to an unusable or non-standard wallet policy being accepted by the device.

AI review queuedAdd failing unit test for thresh parsingby Salvatore Ingala · 02ee776f · Apr 22, 2026 · 1 fileMessage 55 · ThinLow 27Details
Commit message · Salvatore Ingala

Add failing unit test for thresh parsing

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 27/100

This commit only adds two new test cases to the project's unit tests. The tests check that the wallet policy parser correctly rejects 'thresh' descriptors with an invalid threshold number (zero or larger than the number of available sub-policies). It does not change any production code. The commit itself is a test-only change and appears to be preparing the ground for a later fix, but it signals that the developers have identified a parsing edge case that currently fails.

AI review queuedStore opreturn_amount as uint64_t in cross-chain swapsby Salvatore Ingala · a6470681 · Apr 22, 2026 · 1 fileMessage 65 · AdequateModerate 58Details
Commit message · Salvatore Ingala

Store opreturn_amount as uint64_t in cross-chain swaps

This prevents possible truncation problems

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 58/100

This commit fixes a variable type in Ledger's Bitcoin app used during cross-chain cryptocurrency swaps. The amount attached to an OP_RETURN output was being stored in a `size_t` variable, which on Ledger's embedded device is likely 32 bits, while the actual amount is a 64-bit value. This mismatch could cause the amount to be silently truncated (cut off), potentially allowing a swap to be validated with an incorrect amount. The fix changes the variable to `uint64_t` to match the real data size and prevent truncation.

AI review queuedUpdate ragger snapshotsby Salvatore Ingala · 92fe8e4a · Apr 22, 2026 · 10 filesMessage 28 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Update ragger snapshots

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates test screenshot snapshots (expected device screen images used by automated tests). No application code, firmware logic, or user-facing behavior was changed. It is not a security fix and does not introduce a vulnerability.

Security candidateImprove tests for replace_musigsby Salvatore Ingala · 25e77a99 · Apr 21, 2026 · 1 fileMessage 68 · AdequateInformational 14Details
Commit message · Salvatore Ingala

Improve tests for replace_musigs

- use the canonical /<0;1>/* derivation steps
- add a test with empty musig
- add a test with two separate musig() expressions

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
cryptography-sensitive path
AI analysis · Informational 14/100

This commit only changes test code for a Bitcoin descriptor helper. It updates existing test strings to use a newer standard derivation format and adds two new test cases (an empty multi-signature expression and a descriptor containing two separate multi-signature expressions). There is no change to production code, no fix, and no security-relevant behavior change.

Security candidateAdd support for "musig()" in the rust clientby Salvatore Ingala · 244d6027 · Apr 21, 2026 · 4 filesMessage 80 · StrongLow 26Details
Commit message · Salvatore Ingala

Add support for "musig()" in the rust client

Since rust-miniscript currently doesn't support musig() key
expressions, it cannot be used for the calculation of addresses
for such wallet policies in the client.

Similarly to the python client, this implements the minimal code
for BIP327- and BIP328-complient key aggregation, in order to
replace musig() with the corresponding synthetic xpub, before
computing the address using rust-miniscript.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
secret or key materialcryptography-sensitive path
AI analysis · Low 26/100

This commit adds code to the Ledger Bitcoin app's Rust client that pre-processes wallet descriptors containing 'musig(...)' key groups before computing addresses. It implements a small BIP-327/BIP-328 key aggregation so the existing miniscript library can still parse the descriptor. It is a feature addition, not a reported vulnerability fix, but any new cryptographic code can introduce bugs that could cause wrong addresses or, in the worst case, weaken security if implemented incorrectly.