LD
← All projectsLedger

Ledger Bitcoin app

Open-source Bitcoin application running on Ledger devices; the device OS is outside this repository.

BitcoinHardware walletsNormal
Repository coverage

301 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

75security candidates126second-pass queue298AI analyses
51commits · 30 days
82commits · 60 days
231commits · 180 days
301commits · 365 days
Backfill bands
Aug 5 → Feb 670 seen8 candidatesComplete
Feb 6 → Jun 6149 seen21 candidatesComplete
Jun 6 → Jul 623 seen0 candidatesComplete
Jul 6 → Aug 555 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

51/100 average clarity
13Strong · 80–100
76Adequate · 60–79
157Thin · 40–59
55Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Salvatore Ingala16748167455
Ilya Artemov952692145
github-actions[bot]17117046
Mathias BROUSSET14014040
José Luis Landabaso Díaz404067
Cerberus Merlin101062
iartemov-ledger101043
Michael Evans101073
Charles-Edouard de la Vergne101045
Analysis record

Published AI watches

Last scanned 57 minutes ago

Moderate 59 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #542 from LedgerHQ/musig-fixes

This commit fixes missing error handling in the Ledger Bitcoin app's MuSig2 multi-signature code. Several cryptographic functions could fail silently or return incorrect results because their error codes were ignored. The patch now checks …

Missing error propagation in cryptographic point operationsUnchecked return value of crypto_tr_lift_x could lead to use of an unspecified pointUnchecked point_add return value in key aggregation, nonce aggregation, and tweaking
0fec192fby Salvatore Ingala+21−63 files
No security note in commit
Moderate 59 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix missing return value checks for point_add calls

This commit fixes three places in the Ledger Bitcoin app's MuSig2 code where the result of an elliptic-curve point-addition operation was not checked for failure. If point_add fails (for example, because it produced the special 'point at i…

Unchecked cryptographic operation return value (point_add)Potential use of invalid/infinite elliptic-curve point in MuSig2 aggregationMuSig2 nonce aggregation failure path now returns correct cosigner index
b1132395by Salvatore Ingala+14−52 files
No security note in commit
Moderate 59 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Propagate crypto_tr_lift_x errors in cpoint

This commit fixes a small but meaningful bug in the Ledger Bitcoin app's code that handles advanced multi-signature (MuSig) operations. A function called crypto_tr_lift_x can fail when given an invalid x-coordinate that does not correspond…

Unchecked return value from cryptographic point-lifting functionPotential use of invalid/uninitialized curve point in MuSig signing flowMissing error propagation in compressed public-key parsing
18647877by Salvatore Ingala+7−12 files
No security note in commit
High 72 AI analysisMessage 58 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #539 from LedgerHQ/fix-stack-exhaustion

This update fixes a stack-exhaustion weakness in Ledger's Bitcoin app. A malicious or unusually crafted wallet policy (the text string that describes how coins can be spent) could make the app recurse so deeply that it runs out of call sta…

Stack exhaustion / unbounded recursion in policy parsing and validationMissing depth accounting for miniscript wrapper chainsLarge automatic arrays inside recursive functions (compute_thresh_ops / compute_thresh_stacksize)
1621b7faby Salvatore Ingala+371−1427 files
Vendor flagged security relevance
Low 41 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reduce the stack frame of key_orderings_count

This commit rewrites a function in the Ledger Bitcoin app to use less memory. The old code stored a large table of key-derivation pairs for every possible class of key expression, which grew quadratically with the maximum number of key exp…

Large stack allocation removed (quadratic memory reduced to linear)Integer types narrowed based on stated boundsNo explicit security claim in commit message or diff comments
2e39aa2aby Salvatore Ingala+29−361 file
No security note in commit
Low 27 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Move the wallet confirmation stage out of the handler's frame

This commit refactors the Ledger Bitcoin app's wallet registration code so that the user-confirmation step runs in a separate function that the compiler is told not to inline. The stated goal is to reduce peak stack memory use by freeing l…

Stack memory layout hardening via noinline separation of validation and UI phasesReduction of peak stack footprint for deeply recursive policy validationRefactor only: no change to validation rules, cryptographic checks, or UI logic
ff2a7c7aby Salvatore Ingala+107−861 file
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Limit the amount of nesting for `thresh` fragments to 4

This commit fixes a stack-overflow risk in Ledger's Bitcoin app when parsing wallet policies that deeply nest 'thresh' miniscript fragments. It limits nesting to four levels and prevents two helper functions from being inlined so their lar…

Stack-frame bloat from inlined functions with large local arraysRecursive policy-tree walker with unbounded nested thresh inputPotential stack exhaustion / overflow on crafted miniscript policy
d4e23574by Salvatore Ingala+68−73 files
No security note in commit
Low 36 AI analysisMessage 55 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add functional tests for the policy depth limits

This commit adds automated tests to the Ledger Bitcoin app to check that very deep or heavily nested wallet policies are rejected safely. The tests confirm that an over-deep policy returns an error instead of freezing or crashing the devic…

Tests for policy recursion/depth limitsReference to app constants MAX_PARSE_SCRIPT_RECURSION_DEPTH and MAX_THRESH_NESTINGAssertion that over-deep policy does not crash the app
a81554f8by Salvatore Ingala+51−01 file
No security note in commit
Low 43 AI analysisMessage 70 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Lowers MAX_N_IN_THRESH to 24

This commit reduces a hard-coded limit in Ledger's Bitcoin app on how many branches a 'thresh' miniscript operator can have, from 128 down to 24. The change is framed as a memory-usage improvement, not a security fix. It also adds a test t…

Stack-memory pressure reduction in recursive miniscript analysisHard-coded threshold lowered to prevent large dynamic-programming tablesNew unit test checks rejection of oversized thresh fragments
97ad772aby Salvatore Ingala+38−33 files
No security note in commit
High 72 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Count miniscript wrappers in the parser's recursion depth limit

This commit fixes a bug in the Ledger Bitcoin app's wallet-policy parser. Miniscript 'wrappers' (short letters like 'n' that modify a policy) were not counted toward the parser's recursion-depth safety limit. A crafted wallet descriptor wi…

Stack-exhaustion / denial-of-service via crafted descriptor templateMissing recursion-depth accounting for parser-level wrapper expansionPatch adds explicit depth budget check and regression test
ed7cd029by Salvatore Ingala+75−63 files
Vendor flagged security relevance
Low 31 AI analysisMessage 50 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Delete MAX_POLICY_DEPTH; rather, align with MAX_PARSE_SCRIPT_RECURSION_DEPTH from the parsing stage

This commit changes how deeply nested Bitcoin wallet policies can be when processed by a Ledger hardware wallet app. It removes a separate, smaller limit (10 levels) and instead uses the same deeper limit already applied during an earlier …

Depth-limit constant unified across parsing and processing stagesRemoval of a stricter local limit that could create inconsistent policy acceptanceNo new input validation or memory safety bug introduced by the diff itself
bb5386b0by Salvatore Ingala+3−41 file
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix wrong comment in policy_node_thresh_t

This commit only changes a code comment to accurately describe how child scripts are stored. It does not alter any actual program logic, data structures, or behavior, so it has no security impact.

fbbdca3fby Salvatore Ingala+1−11 file
No security note in commit
Low 42 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Disable musig in key expressions of musig_a/sortedmulti_a

This commit temporarily blocks a specific advanced Bitcoin wallet feature (MuSig inside multi_a/sortedmulti_a) because the code that reads those wallet descriptions doesn't handle it correctly yet. It's a defensive change to prevent malfor…

Parser hardening for unsupported nested MuSig expressionsAddition of negative unit tests for malformed/unsupported policiesCommentary in code explicitly notes incompatibility and temporary disablement
558854ebby Salvatore Ingala+24−132 files
No security note in commit
Moderate 62 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Additional integrity checks for Merkle proofs

This commit adds extra safety checks when the Ledger Bitcoin app verifies Merkle proofs, which are cryptographic evidence used to confirm that a piece of data belongs to a larger set. The changes ensure that the proof length matches the ex…

Merkle proof length validation against leaf depthEnforcement of Merkle leaf prefix byte 0x00Prevention of streaming invalid preimage data before callback invocation
c44c9b8bby Salvatore Ingala+32−44 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 55 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add unit tests for get_merkle_preimage

This commit only adds new unit tests for existing code. It does not change any production behavior, fix a bug, or introduce new functionality. The tests verify that certain security checks (proof length and domain separator checks) already…

Test-only commit with no production code changesTests verify existing Merkle proof length validation rejects internal-node-as-leaf and overlong proofsTests verify existing leaf preimage domain-separator check rejects internal-node preimages and non-zero prefixes
05445baeby Salvatore Ingala+334−03 files
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Type consistency in psbt_parse_rawtx, and some other hardenings

This commit hardens a Bitcoin transaction parser in Ledger's app. It changes some numeric fields to safer types, adds bounds checks on transaction counts and sizes, rejects extra trailing bytes after a transaction, checks a previously-igno…

Integer type narrowing and sentinel change from -1 to SIZE_MAXBounds checks before uint64_t to unsigned int castsReturn value of parser_consolidate_buffers now checked
1af86279by Salvatore Ingala+66−173 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Sign consistency for parser steps; removed stale comment

This commit only changes the declared type of three array-length constants from signed int to unsigned size_t, and removes two stale comments about a 10,000-byte limit. There is no change to program logic, memory allocation, bounds checkin…

373f4a56by Salvatore Ingala+7−72 files
No security note in commit
Moderate 59 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Harden prevout tx parsing checks

This commit tightens how the Ledger Bitcoin app parses previous transaction data when signing Bitcoin transactions. It adds size limits and completion checks that prevent malformed or oversized previous transaction outputs from being proce…

Adds explicit bounds checks on prevout scriptPubKey lengthsSwitches signed integer length arithmetic to size_t to avoid negative-length edge casesAdds completion check for streamed raw previous transaction parsing
0df0add4by Salvatore Ingala+44−64 files
No security note in commit
Informational 18 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix taptree hash computation in test_utils

This commit fixes a copy-paste bug in test helper code used during automated testing of Ledger's Bitcoin app. The bug caused the right-hand branch of a Taproot script tree to be ignored and the left-hand branch to be hashed twice when comp…

Incorrect cryptographic hash construction in Taproot taptree root computationCopy-paste error causing left subtree to be hashed twice and right subtree omittedTest-only code path, not production firmware
7cba440aby Salvatore Ingala+6−52 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Do not truncate preset names

This commit removes manual shortening of preset names in a developer-only playground GUI and lets the UI toolkit handle truncation automatically. It is a cosmetic/usability fix with no apparent security relevance.

9f57d1a4by Salvatore Ingala+9−41 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidateDelete mock_include, rely on the speculos_bridge for all testsby Salvatore Ingala · 6f7b4472 · May 29, 2026 · 28 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Delete mock_include, rely on the speculos_bridge for all tests

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100

This commit is a test-only refactoring: it removes a set of local mock SDK headers and a software SHA-256 implementation used by unit tests, and instead makes those tests run against the real Ledger SDK headers through the existing Speculos emulator bridge. No production application code is changed, and there is no indication this fixes or introduces a security vulnerability.

Security candidateAdd minimal utility functions to work with serialized xpub in unit testsby Salvatore Ingala · 31a302d2 · May 29, 2026 · 4 filesMessage 75 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Add minimal utility functions to work with serialized xpub in unit tests

It is much cleaner than encoding in hex.

75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100

This commit only adds helper functions for unit tests to convert Bitcoin extended public keys (xpubs) between base58 string form and raw binary form. It does not change the actual Ledger app code that runs on the device, nor does it fix or introduce any security-relevant behavior. It is a test-code cleanup that replaces hard-coded hex byte arrays with readable xpub strings.

Security candidateLink unit tests with speculos implementations of crypto syscallsby Salvatore Ingala · 53a997c6 · May 29, 2026 · 6 filesMessage 75 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Link unit tests with speculos implementations of crypto syscalls

This allows writing unit tests for code that calls syscalls.
In this commit, tests for bip32_CKDpub are added.

75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
secret or key materialcryptography-sensitive path
AI analysis · Informational 15/100

This commit is purely about improving the project's automated test setup. It links unit tests to a software simulator (Speculos) so cryptographic code can be tested on a regular computer without a physical Ledger device. It adds tests for a Bitcoin key-derivation function and re-enables an existing test file. There is no change to the actual app code that runs on the device, and nothing in the commit suggests a security vulnerability or fix.

Security candidateAdd utilities to parse serialized PSBTs and mock its maps; added unit tests for extract_bip32_derivationby Salvatore Ingala · e7453297 · May 19, 2026 · 7 filesMessage 60 · AdequateInformational 14Details
Commit message · Salvatore Ingala

Add utilities to parse serialized PSBTs and mock its maps; added unit tests for extract_bip32_derivation

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
secret or key materialsigning boundarycryptography-sensitive pathsigning or wallet path
AI analysis · Informational 14/100

This commit only adds new unit-test helper code and test cases. It does not change the actual Ledger Bitcoin app that runs on the device, nor does it fix or alter any production security logic. The new files parse PSBT data and mock dispatcher responses so developers can test the existing `extract_bip32_derivation` function in isolation. Nothing here is shipped to users or reachable by an attacker.

Security candidateSimplify unit test setup/teardown, and allocate state on the heapby Salvatore Ingala · d4be5ca1 · May 19, 2026 · 12 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Simplify unit test setup/teardown, and allocate state on the heap

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100

This commit is a pure refactoring of the project's unit tests. It replaces manually initialized static mock dispatcher objects with heap-allocated ones managed by cmocka test fixtures, and moves hash-pool reset into the common setup function. There is no change to the actual Ledger Bitcoin app firmware or its security-critical code, so this commit does not introduce or fix any user-facing security vulnerability.

Security candidateMove some duplicated mocking code to headersby Salvatore Ingala · 3ac25325 · May 19, 2026 · 15 filesMessage 70 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Move some duplicated mocking code to headers

These lines where was also confusing gcov coverage measurements;
this should address it.

70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 15/100

This commit is a routine cleanup of the project's unit-test code. It removes duplicate mock implementations of a small helper function called `pic()` from 14 test files and places a single shared version in a mock header. The change only affects test code, not the actual Ledger Bitcoin app that runs on devices. The commit message says the cleanup was done to fix confusing code-coverage measurements. There is no indication this fixes a security vulnerability or changes how the app behaves.

Lower-priorityAdd tests for get_merkleized_map and get_merkleized_map_valueby Salvatore Ingala · 2f65cceb · May 19, 2026 · 3 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Add tests for get_merkleized_map and get_merkleized_map_value

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds new automated unit tests for two existing functions in Ledger's Bitcoin app. It does not change the actual app code that runs on devices, so it cannot introduce a security vulnerability or fix one by itself. The tests check that the functions correctly fetch and decode data from tamper-evident Merkle trees and reject malformed or corrupted inputs.

Security candidateAdditional unit testsby Salvatore Ingala · e130db4d · May 19, 2026 · 6 filesMessage 73 · AdequateInformational 12Details
Commit message · Salvatore Ingala

Additional unit tests

This reaches 100% coverage, except a few lines that can't be
covered (either gcov artifacts, or non-reachable code because of
defense-in-depth checks).

73/100 · AdequateMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
cryptography-sensitive path
AI analysis · Informational 12/100

This commit only adds new unit tests to the Ledger Bitcoin app. It does not change any production code, so it cannot introduce a security vulnerability or fix one directly. The tests exercise edge cases and adversarial inputs for functions that handle Merkle-tree preimages and BIP32 derivation extraction, which helps confirm existing defensive checks reject malformed data.

Security candidateNits from reviewby Salvatore Ingala · 9e23b56d · May 19, 2026 · 6 filesMessage 28 · OpaqueInformational 12Details
Commit message · Salvatore Ingala

Nits from review

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
cryptography-sensitive path
AI analysis · Informational 12/100

This commit is a small cleanup following a code review. It updates comments, adds safety checks to a test-only mock function, increases a test mock queue size, and adds a missing standard header include. None of the changes affect the real device firmware's security behavior.

Lower-priorityAdd various tests with client tamperingby Salvatore Ingala · 2e7ff701 · May 19, 2026 · 6 filesMessage 55 · ThinInformational 12Details
Commit message · Salvatore Ingala

Add various tests with client tampering

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 12/100

This commit only adds new unit tests that simulate a malicious or buggy companion app sending bad data to the Ledger device. It does not change the actual security code being tested. The tests check that the device-side functions correctly reject corrupted Merkle proofs, wrong leaf indices, bad preimage lengths, and interrupted communications. Because no production code is modified, the commit itself does not introduce or fix a vulnerability; it improves test coverage for existing defensive behavior.

Lower-priorityAdd tests for various Merkle-tree related functionalitiesby Salvatore Ingala · b4a43096 · May 19, 2026 · 9 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Add tests for various Merkle-tree related functionalities

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds new automated unit tests for Merkle-tree helper functions in the Ledger Bitcoin app. It does not change any production firmware code, so it cannot by itself introduce a security vulnerability or fix one. The tests exercise functions that verify Merkle proofs, retrieve leaf data, and stream key-value map entries.

Lower-priorityAdd reactive tampering functionality to mock dispatcherby Salvatore Ingala · 16ea324a · May 19, 2026 · 2 filesMessage 83 · StrongInformational 15Details
Commit message · Salvatore Ingala

Add reactive tampering functionality to mock dispatcher

A malicious client could tamper with the protocol arbitrarily.
This adds a way of modifying the responses of the mock dispatcher
in an arbitrary way, allowing to test more precise or malicious
behaviors.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only adds a new testing feature to the unit-test mock dispatcher. It lets test authors simulate a malicious client that tampers with protocol responses. It does not change the actual Ledger Bitcoin app code, does not introduce a real vulnerability, and is not a security fix. It is purely test infrastructure.

Security candidateAdd initial mock for the dispatcher, and tests for get_preimageby Salvatore Ingala · 5ac1ec68 · May 19, 2026 · 8 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Add initial mock for the dispatcher, and tests for get_preimage

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100

This commit only adds unit-test infrastructure: a mock implementation of the Ledger SDK dispatcher and SHA-256 hashing, plus tests for the get_preimage handler. It does not change any production code in the Bitcoin app, so it cannot introduce a runtime security vulnerability on its own.

AI review queuedImprove docs of get_merkle_preimage.h; remove stale TODOby Salvatore Ingala · 957eb8cd · May 19, 2026 · 2 filesMessage 30 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Improve docs of get_merkle_preimage.h; remove stale TODO

30/100 · OpaqueMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body! Contains work-in-progress language
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates comments and removes a stale TODO marker. No executable code, logic, or security behavior changed.

AI review queuedfix pypi deployby Mathias BROUSSET · 01133ef8 · May 18, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Mathias BROUSSET

fix pypi deploy

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit removes a single line from a GitHub Actions CI workflow file. The removed line disabled a JFrog deployment option for a Python package publishing job. It is a routine build/pipeline configuration fix with no apparent security relevance.

AI review queuedremove pypi tokenby Mathias BROUSSET · 42bdeb0f · May 18, 2026 · 1 fileMessage 28 · OpaqueLow 27Details
Commit message · Mathias BROUSSET

remove pypi token

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Low 27/100

This commit removes a PyPI (Python package publishing) API token from a public GitHub Actions workflow file. The change itself is a cleanup step, likely after the token was exposed or no longer needed. It does not show whether the token was ever valid, leaked, or misused, but removing exposed credentials is a standard security hygiene measure.

AI review queuedRefactor the common pre-pass between produce_musig2_pubnonces and sign_transactionby Salvatore Ingala · 8d96347b · May 11, 2026 · 1 fileMessage 50 · ThinInformational 13Details
Commit message · Salvatore Ingala

Refactor the common pre-pass between produce_musig2_pubnonces and sign_transaction

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 13/100

This commit is a straightforward code cleanup: it extracts a repeated block of code into a shared helper function. Two existing functions that previously each had their own nearly identical loop now call the helper instead. There is no change to what the code does, only to how it is organized.

Security candidateImprove signing performance in case of several internal keysby Salvatore Ingala · 1d2a4341 · May 11, 2026 · 1 fileMessage 73 · AdequateInformational 13Details
Commit message · Salvatore Ingala

Improve signing performance in case of several internal keys

Instead of structuring the sign_transaction and (musig2 pubnonces)
functions as iterating:

for all internal keys:
for all inputs:
<do stuff>

we reverse the nested loop to:

for all inputs
for all internal keys:
<do stuff>

This avoids processing all the psbt keys for the inputs once for
every key placeholder (running it instead once per input), with
no functional change.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 13/100

This commit is a performance optimization for the Ledger Bitcoin app. It reorders nested loops in two signing-related functions so that the app reads each transaction input's data once and then processes all relevant internal keys, rather than re-reading the input data once per key. The commit message and diff show no functional change—only a reduction in redundant work.

AI review queuedMove taptree hash computation in the inner loop of produce_musig2_pubnoncesby Salvatore Ingala · b0d900fd · May 11, 2026 · 1 fileMessage 50 · ThinInformational 17Details
Commit message · Salvatore Ingala

Move taptree hash computation in the inner loop of produce_musig2_pubnonces

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 17/100

This commit is a small performance refactor inside the Ledger Bitcoin app. It moves the calculation of a Taproot tree hash (used for advanced multi-signature scripts) so it only runs when actually needed, rather than once per input unconditionally. There is no direct evidence this fixes a security bug; it appears to be an optimization, though it slightly reduces the chance of unnecessary computation or state errors.

Lower-priorityRemove unnecessary port bindings in CI jobsby Salvatore Ingala · 8b4a901c · May 11, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Remove unnecessary port bindings in CI jobs

It might cause intermittent CI failures during container setup

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit removes unused network port mappings from GitHub Actions CI configuration files. It is a routine infrastructure cleanup to reduce random test failures when CI containers start up. It does not change any application code, cryptographic logic, or user-facing behavior, and it does not fix a security vulnerability.

Lower-priorityBump Rust client library to 0.6.2by Salvatore Ingala · 97ae5b41 · May 11, 2026 · 1 fileMessage 80 · StrongInformational 15Details
Commit message · Salvatore Ingala

Bump Rust client library to 0.6.2

Technical version bump to re-run the deployment pipeline.
No code changes versus the 0.6.1. Redeploying because the previous
deployment is missing the README.md on crates.io.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Informational 15/100

This commit only changes a version number in a packaging file from 0.6.1 to 0.6.2. The stated reason is to re-run the publishing process so the package page on crates.io includes the README file. No program code was modified, and there is no security relevance.

AI review queuedadd CODEOWNERSby Mathias BROUSSET · 4001e47f · May 7, 2026 · 1 fileMessage 18 · OpaqueInformational 15Details
Commit message · Mathias BROUSSET

add CODEOWNERS

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only adds a GitHub CODEOWNERS file that assigns the embedded-apps-bitcoin team as the default reviewer for all changes. It does not modify any application code, build scripts, or security-sensitive configuration.

Lower-priorityDelete legacy !IO_REVAMPED code, which is no longer usedby Salvatore Ingala · 1dfd28f0 · May 7, 2026 · 1 fileMessage 50 · ThinInformational 14Details
Commit message · Salvatore Ingala

Delete legacy !IO_REVAMPED code, which is no longer used

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 14/100

This commit removes an old, unused code path that handled device communication when a newer 'revamped' input/output system was not enabled. The change only deletes code that was already guarded by a compile-time flag and no longer used, with no functional change to the active system.

AI review queuedReplace VarInt with custom UncheckedVarIntby Salvatore Ingala · 6a66e4e2 · May 7, 2026 · 5 filesMessage 68 · AdequateLow 34Details
Commit message · Salvatore Ingala

Replace VarInt with custom UncheckedVarInt

rust-bitcoin version 0.32.9 started enforcing a consensus rule that
VarInt objects are at most 0x02000000, while the Bitcoin app
protocol uses it for arbitrary numbers up to 64 bits.

UncheckedVarInt works for any u64.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathparser or protocol pathsecond-pass: security-sensitive path
AI analysis · Low 34/100

This commit swaps the library's standard variable-length integer type for a custom one in Ledger's Bitcoin app client code. The change is needed because a newer version of the rust-bitcoin library started rejecting large varints that the Ledger protocol legitimately uses for non-Bitcoin data. The patch itself is a compatibility fix, not an obvious vulnerability, but it removes a safety boundary and any bugs in the new custom encoder/decoder could affect how the client talks to Ledger devices.

Security candidateEnsure the version of the transaction is 2 for all e2e testsby Salvatore Ingala · 0dd48467 · May 7, 2026 · 4 filesMessage 83 · StrongInformational 15Details
Commit message · Salvatore Ingala

Ensure the version of the transaction is 2 for all e2e tests

Some of the psbts generated in the test suite had nVersion = 1,
which made combinepsbt fail (since changing the nVersion results
in a different sighash).

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing boundary
AI analysis · Informational 15/100

This commit only changes automated test files. It forces the test transactions to use Bitcoin transaction version 2 so that a test helper called combinepsbt works correctly. There is no change to the actual Ledger app code that users run, and no security fix or vulnerability is present in the diff.