LD
← All projectsLedger

Ledger Bitcoin app

Open-source Bitcoin application running on Ledger devices; the device OS is outside this repository.

BitcoinHardware walletsNormal
Repository coverage

447 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

148security candidates154second-pass queue402AI analyses
19commits · 30 days
63commits · 60 days
249commits · 180 days
414commits · 365 days
Backfill bands
Aug 5 → Feb 670 seen8 candidatesComplete
Feb 6 → Jun 6149 seen21 candidatesComplete
Jun 6 → Jul 623 seen0 candidatesComplete
Jul 6 → Aug 555 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

57/100 average clarity
50Strong · 80–100
152Adequate · 60–79
186Thin · 40–59
59Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Salvatore Ingala2981122561062
Ilya Artemov962696145
Ruben Waterman666083
Aymeric Robert434063
github-actions[bot]17117046
Mathias BROUSSET17015039
José Luis Landabaso Díaz404067
iartemov-ledger201051
Cerberus Merlin101062
Michael Evans101073
Charles-Edouard de la Vergne101045
Analysis record

Published AI watches

Last scanned 56 minutes ago

Informational 20 AI analysisMessage 83 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

tests: pin all Python test dependencies to exact versions

This commit pins the exact versions of Python testing tools used by the project's automated tests. Previously, the test setup allowed any newly released version of those tools to be installed automatically, which could introduce unexpected…

Supply-chain risk reduction for test/CI dependenciesPrevents unreviewed automatic upgrades of speculos and raggerNo change to firmware or published package code
def417a3by Salvatore Ingala+329−142 files
No security note in commit
Informational 15 AI analysisMessage 38 · Opaque
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Bump version to 2.6.0

This commit is a routine version bump from 2.5.1 to 2.6.0 in the Ledger Bitcoin app. It only updates the version number in the Makefile and the release date in the CHANGELOG. There are no code changes, no bug fixes, and no security-related…

2b424b54by Salvatore Ingala+4−42 files
No security note in commit
Moderate 66 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #581 from LedgerHQ/client-fixes

This commit tightens how the Ledger Bitcoin app and its companion client libraries read PSBT (Partially Signed Bitcoin Transaction) data. It adds checks that reject malformed or suspicious PSBTs: truncated fields, unexpected extra bytes af…

Hardened PSBT deserialization against truncation and trailing dataAdded duplicate-key detection in PSBT mapsRejected PSBTv2-only fields inside PSBTv0 to prevent locktime/field override attacks
f8f790a3by Salvatore Ingala+544−17018 files
No security note in commit
Low 47 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

python client: reject PSBTv2-only fields in a PSBTv0

This commit tightens input validation in the Python helper library that prepares Bitcoin transaction data for Ledger hardware wallets. It now rejects PSBT files that claim to be the older version 0 format but contain fields that only belon…

Input-validation hardening: stricter parsing of PSBT version 0 to reject v2-only key typesConsistency fix across clients: aligns Python client with HS and Rust client behaviorLocktime normalization during v0-to-v2 conversion to prevent per-input locktime from overriding transaction locktime
84165be7by Salvatore Ingala+92−02 files
No security note in commit
Informational 24 AI analysisMessage 83 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

tests: update authproxy.py to the latest version from Bitcoin Core

This commit updates a test helper file used to talk to a Bitcoin node during automated testing. The old helper could accidentally send the same command twice if the network connection hiccuped, which could cause a test-only action like sen…

Removed transparent retry of non-idempotent RPC requests after connection resetsTest helper could execute state-changing RPCs twice before the fixNew connection-per-call configuration mitigates idle-timeout disconnects without retry risk
c7ca508eby Salvatore Ingala+91−522 files
Vendor flagged security relevance
Low 40 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject duplicate keys and trailing data when parsing a PSBT in the JS client

This commit fixes the JavaScript PSBT (Partially Signed Bitcoin Transaction) parser in Ledger's Bitcoin app so it now rejects malformed PSBTs that contain duplicate keys or extra trailing bytes. Previously, such malformed data could be acc…

BIP-174 non-compliance: duplicate keys and trailing data were previously acceptedState reuse bug: deserializing multiple PSBTs in the same instance could merge mapsInput validation gap in client-side PSBT parsing
4942a4aeby Salvatore Ingala+40−02 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

ragger: fail if a request succeeds without showing the expected screens

This commit fixes the automated test harness, not the Ledger Bitcoin app itself. Previously, the test framework could silently pass even when the device completed a request without showing the expected on-screen review. The change makes te…

Test-hardening only: no firmware or runtime application code changedFixes false-negative test results where a request could succeed without expected UI reviewCorrects scope of navigation settings to avoid leaking across nested or subsequent calls
202d352aby Salvatore Ingala+76−957 files
No security note in commit
Low 37 AI analysisMessage 88 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

unit tests: Fix length overflow in unit-test PSBT parser

This commit fixes an arithmetic overflow bug in a test-only PSBT (Bitcoin transaction format) parser used in unit tests. The bug could let a crafted test input make the parser think a data length is huge, potentially confusing the mock dis…

Integer overflow/wrap-around in length calculationOut-of-bounds length derived from arithmetic on attacker-influenced offsetsUnit-test-only code path, not device firmware
6a2a9262by Salvatore Ingala+6−21 file
No security note in commit
Low 48 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

rust client: reject PSBTv2-only fields when converting a PSBTv0

This commit fixes a bug in the Ledger Bitcoin app's Rust client where a PSBT v0 (an older transaction format) could silently carry fields that only have meaning in PSBT v2. When converting v0 to v2, those fields could override values taken…

Input validation added for cross-format PSBT conversionPrevents v2-only fields from overriding unsigned-transaction-derived valuesBIP-370 compliance enforcement for PSBTv0
602055d6by Salvatore Ingala+66−91 file
No security note in commit
Moderate 51 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject PSBTv2-only fields when converting a PSBTv0 in the JS client

This commit fixes a bug in the Ledger Bitcoin app's JavaScript client library. When converting an older-style Bitcoin transaction file (PSBT version 0) into the newer PSBT version 2 format, the library previously ignored fields that are on…

Input validation fix: rejects malformed PSBTv0 containing v2-only fieldsPrevents silent override of transaction locktime during PSBTv0-to-v2 conversionAdds missing BIP-370 key type constants for required time/height locktime
a1f6dc84by Salvatore Ingala+66−22 files
No security note in commit
High 72 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject duplicate keys and truncated maps when parsing PSBT maps in sign_psbt

This commit fixes a bug in how the Ledger Bitcoin app client parses PSBT (Partially Signed Bitcoin Transaction) maps. Previously, if the same key appeared twice in a map, the parser silently kept the last value. A malicious or malformed PS…

Silent overwrite of duplicate PSBT map keys could create commitment mismatch between client and deviceTruncated PSBT maps were silently accepted due to exception swallowing in deserialization loopsTrailing data after PSBT maps was ignored, allowing reserialization to silently normalize malformed inputs
75df80f9by Salvatore Ingala+107−104 files
Vendor flagged security relevance
High 72 AI analysisMessage 53 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #579 from LedgerHQ/misc-fixes

This commit fixes several bugs in Ledger's Bitcoin app. The most serious ones are: (1) a set of miniscript policy analyzer mistakes that could let the app accept Bitcoin wallet policies whose scripts are too large or too expensive to execu…

Miniscript cost/property analysis errors that could allow oversized/undercosted wallet policiesHost-driven infinite-loop / denial-of-service via zero-length GET_MORE_ELEMENTS responsesUI state inconsistency causing a security warning to be prematurely dismissed
ec389348by Salvatore Ingala+413−3113 files
No security note in commit
Low 26 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #576 from LedgerHQ/musig2_improvements

This commit improves the Ledger Bitcoin app's MuSig2 multi-signature feature. It lets wallet software pre-generate public nonces before a transaction is known, adds an optional MUSIG2_SESSION_ID field so multiple signing sessions can be in…

New PSBT proprietary field parsing with length validation (1-32 bytes, empty rejected)Session ID now commits to wallet policy plus optional MUSIG2_SESSION_IDSession storage limit raised from 8 to 32 with LRU eviction
26d22adcby Salvatore Ingala+710−7216 files
No security note in commit
Informational 18 AI analysisMessage 85 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Use signed scratch arrays in the thresh ops and stack size computations

This commit is a small code cleanup in Ledger's Bitcoin app. It changes two local arrays from unsigned (uint16_t) to signed (int16_t) in functions that count operations and stack sizes for Bitcoin miniscript 'thresh' policies. The commit m…

Signed/unsigned type mismatch in sentinel handlingPotential latent integer interpretation bug in miniscript threshold policy analysisCode clarity improvement around invalid (dis)satisfaction markers
4ff6f2f0by Salvatore Ingala+4−41 file
No security note in commit
Low 48 AI analysisMessage 91 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Align miniscript type and ops computations with bitcoin-core

This commit fixes the Ledger Bitcoin app's internal checker for Miniscript wallet policies. The checker was incorrectly rejecting some valid Bitcoin spending policies as unsafe, and in a few places it was computing safety properties using …

Logic change in Miniscript policy analysisAlignment with upstream Bitcoin Core reference implementationRelaxation of overly strict non-malleability and timelock-mixing checks
4694d317by Salvatore Ingala+26−132 files
No security note in commit
Moderate 68 AI analysisMessage 86 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix ops computation for andor fragments

This commit fixes a bug in how the Ledger Bitcoin app counts the number of Bitcoin script operations (ops) needed to spend certain wallet policies that use a 'miniscript andor' fragment. Because the count was wrong, the app could allow use…

Incorrect miniscript ops accounting for andor fragmentPolicy sanity check bypass leading to unspendable registered walletsReference alignment with Bitcoin Core implementation
86159d1eby Salvatore Ingala+40−13 files
Vendor flagged security relevance
High 74 AI analysisMessage 78 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix ops computation for l: and u: fragments

This commit fixes a bug in how the Ledger Bitcoin app counts Bitcoin script operations ('ops') for two specific Miniscript fragments, 'l:' and 'u:'. Because the count was too low, the app could accept wallet policies that look valid but ar…

Undercounting of script operation budget leading to acceptance of unspendable policiesIncorrect handling of Miniscript wrapper dissatisfaction semanticsPolicy sanity check bypass via operation-count accounting flaw
b6ac1de8by Salvatore Ingala+39−33 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

doc: document the MUSIG2_SESSION_ID PSBT field

This commit only updates documentation and the changelog. It explains a new optional PSBT field called MUSIG2_SESSION_ID that lets software wallets manage multiple MuSig2 signing sessions for the same wallet policy on a Ledger device. Ther…

8d8ed9afby Salvatore Ingala+28−62 files
No security note in commit
Informational 15 AI analysisMessage 78 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

musig_sessions: store up to 32 sessions

This commit is a simple capacity increase, not a security fix. It raises the number of simultaneous MuSig2 signing sessions the Ledger Bitcoin app can keep in memory from 8 to 32, because users with multiple MuSig accounts or wallets that …

a6798172by Salvatore Ingala+12−54 files
No security note in commit
Low 26 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

sign_psbt: fail before the UI if the MuSig2 session is missing

This commit improves the user experience and error handling for Ledger's Bitcoin app when using MuSig2 multi-signatures. Previously, if a required MuSig2 session was missing during the second round of signing, the device would only report …

UX-hardening: fail-fast before user approval instead of afterNew specific error code EC_SIGN_PSBT_MUSIG2_SESSION_NOT_FOUND for missing MuSig2 sessionsRefactored session storage lookup to support non-destructive existence check
2d04b144by Salvatore Ingala+118−187 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedHarden count_distinct_keys_info to correctly count the used keysby Salvatore Ingala · d94c51a2 · Aug 27, 2026 · 4 filesMessage 65 · AdequateModerate 67Details
Commit message · Salvatore Ingala

Harden count_distinct_keys_info to correctly count the used keys

This avoids registering wallet policies that contain unused xpubs
that are not referenced in the descriptor template.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Moderate 67/100

This commit fixes a bug in Ledger's Bitcoin app that could let a wallet policy slip through registration even when it contained unused or out-of-range public keys. The old code simply looked at the highest key index referenced in the wallet descriptor and assumed every key up to that number was used. That meant an attacker could craft a policy where the user's own key was listed as an unused extra key while the descriptor only required the attacker's key. The fix now explicitly counts which keys are actually referenced and rejects policies with gaps or unreferenced keys.

AI review queuedReject registering wallet policies with pubkeys not on the curveby Salvatore Ingala · d0c47c7a · Aug 27, 2026 · 1 fileMessage 73 · AdequateLow 44Details
Commit message · Salvatore Ingala

Reject registering wallet policies with pubkeys not on the curve

While this would be detected and fail at the first attempt at
deriving addresses from it, checking it early consts little.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 44/100

This commit adds an early safety check in the Ledger Bitcoin app. Before registering a new wallet policy, the app now verifies that each public key is a valid point on the Bitcoin elliptic curve. Previously, an invalid public key would only be caught later when trying to derive addresses. Catching it earlier prevents the device from storing a broken or potentially manipulated wallet policy.

Security candidateAdditional validation in crypto_get_uncompressed_pubkeyby Salvatore Ingala · d7fc0f8a · Aug 27, 2026 · 1 fileMessage 55 · ThinModerate 61Details
Commit message · Salvatore Ingala

Additional validation in crypto_get_uncompressed_pubkey

Return with error if:
- x is too large
- x^3 + 7 is not a quadratic residue

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Provides an explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Moderate 61/100

This commit tightens checks in a Ledger Bitcoin app function that converts compressed public keys into full (x,y) public key points. Previously, the code did not verify that the supplied x-coordinate is a valid field element (less than the curve prime p) and did not confirm that the computed y really satisfies the secp256k1 curve equation. The patch adds both checks, rejecting malformed keys. Without these checks, a specially crafted compressed key could cause the function to produce a point that is not actually on the Bitcoin curve, which could then be used in subsequent cryptographic operations in unexpected ways.

Security candidateAdd various unit tests for crypto_get_uncompressed_pubkeyby Salvatore Ingala · 327db310 · Aug 27, 2026 · 1 fileMessage 75 · AdequateInformational 12Details
Commit message · Salvatore Ingala

Add various unit tests for crypto_get_uncompressed_pubkey

This includes failure cases that will be fixed in the next commit.

75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
cryptography-sensitive path
AI analysis · Informational 12/100

This commit only adds new automated tests for an existing cryptography helper function. It does not change the actual app code that runs on Ledger devices, so it cannot by itself introduce or fix a security bug. The commit message notes that some of the new tests check failure cases that will be addressed in a later commit.

Security candidateCheck return value of crypto_get_uncompressed_pubkeyby Salvatore Ingala · 7c2354ba · Aug 27, 2026 · 1 fileMessage 65 · AdequateLow 42Details
Commit message · Salvatore Ingala

Check return value of crypto_get_uncompressed_pubkey

Failures should not silently absorb errors.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Low 42/100

This commit fixes a spot in the Ledger Bitcoin app where a function that converts a compressed public key to an uncompressed one was called without checking whether it succeeded. Before the fix, if the conversion failed, the code would keep going with potentially invalid data. After the fix, the function's return value is checked and the operation aborts with an error if something went wrong. The change is small and defensive, but it removes a silent-failure path in cryptographic key derivation.

Lower-priorityAdd validation of tree_size and leaf_index in call_get_merkle_leaf_hashby Salvatore Ingala · dba180f7 · Aug 27, 2026 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Salvatore Ingala

Add validation of tree_size and leaf_index in call_get_merkle_leaf_hash

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityAdd failing test for call_get_merkle_leaf_hashby Salvatore Ingala · 3dd1c61a · Aug 27, 2026 · 3 filesMessage 78 · AdequateTriage 5Details
Commit message · Salvatore Ingala

Add failing test for call_get_merkle_leaf_hash

If called with incorrect tree_size/leaf_index, it can return
without detecting the error.

This adds the regression test before committing the fix.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidence
Security candidateRemove unnecessary SDK includeby Salvatore Ingala · c4033d09 · Aug 25, 2026 · 2 filesMessage 50 · ThinInformational 15Details
Commit message · Salvatore Ingala

Remove unnecessary SDK include

We no longer access G_cx anywhere, so this is redundant.
Also remove unused imports in crypto.c.

50/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100

This commit is a routine code cleanup. It removes an unused SDK include path from the build configuration and deletes several unused header imports in a source file. There is no functional change and no security issue is indicated.

Lower-priorityRemove obsolete references to 8kb stack limit on Nano Xby Salvatore Ingala · 76ea81e4 · Aug 25, 2026 · 2 filesMessage 65 · AdequateTriage 0Details
Commit message · Salvatore Ingala

Remove obsolete references to 8kb stack limit on Nano X

Since the stack usage increased in the previous commit, we also
increase the APP_STACK_MIN_SIZE constant.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Security candidateMove sign_psbt cache inside the handlerby Salvatore Ingala · 67a1c45c · Aug 25, 2026 · 2 filesMessage 68 · AdequateInformational 12Details
Commit message · Salvatore Ingala

Move sign_psbt cache inside the handler

Using a global was a workaround around an old Nano X limitation on
the stack size, that has since been removed.

This reclaims about 2.5kb of memory from the .bss section, rather
allocating it on the stack during the sign_psbt flow.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 12/100

This commit is a straightforward internal code cleanup: it moves a temporary data cache used during Bitcoin transaction signing from a permanent global variable into a local stack variable inside the signing function. The change frees about 2.5 KB of always-reserved RAM and is described by the developer as removing an old workaround for a device stack-size limit that no longer exists. There is no indication in the commit that this fixes a security bug or changes behavior visible to users or attackers.

Lower-priorityMerge pull request #554 from LedgerHQ/mbr/ltoby Mathias BROUSSET · ea481818 · Aug 24, 2026 · 1 fileMessage 53 · ThinTriage 0Details
Commit message · Mathias BROUSSET

Merge pull request #554 from LedgerHQ/mbr/lto

enable LTO

53/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
merge-commit duplicate discount
AI review queuedenable LTOby Mathias BROUSSET · 9b42a195 · Aug 24, 2026 · 1 fileMessage 0 · OpaqueInformational 15Details
Commit message · Mathias BROUSSET

enable LTO

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit simply turns on Link Time Optimization (LTO), a standard compiler feature that can make the app smaller and faster. There is no indication of a security bug or fix in the change itself or the commit message.

Lower-priorityAlign cleartext test vectors with reference implementationby Salvatore Ingala · 610292a8 · Aug 21, 2026 · 3 filesMessage 95 · StrongTriage 13Details
Commit message · Salvatore Ingala

Align cleartext test vectors with reference implementation

The new test vectors ensure $keys does not bind to musig().

One of the new test vectors puts musig() inside a sortedmulti_a,
which this parser deliberately rejects (despite being technically
valid). Therefore, we explicitly mark it as an exception, by
creating a list of templates that this parser cannot parse, and
therefore cannot be exercised in the cleartext rendering.
An assertion validates that indeed the template does not parse, in
order to prevent future drift from going unnoticed.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
defensive validationfuzzing or regression evidence
AI review queuedSupport musig in multi_a key expressionsby Salvatore Ingala · 5622eec3 · Aug 21, 2026 · 8 filesMessage 78 · AdequateLow 29Details
Commit message · Salvatore Ingala

Support musig in multi_a key expressions

musig() is deliberately rejected in sortedmulti_a, where sorting the
keys would require recomputing each aggregate key once per position;
doc/musig.md now documents that.

Also update some imprecisions in the documentation about
MAX_PUBKEYS_PER_MUSIG.

Add positive tests for musig in multi_a, and rejection test for musig
in sortedmulti_a (where sorting makes things more complicated).

The cleartext module makes sure that $keys only matches plain keys,
and not musig-aggregate keys.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 29/100

This commit adds support for using MuSig multi-signature key groups inside taproot multi_a wallet policies on Ledger devices, while deliberately blocking them in sortedmulti_a. It also fixes a subtle parsing bug: previously, key expressions inside multi_a/sortedmulti_a were allocated one-by-one in a memory buffer, which would interleave badly with MuSig's own allocations and corrupt the in-memory layout. The new code parses all the keys into a temporary stack array first, then copies them into one contiguous allocation. Separately, the 'cleartext' human-readable display module now refuses to classify multisig patterns that contain musig keys, so the device falls back to showing the raw descriptor instead of potentially misleading text (for example, showing 'any 1 of two keys' for a musig that actually requires both).

Lower-priorityMerge pull request #553 from LedgerHQ/cargolockby Salvatore Ingala · c14c896e · Aug 20, 2026 · 2 filesMessage 68 · AdequateTriage 0Details
Commit message · Salvatore Ingala

Merge pull request #553 from LedgerHQ/cargolock

Commit Cargo.lock for the bitcoin app Rust client

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityCommit Cargo.lock for the bitcoin app Rust clientby Salvatore Ingala · 82f78025 · Aug 20, 2026 · 2 filesMessage 45 · ThinTriage 0Details
Commit message · Salvatore Ingala

Commit Cargo.lock for the bitcoin app Rust client

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Security candidateClear the output buffer on failures in merkle-tree related functionsby Salvatore Ingala · 240552f7 · Aug 20, 2026 · 18 filesMessage 73 · AdequateModerate 51Details
Commit message · Salvatore Ingala

Clear the output buffer on failures in merkle-tree related functions

As a defense-in-depth measure, we make sure that the output buffers are zeroed on
failures, preventing the attacker from leaving host-chosen content on uninitialized
buffers.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
explicit security language
AI analysis · Moderate 51/100

This commit hardens Ledger's Bitcoin app so that when it asks the host computer for Merkle-tree data and the request fails or the data is rejected, the memory buffer that was supposed to receive the data is wiped clean with zeros. Before the change, an attacker-controlled host could leave chosen bytes in that buffer even after the app decided the data was invalid. The patch is a defense-in-depth measure; it does not by itself fix a known exploitable bug, but it removes a class of subtle mistakes where later code might accidentally trust leftover hostile data.

Security candidateMerge pull request #502 from LedgerHQ/aro/fuzzing-frameworkby Aymeric Robert · ab26f04c · Aug 18, 2026 · 41 filesMessage 58 · ThinInformational 15Details
Commit message · Aymeric Robert

Merge pull request #502 from LedgerHQ/aro/fuzzing-framework

Add Absolution-based fuzzing

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
fuzzing or regression evidenceseed or entropy pathsigning or wallet pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit adds a new developer-only fuzzing test framework to the Ledger Bitcoin app. It does not change how the app behaves on a real device; it only adds automated test infrastructure that feeds random or structured inputs to the app in a simulated environment to help find bugs. There is no indication this commit fixes or introduces a security vulnerability in production code.

Security candidateDerive MuSig2 nonces from the untweaked aggregate keyby Salvatore Ingala · b56cf7ab · Aug 17, 2026 · 2 filesMessage 85 · StrongLow 30Details
Commit message · Salvatore Ingala

Derive MuSig2 nonces from the untweaked aggregate key

The `aggpk` argument passed to NonceGen was the aggregate key after all the
tweaks, which depends on the input's (change, address_index) and on the
taptree. This, however, depends on the transaction being signed, which in
some cases might not be known until round 2, since wallets might want to
pre-generate nonces in advance.

Therefore, we change the argument passed to `aggpk` so that it takes the
aggrgate key _before_ the tweaks.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
nonce handlingsigning or wallet path
AI analysis · Low 30/100

This commit changes how cryptographic 'nonces' (one-time random numbers used in multi-signature Bitcoin signing) are derived in Ledger's Bitcoin app. Previously, the nonce was tied to details of the exact transaction being signed, which could cause problems if a wallet wanted to prepare nonces before the final transaction was known. The change makes the nonce depend only on secret device randomness and wallet policy, not on transaction details. The commit frames this as a usability/protocol correctness improvement and explicitly states it is not a security vulnerability, because the old design still did not let an attacker predict or control the nonces.

Lower-priorityInitialize wallet_name on both paths of ui_display_wallet_addressby Salvatore Ingala · 34a4aa78 · Aug 17, 2026 · 1 fileMessage 65 · AdequateTriage 0Details
Commit message · Salvatore Ingala

Initialize wallet_name on both paths of ui_display_wallet_address

While it's only used for one path, zero-ing unconditionally is better hygiene.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityZero the transaction state in the streaming review entry pointby Salvatore Ingala · 7c646722 · Aug 17, 2026 · 1 fileMessage 65 · AdequateTriage 0Details
Commit message · Salvatore Ingala

Zero the transaction state in the streaming review entry point

This ensures that no state can cross boundaries from a past
streaming UX flow.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityClear the tag/value pool at the start of each reviewby Salvatore Ingala · 8aa0a7a6 · Aug 17, 2026 · 1 fileMessage 65 · AdequateTriage 0Details
Commit message · Salvatore Ingala

Clear the tag/value pool at the start of each review

Centralizes the initialization in a new `reset_flow_state()` function, and calls
it at the beginning of each UI flow.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI review queuedAdd functional test for stale review state across commandsby Salvatore Ingala · 29d8d61d · Aug 17, 2026 · 70 filesMessage 75 · AdequateLow 48Details
Commit message · Salvatore Ingala

Add functional test for stale review state across commands

Verified to fail on the parent of the previous commit.

75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Low 48/100

This commit only adds a new automated test, plus screen snapshots used by that test. The test checks that after signing a Bitcoin transaction (PSBT), then signing a text message, the device does not accidentally reuse leftover display settings from the previous operation. The commit message says the test would have failed on an older version of the app, implying a prior UI bug existed. However, this commit itself does not change the app code, so it is not a fix and cannot be directly exploited. It is a regression test that documents a previous display-state issue.

Lower-priorityFix broken comparisonby Salvatore Ingala · cd6d5f0c · Aug 14, 2026 · 1 fileMessage 51 · ThinTriage 0Details
Commit message · Salvatore Ingala

Fix broken comparison

With relative pointers, this check was just redundant; with
absolute pointers, it actually makes the comparison fail, as two
identical placeholders would still have different pointers.

51/100 · ThinMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context
Security candidateMerge pull request #533 from LedgerHQ/psbt_refactorby Salvatore Ingala · deaf1f3c · Aug 14, 2026 · 27 filesMessage 58 · ThinHigh 80Details
Commit message · Salvatore Ingala

Merge pull request #533 from LedgerHQ/psbt_refactor

Harden and refactor PSBT accessor API

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing boundarydefensive validationsigning or wallet pathmerge-commit duplicate discount
AI analysis · High 80/100

This commit is a hardening and refactor of the code that reads PSBT (Partially Signed Bitcoin Transaction) fields from a host computer into a Ledger hardware wallet. The core security fix is that the device now clearly distinguishes between a field that is genuinely missing in a PSBT map and a field that is present but malformed or failed to verify. Previously, both cases could return the same error code, which could trick the wallet into silently using a default value (for example, default nSequence or default locktime) when the host had actually committed to something else. The commit also adds a guard that refuses to look up values by key unless the map's keys have already been proven to be sorted and unique, preventing a malicious host from supplying two different values for the same key.