Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit fixes how Ledger's Bitcoin client libraries convert older PSBTv0 transaction data into the newer PSBTv2 format that Ledger hardware wallets expect. The changes correct several field-handling bugs: the transaction locktime is no…
PSBTv0-to-v2 conversion bug fixesMissing input sequence defaulted to 0xffffffff (final sequence)Locktime assigned to transaction object instead of PSBT object
This commit fixes a small bug in the Python helper library that builds unsigned Bitcoin transactions from PSBT data. Previously, if a PSBT did not explicitly include a per-input sequence number, the code would crash with an assertion error…
Behavioral change in transaction serialization helperRemoves an assertion that could cause crashes on valid PSBTs missing optional sequence fieldsAligns implementation with BIP-370 and HWI upstream behavior
This commit only updates a version number from 0.6.2 to 0.7.0 in two Rust package files. It is a routine bookkeeping change because the public interface of the PSBT module changed, requiring a minor version bump under semantic versioning r…
This commit only changes hardcoded test data used in JavaScript unit tests. It removes an invalid zero-value locktime field from two PSBT (Partially Signed Bitcoin Transaction) test fixtures so they conform to the BIP-370 standard. No prod…
This commit fixes three bugs in a Python helper that converts modern PSBTv2 transaction data into the older PSBTv0 format used by Ledger hardware wallets. The bugs could silently corrupt the transaction's lock time and version fields durin…
Silent data corruption in transaction serialization (nLockTime, tx_version, fallback_locktime)PSBTv2 to PSBTv0 conversion path affectedPotential for producing an unsigned transaction that does not match the PSBT's declared fields
This commit refactors how the Ledger Bitcoin app's Rust client converts a PSBT (Partially Signed Bitcoin Transaction) from version 0 to version 2. Previously, the code manually listed every PSBT field it knew how to serialize, which risked…
Refactor of PSBT serialization path used before signing on hardware walletRemoval of hand-maintained field enumeration that could omit or mis-serialize PSBT fieldsAddition of explicit error handling for PSBTs containing pre-existing v2 keys that conflict with v0 transaction data
This commit is a routine version bump from 2.5.0 to 2.5.1 for the Ledger Bitcoin app. It only updates the changelog and Makefile version number. No code changes are present in the diff, and no security fixes or vulnerabilities are describe…
This commit is a large internal refactoring of the Ledger Bitcoin app's wallet-policy parser. It replaces compact 'relative pointers' with ordinary memory pointers in the abstract syntax tree (AST) used to represent Bitcoin wallet descript…
Large-scale memory-layout refactoring of security-critical parserRemoval of custom relative-pointer abstraction, eliminating a class of offset-calculation bugsIncrease in policy buffer size limits and key-info length limits
This commit fixes a size limit in the Ledger Bitcoin app that was too small. The app uses this limit when registering Bitcoin wallet policies (descriptions of how to spend coins). The old limit underestimated how long a key description can…
Buffer/limit size correction for key origin infoRemoval of unused ledger_assert.h includeComment-only updates to serialized wallet policy length bounds
This commit removes an old memory workaround in Ledger's Bitcoin app. Previously, a large data structure used during transaction signing was stored in global memory instead of on the function's stack, because some Ledger devices were thoug…
Memory allocation model changed for high-risk signing pathStack-size build-time guard changed for Nano XGlobal cache removed; signing state now lives on stack
This commit simply renames an internal Python package from `embit` to `_embit` (a common convention indicating it is private/implementation detail) and updates all import statements accordingly. There is no functional code change and no se…
This update fixes a boundary bug in how the Ledger Bitcoin app parses wallet policies that use multi-path key expressions like /<M;N>/*. The app was supposed to reject hardened (high-security) derivation indexes, but it incorrectly allowed…
Boundary condition error: hardened derivation index 0x80000000 accepted as unhardenedWallet policy parser validation bypass in multi-path key expressionsRegression unit test added for hardened boundary rejection
This commit only adds 'U' suffixes to numeric constants in a header file and makes a few matching type adjustments in C source files so the code still compiles cleanly with strict compiler warnings. It is a code-quality cleanup, not a secu…
This commit changes a JavaScript package dependency from allowing any compatible 3.x version of @bitcoinerlab/descriptors to a fixed, exact version (3.1.7). Pinning a dependency is often done to prevent unexpected future changes, but the c…
Dependency version pinningNo explicit security claim in commit messageNo code-level security fix visible in diff
This commit fixes a boundary-check bug in how the Ledger Bitcoin app parses wallet policies (BIP-388). The app was supposed to reject any hardened derivation step in a specific range expression, but it allowed the value 2147483648 (0x80000…
Off-by-one boundary check in BIP-388 wallet policy parsingForbidden hardened derivation index accepted as unhardenedPotential failure or incorrect behavior in address derivation and signing
This commit only adds a new regression test to the Bitcoin app's test suite. The test checks that wallet policy key expressions reject a specific boundary value (2147483648, the first 'hardened' child index) where only 'unhardened' values …
Regression test for hardened/unhardened derivation index boundary parsingCommit message states older version accepted 0x80000000 as unhardenedNo production code change in this commit
This commit simply renames a vendored (internally bundled) copy of the 'embit' library inside the Python client from `embit` to `_embit`. The leading underscore is a Python convention meaning 'private/internal use only.' No code behavior c…
This commit adds a memory wipe of a cryptographic hash context after it is used to derive a secret random value in the Ledger Bitcoin app's MuSig multi-signature code. The change is described by the developer as a 'defense-in-depth' measur…
explicit_bzero added to clear sensitive cryptographic contextMuSig signing randomness treated as sensitive after partial signatures are knownDefense-in-depth memory hygiene patch
This commit fixes a bug in Ledger's Bitcoin app that could let a wallet policy slip through registration even when it contained unused or out-of-range public keys. The old code simply looked at the highest key index referenced in the walle…
Logic flaw in wallet policy validationPotential bypass of internal-key ownership check via unused key slotsBounds checking added for key indices
This commit adds an early safety check in the Ledger Bitcoin app. Before registering a new wallet policy, the app now verifies that each public key is a valid point on the Bitcoin elliptic curve. Previously, an invalid public key would onl…
Input validation added for cryptographic public key pointsInvalid curve points now rejected at wallet registration time rather than deferred to address derivationUse of standard status word SW_INCORRECT_DATA for malformed input
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
AI review queuedFor external input amounts, only show if trustworthyby Salvatore Ingala · 5174611d · Jul 24, 2026 · 5 filesMessage 85 · StrongModerate 66Details
Commit message · Salvatore Ingala
For external input amounts, only show if trustworthy
Because legacy and SegwitV0 sighash algorithm doesn't commit to the other inputs' amounts, the amount of external inputs is only trustworthy if validated via the non-witness-utxo. That is not a problem for taproot.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Moderate 66/100
This commit fixes a security issue in Ledger's Bitcoin app where the device could display a fake external input amount or fee to the user. When signing transactions with external inputs (coins controlled by someone else), the app previously trusted amounts supplied only via an unverified 'witness UTXO' for older SegWit v0 and legacy inputs. Because those signature types do not lock in the amounts of other inputs, a malicious computer could lie about how much those external inputs are worth, making the shown total, net amount, or fee look wrong while still producing a valid transaction. The fix hides the untrustworthy external-input total and fee in those cases, showing only the net amount the user's own account moves. For Taproot inputs, the amounts are cryptographically committed, so the full display remains.
AI review queuedTests for showing transactions with external inputsby Salvatore Ingala · aa796593 · Jul 23, 2026 · 3 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala
Tests for showing transactions with external inputs
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only adds and updates automated test code for the Ledger Bitcoin app. It introduces new test cases that verify how the device screen displays transactions containing external inputs and unusual signature rules. There are no changes to the actual app firmware, wallet logic, or security-critical code.
This commit only updates test screenshot images (snapshots) used to verify what the Ledger app displays during Bitcoin transaction signing. No application source code was changed, so this cannot directly fix or introduce a security vulnerability in the device app itself.
Security candidateDisplay total amount of external inputs when reliableby Salvatore Ingala · 26f631c5 · Jul 20, 2026 · 4 filesMessage 78 · AdequateInformational 21Details
Commit message · Salvatore Ingala
Display total amount of external inputs when reliable
While warning for the presence of external inputs remains necessary (certain attacks are possible), we can show additional info when the amount of external inputs is committed to (that is, when the sighash flag we're signing with does not have ANYONECANPAY, and therefore the signature commits to all inputs).
In that case, we can show: - The total amount of external inputs - The net spend (or receive) from/to the wallet policy, similarly to the transaction summary shown with certain sighash flags.
78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
explicit security languagesigning boundarysigning or wallet path
AI analysis · Informational 21/100
This commit changes what information the Ledger Bitcoin app shows on its screen when signing a transaction that includes 'external inputs'—coins the user did not provide and whose amounts the device cannot independently verify. Previously the app only warned that such inputs exist. After this change, when the signature commits to the full set of inputs (i.e., no ANYONECANPAY sighash flag), the app also displays the total value of those external inputs and the net amount the user's wallet is spending or receiving. This is a user-interface improvement intended to reduce confusion, not a fix for a code-execution or theft vulnerability. The underlying security model—external inputs are still 'unverified'—is unchanged.
Lower-priorityAdd to playground presets for sighash flags, and for external inputsby Salvatore Ingala · 8bf62f9a · Jul 20, 2026 · 4 filesMessage 50 · ThinInformational 15Details
Commit message · Salvatore Ingala
Add to playground presets for sighash flags, and for external inputs
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100
This commit only adds new developer-testing presets and a declarative helper for the project's internal 'playground' dev tool. It does not change the Ledger Bitcoin app firmware, wallet logic, or any code that end users rely on. There is no security fix or vulnerability introduced here.
Update txmaker to allow creating transactions with external inputs
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100
This commit only changes a test helper script (txmaker.py) used to build fake Bitcoin transactions for automated tests. It adds the ability to mark some inputs as 'external' (not owned by the wallet being tested) so the test suite can exercise transaction signing with mixed wallet and non-wallet inputs. There is no change to the actual Ledger app firmware or its security logic.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only updates test screenshot images (called 'Ragger snapshots') used to check what the Ledger device screen looks like during automated testing. No application code, firmware, or user-facing behavior was changed. It is not a security fix and does not affect users' devices or funds.
Lower-priorityAligning the streaming review to the normal one - using "To" for "Adddress"by Ilya Artemov · 0d4a7599 · Jul 17, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov
Aligning the streaming review to the normal one - using "To" for "Adddress"
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100
This commit changes a single label shown on Ledger hardware wallet screens during Bitcoin transaction review. The label 'Address' is renamed to 'To' in the streaming transaction review flow so it matches the regular (non-streaming) review flow. There is no code behavior change, no security fix, and no vulnerability.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 15/100
This commit only updates automated test screenshots (Ragger snapshots) for the Ledger Bitcoin app. No application code, firmware, or user-facing behavior was changed. It is not a security fix and does not introduce a vulnerability.
This commit only changes a GitHub Actions CI workflow file. It adds a new optional checkbox that lets maintainers choose to delete outdated test snapshot files when automatically regenerating snapshots during a manual test run. There is no change to the Bitcoin app code, device firmware, cryptography, or anything users install.
Trustworthy sign_psbt amount/fee display for non-default sighash: snapshots
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100
This commit only updates test screenshot snapshots for the Ledger Bitcoin app. It does not change any application source code, so it cannot directly fix or introduce a security vulnerability in the shipped app. The snapshots reflect new expected screen output after a prior code change that altered how amounts and fees are displayed when signing transactions with non-default Bitcoin sighash types.
Trustworthy sign_psbt amount/fee display for non-default sighash: integration tests
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 12/100
This commit only adds and updates automated integration tests for the Ledger Bitcoin app. It does not change the app's actual signing code. The tests verify that the device now shows clearer, more trustworthy on-screen amount and fee information when a transaction uses unusual Bitcoin signature modes (non-default 'sighash' types). Because no production firmware code is modified, there is no direct security vulnerability or fix introduced by this commit itself.
Trustworthy sign_psbt amount/fee display for non-default sighash: unit-tests
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundary
AI analysis · Informational 12/100
This commit only adds new automated unit tests for functions that decide how transaction amounts and fees are displayed on a Ledger device when signing a Bitcoin transaction with non-standard signature hash (sighash) modes. It does not change the actual signing or display logic, so by itself it cannot introduce or fix a security bug. The tests appear to be a companion to a separate code change that made the amount/fee display trustworthy for non-default sighash types.
Trustworthy sign_psbt amount/fee display for non-default sighash: implementation
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 59/100
This commit changes how the Ledger Bitcoin app shows transaction amounts and fees on the device screen when a user signs a transaction that does not use the normal 'sign everything' rule (a so-called non-default sighash). Previously the app might have displayed a fee or total that could actually change later, because some sighash types let other people add inputs or change outputs after the signature. Now the app detects those cases and either shows only the net amount the user is spending/receiving, or shows a warning that amounts cannot be verified. It also adds a 'Signing rule' line so the user knows the transaction is not fully committed.
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100
This commit adds a configuration file for Codecov, a service that tracks how much of the project's code is covered by automated tests. It only tells Codecov which folders to ignore and how to label different kinds of test coverage. It does not change any application code, security logic, or build process.
✓ Descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100
This commit only adds a new GitHub Actions CI job that runs automated test coverage reports for the Bitcoin app. It does not change any application code, wallet logic, or security behavior. There is no user-facing or security-relevant change.
AI review queuedAdd testcases with snapshots for multisig k-of-n and several taproot leavesby Salvatore Ingala · fd75dadd · Jul 17, 2026 · 108 filesMessage 50 · ThinInformational 15Details
Commit message · Salvatore Ingala
Add testcases with snapshots for multisig k-of-n and several taproot leaves
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only adds new test cases and screen snapshots for the Ledger Bitcoin app. It exercises two wallet-registration scenarios: a 2-of-3 multisig wallet and a Taproot wallet with multiple spending paths. There are no changes to the app's actual code, so this cannot introduce a security vulnerability or fix one in the shipped firmware.
Writing the struct directly is fragile, and risks incomplete initializations or non-zeroed fields 'leaking' into future calls.
We rather write a simple helper that creates the full struct with a literal, guaranteeing that everything that is not explicitly set is zeroed.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 26/100
This commit is a defensive code cleanup in the user-interface layer of Ledger's Bitcoin app. It replaces repeated manual setup of a display data structure with a single helper function that always zeroes out any fields the caller does not explicitly set. The change reduces the risk that leftover data from a previous screen could accidentally leak into a later one, but it does not by itself fix a known, exploitable bug.
AI review queuedAdd testcase for registering a policy with too high confusion scoreby Salvatore Ingala · 20963719 · Jul 17, 2026 · 1 fileMessage 83 · StrongInformational 15Details
Commit message · Salvatore Ingala
Add testcase for registering a policy with too high confusion score
The test verifies that register_wallet still succeeds, but showing the raw descriptor template (fallback to usual behavior) rather than the cleartext version.
Also, slightly refactored the shared code across unit tests.
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only adds a new unit test and refactors shared test helper code. It does not change the actual Ledger Bitcoin app firmware behavior. The new test verifies that when a wallet policy is too confusing to display safely, the app falls back to showing the raw technical descriptor instead of a user-friendly version. This is a defensive test for an existing safety mechanism, not a fix for a vulnerability.
cleartext: add BIP388 cleartext engine, codegen and CI check
Implements the confusion score and the cleartext representation for a large subset of commonly used wallet policies. This is the standalone engine layer: it compiles into the app but is not yet wired into any handler.
The classifier tables and AST matchers are generated from the TOML specs in specs/bip388/ by gen.py: - specs/bip388/cleartext.toml -> cleartext_specs.{h,c}, cleartext_match.c - specs/bip388/test_vectors.toml -> unit-tests/cleartext_vectors.inc.c The hand-written runtime (cleartext.c, cleartext_match.h) provides the scorer/encoder and the primitives the generated classifier calls into.
are_key_placeholders_identical() is exposed from policy.h for use by the encoder.
A CI job (cleartext-gen-check.yml) runs `gen.py --check` to ensure the committed generated files stay in sync with the TOML specs.
Mostly ported by Claude from the Rust reference implementation, with several iterations of review and refinement.
95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 12/100
This commit adds a new feature to the Ledger Bitcoin app that translates complex wallet policies into plain English for user review, plus a 'confusion score' to warn when a policy's description could match multiple different wallet setups. It is a large, self-contained addition of generated code, a code generator, specs, tests, and a CI check. The feature is not yet connected to any user-facing handler, so it cannot by itself change app behavior or expose secrets. Nothing in the commit message or diff describes this as a security fix or reports a vulnerability.
AI review queuedUpdate test snapshotsby Salvatore Ingala · a606e745 · Jul 17, 2026 · 229 filesMessage 38 · OpaqueInformational 15Details
Commit message · Salvatore Ingala
Update test snapshots
38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Mentions testing or verification! No meaningful explanatory body
This commit only updates test snapshot images (screenshots used for automated visual testing) for the Ledger Bitcoin app. No application source code, firmware logic, or user-facing behavior was changed. It is a routine test-maintenance update and has no security relevance on its own.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100
This commit only updates the changelog text. It documents a user-experience improvement that shows wallet policies in plain English on the Ledger device screen. There is no code change and no security fix or vulnerability present in the diff.
Lower-prioritycleartext: add unit tests for the cleartext engineby Salvatore Ingala · 178e2a43 · Jul 17, 2026 · 2 filesMessage 60 · AdequateInformational 12Details
Commit message · Salvatore Ingala
cleartext: add unit tests for the cleartext engine
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 12/100
This commit only adds new unit tests for an existing 'cleartext' feature in the Ledger Bitcoin app. It does not change any production code, fix a bug, or alter app behavior. The tests check how wallet descriptors are rendered into human-readable text and how a 'confusion score' is calculated. There is no security patch here.
AI review queuedShow cleartext representation of wallet policy, when possibleby Salvatore Ingala · f883a913 · Jul 17, 2026 · 7 filesMessage 83 · StrongInformational 22Details
Commit message · Salvatore Ingala
Show cleartext representation of wallet policy, when possible
Wires the cleartext engine into the register-wallet flow: the handler computes the confusion score and, when below the threshold, renders the cleartext spending-path lines shown before the raw descriptor template.
For multisig wallet policies specifically, this also simplifies the UX by omitting the raw descriptor template altogether. This is safe for such simple policies, with very little ambiguity. In the long term, we might be able to extend this to more complex wallet policies, but that needs to be done intentionally, and possibly be an opt-in feature that is explicitly requested by software wallets that adapt their own UX accordingly.
Unit tests of register_wallet had to be adapted slightly to take into account that the descriptor is not always shown.
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 22/100
This commit changes how Ledger devices display Bitcoin wallet policies during setup. Instead of always showing the raw technical descriptor, it tries to show a human-readable summary ("cleartext") of the spending rules. For simple multisig wallets, it hides the raw descriptor entirely because the plain-English summary is considered unambiguous. This is a UX improvement, not a fix for a known vulnerability, but it touches security-critical user confirmation code.
Lower-priorityapp-bitcoin-new rename to app-bitcoin - let's now use the docker image - already deployed after the push on developby Ilya Artemov · be18c501 · Jul 7, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov
app-bitcoin-new rename to app-bitcoin - let's now use the docker image - already deployed after the push on develop
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100
This commit simply updates a GitHub Actions workflow to use a renamed Docker container image. The old image name contained 'app-bitcoin-new' and the new name contains 'app-bitcoin'. This is a routine repository rename follow-up with no visible security relevance.
