What the developer wrote
Authored by Salvatore Ingala
Remove unnecessary SDK include
We no longer access G_cx anywhere, so this is redundant.
Also remove unused imports in crypto.c.
What changed, and why it matters
This commit is a routine code cleanup. It removes an unused SDK include path from the build configuration and deletes several unused header imports in a source file. There is no functional change and no security issue is indicated.
No action required. This is a benign cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit removes the INCLUDES_PATH pointing to the SDK’s lib_cxng/src directory because the code no longer references G_cx. It also removes unused imports (cx_ecfp.h, cx_ram.h, cx_ripemd160.h, cx_stubs.h, lcx_ripemd160.h, ox_ec.h) from src/crypto.c. This is a non-functional refactoring change with no patch of a vulnerability.
Changed components
Makefilesrc/crypto.cInspect captured patch +0 / −9
### Makefile
@@ -200,9 +200,6 @@ ifeq ($(DEBUG),10)
DEFINES += HAVE_SEMIHOSTED_PRINTF
endif
-# Needed to be able to include the definition of G_cx
-INCLUDES_PATH += $(BOLOS_SDK)/lib_cxng/src
-
########################################
# Features enablers #
########################################
### src/crypto.c
@@ -26,14 +26,8 @@
#include "bip32.h"
#include "crypto_helpers.h"
#include "cx.h"
-#include "cx_ecfp.h"
-#include "cx_ram.h"
-#include "cx_ripemd160.h"
-#include "cx_stubs.h"
#include "format.h"
-#include "lcx_ripemd160.h"
#include "os.h"
-#include "ox_ec.h"
#include "read.h"
#include "write.h"
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.