LD
← All projectsLedger

Ledger Bitcoin app

Open-source Bitcoin application running on Ledger devices; the device OS is outside this repository.

BitcoinHardware walletsNormal
Repository coverage

447 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

148security candidates154second-pass queue402AI analyses
19commits · 30 days
63commits · 60 days
249commits · 180 days
414commits · 365 days
Backfill bands
Aug 5 → Feb 670 seen8 candidatesComplete
Feb 6 → Jun 6149 seen21 candidatesComplete
Jun 6 → Jul 623 seen0 candidatesComplete
Jul 6 → Aug 555 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

57/100 average clarity
50Strong · 80–100
152Adequate · 60–79
186Thin · 40–59
59Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Salvatore Ingala2981122561062
Ilya Artemov962696145
Ruben Waterman666083
Aymeric Robert434063
github-actions[bot]17117046
Mathias BROUSSET17015039
José Luis Landabaso Díaz404067
iartemov-ledger201051
Cerberus Merlin101062
Michael Evans101073
Charles-Edouard de la Vergne101045
Analysis record

Published AI watches

Last scanned 44 minutes ago

Informational 20 AI analysisMessage 83 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

tests: pin all Python test dependencies to exact versions

This commit pins the exact versions of Python testing tools used by the project's automated tests. Previously, the test setup allowed any newly released version of those tools to be installed automatically, which could introduce unexpected…

Supply-chain risk reduction for test/CI dependenciesPrevents unreviewed automatic upgrades of speculos and raggerNo change to firmware or published package code
def417a3by Salvatore Ingala+329−142 files
No security note in commit
Informational 15 AI analysisMessage 38 · Opaque
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Bump version to 2.6.0

This commit is a routine version bump from 2.5.1 to 2.6.0 in the Ledger Bitcoin app. It only updates the version number in the Makefile and the release date in the CHANGELOG. There are no code changes, no bug fixes, and no security-related…

2b424b54by Salvatore Ingala+4−42 files
No security note in commit
Moderate 66 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #581 from LedgerHQ/client-fixes

This commit tightens how the Ledger Bitcoin app and its companion client libraries read PSBT (Partially Signed Bitcoin Transaction) data. It adds checks that reject malformed or suspicious PSBTs: truncated fields, unexpected extra bytes af…

Hardened PSBT deserialization against truncation and trailing dataAdded duplicate-key detection in PSBT mapsRejected PSBTv2-only fields inside PSBTv0 to prevent locktime/field override attacks
f8f790a3by Salvatore Ingala+544−17018 files
No security note in commit
Low 47 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

python client: reject PSBTv2-only fields in a PSBTv0

This commit tightens input validation in the Python helper library that prepares Bitcoin transaction data for Ledger hardware wallets. It now rejects PSBT files that claim to be the older version 0 format but contain fields that only belon…

Input-validation hardening: stricter parsing of PSBT version 0 to reject v2-only key typesConsistency fix across clients: aligns Python client with HS and Rust client behaviorLocktime normalization during v0-to-v2 conversion to prevent per-input locktime from overriding transaction locktime
84165be7by Salvatore Ingala+92−02 files
No security note in commit
Informational 24 AI analysisMessage 83 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

tests: update authproxy.py to the latest version from Bitcoin Core

This commit updates a test helper file used to talk to a Bitcoin node during automated testing. The old helper could accidentally send the same command twice if the network connection hiccuped, which could cause a test-only action like sen…

Removed transparent retry of non-idempotent RPC requests after connection resetsTest helper could execute state-changing RPCs twice before the fixNew connection-per-call configuration mitigates idle-timeout disconnects without retry risk
c7ca508eby Salvatore Ingala+91−522 files
Vendor flagged security relevance
Low 40 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject duplicate keys and trailing data when parsing a PSBT in the JS client

This commit fixes the JavaScript PSBT (Partially Signed Bitcoin Transaction) parser in Ledger's Bitcoin app so it now rejects malformed PSBTs that contain duplicate keys or extra trailing bytes. Previously, such malformed data could be acc…

BIP-174 non-compliance: duplicate keys and trailing data were previously acceptedState reuse bug: deserializing multiple PSBTs in the same instance could merge mapsInput validation gap in client-side PSBT parsing
4942a4aeby Salvatore Ingala+40−02 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

ragger: fail if a request succeeds without showing the expected screens

This commit fixes the automated test harness, not the Ledger Bitcoin app itself. Previously, the test framework could silently pass even when the device completed a request without showing the expected on-screen review. The change makes te…

Test-hardening only: no firmware or runtime application code changedFixes false-negative test results where a request could succeed without expected UI reviewCorrects scope of navigation settings to avoid leaking across nested or subsequent calls
202d352aby Salvatore Ingala+76−957 files
No security note in commit
Low 37 AI analysisMessage 88 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

unit tests: Fix length overflow in unit-test PSBT parser

This commit fixes an arithmetic overflow bug in a test-only PSBT (Bitcoin transaction format) parser used in unit tests. The bug could let a crafted test input make the parser think a data length is huge, potentially confusing the mock dis…

Integer overflow/wrap-around in length calculationOut-of-bounds length derived from arithmetic on attacker-influenced offsetsUnit-test-only code path, not device firmware
6a2a9262by Salvatore Ingala+6−21 file
No security note in commit
Low 48 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

rust client: reject PSBTv2-only fields when converting a PSBTv0

This commit fixes a bug in the Ledger Bitcoin app's Rust client where a PSBT v0 (an older transaction format) could silently carry fields that only have meaning in PSBT v2. When converting v0 to v2, those fields could override values taken…

Input validation added for cross-format PSBT conversionPrevents v2-only fields from overriding unsigned-transaction-derived valuesBIP-370 compliance enforcement for PSBTv0
602055d6by Salvatore Ingala+66−91 file
No security note in commit
Moderate 51 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject PSBTv2-only fields when converting a PSBTv0 in the JS client

This commit fixes a bug in the Ledger Bitcoin app's JavaScript client library. When converting an older-style Bitcoin transaction file (PSBT version 0) into the newer PSBT version 2 format, the library previously ignored fields that are on…

Input validation fix: rejects malformed PSBTv0 containing v2-only fieldsPrevents silent override of transaction locktime during PSBTv0-to-v2 conversionAdds missing BIP-370 key type constants for required time/height locktime
a1f6dc84by Salvatore Ingala+66−22 files
No security note in commit
High 72 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject duplicate keys and truncated maps when parsing PSBT maps in sign_psbt

This commit fixes a bug in how the Ledger Bitcoin app client parses PSBT (Partially Signed Bitcoin Transaction) maps. Previously, if the same key appeared twice in a map, the parser silently kept the last value. A malicious or malformed PS…

Silent overwrite of duplicate PSBT map keys could create commitment mismatch between client and deviceTruncated PSBT maps were silently accepted due to exception swallowing in deserialization loopsTrailing data after PSBT maps was ignored, allowing reserialization to silently normalize malformed inputs
75df80f9by Salvatore Ingala+107−104 files
Vendor flagged security relevance
High 72 AI analysisMessage 53 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #579 from LedgerHQ/misc-fixes

This commit fixes several bugs in Ledger's Bitcoin app. The most serious ones are: (1) a set of miniscript policy analyzer mistakes that could let the app accept Bitcoin wallet policies whose scripts are too large or too expensive to execu…

Miniscript cost/property analysis errors that could allow oversized/undercosted wallet policiesHost-driven infinite-loop / denial-of-service via zero-length GET_MORE_ELEMENTS responsesUI state inconsistency causing a security warning to be prematurely dismissed
ec389348by Salvatore Ingala+413−3113 files
No security note in commit
Low 26 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #576 from LedgerHQ/musig2_improvements

This commit improves the Ledger Bitcoin app's MuSig2 multi-signature feature. It lets wallet software pre-generate public nonces before a transaction is known, adds an optional MUSIG2_SESSION_ID field so multiple signing sessions can be in…

New PSBT proprietary field parsing with length validation (1-32 bytes, empty rejected)Session ID now commits to wallet policy plus optional MUSIG2_SESSION_IDSession storage limit raised from 8 to 32 with LRU eviction
26d22adcby Salvatore Ingala+710−7216 files
No security note in commit
Informational 18 AI analysisMessage 85 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Use signed scratch arrays in the thresh ops and stack size computations

This commit is a small code cleanup in Ledger's Bitcoin app. It changes two local arrays from unsigned (uint16_t) to signed (int16_t) in functions that count operations and stack sizes for Bitcoin miniscript 'thresh' policies. The commit m…

Signed/unsigned type mismatch in sentinel handlingPotential latent integer interpretation bug in miniscript threshold policy analysisCode clarity improvement around invalid (dis)satisfaction markers
4ff6f2f0by Salvatore Ingala+4−41 file
No security note in commit
Low 48 AI analysisMessage 91 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Align miniscript type and ops computations with bitcoin-core

This commit fixes the Ledger Bitcoin app's internal checker for Miniscript wallet policies. The checker was incorrectly rejecting some valid Bitcoin spending policies as unsafe, and in a few places it was computing safety properties using …

Logic change in Miniscript policy analysisAlignment with upstream Bitcoin Core reference implementationRelaxation of overly strict non-malleability and timelock-mixing checks
4694d317by Salvatore Ingala+26−132 files
No security note in commit
Moderate 68 AI analysisMessage 86 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix ops computation for andor fragments

This commit fixes a bug in how the Ledger Bitcoin app counts the number of Bitcoin script operations (ops) needed to spend certain wallet policies that use a 'miniscript andor' fragment. Because the count was wrong, the app could allow use…

Incorrect miniscript ops accounting for andor fragmentPolicy sanity check bypass leading to unspendable registered walletsReference alignment with Bitcoin Core implementation
86159d1eby Salvatore Ingala+40−13 files
Vendor flagged security relevance
High 74 AI analysisMessage 78 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix ops computation for l: and u: fragments

This commit fixes a bug in how the Ledger Bitcoin app counts Bitcoin script operations ('ops') for two specific Miniscript fragments, 'l:' and 'u:'. Because the count was too low, the app could accept wallet policies that look valid but ar…

Undercounting of script operation budget leading to acceptance of unspendable policiesIncorrect handling of Miniscript wrapper dissatisfaction semanticsPolicy sanity check bypass via operation-count accounting flaw
b6ac1de8by Salvatore Ingala+39−33 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

doc: document the MUSIG2_SESSION_ID PSBT field

This commit only updates documentation and the changelog. It explains a new optional PSBT field called MUSIG2_SESSION_ID that lets software wallets manage multiple MuSig2 signing sessions for the same wallet policy on a Ledger device. Ther…

8d8ed9afby Salvatore Ingala+28−62 files
No security note in commit
Informational 15 AI analysisMessage 78 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

musig_sessions: store up to 32 sessions

This commit is a simple capacity increase, not a security fix. It raises the number of simultaneous MuSig2 signing sessions the Ledger Bitcoin app can keep in memory from 8 to 32, because users with multiple MuSig accounts or wallets that …

a6798172by Salvatore Ingala+12−54 files
No security note in commit
Low 26 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

sign_psbt: fail before the UI if the MuSig2 session is missing

This commit improves the user experience and error handling for Ledger's Bitcoin app when using MuSig2 multi-signatures. Previously, if a required MuSig2 session was missing during the second round of signing, the device would only report …

UX-hardening: fail-fast before user approval instead of afterNew specific error code EC_SIGN_PSBT_MUSIG2_SESSION_NOT_FOUND for missing MuSig2 sessionsRefactored session storage lookup to support non-destructive existence check
2d04b144by Salvatore Ingala+118−187 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidateNits from reviewby Salvatore Ingala · 9e23b56d · May 19, 2026 · 6 filesMessage 28 · OpaqueInformational 12Details
Commit message · Salvatore Ingala

Nits from review

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
cryptography-sensitive path
AI analysis · Informational 12/100

This commit is a small cleanup following a code review. It updates comments, adds safety checks to a test-only mock function, increases a test mock queue size, and adds a missing standard header include. None of the changes affect the real device firmware's security behavior.

Security candidateAdd initial mock for the dispatcher, and tests for get_preimageby Salvatore Ingala · 5ac1ec68 · May 19, 2026 · 8 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Add initial mock for the dispatcher, and tests for get_preimage

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100

This commit only adds unit-test infrastructure: a mock implementation of the Ledger SDK dispatcher and SHA-256 hashing, plus tests for the get_preimage handler. It does not change any production code in the Bitcoin app, so it cannot introduce a runtime security vulnerability on its own.

Lower-priorityAdd tests for various Merkle-tree related functionalitiesby Salvatore Ingala · b4a43096 · May 19, 2026 · 9 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Add tests for various Merkle-tree related functionalities

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds new automated unit tests for Merkle-tree helper functions in the Ledger Bitcoin app. It does not change any production firmware code, so it cannot by itself introduce a security vulnerability or fix one. The tests exercise functions that verify Merkle proofs, retrieve leaf data, and stream key-value map entries.

Security candidateSimplify unit test setup/teardown, and allocate state on the heapby Salvatore Ingala · d4be5ca1 · May 19, 2026 · 12 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Simplify unit test setup/teardown, and allocate state on the heap

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100

This commit is a pure refactoring of the project's unit tests. It replaces manually initialized static mock dispatcher objects with heap-allocated ones managed by cmocka test fixtures, and moves hash-pool reset into the common setup function. There is no change to the actual Ledger Bitcoin app firmware or its security-critical code, so this commit does not introduce or fix any user-facing security vulnerability.

Lower-priorityAdd reactive tampering functionality to mock dispatcherby Salvatore Ingala · 16ea324a · May 19, 2026 · 2 filesMessage 83 · StrongInformational 15Details
Commit message · Salvatore Ingala

Add reactive tampering functionality to mock dispatcher

A malicious client could tamper with the protocol arbitrarily.
This adds a way of modifying the responses of the mock dispatcher
in an arbitrary way, allowing to test more precise or malicious
behaviors.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only adds a new testing feature to the unit-test mock dispatcher. It lets test authors simulate a malicious client that tampers with protocol responses. It does not change the actual Ledger Bitcoin app code, does not introduce a real vulnerability, and is not a security fix. It is purely test infrastructure.

Security candidateAdd utilities to parse serialized PSBTs and mock its maps; added unit tests for extract_bip32_derivationby Salvatore Ingala · e7453297 · May 19, 2026 · 7 filesMessage 60 · AdequateInformational 14Details
Commit message · Salvatore Ingala

Add utilities to parse serialized PSBTs and mock its maps; added unit tests for extract_bip32_derivation

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
secret or key materialsigning boundarycryptography-sensitive pathsigning or wallet path
AI analysis · Informational 14/100

This commit only adds new unit-test helper code and test cases. It does not change the actual Ledger Bitcoin app that runs on the device, nor does it fix or alter any production security logic. The new files parse PSBT data and mock dispatcher responses so developers can test the existing `extract_bip32_derivation` function in isolation. Nothing here is shipped to users or reachable by an attacker.

Security candidateMove some duplicated mocking code to headersby Salvatore Ingala · 3ac25325 · May 19, 2026 · 15 filesMessage 70 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Move some duplicated mocking code to headers

These lines where was also confusing gcov coverage measurements;
this should address it.

70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 15/100

This commit is a routine cleanup of the project's unit-test code. It removes duplicate mock implementations of a small helper function called `pic()` from 14 test files and places a single shared version in a mock header. The change only affects test code, not the actual Ledger Bitcoin app that runs on devices. The commit message says the cleanup was done to fix confusing code-coverage measurements. There is no indication this fixes a security vulnerability or changes how the app behaves.

Lower-priorityAdd tests for get_merkleized_map and get_merkleized_map_valueby Salvatore Ingala · 2f65cceb · May 19, 2026 · 3 filesMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Add tests for get_merkleized_map and get_merkleized_map_value

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds new automated unit tests for two existing functions in Ledger's Bitcoin app. It does not change the actual app code that runs on devices, so it cannot introduce a security vulnerability or fix one by itself. The tests check that the functions correctly fetch and decode data from tamper-evident Merkle trees and reject malformed or corrupted inputs.

AI review queuedImprove docs of get_merkle_preimage.h; remove stale TODOby Salvatore Ingala · 957eb8cd · May 19, 2026 · 2 filesMessage 30 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Improve docs of get_merkle_preimage.h; remove stale TODO

30/100 · OpaqueMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body! Contains work-in-progress language
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates comments and removes a stale TODO marker. No executable code, logic, or security behavior changed.

Security candidateAdditional unit testsby Salvatore Ingala · e130db4d · May 19, 2026 · 6 filesMessage 73 · AdequateInformational 12Details
Commit message · Salvatore Ingala

Additional unit tests

This reaches 100% coverage, except a few lines that can't be
covered (either gcov artifacts, or non-reachable code because of
defense-in-depth checks).

73/100 · AdequateMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
cryptography-sensitive path
AI analysis · Informational 12/100

This commit only adds new unit tests to the Ledger Bitcoin app. It does not change any production code, so it cannot introduce a security vulnerability or fix one directly. The tests exercise edge cases and adversarial inputs for functions that handle Merkle-tree preimages and BIP32 derivation extraction, which helps confirm existing defensive checks reject malformed data.

AI review queuedfix pypi deployby Mathias BROUSSET · 01133ef8 · May 18, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Mathias BROUSSET

fix pypi deploy

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit removes a single line from a GitHub Actions CI workflow file. The removed line disabled a JFrog deployment option for a Python package publishing job. It is a routine build/pipeline configuration fix with no apparent security relevance.

AI review queuedremove pypi tokenby Mathias BROUSSET · 42bdeb0f · May 18, 2026 · 1 fileMessage 28 · OpaqueLow 27Details
Commit message · Mathias BROUSSET

remove pypi token

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Low 27/100

This commit removes a PyPI (Python package publishing) API token from a public GitHub Actions workflow file. The change itself is a cleanup step, likely after the token was exposed or no longer needed. It does not show whether the token was ever valid, leaked, or misused, but removing exposed credentials is a standard security hygiene measure.

AI review queuedRefactor the common pre-pass between produce_musig2_pubnonces and sign_transactionby Salvatore Ingala · 8d96347b · May 11, 2026 · 1 fileMessage 50 · ThinInformational 13Details
Commit message · Salvatore Ingala

Refactor the common pre-pass between produce_musig2_pubnonces and sign_transaction

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 13/100

This commit is a straightforward code cleanup: it extracts a repeated block of code into a shared helper function. Two existing functions that previously each had their own nearly identical loop now call the helper instead. There is no change to what the code does, only to how it is organized.

Security candidateImprove signing performance in case of several internal keysby Salvatore Ingala · 1d2a4341 · May 11, 2026 · 1 fileMessage 73 · AdequateInformational 13Details
Commit message · Salvatore Ingala

Improve signing performance in case of several internal keys

Instead of structuring the sign_transaction and (musig2 pubnonces)
functions as iterating:

for all internal keys:
for all inputs:
<do stuff>

we reverse the nested loop to:

for all inputs
for all internal keys:
<do stuff>

This avoids processing all the psbt keys for the inputs once for
every key placeholder (running it instead once per input), with
no functional change.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 13/100

This commit is a performance optimization for the Ledger Bitcoin app. It reorders nested loops in two signing-related functions so that the app reads each transaction input's data once and then processes all relevant internal keys, rather than re-reading the input data once per key. The commit message and diff show no functional change—only a reduction in redundant work.

AI review queuedMove taptree hash computation in the inner loop of produce_musig2_pubnoncesby Salvatore Ingala · b0d900fd · May 11, 2026 · 1 fileMessage 50 · ThinInformational 17Details
Commit message · Salvatore Ingala

Move taptree hash computation in the inner loop of produce_musig2_pubnonces

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 17/100

This commit is a small performance refactor inside the Ledger Bitcoin app. It moves the calculation of a Taproot tree hash (used for advanced multi-signature scripts) so it only runs when actually needed, rather than once per input unconditionally. There is no direct evidence this fixes a security bug; it appears to be an optimization, though it slightly reduces the chance of unnecessary computation or state errors.

Lower-priorityRemove unnecessary port bindings in CI jobsby Salvatore Ingala · 8b4a901c · May 11, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Remove unnecessary port bindings in CI jobs

It might cause intermittent CI failures during container setup

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit removes unused network port mappings from GitHub Actions CI configuration files. It is a routine infrastructure cleanup to reduce random test failures when CI containers start up. It does not change any application code, cryptographic logic, or user-facing behavior, and it does not fix a security vulnerability.

Lower-priorityBump Rust client library to 0.6.2by Salvatore Ingala · 97ae5b41 · May 11, 2026 · 1 fileMessage 80 · StrongInformational 15Details
Commit message · Salvatore Ingala

Bump Rust client library to 0.6.2

Technical version bump to re-run the deployment pipeline.
No code changes versus the 0.6.1. Redeploying because the previous
deployment is missing the README.md on crates.io.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Informational 15/100

This commit only changes a version number in a packaging file from 0.6.1 to 0.6.2. The stated reason is to re-run the publishing process so the package page on crates.io includes the README file. No program code was modified, and there is no security relevance.

AI review queuedadd CODEOWNERSby Mathias BROUSSET · 4001e47f · May 7, 2026 · 1 fileMessage 18 · OpaqueInformational 15Details
Commit message · Mathias BROUSSET

add CODEOWNERS

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only adds a GitHub CODEOWNERS file that assigns the embedded-apps-bitcoin team as the default reviewer for all changes. It does not modify any application code, build scripts, or security-sensitive configuration.

Lower-priorityDelete legacy !IO_REVAMPED code, which is no longer usedby Salvatore Ingala · 1dfd28f0 · May 7, 2026 · 1 fileMessage 50 · ThinInformational 14Details
Commit message · Salvatore Ingala

Delete legacy !IO_REVAMPED code, which is no longer used

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 14/100

This commit removes an old, unused code path that handled device communication when a newer 'revamped' input/output system was not enabled. The change only deletes code that was already guarded by a compile-time flag and no longer used, with no functional change to the active system.

Security candidateEnsure the version of the transaction is 2 for all e2e testsby Salvatore Ingala · 0dd48467 · May 7, 2026 · 4 filesMessage 83 · StrongInformational 15Details
Commit message · Salvatore Ingala

Ensure the version of the transaction is 2 for all e2e tests

Some of the psbts generated in the test suite had nVersion = 1,
which made combinepsbt fail (since changing the nVersion results
in a different sighash).

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing boundary
AI analysis · Informational 15/100

This commit only changes automated test files. It forces the test transactions to use Bitcoin transaction version 2 so that a test helper called combinepsbt works correctly. There is no change to the actual Ledger app code that users run, and no security fix or vulnerability is present in the diff.

AI review queuedReplace VarInt with custom UncheckedVarIntby Salvatore Ingala · 6a66e4e2 · May 7, 2026 · 5 filesMessage 68 · AdequateLow 34Details
Commit message · Salvatore Ingala

Replace VarInt with custom UncheckedVarInt

rust-bitcoin version 0.32.9 started enforcing a consensus rule that
VarInt objects are at most 0x02000000, while the Bitcoin app
protocol uses it for arbitrary numbers up to 64 bits.

UncheckedVarInt works for any u64.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathparser or protocol pathsecond-pass: security-sensitive path
AI analysis · Low 34/100

This commit swaps the library's standard variable-length integer type for a custom one in Ledger's Bitcoin app client code. The change is needed because a newer version of the rust-bitcoin library started rejecting large varints that the Ledger protocol legitimately uses for non-Bitcoin data. The patch itself is a compatibility fix, not an obvious vulnerability, but it removes a safety boundary and any bugs in the new custom encoder/decoder could affect how the client talks to Ledger devices.

Lower-priorityBump Rust client library to 0.6.1by Salvatore Ingala · 7cc39189 · May 7, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Bump Rust client library to 0.6.1

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only changes a version number in a package configuration file from 0.6.0 to 0.6.1. There is no code change, no bug fix, and no security-related content visible in the diff.

Lower-priorityenable build comparison and stack usage reportby Mathias BROUSSET · 12a7834f · May 4, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Mathias BROUSSET

enable build comparison and stack usage report

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only changes GitHub CI workflow settings. It turns on two build-reporting features: comparing compiled outputs across builds and reporting how much stack memory the app uses during tests. There is no change to the actual Bitcoin app code, no bug fix, and no security patch.

AI review queuedupdate crate deploymentby Mathias BROUSSET · 7d19c7a3 · May 4, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Mathias BROUSSET

update crate deployment

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit removes two lines from a GitHub Actions CI workflow file. It disables a JFrog deployment step and stops passing a Cargo crate publishing token to that workflow job. There is no change to the actual Bitcoin app code, cryptography, or anything users install on their Ledger devices. It is purely an internal adjustment to how a Rust client library crate is published.

Lower-priorityAdd missing length validation for V2 wallet policiesby Salvatore Ingala · a2ba8560 · May 4, 2026 · 1 fileMessage 73 · AdequateModerate 58Details
Commit message · Salvatore Ingala

Add missing length validation for V2 wallet policies

With V2 wallet policies, the preimage of the wallet policy is
requested after the wallet poicy header, which already declares its
length. Therefore, the length of the preimage should always match.

Thanks to Rob Hamilton for the bug report.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Moderate 58/100

This commit fixes a missing safety check in Ledger's Bitcoin app when handling newer 'V2 wallet policies.' The app was told in advance how long the wallet policy data should be, but it never verified that the actual data matched that length. The fix adds a simple comparison: if the lengths don't match, the app now rejects the request. The commit credits Rob Hamilton for reporting the bug, but no public security advisory or CVE is included in the materials.