LD
← All projectsLedger

Ledger Bitcoin app

Open-source Bitcoin application running on Ledger devices; the device OS is outside this repository.

BitcoinHardware walletsNormal
Repository coverage

301 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

75security candidates126second-pass queue301AI analyses
51commits · 30 days
82commits · 60 days
231commits · 180 days
301commits · 365 days
Backfill bands
Aug 5 → Feb 670 seen8 candidatesComplete
Feb 6 → Jun 6149 seen21 candidatesComplete
Jun 6 → Jul 623 seen0 candidatesComplete
Jul 6 → Aug 555 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

51/100 average clarity
13Strong · 80–100
76Adequate · 60–79
157Thin · 40–59
55Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Salvatore Ingala16748167455
Ilya Artemov952695145
github-actions[bot]17117046
Mathias BROUSSET14014040
José Luis Landabaso Díaz404067
Cerberus Merlin101062
iartemov-ledger101043
Michael Evans101073
Charles-Edouard de la Vergne101045
Analysis record

Published AI watches

Last scanned 24 minutes ago

Moderate 59 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #542 from LedgerHQ/musig-fixes

This commit fixes missing error handling in the Ledger Bitcoin app's MuSig2 multi-signature code. Several cryptographic functions could fail silently or return incorrect results because their error codes were ignored. The patch now checks …

Missing error propagation in cryptographic point operationsUnchecked return value of crypto_tr_lift_x could lead to use of an unspecified pointUnchecked point_add return value in key aggregation, nonce aggregation, and tweaking
0fec192fby Salvatore Ingala+21−63 files
No security note in commit
Moderate 59 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix missing return value checks for point_add calls

This commit fixes three places in the Ledger Bitcoin app's MuSig2 code where the result of an elliptic-curve point-addition operation was not checked for failure. If point_add fails (for example, because it produced the special 'point at i…

Unchecked cryptographic operation return value (point_add)Potential use of invalid/infinite elliptic-curve point in MuSig2 aggregationMuSig2 nonce aggregation failure path now returns correct cosigner index
b1132395by Salvatore Ingala+14−52 files
No security note in commit
Moderate 59 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Propagate crypto_tr_lift_x errors in cpoint

This commit fixes a small but meaningful bug in the Ledger Bitcoin app's code that handles advanced multi-signature (MuSig) operations. A function called crypto_tr_lift_x can fail when given an invalid x-coordinate that does not correspond…

Unchecked return value from cryptographic point-lifting functionPotential use of invalid/uninitialized curve point in MuSig signing flowMissing error propagation in compressed public-key parsing
18647877by Salvatore Ingala+7−12 files
No security note in commit
High 72 AI analysisMessage 58 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #539 from LedgerHQ/fix-stack-exhaustion

This update fixes a stack-exhaustion weakness in Ledger's Bitcoin app. A malicious or unusually crafted wallet policy (the text string that describes how coins can be spent) could make the app recurse so deeply that it runs out of call sta…

Stack exhaustion / unbounded recursion in policy parsing and validationMissing depth accounting for miniscript wrapper chainsLarge automatic arrays inside recursive functions (compute_thresh_ops / compute_thresh_stacksize)
1621b7faby Salvatore Ingala+371−1427 files
Vendor flagged security relevance
Low 41 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reduce the stack frame of key_orderings_count

This commit rewrites a function in the Ledger Bitcoin app to use less memory. The old code stored a large table of key-derivation pairs for every possible class of key expression, which grew quadratically with the maximum number of key exp…

Large stack allocation removed (quadratic memory reduced to linear)Integer types narrowed based on stated boundsNo explicit security claim in commit message or diff comments
2e39aa2aby Salvatore Ingala+29−361 file
No security note in commit
Low 27 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Move the wallet confirmation stage out of the handler's frame

This commit refactors the Ledger Bitcoin app's wallet registration code so that the user-confirmation step runs in a separate function that the compiler is told not to inline. The stated goal is to reduce peak stack memory use by freeing l…

Stack memory layout hardening via noinline separation of validation and UI phasesReduction of peak stack footprint for deeply recursive policy validationRefactor only: no change to validation rules, cryptographic checks, or UI logic
ff2a7c7aby Salvatore Ingala+107−861 file
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Limit the amount of nesting for `thresh` fragments to 4

This commit fixes a stack-overflow risk in Ledger's Bitcoin app when parsing wallet policies that deeply nest 'thresh' miniscript fragments. It limits nesting to four levels and prevents two helper functions from being inlined so their lar…

Stack-frame bloat from inlined functions with large local arraysRecursive policy-tree walker with unbounded nested thresh inputPotential stack exhaustion / overflow on crafted miniscript policy
d4e23574by Salvatore Ingala+68−73 files
No security note in commit
Low 36 AI analysisMessage 55 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add functional tests for the policy depth limits

This commit adds automated tests to the Ledger Bitcoin app to check that very deep or heavily nested wallet policies are rejected safely. The tests confirm that an over-deep policy returns an error instead of freezing or crashing the devic…

Tests for policy recursion/depth limitsReference to app constants MAX_PARSE_SCRIPT_RECURSION_DEPTH and MAX_THRESH_NESTINGAssertion that over-deep policy does not crash the app
a81554f8by Salvatore Ingala+51−01 file
No security note in commit
Low 43 AI analysisMessage 70 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Lowers MAX_N_IN_THRESH to 24

This commit reduces a hard-coded limit in Ledger's Bitcoin app on how many branches a 'thresh' miniscript operator can have, from 128 down to 24. The change is framed as a memory-usage improvement, not a security fix. It also adds a test t…

Stack-memory pressure reduction in recursive miniscript analysisHard-coded threshold lowered to prevent large dynamic-programming tablesNew unit test checks rejection of oversized thresh fragments
97ad772aby Salvatore Ingala+38−33 files
No security note in commit
High 72 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Count miniscript wrappers in the parser's recursion depth limit

This commit fixes a bug in the Ledger Bitcoin app's wallet-policy parser. Miniscript 'wrappers' (short letters like 'n' that modify a policy) were not counted toward the parser's recursion-depth safety limit. A crafted wallet descriptor wi…

Stack-exhaustion / denial-of-service via crafted descriptor templateMissing recursion-depth accounting for parser-level wrapper expansionPatch adds explicit depth budget check and regression test
ed7cd029by Salvatore Ingala+75−63 files
Vendor flagged security relevance
Low 31 AI analysisMessage 50 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Delete MAX_POLICY_DEPTH; rather, align with MAX_PARSE_SCRIPT_RECURSION_DEPTH from the parsing stage

This commit changes how deeply nested Bitcoin wallet policies can be when processed by a Ledger hardware wallet app. It removes a separate, smaller limit (10 levels) and instead uses the same deeper limit already applied during an earlier …

Depth-limit constant unified across parsing and processing stagesRemoval of a stricter local limit that could create inconsistent policy acceptanceNo new input validation or memory safety bug introduced by the diff itself
bb5386b0by Salvatore Ingala+3−41 file
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix wrong comment in policy_node_thresh_t

This commit only changes a code comment to accurately describe how child scripts are stored. It does not alter any actual program logic, data structures, or behavior, so it has no security impact.

fbbdca3fby Salvatore Ingala+1−11 file
No security note in commit
Low 42 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Disable musig in key expressions of musig_a/sortedmulti_a

This commit temporarily blocks a specific advanced Bitcoin wallet feature (MuSig inside multi_a/sortedmulti_a) because the code that reads those wallet descriptions doesn't handle it correctly yet. It's a defensive change to prevent malfor…

Parser hardening for unsupported nested MuSig expressionsAddition of negative unit tests for malformed/unsupported policiesCommentary in code explicitly notes incompatibility and temporary disablement
558854ebby Salvatore Ingala+24−132 files
No security note in commit
Moderate 62 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Additional integrity checks for Merkle proofs

This commit adds extra safety checks when the Ledger Bitcoin app verifies Merkle proofs, which are cryptographic evidence used to confirm that a piece of data belongs to a larger set. The changes ensure that the proof length matches the ex…

Merkle proof length validation against leaf depthEnforcement of Merkle leaf prefix byte 0x00Prevention of streaming invalid preimage data before callback invocation
c44c9b8bby Salvatore Ingala+32−44 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 55 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add unit tests for get_merkle_preimage

This commit only adds new unit tests for existing code. It does not change any production behavior, fix a bug, or introduce new functionality. The tests verify that certain security checks (proof length and domain separator checks) already…

Test-only commit with no production code changesTests verify existing Merkle proof length validation rejects internal-node-as-leaf and overlong proofsTests verify existing leaf preimage domain-separator check rejects internal-node preimages and non-zero prefixes
05445baeby Salvatore Ingala+334−03 files
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Type consistency in psbt_parse_rawtx, and some other hardenings

This commit hardens a Bitcoin transaction parser in Ledger's app. It changes some numeric fields to safer types, adds bounds checks on transaction counts and sizes, rejects extra trailing bytes after a transaction, checks a previously-igno…

Integer type narrowing and sentinel change from -1 to SIZE_MAXBounds checks before uint64_t to unsigned int castsReturn value of parser_consolidate_buffers now checked
1af86279by Salvatore Ingala+66−173 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Sign consistency for parser steps; removed stale comment

This commit only changes the declared type of three array-length constants from signed int to unsigned size_t, and removes two stale comments about a 10,000-byte limit. There is no change to program logic, memory allocation, bounds checkin…

373f4a56by Salvatore Ingala+7−72 files
No security note in commit
Moderate 59 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Harden prevout tx parsing checks

This commit tightens how the Ledger Bitcoin app parses previous transaction data when signing Bitcoin transactions. It adds size limits and completion checks that prevent malformed or oversized previous transaction outputs from being proce…

Adds explicit bounds checks on prevout scriptPubKey lengthsSwitches signed integer length arithmetic to size_t to avoid negative-length edge casesAdds completion check for streamed raw previous transaction parsing
0df0add4by Salvatore Ingala+44−64 files
No security note in commit
Informational 18 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix taptree hash computation in test_utils

This commit fixes a copy-paste bug in test helper code used during automated testing of Ledger's Bitcoin app. The bug caused the right-hand branch of a Taproot script tree to be ignored and the left-hand branch to be hashed twice when comp…

Incorrect cryptographic hash construction in Taproot taptree root computationCopy-paste error causing left subtree to be hashed twice and right subtree omittedTest-only code path, not production firmware
7cba440aby Salvatore Ingala+6−52 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Do not truncate preset names

This commit removes manual shortening of preset names in a developer-only playground GUI and lets the UI toolkit handle truncation automatically. It is a cosmetic/usability fix with no apparent security relevance.

9f57d1a4by Salvatore Ingala+9−41 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityAdding exception for Electrum walletby Ilya Artemov · 9afe3e96 · Dec 15, 2025 · 1 fileMessage 45 · ThinLow 25Details
Commit message · Ilya Artemov

Adding exception for Electrum wallet

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 25/100

This commit changes the Ledger Bitcoin app's Makefile to add two extra allowed derivation paths alongside the standard Bitcoin paths. One path (4541509') appears to be a special Electrum wallet path, and the other (45') is the BIP-45 whole-tree path for multi-signature wallets. This is a configuration change that widens which key derivation paths the app can use, but it does not by itself look like a vulnerability fix or an exploit. It is more like a compatibility/permission update.

Lower-priorityBump version of JS client library to 2.3.0by Salvatore Ingala · 47bac89e · Dec 12, 2025 · 4 filesMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Bump version of JS client library to 2.3.0

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a routine packaging update for the JavaScript client library of Ledger's Bitcoin app. It bumps the version number, refreshes the package-lock.json dependency manifest, and makes two tiny configuration cleanups (removing an unused word from the spell-check dictionary and a redundant Prettier ESLint preset). There are no code changes that handle user data, cryptographic operations, or device communication, and nothing in the commit describes a security fix or vulnerability.

Lower-priorityMake the JS client accept the 'Bitcoin Recovery' appby Salvatore Ingala · 926a3209 · Dec 12, 2025 · 1 fileMessage 50 · ThinInformational 21Details
Commit message · Salvatore Ingala

Make the JS client accept the 'Bitcoin Recovery' app

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 21/100

This commit updates the JavaScript client for Ledger's Bitcoin app so it also recognizes an app named 'Bitcoin Recovery' as the main Bitcoin network app. Previously, only 'Bitcoin' and 'Bitcoin Test' were accepted. This is a small compatibility change and does not appear to be a security fix.

Lower-priorityRe-enabling test_get_extended_pubkey_non_standard for Speculos as now it is hardened thereby Ilya Artemov · 48189643 · Dec 11, 2025 · 1 fileMessage 50 · ThinInformational 17Details
Commit message · Ilya Artemov

Re-enabling test_get_extended_pubkey_non_standard for Speculos as now it is hardened there

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
defensive validation
AI analysis · Informational 17/100

This commit only changes a test file. It re-enables a previously skipped automated test for the Speculos simulator because the simulator now correctly blocks an insecure key-derivation operation that the real Ledger hardware already blocked. It also adds a comment explaining another test case. There is no change to the actual app code that users run on their devices.

Lower-priorityAdding COIN=bitcoin_recovery with all the paths permittedby Ilya Artemov · 19704263 · Dec 11, 2025 · 1 fileMessage 50 · ThinLow 42Details
Commit message · Ilya Artemov

Adding COIN=bitcoin_recovery with all the paths permitted

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 42/100

This commit adds a new build variant called 'bitcoin_recovery' to the Ledger Bitcoin app. Unlike the normal Bitcoin app, this variant allows all BIP32 derivation paths and is intended for recovery scenarios. The commit itself does not change runtime code; it only adds a Makefile option to compile a special recovery version of the app. Because it permits all paths, if this variant were loaded onto a device and used normally, it could weaken the usual path-restriction protections, but the commit explicitly frames it as a recovery tool and blocks the dangerous AUTOAPPROVE_FOR_PERF_TESTS flag for this variant.

AI review queuedFix JS-testsby Ilya Artemov · af826a1f · Dec 8, 2025 · 1 fileMessage 38 · OpaqueInformational 15Details
Commit message · Ilya Artemov

Fix JS-tests

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit updates a single test automation JSON file used in JavaScript tests. It changes a regular expression that matches on-screen text during automated device testing, replacing the keyword 'Key' with 'Our' and 'Their'. This is a test-only adjustment with no effect on the actual Ledger Bitcoin app firmware or its security.

AI review queued[auto-update] Update Ragger snapshotsby github-actions[bot] · e1b82eb1 · Dec 8, 2025 · 276 filesMessage 45 · ThinInformational 15Details
Commit message · github-actions[bot]

[auto-update] Update Ragger snapshots

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates screenshot files used for automated testing of the Ledger Bitcoin app. No application code, firmware, or user-facing behavior was changed. It is not a security fix and does not introduce a vulnerability.

Lower-priorityRearranging the key information so it fits without ...by Ilya Artemov · 2aeafd38 · Dec 8, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

Rearranging the key information so it fits without ...

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only changes the on-screen text shown when registering a Bitcoin wallet policy on a Ledger device. It rewords labels like 'ours' to 'Our' and shortens the format so the text fits on the device's small screen. There is no security-relevant change.

Lower-priorityConverting build warnings to errorsby Ilya Artemov · 871ec9d3 · Dec 4, 2025 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Ilya Artemov

Converting build warnings to errors

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit adds a compiler flag (-Werror) that turns all build warnings into errors. It is a build-hardening change, not a fix for a specific security bug. There is no evidence in the commit of any vulnerability, exploit, or affected code path.

Lower-priorityUsing generic and simpler format_sats_amount() for swap as wellby Ilya Artemov · b200772e · Dec 4, 2025 · 3 filesMessage 50 · ThinLow 26Details
Commit message · Ilya Artemov

Using generic and simpler format_sats_amount() for swap as well

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 26/100

This commit replaces a custom Bitcoin amount-formatting routine used during Ledger's cryptocurrency swap feature with a shared, simpler utility. The old code converted an 8-byte big-endian amount into a human-readable decimal string with a coin ticker. The new code uses the project's generic `format_sats_amount()` function. The change removes about 120 lines of low-level bit-manipulation code. On its own, the commit does not claim to fix a security bug, and the diff does not show an obvious vulnerability. However, any change to amount display logic in a swap context is security-sensitive because a bug could mislead a user about how much value is being exchanged.

Security candidateAdditional check to avoid vout_scriptpubkey overflowby Ilya Artemov · aeeeaf09 · Dec 4, 2025 · 1 fileMessage 67 · AdequateHigh 71Details
Commit message · Ilya Artemov

Additional check to avoid vout_scriptpubkey overflow

67/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Explains rationale or failure mode✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
memory safetysigning or wallet path
AI analysis · High 71/100

This commit adds a safety check in the Ledger Bitcoin app's code that parses previous transaction outputs. Before copying a scriptPubKey (the part of a Bitcoin output that locks funds) into a fixed-size buffer, the code now verifies the copy won't exceed the buffer's maximum length when combined with how much has already been written. Without this check, a malformed or oversized scriptPubKey could overflow the buffer, potentially corrupting memory and affecting the device's behavior. The commit also fixes two nearby variables from 'bool' to 'int' so parser error codes are preserved instead of being collapsed to true/false.

Lower-priorityUpdate CHANGELOG.mdby iartemov-ledger · 5506c97d · Nov 25, 2025 · 1 fileMessage 43 · ThinInformational 15Details
Commit message · iartemov-ledger

Update CHANGELOG.md

Co-authored-by: Salvatore Ingala <6681844+bigspider@users.noreply.github.com>

43/100 · ThinMessage clarity
✓ Subject identifies a change✓ Provides an explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only edits the project's CHANGELOG.md file, removing an empty '### Added' heading and merging its bullet points into the preceding release section. There are no code changes, no functional changes, and no security fixes or features introduced.

Lower-priority[auto-update] Update Ragger snapshotsby github-actions[bot] · f9b860c2 · Nov 25, 2025 · 3 filesMessage 45 · ThinInformational 15Details
Commit message · github-actions[bot]

[auto-update] Update Ragger snapshots

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only updates three test snapshot images used by an automated testing tool called Ragger. These snapshots are reference screenshots of device screens during tests. There are no code changes, no application logic changes, and nothing that affects the security of the Bitcoin app running on Ledger devices.

Lower-priorityVersion bump to v2.4.3 + changelog updateby Ilya Artemov · d42ca717 · Nov 25, 2025 · 2 filesMessage 45 · ThinInformational 15Details
Commit message · Ilya Artemov

Version bump to v2.4.3 + changelog update

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only bumps the app version number from 2.4.2 to 2.4.3 and updates the changelog. No code changes to security logic are present in the diff. The changelog mentions prior security-related UI and derivation-path hardening work, but those changes were made in earlier commits, not here.

AI review queuedFixing unit testsby Ilya Artemov · 79f44e7a · Nov 25, 2025 · 1 fileMessage 38 · OpaqueInformational 15Details
Commit message · Ilya Artemov

Fixing unit tests

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit adds a single type definition (`cx_err_t`) to a unit-test mock header so the test code compiles. It does not change any actual application code, cryptographic operations, or device behavior. There is no security relevance.

AI review queued[auto-update] Update Ragger snapshotsby github-actions[bot] · d9756e65 · Nov 25, 2025 · 50 filesMessage 45 · ThinInformational 15Details
Commit message · github-actions[bot]

[auto-update] Update Ragger snapshots

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 15/100

This commit only updates test screenshot images used by the Ragger testing framework. No application code, firmware logic, or user-facing behavior was changed. It is not a security patch and does not fix or introduce any vulnerability.

Security candidateSpecial handling for get_extended_pubkey_at_path() distinguishing error codesby Ilya Artemov · cf630a59 · Nov 25, 2025 · 7 filesMessage 50 · ThinLow 38Details
Commit message · Ilya Artemov

Special handling for get_extended_pubkey_at_path() distinguishing error codes

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Low 38/100

This commit changes how the Ledger Bitcoin app reports failures when deriving public keys from a BIP32 path. Previously, almost any derivation failure was reported as a generic 'bad state' error. Now, the app distinguishes between different underlying error codes, specifically mapping two SDK error codes (0x4212 and 0x4215) to a 'not supported' status word instead of 'bad state'. This is a defensive hardening change: it gives callers more accurate error information and avoids misleading 'bad state' responses for permission or policy-related derivation failures. There is no direct evidence in the commit of an exploitable vulnerability being fixed.

AI review queuedUpdating few tests that did not respect the derivation path hardeningby Ilya Artemov · 550aa545 · Nov 25, 2025 · 2 filesMessage 60 · AdequateInformational 12Details
Commit message · Ilya Artemov

Updating few tests that did not respect the derivation path hardening

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit only changes automated test files. It updates test cases so they use correct hardened Bitcoin derivation paths and expect the app to reject non-standard or root-level key derivation requests. There is no change to the actual app code that runs on Ledger devices, so this commit does not introduce or fix a security vulnerability by itself. It appears to be a follow-up to a real security hardening in the app firmware that happened elsewhere.

Security candidateRemoving DERIVE_MASTER flag, enforcing the derivation pathsby Ilya Artemov · a4888e4f · Nov 21, 2025 · 2 filesMessage 50 · ThinModerate 61Details
Commit message · Ilya Artemov

Removing DERIVE_MASTER flag, enforcing the derivation paths

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Moderate 61/100

This commit removes a special 'derive master key' permission from the Ledger Bitcoin app and replaces direct master-key derivation with a safer OS-provided fingerprint. It also enforces BIP-44 coin-type restrictions (mainnet 0' or testnet 1') at app-load time, closing a path where the app could previously be asked to derive keys outside those intended coin types. The change is defensive: it reduces the app's privileges and makes path enforcement stricter.

Lower-priorityhandler_get_master_fingerprint through new os_perso_get_master_key_identifier syscallby Ilya Artemov · 11dcea02 · Nov 21, 2025 · 1 fileMessage 50 · ThinLow 35Details
Commit message · Ilya Artemov

handler_get_master_fingerprint through new os_perso_get_master_key_identifier syscall

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 35/100

This commit changes how the Bitcoin app on Ledger hardware wallets obtains the wallet's master fingerprint. Previously, the app derived the master public key and computed the fingerprint itself. Now it calls a dedicated operating-system API, os_perso_get_master_key_identifier, which returns the fingerprint directly. This is a refactoring that reduces the app's own cryptographic surface and likely improves consistency with other apps, but the commit message and diff alone do not indicate a security bug was fixed.

AI review queued[auto-update] Update Ragger snapshotsby github-actions[bot] · c74ab33d · Nov 20, 2025 · 582 filesMessage 45 · ThinInformational 15Details
Commit message · github-actions[bot]

[auto-update] Update Ragger snapshots

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates test screenshot snapshots (PNG images) used by the Ragger automated testing framework. No application source code, firmware, or cryptographic logic was changed. It is not a security patch and does not affect users' devices or funds.

Security candidateFixing uninitialized variableby Ilya Artemov · 27a9c9da · Nov 20, 2025 · 1 fileMessage 35 · OpaqueLow 42Details
Commit message · Ilya Artemov

Fixing uninitialized variable

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
cryptography-sensitive path
AI analysis · Low 42/100

This commit fixes a coding bug in the Ledger Bitcoin app where a variable that tracks whether cryptographic operations succeeded was not initialized before use. Because the function is marked as unsafe for secret data (it is vulnerable to timing attacks) and is now also made private to the file, the patch both removes a potential source of incorrect error handling and limits how widely the unsafe helper can be called. The actual security impact is moderate: on its own this is a defensive fix rather than a demonstrated exploit, but uninitialized error variables can in principle lead to wrong decisions downstream if an error path is taken before the variable is set.

Security candidateFixing expected output array length for os_derive_bip32_with_seed_no_throw() SDK functionby Ilya Artemov · e289daf9 · Nov 20, 2025 · 1 fileMessage 50 · ThinModerate 58Details
Commit message · Ilya Artemov

Fixing expected output array length for os_derive_bip32_with_seed_no_throw() SDK function

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
secret or key materialcryptography-sensitive path
AI analysis · Moderate 58/100

This commit fixes a buffer-size mismatch in the Ledger Bitcoin app. A function that derives secret keys was being asked to write 64 bytes of output into a caller-supplied 32-byte buffer. The patch now provides a 64-byte temporary buffer and copies only the needed 32 bytes afterward, then securely wipes the temporary buffer. The original bug could have caused memory corruption or leaked key material, depending on how the SDK behaves when given an undersized buffer.

AI review queued[auto-update] Update Ragger snapshotsby github-actions[bot] · 9cc63e3d · Nov 17, 2025 · 33 filesMessage 45 · ThinInformational 15Details
Commit message · github-actions[bot]

[auto-update] Update Ragger snapshots

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates test screenshot images used by an automated testing tool called Ragger. No actual application code, firmware, or security logic was changed. It is not a security fix and does not affect users' devices or funds.

Security candidateAllowing for message signature the line feed (LF) character handled by NBGL (documentation update)by Ilya Artemov · 5daee06f · Nov 17, 2025 · 1 fileMessage 55 · ThinInformational 15Details
Commit message · Ilya Artemov

Allowing for message signature the line feed (LF) character handled by NBGL (documentation update)

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing boundarydocumentation-only discount
AI analysis · Informational 15/100

This commit only updates documentation. It fixes a typo in an error-code table and clarifies that the Ledger device can display the full text of a Bitcoin message being signed if it is short enough and contains only printable ASCII characters plus line feeds; otherwise it shows a hash. There is no code change and no security fix.