Delete legacy !IO_REVAMPED code, which is no longer used
What the developer wrote
Authored by Salvatore Ingala
Delete legacy !IO_REVAMPED code, which is no longer used
What changed, and why it matters
This commit removes an old, unused code path that handled device communication when a newer 'revamped' input/output system was not enabled. The change only deletes code that was already guarded by a compile-time flag and no longer used, with no functional change to the active system.
No security action needed; treat as routine code cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes the legacy !REVAMPED_IO branch in io_ui_process() within src/ui/display.c. The active REVAMPED_IO path remains unchanged. This is a cleanup of dead code, not a logic or security fix.
Changed components
src/ui/display.cInspect captured patch +0 / −9
diff --git a/src/ui/display.c b/src/ui/display.c
index 407dbb8..d233864 100644
--- a/src/ui/display.c
+++ b/src/ui/display.c
@@ -77,18 +77,9 @@ static bool io_ui_process(dispatcher_context_t *context) {
// We are not waiting for the client's input, nor we are doing computations on the device
ioe_clear_processing_timeout();
-#ifdef REVAMPED_IO
do {
io_seproxyhal_io_heartbeat();
} while (!g_ux_flow_ended);
-#else // !REVAMPED_IO
- io_seproxyhal_general_status();
- do {
- io_seproxyhal_spi_recv(G_io_seproxyhal_spi_buffer, sizeof(G_io_seproxyhal_spi_buffer), 0);
- io_seproxyhal_handle_event();
- io_seproxyhal_general_status();
- } while (io_seproxyhal_spi_is_status_sent() && !g_ux_flow_ended);
-#endif // !REVAMPED_IO
// We're back at work, we want to show the "Processing..." screen when appropriate
ioe_start_processing_timeout();
Why this scored 14/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.