Remove unnecessary port bindings in CI jobs
What the developer wrote
Authored by Salvatore Ingala
Remove unnecessary port bindings in CI jobs
It might cause intermittent CI failures during container setup
What changed, and why it matters
This commit removes unused network port mappings from GitHub Actions CI configuration files. It is a routine infrastructure cleanup to reduce random test failures when CI containers start up. It does not change any application code, cryptographic logic, or user-facing behavior, and it does not fix a security vulnerability.
No security action required. Treat as a normal CI hygiene change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change deletes duplicate ports: sections under four GitHub Actions job definitions that use the Speculos emulator container. The ports (1234, 9999, 40000-43000) were being bound from the container to the host even though the CI steps apparently do not need them. Removing them avoids potential port-conflict errors during container creation. No source code, build artifacts, secrets, or runtime permissions are modified.
Changed components
.github/workflows/ci-workflow.ymlInspect captured patch +0 / −28
diff --git a/.github/workflows/ci-workflow.yml b/.github/workflows/ci-workflow.yml
index 062b50f..ce6bf4c 100644
--- a/.github/workflows/ci-workflow.yml
+++ b/.github/workflows/ci-workflow.yml
@@ -95,13 +95,6 @@ jobs:
container:
image: ghcr.io/ledgerhq/speculos:latest
- ports:
- - 1234:1234
- - 9999:9999
- - 40000:40000
- - 41000:41000
- - 42000:42000
- - 43000:43000
options: --entrypoint /bin/bash
steps:
@@ -131,13 +124,6 @@ jobs:
container:
# As for the test we use v1.6.5 Nano S BTC binary we freeze the last Speculos version supporting this device
image: ghcr.io/ledgerhq/speculos:0.25.5
- ports:
- - 1234:1234
- - 9999:9999
- - 40000:40000
- - 41000:41000
- - 42000:42000
- - 43000:43000
options: --entrypoint /bin/bash
steps:
@@ -161,13 +147,6 @@ jobs:
container:
image: ghcr.io/ledgerhq/speculos:latest
- ports:
- - 1234:1234
- - 9999:9999
- - 40000:40000
- - 41000:41000
- - 42000:42000
- - 43000:43000
options: --entrypoint /bin/bash
steps:
@@ -214,13 +193,6 @@ jobs:
container:
image: ghcr.io/ledgerhq/speculos:latest
- ports:
- - 1234:1234
- - 9999:9999
- - 40000:40000
- - 41000:41000
- - 42000:42000
- - 43000:43000
options: --entrypoint /bin/bash
steps:
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.